20681 2008-09-05 18:05:25 -0700 JSPropertyNameIterator functions need to be inlined 2008-09-05 22:00:10 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin darin zwarich oldest_to_newest 90335 0 darin 2008-09-05 18:05:25 -0700 They were showing up on the profile. And inlining them gives a 1.007x speedup. 90336 1 23208 darin 2008-09-05 18:10:55 -0700 Created attachment 23208 patch 90341 2 23208 zwarich 2008-09-05 20:24:35 -0700 Comment on attachment 23208 patch r=me 90348 3 darin 2008-09-05 22:00:10 -0700 Committed revision 36125. 23208 2008-09-05 18:10:55 -0700 2008-09-05 20:24:35 -0700 patch PropertyIteratorPatch.txt text/plain 4287 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM2MTIyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMDktMDUgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIwNjgxCisgICAgICAgICAgSlNQcm9wZXJ0eU5hbWVJdGVyYXRvciBmdW5jdGlvbnMgbmVlZCB0 byBiZSBpbmxpbmVkCisKKyAgICAgICAgMS4wMDd4IGFzIGZhc3Qgb24gU3VuU3BpZGVyIG92ZXJh bGwKKyAgICAgICAgMS4wODF4IGFzIGZhc3Qgb24gbWF0aC1jb3JkaWMKKworICAgICAgICAqIFZN L0pTUHJvcGVydHlOYW1lSXRlcmF0b3IuY3BwOiBNb3ZlZCBmdW5jdGlvbnMgb3V0IG9mIGhlcmUu CisgICAgICAgICogVk0vSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5oOgorICAgICAgICAoS0pTOjpK U1Byb3BlcnR5TmFtZUl0ZXJhdG9yOjpKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yKTogTW92ZWQKKyAg ICAgICAgdGhpcyBpbnRvIHRoZSBoZWFkZXIgYW5kIG1hcmtlZCBpdCBpbmxpbmUuCisgICAgICAg IChLSlM6OkpTUHJvcGVydHlOYW1lSXRlcmF0b3I6OmNyZWF0ZSk6IERpdHRvLgorICAgICAgICAo S0pTOjpKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yOjpuZXh0KTogRGl0dG8uCisKIDIwMDgtMDktMDUg IE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguCkluZGV4 OiBKYXZhU2NyaXB0Q29yZS9WTS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKYXZhU2NyaXB0Q29yZS9WTS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNwcAkocmV2aXNp b24gMzYxMjIpCisrKyBKYXZhU2NyaXB0Q29yZS9WTS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMjksMzUgKzI5LDEwIEBACiAjaW5jbHVkZSAiY29uZmlnLmgi CiAjaW5jbHVkZSAiSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5oIgogCi0jaW5jbHVkZSAiSlNPYmpl Y3QuaCIKLSNpbmNsdWRlICJKU1N0cmluZy5oIgotI2luY2x1ZGUgIlByb3BlcnR5TmFtZUFycmF5 LmgiCi0jaW5jbHVkZSAiaWRlbnRpZmllci5oIgotCiBuYW1lc3BhY2UgS0pTIHsKIAogQVNTRVJU X0NMQVNTX0ZJVFNfSU5fQ0VMTChKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yKTsKIAotSlNQcm9wZXJ0 eU5hbWVJdGVyYXRvciogSlNQcm9wZXJ0eU5hbWVJdGVyYXRvcjo6Y3JlYXRlKEV4ZWNTdGF0ZSog ZXhlYywgSlNWYWx1ZSogdikKLXsKLSAgICBpZiAodi0+aXNVbmRlZmluZWRPck51bGwoKSkKLSAg ICAgICAgcmV0dXJuIG5ldyAoZXhlYykgSlNQcm9wZXJ0eU5hbWVJdGVyYXRvcigwLCAwLCAwKTsK LQotICAgIEpTT2JqZWN0KiBvID0gdi0+dG9PYmplY3QoZXhlYyk7Ci0gICAgUHJvcGVydHlOYW1l QXJyYXkgcHJvcGVydHlOYW1lcyhleGVjKTsKLSAgICBvLT5nZXRQcm9wZXJ0eU5hbWVzKGV4ZWMs IHByb3BlcnR5TmFtZXMpOwotICAgIHNpemVfdCBudW1Qcm9wZXJ0aWVzID0gcHJvcGVydHlOYW1l cy5zaXplKCk7Ci0gICAgcmV0dXJuIG5ldyAoZXhlYykgSlNQcm9wZXJ0eU5hbWVJdGVyYXRvcihv LCBwcm9wZXJ0eU5hbWVzLnJlbGVhc2VJZGVudGlmaWVycygpLCBudW1Qcm9wZXJ0aWVzKTsKLX0K LQotSlNQcm9wZXJ0eU5hbWVJdGVyYXRvcjo6SlNQcm9wZXJ0eU5hbWVJdGVyYXRvcihKU09iamVj dCogb2JqZWN0LCBJZGVudGlmaWVyKiBwcm9wZXJ0eU5hbWVzLCBzaXplX3QgbnVtUHJvcGVydGll cykKLSAgICA6IG1fb2JqZWN0KG9iamVjdCkKLSAgICAsIG1fcHJvcGVydHlOYW1lcyhwcm9wZXJ0 eU5hbWVzKQotICAgICwgbV9wb3NpdGlvbihwcm9wZXJ0eU5hbWVzKQotICAgICwgbV9lbmQocHJv cGVydHlOYW1lcyArIG51bVByb3BlcnRpZXMpCi17Ci19Ci0KIEpTUHJvcGVydHlOYW1lSXRlcmF0 b3I6On5KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yKCkKIHsKICAgICBpbnZhbGlkYXRlKCk7CkBAIC0x MDYsMTcgKzgxLDYgQEAgdm9pZCBKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yOjptYXJrKCkKICAgICAg ICAgbV9vYmplY3QtPm1hcmsoKTsKIH0KIAotSlNWYWx1ZSogSlNQcm9wZXJ0eU5hbWVJdGVyYXRv cjo6bmV4dChFeGVjU3RhdGUqIGV4ZWMpCi17Ci0gICAgd2hpbGUgKG1fcG9zaXRpb24gIT0gbV9l bmQpIHsKLSAgICAgICAgaWYgKG1fb2JqZWN0LT5oYXNQcm9wZXJ0eShleGVjLCAqbV9wb3NpdGlv bikpCi0gICAgICAgICAgICByZXR1cm4ganNPd25lZFN0cmluZyhleGVjLCAoKm1fcG9zaXRpb24r KykudXN0cmluZygpKTs7Ci0gICAgICAgIG1fcG9zaXRpb24rKzsKLSAgICB9Ci0gICAgaW52YWxp ZGF0ZSgpOwotICAgIHJldHVybiAwOwotfQotCiB2b2lkIEpTUHJvcGVydHlOYW1lSXRlcmF0b3I6 OmludmFsaWRhdGUoKQogewogICAgIGlmIChtX3Byb3BlcnR5TmFtZXMpIHsKSW5kZXg6IEphdmFT Y3JpcHRDb3JlL1ZNL0pTUHJvcGVydHlOYW1lSXRlcmF0b3IuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh U2NyaXB0Q29yZS9WTS9KU1Byb3BlcnR5TmFtZUl0ZXJhdG9yLmgJKHJldmlzaW9uIDM2MTIyKQor KysgSmF2YVNjcmlwdENvcmUvVk0vSlNQcm9wZXJ0eU5hbWVJdGVyYXRvci5oCSh3b3JraW5nIGNv cHkpCkBAIC0yOSw3ICsyOSw5IEBACiAjaWZuZGVmIEpTUHJvcGVydHlOYW1lSXRlcmF0b3JfaAog I2RlZmluZSBKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yX2gKIAotI2luY2x1ZGUgIkpTQ2VsbC5oIgor I2luY2x1ZGUgIkpTT2JqZWN0LmgiCisjaW5jbHVkZSAiSlNTdHJpbmcuaCIKKyNpbmNsdWRlICJQ cm9wZXJ0eU5hbWVBcnJheS5oIgogCiBuYW1lc3BhY2UgS0pTIHsKIApAQCAtNjMsNiArNjUsMzcg QEAgbmFtZXNwYWNlIEtKUyB7CiAgICAgICAgIElkZW50aWZpZXIqIG1fZW5kOwogICAgIH07CiAK K2lubGluZSBKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yOjpKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yKEpT T2JqZWN0KiBvYmplY3QsIElkZW50aWZpZXIqIHByb3BlcnR5TmFtZXMsIHNpemVfdCBudW1Qcm9w ZXJ0aWVzKQorICAgIDogbV9vYmplY3Qob2JqZWN0KQorICAgICwgbV9wcm9wZXJ0eU5hbWVzKHBy b3BlcnR5TmFtZXMpCisgICAgLCBtX3Bvc2l0aW9uKHByb3BlcnR5TmFtZXMpCisgICAgLCBtX2Vu ZChwcm9wZXJ0eU5hbWVzICsgbnVtUHJvcGVydGllcykKK3sKK30KKworaW5saW5lIEpTUHJvcGVy dHlOYW1lSXRlcmF0b3IqIEpTUHJvcGVydHlOYW1lSXRlcmF0b3I6OmNyZWF0ZShFeGVjU3RhdGUq IGV4ZWMsIEpTVmFsdWUqIHYpCit7CisgICAgaWYgKHYtPmlzVW5kZWZpbmVkT3JOdWxsKCkpCisg ICAgICAgIHJldHVybiBuZXcgKGV4ZWMpIEpTUHJvcGVydHlOYW1lSXRlcmF0b3IoMCwgMCwgMCk7 CisKKyAgICBKU09iamVjdCogbyA9IHYtPnRvT2JqZWN0KGV4ZWMpOworICAgIFByb3BlcnR5TmFt ZUFycmF5IHByb3BlcnR5TmFtZXMoZXhlYyk7CisgICAgby0+Z2V0UHJvcGVydHlOYW1lcyhleGVj LCBwcm9wZXJ0eU5hbWVzKTsKKyAgICBzaXplX3QgbnVtUHJvcGVydGllcyA9IHByb3BlcnR5TmFt ZXMuc2l6ZSgpOworICAgIHJldHVybiBuZXcgKGV4ZWMpIEpTUHJvcGVydHlOYW1lSXRlcmF0b3Io bywgcHJvcGVydHlOYW1lcy5yZWxlYXNlSWRlbnRpZmllcnMoKSwgbnVtUHJvcGVydGllcyk7Cit9 CisKK2lubGluZSBKU1ZhbHVlKiBKU1Byb3BlcnR5TmFtZUl0ZXJhdG9yOjpuZXh0KEV4ZWNTdGF0 ZSogZXhlYykKK3sKKyAgICB3aGlsZSAobV9wb3NpdGlvbiAhPSBtX2VuZCkgeworICAgICAgICBp ZiAobV9vYmplY3QtPmhhc1Byb3BlcnR5KGV4ZWMsICptX3Bvc2l0aW9uKSkKKyAgICAgICAgICAg IHJldHVybiBqc093bmVkU3RyaW5nKGV4ZWMsICgqbV9wb3NpdGlvbisrKS51c3RyaW5nKCkpOwor ICAgICAgICBtX3Bvc2l0aW9uKys7CisgICAgfQorICAgIGludmFsaWRhdGUoKTsKKyAgICByZXR1 cm4gMDsKK30KKwogfSAvLyBuYW1lc3BhY2UgS0pTCiAKICNlbmRpZiAvLyBKU1Byb3BlcnR5TmFt ZUl0ZXJhdG9yX2gK