206801 2020-01-25 10:44:34 -0800 webkit-patch upload should not submit automatically to old EWS 2020-01-25 12:03:12 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist glenn jbedard peng.liu6 webkit-bug-importer oldest_to_newest 1611071 0 aakash_jain 2020-01-25 10:44:34 -0800 Peng reported following error while trying to use webkit-patch upload. Traceback (most recent call last): File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkit-patch”, line 80, in <module> main() File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkit-patch”, line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py”, line 305, in main result = command.check_arguments_and_execute(options, args, self) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/multicommandtool.py”, line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py”, line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py”, line 73, in run_and_handle_errors self._run(tool, options, state) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/commands/stepsequence.py”, line 67, in _run step(tool, options).run(state) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/tool/steps/submittoews.py”, line 42, in run self._tool.status_server.upload_attachment(attachment) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 156, in upload_attachment return NetworkTransaction(convert_404_to_None=True).run(lambda: self._upload_attachment_to_server(attachment.id(), attachment.to_json(), attachment.contents())) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/networktransaction.py”, line 58, in run return request() File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 156, in <lambda> return NetworkTransaction(convert_404_to_None=True).run(lambda: self._upload_attachment_to_server(attachment.id(), attachment.to_json(), attachment.contents())) File “/Volumes/Data/webkit/OpenSource/Tools/Scripts/webkitpy/common/net/statusserver.py”, line 147, in _upload_attachment_to_server self._browser.add_file(StringIO.StringIO(unicode(attachment_metadata)), ‘application/json’, ‘attachment-{}-metadata.json’.format(attachment_id), ‘attachment_metadata’) AttributeError: class StringIO has no attribute ‘StringIO’ 1611072 1 aakash_jain 2020-01-25 10:51:03 -0800 The error is while uploading the patch (for security bug) to old EWS. We don't need to upload to old EWS anymore since almost all the queues have been removed from old EWS (moved to new EWS). Only queue remaining on old EWS is commit-queue (which doesn't support security bugs anyways). 1611075 2 388781 aakash_jain 2020-01-25 10:55:33 -0800 Created attachment 388781 Patch 1611076 3 aakash_jain 2020-01-25 10:57:37 -0800 Reverting part of r232979 , https://trac.webkit.org/changeset/232979/webkit/trunk/Tools/Scripts/webkitpy/tool/steps/submittoews.py webkit-patch upload wouldn't automatically submit to old EWS with that. However old EWS would continue fetching/processing patches based on the bugzilla flags (like r?/cq+). 1611091 4 aakash_jain 2020-01-25 12:02:05 -0800 Committed r255123: <https://trac.webkit.org/changeset/255123> 1611092 5 webkit-bug-importer 2020-01-25 12:03:12 -0800 <rdar://problem/58896244> 388781 2020-01-25 10:55:33 -0800 2020-01-25 11:08:08 -0800 Patch bug-206801-20200125135532.patch text/plain 2743 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTEyMSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXQtcGF0Y2ggdXBsb2FkIHNob3VsZCBub3Qgc3VibWl0IGF1dG9t YXRpY2FsbHkgdG8gb2xkIEVXUworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA2ODAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkX3VuaXR0 ZXN0LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9zdWJtaXR0b2V3 cy5weToKKwogMjAyMC0wMS0yNSAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW0NvY29hXSBNZWRpYSBtaW1lIHR5cGVzIG1hcCBzaG91bGQgYmUgY3JlYXRl ZCBpbiB0aGUgVUkgcHJvY2VzcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2Nv bW1hbmRzL3VwbG9hZF91bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dl YmtpdHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAyNTUxMjEp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkX3VuaXR0ZXN0 LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODEsNyArMTgxLDYgQEAgT2Jzb2xldGluZyAyIG9sZCBw YXRjaGVzIG9uIGJ1ZyA1MDAwMAogTU9DSyByZWFzc2lnbl9idWc6IGJ1Z19pZD01MDAwMCwgYXNz aWduZWU9Tm9uZQogTU9DSyBhZGRfcGF0Y2hfdG9fYnVnOiBidWdfaWQ9NTAwMDAsIGRlc2NyaXB0 aW9uPU1PQ0sgZGVzY3JpcHRpb24sIG1hcmtfZm9yX3Jldmlldz1GYWxzZSwgbWFya19mb3JfY29t bWl0X3F1ZXVlPUZhbHNlLCBtYXJrX2Zvcl9sYW5kaW5nPUZhbHNlCiBNT0NLOiB1c2VyLm9wZW5f dXJsOiBodHRwOi8vZXhhbXBsZS5jb20vNTAwMDAKLU1PQ0s6IHN1Ym1pdF90b19vbGRfZXdzOiAx MDAwMQogTU9DSzogc3VibWl0X3RvX2V3czogMTAwMDEKICIiIgogICAgICAgICBzZWxmLmFzc2Vy dF9leGVjdXRlX291dHB1dHMoVXBsb2FkKCksIFs1MDAwMF0sIG9wdGlvbnM9b3B0aW9ucywgZXhw ZWN0ZWRfbG9ncz1leHBlY3RlZF9sb2dzKQpAQCAtMjA0LDggKzIwMyw2IEBAIFdhcyB0aGF0IGRp ZmYgY29ycmVjdD8KIE9ic29sZXRpbmcgMSBvbGQgcGF0Y2ggb24gYnVnIDUwMDA3CiBNT0NLIGFk ZF9wYXRjaF90b19idWc6IGJ1Z19pZD01MDAwNywgZGVzY3JpcHRpb249TU9DSyBkZXNjcmlwdGlv biwgbWFya19mb3JfcmV2aWV3PUZhbHNlLCBtYXJrX2Zvcl9jb21taXRfcXVldWU9RmFsc2UsIG1h cmtfZm9yX2xhbmRpbmc9RmFsc2UKIE1PQ0s6IHVzZXIub3Blbl91cmw6IGh0dHA6Ly9leGFtcGxl LmNvbS81MDAwNwotTU9DSzogdXBsb2FkX2F0dGFjaG1lbnQ6IDEwMDA4Ci1NT0NLOiBzdWJtaXRf dG9fb2xkX2V3czogMTAwMDgKIE1PQ0s6IHN1Ym1pdF90b19ld3M6IDEwMDA4CiAiIiIKICAgICAg ICAgc2VsZi5hc3NlcnRfZXhlY3V0ZV9vdXRwdXRzKFVwbG9hZCgpLCBbNTAwMDddLCBvcHRpb25z PW9wdGlvbnMsIGV4cGVjdGVkX2xvZ3M9ZXhwZWN0ZWRfbG9ncykKSW5kZXg6IFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvdG9vbC9zdGVwcy9zdWJtaXR0b2V3cy5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvc3VibWl0dG9ld3MucHkJKHJldmlzaW9uIDI1 NTEyMSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9zdWJtaXR0b2V3cy5w eQkod29ya2luZyBjb3B5KQpAQCAtMzUsMTAgKzM1LDQgQEAgY2xhc3MgU3VibWl0VG9FV1MoQWJz dHJhY3RTdGVwKToKIAogICAgIGRlZiBydW4oc2VsZiwgc3RhdGUpOgogICAgICAgICBmb3IgYXR0 YWNobWVudF9pZCBpbiBzdGF0ZS5nZXQoJ2F0dGFjaG1lbnRfaWRzJywgW10pOgotICAgICAgICAg ICAgYXR0YWNobWVudCA9IHNlbGYuX3Rvb2wuYnVncy5mZXRjaF9hdHRhY2htZW50KGF0dGFjaG1l bnRfaWQpCi0gICAgICAgICAgICBpZiBub3QgYXR0YWNobWVudDoKLSAgICAgICAgICAgICAgICBj b250aW51ZSAgIyBFaXRoZXIgQnVnemlsbGEgaXMgZG93biBvciB3ZSBkbyBub3QgaGF2ZSBwZXJt aXNzaW9uIHRvIHZpZXcgdGhlIGF0dGFjaG1lbnQuCi0gICAgICAgICAgICBpZiBhdHRhY2htZW50 LmJ1ZygpLmlzX3NlY3VyaXR5X3NlbnNpdGl2ZSgpOgotICAgICAgICAgICAgICAgIHNlbGYuX3Rv b2wuc3RhdHVzX3NlcnZlci51cGxvYWRfYXR0YWNobWVudChhdHRhY2htZW50KQotICAgICAgICAg ICAgc2VsZi5fdG9vbC5zdGF0dXNfc2VydmVyLnN1Ym1pdF90b19ld3MoYXR0YWNobWVudF9pZCkK ICAgICAgICAgICAgIHNlbGYuX3Rvb2wuZXdzX3NlcnZlci5zdWJtaXRfdG9fZXdzKGF0dGFjaG1l bnRfaWQpCg==