206799 2020-01-25 08:28:53 -0800 Protect against crashes during WKWebView initialization when methods are called before the view is fully initialized 2020-01-26 14:46:37 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P1 Normal --- 1 darin darin andersca cdumez commit-queue sam simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1611042 0 darin 2020-01-25 08:28:53 -0800 Protect against crashes during WKWebView init function when methods are called before the view is fully initialized 1611043 1 388776 darin 2020-01-25 08:34:57 -0800 Created attachment 388776 Patch 1611044 2 darin 2020-01-25 08:34:59 -0800 <rdar://problem/58871371> 1611224 3 commit-queue 2020-01-26 14:14:55 -0800 The commit-queue encountered the following flaky tests while processing attachment 388776: fetch/fetch-worker-crash.html bug 187257 (author: youennf@gmail.com) imported/w3c/web-platform-tests/xhr/event-abort.any.html bug 206677 (author: psaavedra@igalia.com) The commit-queue is continuing to process your patch. 1611225 4 388776 commit-queue 2020-01-26 14:15:21 -0800 Comment on attachment 388776 Patch Clearing flags on attachment: 388776 Committed r255132: <https://trac.webkit.org/changeset/255132> 1611226 5 commit-queue 2020-01-26 14:15:23 -0800 All reviewed patches have been landed. Closing bug. 388776 2020-01-25 08:34:57 -0800 2020-01-26 14:15:21 -0800 Patch bug-206799-20200125083452.patch text/plain 6074 darin U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MTE4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk4ZjVlY2ZhNTdhOTUyOGFj NWRlZDk2ZjliMjIyMTRmZTE1ODk3YTguLmNkZDdkNTc1YTUwYWE4ZWNkNTgxMmQzOTRjZmMwNTE0 MjIzMDkzNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMjAtMDEtMjUgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFByb3RlY3QgYWdhaW5zdCBjcmFzaGVz IGR1cmluZyBXS1dlYlZpZXcgaW5pdCBmdW5jdGlvbiB3aGVuIG1ldGhvZHMgYXJlIGNhbGxlZCBi ZWZvcmUgdGhlIHZpZXcgaXMgZnVsbHkgaW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjc5OQorICAgICAgICByZGFyOi8vcHJvYmxl bS81ODg3MTM3MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFBhcnQgd2F5IHRocm91Z2ggY3JlYXRpbmcgV0tXZWJWaWV3LCBzb21lIG1ldGhvZHMgY2Fu IGJlIGNhbGxlZCBhbmQgdGhleSBuZWVkIHRvIGJlIGNhcmVmdWwKKyAgICAgICAgbm90IHRvIHVz ZSBhbnl0aGluZyB0aGF0IG1heSBub3QgYmUgaW5pdGlhbGl6ZWQgeWV0LgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBk ZWFsbG9jXSk6IENoZWNrIF9wYWdlIGZvciBudWxsLCBzaW5jZSB0aGlzIG1pZ2h0IGhhcHBlbiBp ZiB0aGUgc3VwZXJjbGFzcydzCisgICAgICAgIGluaXQgbWV0aG9kIHJldHVybmVkIG5pbC4KKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvaW9zL1dLV2ViVmlld0lPUy5tbToKKyAgICAgICAgKC1b V0tXZWJWaWV3IF9mcmFtZU9yQm91bmRzQ2hhbmdlZF0pOiBDaGVjayBfcGFnZSBmb3IgbnVsbCwg c2luY2UgdGhpcyBtaWdodCBiZSBjYWxsZWQKKyAgICAgICAgYmVmb3JlIG9iamVjdCBpbml0aWFs aXphdGlvbiBpcyBjb21wbGV0ZS4KKyAgICAgICAgKC1bV0tXZWJWaWV3IHNldFNlbWFudGljQ29u dGVudEF0dHJpYnV0ZTpdKTogRGl0dG8uCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL21hYy9X S1dlYlZpZXdNYWMubW06CisgICAgICAgICgtW1dLV2ViVmlldyBzZXRGcmFtZVNpemU6XSk6IENo ZWNrIF9pbXBsIGZvciBudWxsIHNpbmNlIHRoaXMgbWlnaHQgYmUgY2FsbGVkIGJlZm9yZQorICAg ICAgICBvamVjdCBpbml0aWFsaXphdGlvbiBpcyBjb21wbGV0ZS4KKyAgICAgICAgKC1bV0tXZWJW aWV3IHNldFVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb246XSk6IERpdHRvLgorICAgICAgICAo LVtXS1dlYlZpZXcgcmVuZXdHU3RhdGVdKTogRGl0dG8uCisKIDIwMjAtMDEtMjUgIEFudHRpIEtv aXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0ludGVncmF0aW9uXSBS ZS1lbmFibGUgbGluZSBsYXlvdXQgaW50ZWdyYXRpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tCmluZGV4IGNhZDdjNWZmYTRmMjdkNmE0MzcwM2Y5 M2U0Yjc4OGRiYzA0OGI2MzMuLjk3YWU0NmI3Y2Q1ZmIyMDRjNTgxNDc5NWNlNzRlMDgxYjdmOWRi YzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZp ZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5t bQpAQCAtMSw1ICsxLDUgQEAKIC8qCi0gKiBDb3B5cmlnaHQgKEMpIDIwMTQtMjAxOSBBcHBsZSBJ bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMTQtMjAyMCBBcHBs ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKQEAgLTU5MSwxMSArNTkxLDEyIEBAIC0gKHZvaWQpZGVhbGxvYwogI2lmIFBMQVRGT1JNKElP U19GQU1JTFkpCiAgICAgW19jb250ZW50VmlldyBfd2ViVmlld0Rlc3Ryb3llZF07CiAKLSAgICBp ZiAoX3JlbW90ZU9iamVjdFJlZ2lzdHJ5KQorICAgIGlmIChfcGFnZSAmJiBfcmVtb3RlT2JqZWN0 UmVnaXN0cnkpCiAgICAgICAgIF9wYWdlLT5wcm9jZXNzKCkucHJvY2Vzc1Bvb2woKS5yZW1vdmVN ZXNzYWdlUmVjZWl2ZXIoTWVzc2FnZXM6OlJlbW90ZU9iamVjdFJlZ2lzdHJ5OjptZXNzYWdlUmVj ZWl2ZXJOYW1lKCksIF9wYWdlLT5pZGVudGlmaWVyKCkpOwogI2VuZGlmCiAKLSAgICBfcGFnZS0+ Y2xvc2UoKTsKKyAgICBpZiAoX3BhZ2UpCisgICAgICAgIF9wYWdlLT5jbG9zZSgpOwogCiAjaWYg UExBVEZPUk0oSU9TX0ZBTUlMWSkKICAgICBbX3JlbW90ZU9iamVjdFJlZ2lzdHJ5IF9pbnZhbGlk YXRlXTsKQEAgLTYwNiw3ICs2MDcsOCBAQCAtICh2b2lkKWRlYWxsb2MKICAgICBDRk5vdGlmaWNh dGlvbkNlbnRlclJlbW92ZU9ic2VydmVyKENGTm90aWZpY2F0aW9uQ2VudGVyR2V0RGFyd2luTm90 aWZ5Q2VudGVyKCksIChfX2JyaWRnZSBjb25zdCB2b2lkICopKHNlbGYpLCAoQ0ZTdHJpbmdSZWYp W05TU3RyaW5nIHN0cmluZ1dpdGhVVEY4U3RyaW5nOmtHU0V2ZW50SGFyZHdhcmVLZXlib2FyZEF2 YWlsYWJpbGl0eUNoYW5nZWROb3RpZmljYXRpb25dLCBudWxscHRyKTsKICNlbmRpZgogCi0gICAg cGFnZVRvVmlld01hcCgpLnJlbW92ZShfcGFnZS5nZXQoKSk7CisgICAgaWYgKF9wYWdlKQorICAg ICAgICBwYWdlVG9WaWV3TWFwKCkucmVtb3ZlKF9wYWdlLmdldCgpKTsKIAogICAgIFtzdXBlciBk ZWFsbG9jXTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9pb3Mv V0tXZWJWaWV3SU9TLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dlYlZp ZXdJT1MubW0KaW5kZXggNDU1ZTQ1NWI3NjY5OTEwODFjZTM2Y2Y0NDU5YWQ5ZDk5NWI1ODc2Mi4u YzgxMzUwN2RhNDBiNTczMzQzYmU0YmU1ZmUxYzg5ZjZiZjFlMzI0ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dlYlZpZXdJT1MubW0KKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL2lvcy9XS1dlYlZpZXdJT1MubW0KQEAgLTEsNSArMSw1IEBA CiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE0LTIwMTkgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE0LTIwMjAgQXBwbGUgSW5jLiBBbGwgcmlnaHRz IHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBi aW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0 dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCkBAIC0xNzU5LDggKzE3 NTksMTAgQEAgLSAodm9pZClfZnJhbWVPckJvdW5kc0NoYW5nZWQKICAgICAgICAgICAgIFtzZWxm IF9kaXNwYXRjaFNldE1heGltdW1Vbm9ic2N1cmVkU2l6ZTpXZWJDb3JlOjpGbG9hdFNpemUoYm91 bmRzLnNpemUpXTsKIAogICAgICAgICBCT09MIHNpemVDaGFuZ2VkID0gTk87Ci0gICAgICAgIGlm IChhdXRvIGRyYXdpbmdBcmVhID0gX3BhZ2UtPmRyYXdpbmdBcmVhKCkpCi0gICAgICAgICAgICBz aXplQ2hhbmdlZCA9IGRyYXdpbmdBcmVhLT5zZXRTaXplKFdlYkNvcmU6OkludFNpemUoYm91bmRz LnNpemUpKTsKKyAgICAgICAgaWYgKF9wYWdlKSB7CisgICAgICAgICAgICBpZiAoYXV0byBkcmF3 aW5nQXJlYSA9IF9wYWdlLT5kcmF3aW5nQXJlYSgpKQorICAgICAgICAgICAgICAgIHNpemVDaGFu Z2VkID0gZHJhd2luZ0FyZWEtPnNldFNpemUoV2ViQ29yZTo6SW50U2l6ZShib3VuZHMuc2l6ZSkp OworICAgICAgICB9CiAKICAgICAgICAgaWYgKHNpemVDaGFuZ2VkICYgW3NlbGYgdXNlc1N0YW5k YXJkQ29udGVudFZpZXddKQogICAgICAgICAgICAgW19jb250ZW50VmlldyBzZXRTaXplQ2hhbmdl ZFNpbmNlTGFzdFZpc2libGVDb250ZW50UmVjdFVwZGF0ZTpZRVNdOwpAQCAtMjM3OCw3ICsyMzgw LDggQEAgLSAodm9pZClzZXRTZW1hbnRpY0NvbnRlbnRBdHRyaWJ1dGU6KFVJU2VtYW50aWNDb250 ZW50QXR0cmlidXRlKWNvbnRlbnRBdHRyaWJ1dGUKIHsKICAgICBbc3VwZXIgc2V0U2VtYW50aWND b250ZW50QXR0cmlidXRlOmNvbnRlbnRBdHRyaWJ1dGVdOwogCi0gICAgX3BhZ2UtPnNldFVzZXJJ bnRlcmZhY2VMYXlvdXREaXJlY3Rpb24odG9Vc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uKGNv bnRlbnRBdHRyaWJ1dGUpKTsKKyAgICBpZiAoX3BhZ2UpCisgICAgICAgIF9wYWdlLT5zZXRVc2Vy SW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uKHRvVXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbihj b250ZW50QXR0cmlidXRlKSk7CiB9CiAKIEBlbmQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9tYWMvV0tXZWJWaWV3TWFjLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvQVBJL21hYy9XS1dlYlZpZXdNYWMubW0KaW5kZXggMzNlODIzOGY5ZjdjMWM4YTIwOGViZjQw ODA2ZDAxNjRkNjdiZDY4My4uMGVkYjYzZDRhNGVmMDk4N2JkNmZiNTkxMzg5MDJmMzQ4OWRhZGJk MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL21hYy9XS1dlYlZpZXdN YWMubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL21hYy9XS1dlYlZpZXdNYWMu bW0KQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE0LTIwMTkgQXBwbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29weXJpZ2h0IChDKSAyMDE0LTIwMjAgQXBw bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAogICogbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zCkBAIC0xMzUsMjEgKzEzNSwyMyBAQCAtICh2b2lkKXNldEZyYW1lU2l6ZTooTlNTaXplKXNp emUKIHsKICAgICBbc3VwZXIgc2V0RnJhbWVTaXplOnNpemVdOwogICAgIFtfc2FmZUJyb3dzaW5n V2FybmluZyBzZXRGcmFtZTpzZWxmLmJvdW5kc107Ci0gICAgX2ltcGwtPnNldEZyYW1lU2l6ZShO U1NpemVUb0NHU2l6ZShzaXplKSk7CisgICAgaWYgKF9pbXBsKQorICAgICAgICBfaW1wbC0+c2V0 RnJhbWVTaXplKE5TU2l6ZVRvQ0dTaXplKHNpemUpKTsKIH0KIAogLSAodm9pZClzZXRVc2VySW50 ZXJmYWNlTGF5b3V0RGlyZWN0aW9uOihOU1VzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb24pdXNl ckludGVyZmFjZUxheW91dERpcmVjdGlvbgogewogICAgIFtzdXBlciBzZXRVc2VySW50ZXJmYWNl TGF5b3V0RGlyZWN0aW9uOnVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb25dOwotCi0gICAgX2lt cGwtPnNldFVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb24odXNlckludGVyZmFjZUxheW91dERp cmVjdGlvbik7CisgICAgaWYgKF9pbXBsKQorICAgICAgICBfaW1wbC0+c2V0VXNlckludGVyZmFj ZUxheW91dERpcmVjdGlvbih1c2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uKTsKIH0KIAogQUxM T1dfREVQUkVDQVRFRF9JTVBMRU1FTlRBVElPTlNfQkVHSU4KIC0gKHZvaWQpcmVuZXdHU3RhdGUK IEFMTE9XX0RFUFJFQ0FURURfSU1QTEVNRU5UQVRJT05TX0VORAogewotICAgIF9pbXBsLT5yZW5l d0dTdGF0ZSgpOworICAgIGlmIChfaW1wbCkKKyAgICAgICAgX2ltcGwtPnJlbmV3R1N0YXRlKCk7 CiAgICAgW3N1cGVyIHJlbmV3R1N0YXRlXTsKIH0KIAo=