206790 2020-01-24 18:46:44 -0800 Fix internal builds 2020-01-27 13:14:07 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin ap commit-queue mjs msaboff saam webkit-bug-importer oldest_to_newest 1610968 0 krollin 2020-01-24 18:46:44 -0800 TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In some circumstances, this file can include <os/thread_self_restrict.h>, which in turn includes <machine/cpu_capabilities.h>. This latter file does not exist at a standard location, and the build fails due to not being able to find the file. Fix this by adding a path to it to the build command line. 1610969 1 webkit-bug-importer 2020-01-24 18:46:56 -0800 <rdar://problem/58888951> 1611419 2 388862 krollin 2020-01-27 08:23:27 -0800 Created attachment 388862 Patch 1611466 3 mjs 2020-01-27 10:23:46 -0800 Is there any plausible way these install path changes could have caused the crashes on bots? 1611479 4 krollin 2020-01-27 10:59:36 -0800 You mean, could it account for the orange and red bubbles I currently see? I don't see how. The change was to DumpRenderTree, which AFAIK isn't run in the wk2 tests. 1611494 5 388862 mjs 2020-01-27 11:37:19 -0800 Comment on attachment 388862 Patch r=me 1611545 6 388862 commit-queue 2020-01-27 13:14:06 -0800 Comment on attachment 388862 Patch Clearing flags on attachment: 388862 Committed r255163: <https://trac.webkit.org/changeset/255163> 1611546 7 commit-queue 2020-01-27 13:14:07 -0800 All reviewed patches have been landed. Closing bug. 388862 2020-01-27 08:23:27 -0800 2020-01-27 13:14:06 -0800 Patch bug-206790-20200127082326.patch text/plain 1992 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0OTQ2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNjkzMzI3MWJjNzZhMWE5MmUwNmM3NWU3MzBjOGU5MGE3 NzlmMjhiNS4uODFkNTRjMGEwYTU5ZGZkYTIyYWEzY2I0YzMzNGZlOWJhYmNhNmE0ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIwLTAxLTI0ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICBGaXggaW50ZXJuYWwgYnVpbGRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDY3OTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4ODg4OTUx PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRlc3RS dW5uZXIuY3BwIGluIER1bXBSZW5kZXJUcmVlIGluY2x1ZGVzIEV4ZWN1dGFibGVBbGxvY2F0b3Iu aC4gSW4KKyAgICAgICAgc29tZSBjaXJjdW1zdGFuY2VzLCB0aGlzIGZpbGUgY2FuIGluY2x1ZGUg PG9zL3RocmVhZF9zZWxmX3Jlc3RyaWN0Lmg+LAorICAgICAgICB3aGljaCBpbiB0dXJuIGluY2x1 ZGVzIDxtYWNoaW5lL2NwdV9jYXBhYmlsaXRpZXMuaD4uIFRoaXMgbGF0dGVyIGZpbGUKKyAgICAg ICAgZG9lcyBub3QgZXhpc3QgYXQgYSBzdGFuZGFyZCBsb2NhdGlvbiwgYW5kIHRoZSBidWlsZCBm YWlscyBkdWUgdG8gbm90CisgICAgICAgIGJlaW5nIGFibGUgdG8gZmluZCB0aGUgZmlsZS4gRml4 IHRoaXMgYnkgYWRkaW5nIGEgcGF0aCB0byBpdCB0byB0aGUKKyAgICAgICAgYnVpbGQgY29tbWFu ZCBsaW5lLgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jh c2UueGNjb25maWc6CisKIDIwMjAtMDEtMjIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBw bGUuY29tPgogCiAgICAgICAgIHdlYmtpdHB5OiBXZWJTb2NrZXQgc2VydmVyIGRvZXNuJ3Qgc3Vw cG9ydCBQeXRob24gMyAoV29ya2Fyb3VuZCkKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJU cmVlL21hYy9Db25maWd1cmF0aW9ucy9CYXNlLnhjY29uZmlnIGIvVG9vbHMvRHVtcFJlbmRlclRy ZWUvbWFjL0NvbmZpZ3VyYXRpb25zL0Jhc2UueGNjb25maWcKaW5kZXggYmFhODkzNjk0NmIzY2Nj NjJjNDE3MTYxM2VkYWUyNjAwNDliMjE2MS4uZDBlYjBhYWNjZDc2ZmUyNTZlNWZhZDhkZjMzYWM4 OTVjMDY5NmY3YyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZpZ3Vy YXRpb25zL0Jhc2UueGNjb25maWcKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0NvbmZp Z3VyYXRpb25zL0Jhc2UueGNjb25maWcKQEAgLTEwNyw4ICsxMDcsOCBAQCBBRF9IT0NfQ09ERV9T SUdOSU5HX0FMTE9XRUQgPSBZRVM7CiAKIFNVUFBPUlRFRF9QTEFURk9STVMgPSBpcGhvbmVvcyBp cGhvbmVzaW11bGF0b3IgbWFjb3N4IGFwcGxldHZvcyBhcHBsZXR2c2ltdWxhdG9yIHdhdGNob3Mg d2F0Y2hzaW11bGF0b3I7CiAKLU9USEVSX0NGTEFHUyA9ICQoQVNBTl9PVEhFUl9DRkxBR1MpOwot T1RIRVJfQ1BMVVNQTFVTRkxBR1MgPSAkKEFTQU5fT1RIRVJfQ1BMVVNQTFVTRkxBR1MpOworT1RI RVJfQ0ZMQUdTID0gJChBU0FOX09USEVSX0NGTEFHUykgLWlzeXN0ZW0gJChTREtST09UKS9TeXN0 ZW0vTGlicmFyeS9GcmFtZXdvcmtzL1N5c3RlbS5mcmFtZXdvcmsvUHJpdmF0ZUhlYWRlcnM7CitP VEhFUl9DUExVU1BMVVNGTEFHUyA9ICQoQVNBTl9PVEhFUl9DUExVU1BMVVNGTEFHUykgLWlzeXN0 ZW0gJChTREtST09UKS9TeXN0ZW0vTGlicmFyeS9GcmFtZXdvcmtzL1N5c3RlbS5mcmFtZXdvcmsv UHJpdmF0ZUhlYWRlcnM7CiBPVEhFUl9MREZMQUdTID0gJChBU0FOX09USEVSX0xERkxBR1MpOwog CiBXRUJLSVRfRlJBTUVXT1JLX1JFU09VUkNFU19QQVRIID0gV2ViS2l0LmZyYW1ld29yazsK