206786 2020-01-24 17:28:36 -0800 WebCore: Remove iOS 11 macros from NetworkStorageSessionCocoa.mm 2020-01-27 08:17:14 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206096 InRadar P2 Normal --- 1 jbedard jbedard ap commit-queue darin webkit-bug-importer wilander oldest_to_newest 1610945 0 jbedard 2020-01-24 17:28:36 -0800 We have platform checks that are disguising themselves as version checks, they should be made more clear. 1610946 1 388748 jbedard 2020-01-24 17:30:35 -0800 Created attachment 388748 Patch 1611415 2 388748 commit-queue 2020-01-27 08:16:27 -0800 Comment on attachment 388748 Patch Clearing flags on attachment: 388748 Committed r255146: <https://trac.webkit.org/changeset/255146> 1611416 3 commit-queue 2020-01-27 08:16:28 -0800 All reviewed patches have been landed. Closing bug. 1611417 4 webkit-bug-importer 2020-01-27 08:17:14 -0800 <rdar://problem/58918785> 388748 2020-01-24 17:30:35 -0800 2020-01-27 08:16:27 -0800 Patch bug-206786-20200124173034.patch text/plain 4511 jbedard SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NTExMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTI0ICBKb25hdGhh biBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJDb3JlOiBSZW1vdmUg aU9TIDExIG1hY3JvcyBmcm9tIE5ldHdvcmtTdG9yYWdlU2Vzc2lvbkNvY29hLm1tCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY3ODYKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBmdW5jdGlvbmFsIGNo YW5nZXMsIGNvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9u ZXR3b3JrL2NvY29hL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkNvY29hLm1tOgorICAgICAgICAoV2Vi Q29yZTo6Y29va2llc0ZvclVSTCk6IAorICAgICAgICAoV2ViQ29yZTo6c2V0SFRUUENvb2tpZXNG b3JVUkwpOgorCiAyMDIwLTAxLTI0ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUu Y29tPgogCiAgICAgICAgIFtpT1NdIExvbmcgcHJlc3NpbmcgdGV4dCBpbnNpZGUgYSBzZWxlY3Rp b24gc2hvdWxkIHVwZGF0ZSB0aGUgc2VsZWN0aW9uCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9uZXR3b3JrL2NvY29hL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkNvY29hLm1tCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY29jb2EvTmV0d29ya1N0b3Jh Z2VTZXNzaW9uQ29jb2EubW0JKHJldmlzaW9uIDI1NTEwOCkKKysrIFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY29jb2EvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ29jb2EubW0JKHdvcmtp bmcgY29weSkKQEAgLTE5NCw3ICsxOTQsNyBAQCBzdGF0aWMgdm9pZCBkZWxldGVIVFRQQ29va2ll KENGSFRUUENvb2tpCiAgICAgQ0ZIVFRQQ29va2llU3RvcmFnZURlbGV0ZUNvb2tpZShjb29raWVT dG9yYWdlLCBbY29va2llIF9HZXRJbnRlcm5hbENGSFRUUENvb2tpZV0pOwogfQogCi0jaWYgKFBM QVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDAp IHx8IChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFV SVJFRCA+PSAxMjAwMDApCisjaWYgIShQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPCAxMDE0MDApICYmICFQTEFURk9STShXQVRDSE9TKSAmJiAhUExBVEZP Uk0oQVBQTEVUVikKIHN0YXRpYyBSZXRhaW5QdHI8TlNEaWN0aW9uYXJ5PiBwb2xpY3lQcm9wZXJ0 aWVzKGNvbnN0IFNhbWVTaXRlSW5mbyYgc2FtZVNpdGVJbmZvLCBOU1VSTCAqdXJsKQogewogICAg IHN0YXRpYyBOU1VSTCAqZW1wdHlVUkwgPSBbW05TVVJMIGFsbG9jXSBpbml0V2l0aFN0cmluZzpA IiJdOwpAQCAtMjEzLDcgKzIxMyw3IEBAIHN0YXRpYyBOU0FycmF5ICpjb29raWVzRm9yVVJMKE5T SFRUUENvb2sKICAgICBhdXRvIGNvbXBsZXRpb25IYW5kbGVyID0gWyZjb29raWVzUHRyXSAoTlNB cnJheSAqY29va2llcykgewogICAgICAgICBjb29raWVzUHRyID0gcmV0YWluUHRyKGNvb2tpZXMp OwogICAgIH07Ci0jaWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9S RVFVSVJFRCA+PSAxMDE0MDApIHx8IChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9P U19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMjAwMDApCisjaWYgIShQTEFURk9STShNQUMpICYm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE0MDApICYmICFQTEFURk9STShX QVRDSE9TKSAmJiAhUExBVEZPUk0oQVBQTEVUVikKICAgICBpZiAoW3N0b3JhZ2UgcmVzcG9uZHNU b1NlbGVjdG9yOkBzZWxlY3RvcihfZ2V0Q29va2llc0ZvclVSTDptYWluRG9jdW1lbnRVUkw6cGFy dGl0aW9uOnBvbGljeVByb3BlcnRpZXM6Y29tcGxldGlvbkhhbmRsZXI6KV0pCiAgICAgICAgIFtz dG9yYWdlIF9nZXRDb29raWVzRm9yVVJMOnVybCBtYWluRG9jdW1lbnRVUkw6bWFpbkRvY3VtZW50 VVJMIHBhcnRpdGlvbjpwYXJ0aXRpb24gcG9saWN5UHJvcGVydGllczpzYW1lU2l0ZUluZm8gPyBw b2xpY3lQcm9wZXJ0aWVzKHNhbWVTaXRlSW5mby52YWx1ZSgpLCB1cmwpLmdldCgpIDogbnVsbHB0 ciBjb21wbGV0aW9uSGFuZGxlcjpjb21wbGV0aW9uSGFuZGxlcl07CiAgICAgZWxzZQpAQCAtMjMw LDcgKzIzMCw3IEBAIHN0YXRpYyB2b2lkIHNldEhUVFBDb29raWVzRm9yVVJMKENGSFRUUEMKIHsK ICAgICBBU1NFUlQoaGFzUHJvY2Vzc1ByaXZpbGVnZShQcm9jZXNzUHJpdmlsZWdlOjpDYW5BY2Nl c3NSYXdDb29raWVzKSk7CiAgICAgaWYgKCFjb29raWVTdG9yYWdlKSB7Ci0jaWYgKFBMQVRGT1JN KE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMDE0MDApIHx8IChQ TEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSAxMjAwMDApCisjaWYgIShQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPCAxMDE0MDApICYmICFQTEFURk9STShXQVRDSE9TKSAmJiAhUExBVEZPUk0oQVBQ TEVUVikKICAgICAgICAgaWYgKFtOU0hUVFBDb29raWVTdG9yYWdlIGluc3RhbmNlc1Jlc3BvbmRU b1NlbGVjdG9yOkBzZWxlY3Rvcihfc2V0Q29va2llczpmb3JVUkw6bWFpbkRvY3VtZW50VVJMOnBv bGljeVByb3BlcnRpZXM6KV0pCiAgICAgICAgICAgICBbW05TSFRUUENvb2tpZVN0b3JhZ2Ugc2hh cmVkSFRUUENvb2tpZVN0b3JhZ2VdIF9zZXRDb29raWVzOmNvb2tpZXMgZm9yVVJMOnVybCBtYWlu RG9jdW1lbnRVUkw6bWFpbkRvY3VtZW50VVJMIHBvbGljeVByb3BlcnRpZXM6cG9saWN5UHJvcGVy dGllcyhzYW1lU2l0ZUluZm8sIHVybCkuZ2V0KCldOwogICAgICAgICBlbHNlCkBAIC0yMzgsNyAr MjM4LDcgQEAgc3RhdGljIHZvaWQgc2V0SFRUUENvb2tpZXNGb3JVUkwoQ0ZIVFRQQwogICAgICAg ICAgICAgW1tOU0hUVFBDb29raWVTdG9yYWdlIHNoYXJlZEhUVFBDb29raWVTdG9yYWdlXSBzZXRD b29raWVzOmNvb2tpZXMgZm9yVVJMOnVybCBtYWluRG9jdW1lbnRVUkw6bWFpbkRvY3VtZW50VVJM XTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19P U19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTQwMCkgfHwgKFBMQVRGT1JNKElPU19GQU1J TFkpICYmIF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEyMDAwMCkKKyNpZiAh KFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA8IDEwMTQw MCkgJiYgIVBMQVRGT1JNKFdBVENIT1MpICYmICFQTEFURk9STShBUFBMRVRWKQogICAgIGlmIChb TlNIVFRQQ29va2llU3RvcmFnZSBpbnN0YW5jZXNSZXNwb25kVG9TZWxlY3RvcjpAc2VsZWN0b3Io X3NldENvb2tpZXM6Zm9yVVJMOm1haW5Eb2N1bWVudFVSTDpwb2xpY3lQcm9wZXJ0aWVzOildKSB7 CiAgICAgICAgIC8vIEZJWE1FOiBTdG9wIGNyZWF0aW5nIGEgbmV3IE5TSFRUUENvb2tpZVN0b3Jh Z2Ugb2JqZWN0IGVhY2ggdGltZSB3ZSB3YW50IHRvIHF1ZXJ5IHRoZSBjb29raWUgamFyLgogICAg ICAgICAvLyBOZXR3b3JrU3RvcmFnZVNlc3Npb24gY291bGQgaW5zdGVhZCBrZWVwIGEgTlNIVFRQ Q29va2llU3RvcmFnZSBvYmplY3QgZm9yIHVzLgpAQCAtMjQ4LDcgKzI0OCw3IEBAIHN0YXRpYyB2 b2lkIHNldEhUVFBDb29raWVzRm9yVVJMKENGSFRUUEMKICNlbmRpZgogICAgICAgICBhdXRvIGNm Q29va2llcyA9IGFkb3B0Q0YoW05TSFRUUENvb2tpZSBfbnMyY2ZDb29raWVzOmNvb2tpZXNdKTsK ICAgICAgICAgQ0ZIVFRQQ29va2llU3RvcmFnZVNldENvb2tpZXMoY29va2llU3RvcmFnZSwgY2ZD b29raWVzLmdldCgpLCBbdXJsIF9jZnVybF0sIFttYWluRG9jdW1lbnRVUkwgX2NmdXJsXSk7Ci0j aWYgKFBMQVRGT1JNKE1BQykgJiYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAx MDE0MDApIHx8IChQTEFURk9STShJT1NfRkFNSUxZKSAmJiBfX0lQSE9ORV9PU19WRVJTSU9OX01J Tl9SRVFVSVJFRCA+PSAxMjAwMDApCisjaWYgIShQTEFURk9STShNQUMpICYmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPCAxMDE0MDApICYmICFQTEFURk9STShXQVRDSE9TKSAmJiAh UExBVEZPUk0oQVBQTEVUVikKICAgICB9CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShzYW1lU2l0 ZUluZm8pOwo=