206775 2020-01-24 15:50:16 -0800 Update EditorState from WebProcess when requesting context menu 2020-01-24 16:49:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen webkit-bug-importer wenson_hsieh oldest_to_newest 1610888 0 achristensen 2020-01-24 15:50:16 -0800 Update EditorState from WebProcess when requesting context menu 1610890 1 388734 achristensen 2020-01-24 15:53:38 -0800 Created attachment 388734 Patch 1610891 2 achristensen 2020-01-24 15:53:41 -0800 <rdar://problem/56305573> 1610900 3 388734 wenson_hsieh 2020-01-24 16:02:58 -0800 Comment on attachment 388734 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388734&action=review > Source/WebKit/WebProcess/WebPage/WebContextMenu.cpp:-72 > - m_page->send(Messages::WebPageProxy::ShowContextMenu(contextMenuContextData, UserData(WebProcess::singleton().transformObjectsToHandles(userData.get()).get()))); This seems okay, but we should also consider just calling flushPendingEditorStateUpdate() sending WebPageProxy::ShowContextMenu. This would have the advantage of avoiding editor state computation in the state where nothing changed (so m_hasPendingEditorStateUpdate is false). 1610918 4 achristensen 2020-01-24 16:49:30 -0800 Even better! http://trac.webkit.org/r255106 388734 2020-01-24 15:53:38 -0800 2020-01-24 16:02:58 -0800 Patch bug-206775-20200124155338.patch text/plain 5259 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTUxMDIpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDIwLTAxLTI0ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVXBkYXRlIEVkaXRv clN0YXRlIGZyb20gV2ViUHJvY2VzcyB3aGVuIHJlcXVlc3RpbmcgY29udGV4dCBtZW51CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY3NzUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzU2MzA1NTczPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gZ2VuZXJhdGluZyBhIGNvbnRleHQgbWVudSwgQXBw S2l0IGNhbGxzIC12YWxpZFJlcXVlc3RvckZvclNlbmRUeXBlOnJldHVyblR5cGU6CisgICAgICAg IHdoaWNoIHF1ZXJpZXMgdGhlIGVkaXRvciBzdGF0ZSBpbiBXZWJWaWV3SW1wbDo6dmFsaWRSZXF1 ZXN0b3JGb3JTZW5kQW5kUmV0dXJuVHlwZXMuCisgICAgICAgIFdpdGhvdXQgdXBkYXRpbmcgdGhl IGVkaXRvciBzdGF0ZSwgdGhlIGZpcnN0IHRpbWUgeW91IHJpZ2h0IGNsaWNrIG9uIGEgbGluaywK KyAgICAgICAgdGhlIFNlcnZpY2VzIG1lbnUgaXRlbSBkaWQgbm90IGFwcGVhciBiZWNhdXNlIHdl IHdlcmUgbG9va2luZyBhdCBhIHN0YWxlIGVkaXRvciBzdGF0ZS4KKyAgICAgICAgVmVyaWZpZWQg bWFudWFsbHkgdGhpcyBmaXhlcyB0aGUgYnVnLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5oOgorICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkubWVzc2FnZXMuaW46CisgICAgICAgICogV2ViUHJv Y2Vzcy9XZWJQYWdlL1dlYkNvbnRleHRNZW51LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViQ29u dGV4dE1lbnU6OnNob3cpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFn ZU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6aGFuZGxlU2VsZWN0aW9uU2Vydmlj ZUNsaWNrKToKKwogMjAyMC0wMS0yNCAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGEgYnVpbGQgZml4IGFmdGVyIHIyNTUwNTYKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gMjU1MDky KQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjI4NywxMSArNjI4NywxMyBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6aGlkZVBvcHVw TWVudSgpCiB9CiAKICNpZiBFTkFCTEUoQ09OVEVYVF9NRU5VUykKLXZvaWQgV2ViUGFnZVByb3h5 OjpzaG93Q29udGV4dE1lbnUoQ29udGV4dE1lbnVDb250ZXh0RGF0YSYmIGNvbnRleHRNZW51Q29u dGV4dERhdGEsIGNvbnN0IFVzZXJEYXRhJiB1c2VyRGF0YSkKK3ZvaWQgV2ViUGFnZVByb3h5Ojpz aG93Q29udGV4dE1lbnUoQ29udGV4dE1lbnVDb250ZXh0RGF0YSYmIGNvbnRleHRNZW51Q29udGV4 dERhdGEsIEVkaXRvclN0YXRlJiYgZWRpdG9yU3RhdGUsIGNvbnN0IFVzZXJEYXRhJiB1c2VyRGF0 YSkKIHsKICAgICAvLyBTaG93aW5nIGEgY29udGV4dCBtZW51IHJ1bnMgYSBuZXN0ZWQgcnVubG9v cCwgd2hpY2ggY2FuIGhhbmRsZSBtZXNzYWdlcyB0aGF0IGNhdXNlIHx0aGlzfCB0byBnZXQgY2xv c2VkLgogICAgIFJlZjxXZWJQYWdlUHJveHk+IHByb3RlY3QoKnRoaXMpOwogCisgICAgdXBkYXRl RWRpdG9yU3RhdGUoZWRpdG9yU3RhdGUpOworCiAgICAgLy8gSWYgdGhlIHBhZ2UgaXMgY29udHJv bGxlZCBieSBhdXRvbWF0aW9uLCBlbnRlcmluZyBhIG5lc3RlZCBydW4gbG9vcCB3aGlsZSB0aGUg bWVudSBpcyBvcGVuCiAgICAgLy8gY2FuIGhhbmcgdGhlIHBhZ2UgLyBXZWJEcml2ZXIgdGVzdC4g UHJldGVuZCB0byBzaG93IGFuZCBpbW1lZGlhdGVseSBkaXNtaXNzIHRoZSBjb250ZXh0IG1lbnUu CiAgICAgaWYgKGF1dG8qIGF1dG9tYXRpb25TZXNzaW9uID0gcHJvY2VzcygpLnByb2Nlc3NQb29s KCkuYXV0b21hdGlvblNlc3Npb24oKSkgewpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViUGFnZVByb3h5LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmgJKHJldmlzaW9uIDI1NTA5MikKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYlBhZ2VQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xOTI1LDcgKzE5MjUsNyBAQCBwcml2 YXRlOgogICAgIHZvaWQgaGlkZVBvcHVwTWVudSgpOwogCiAjaWYgRU5BQkxFKENPTlRFWFRfTUVO VVMpCi0gICAgdm9pZCBzaG93Q29udGV4dE1lbnUoQ29udGV4dE1lbnVDb250ZXh0RGF0YSYmLCBj b25zdCBVc2VyRGF0YSYpOworICAgIHZvaWQgc2hvd0NvbnRleHRNZW51KENvbnRleHRNZW51Q29u dGV4dERhdGEmJiwgRWRpdG9yU3RhdGUmJiwgY29uc3QgVXNlckRhdGEmKTsKICNlbmRpZgogCiAj aWYgRU5BQkxFKFRFTEVQSE9ORV9OVU1CRVJfREVURUNUSU9OKQpJbmRleDogU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmluCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5tZXNzYWdlcy5pbgkocmV2aXNpb24gMjU1 MDkyKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUGFnZVByb3h5Lm1lc3NhZ2VzLmlu CSh3b3JraW5nIGNvcHkpCkBAIC0yNzQsNyArMjc0LDcgQEAgbWVzc2FnZXMgLT4gV2ViUGFnZVBy b3h5IHsKICAgICBIaWRlUG9wdXBNZW51KCkKIAogI2lmIEVOQUJMRShDT05URVhUX01FTlVTKQot ICAgIFNob3dDb250ZXh0TWVudShXZWJLaXQ6OkNvbnRleHRNZW51Q29udGV4dERhdGEgY29udGV4 dE1lbnVDb250ZXh0RGF0YSwgV2ViS2l0OjpVc2VyRGF0YSB1c2VyRGF0YSkKKyAgICBTaG93Q29u dGV4dE1lbnUoV2ViS2l0OjpDb250ZXh0TWVudUNvbnRleHREYXRhIGNvbnRleHRNZW51Q29udGV4 dERhdGEsIHN0cnVjdCBXZWJLaXQ6OkVkaXRvclN0YXRlIGVkaXRvclN0YXRlLCBXZWJLaXQ6OlVz ZXJEYXRhIHVzZXJEYXRhKQogI2VuZGlmCiAKICAgICAjIERhdGFiYXNlIG1lc3NhZ2VzCkluZGV4 OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJDb250ZXh0TWVudS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViQ29udGV4dE1l bnUuY3BwCShyZXZpc2lvbiAyNTUwOTIpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9XZWJDb250ZXh0TWVudS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY5LDcgKzY5LDcgQEAg dm9pZCBXZWJDb250ZXh0TWVudTo6c2hvdygpCiAKICAgICAvLyBNYXJrIHRoZSBXZWJQYWdlIGhh cyBoYXZpbmcgYSBzaG93biBjb250ZXh0IG1lbnUgdGhlbiBub3RpZnkgdGhlIFVJUHJvY2Vzcy4K ICAgICBtX3BhZ2UtPmNvbnRleHRNZW51U2hvd2luZygpOwotICAgIG1fcGFnZS0+c2VuZChNZXNz YWdlczo6V2ViUGFnZVByb3h5OjpTaG93Q29udGV4dE1lbnUoY29udGV4dE1lbnVDb250ZXh0RGF0 YSwgVXNlckRhdGEoV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkudHJhbnNmb3JtT2JqZWN0c1RvSGFu ZGxlcyh1c2VyRGF0YS5nZXQoKSkuZ2V0KCkpKSk7CisgICAgbV9wYWdlLT5zZW5kKE1lc3NhZ2Vz OjpXZWJQYWdlUHJveHk6OlNob3dDb250ZXh0TWVudShjb250ZXh0TWVudUNvbnRleHREYXRhLCBt X3BhZ2UtPmVkaXRvclN0YXRlKCksIFVzZXJEYXRhKFdlYlByb2Nlc3M6OnNpbmdsZXRvbigpLnRy YW5zZm9ybU9iamVjdHNUb0hhbmRsZXModXNlckRhdGEuZ2V0KCkpLmdldCgpKSkpOwogfQogCiB2 b2lkIFdlYkNvbnRleHRNZW51OjppdGVtU2VsZWN0ZWQoY29uc3QgV2ViQ29udGV4dE1lbnVJdGVt RGF0YSYgaXRlbSkKSW5kZXg6IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9X ZWJQYWdlTWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL21hYy9XZWJQYWdlTWFjLm1tCShyZXZpc2lvbiAyNTUwOTIpCisrKyBTb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV2ViUGFnZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAt ODMyLDcgKzgzMiw3IEBAIHZvaWQgV2ViUGFnZTo6aGFuZGxlU2VsZWN0aW9uU2VydmljZUNsaWMK ICAgICBWZWN0b3I8dWludDhfdD4gc2VsZWN0aW9uRGF0YVZlY3RvcjsKICAgICBzZWxlY3Rpb25E YXRhVmVjdG9yLmFwcGVuZChyZWludGVycHJldF9jYXN0PGNvbnN0IHVpbnQ4X3QqPihzZWxlY3Rp b25EYXRhLmJ5dGVzKSwgc2VsZWN0aW9uRGF0YS5sZW5ndGgpOwogCi0gICAgc2VuZChNZXNzYWdl czo6V2ViUGFnZVByb3h5OjpTaG93Q29udGV4dE1lbnUoQ29udGV4dE1lbnVDb250ZXh0RGF0YShw b2ludCwgc2VsZWN0aW9uRGF0YVZlY3RvciwgcGhvbmVOdW1iZXJzLCBzZWxlY3Rpb24uc2VsZWN0 aW9uKCkuaXNDb250ZW50RWRpdGFibGUoKSksIFVzZXJEYXRhKCkpKTsKKyAgICBzZW5kKE1lc3Nh Z2VzOjpXZWJQYWdlUHJveHk6OlNob3dDb250ZXh0TWVudShDb250ZXh0TWVudUNvbnRleHREYXRh KHBvaW50LCBzZWxlY3Rpb25EYXRhVmVjdG9yLCBwaG9uZU51bWJlcnMsIHNlbGVjdGlvbi5zZWxl Y3Rpb24oKS5pc0NvbnRlbnRFZGl0YWJsZSgpKSwgZWRpdG9yU3RhdGUoKSwgVXNlckRhdGEoKSkp OwogfQogI2VuZGlmCiAK