206744 2020-01-24 07:21:16 -0800 [LFC][Painting] Add Display::Run cleanup to TextPainter::clearGlyphDisplayLists 2020-01-24 08:42:34 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan mmaxfield pdr simon.fraser webkit-bug-importer zalan oldest_to_newest 1610652 0 zalan 2020-01-24 07:21:16 -0800 ssia 1610653 1 webkit-bug-importer 2020-01-24 07:21:35 -0800 <rdar://problem/58867112> 1610659 2 388686 zalan 2020-01-24 07:28:27 -0800 Created attachment 388686 Patch 1610660 3 zalan 2020-01-24 07:32:43 -0800 ifdef all the things 1610661 4 388687 zalan 2020-01-24 07:34:37 -0800 Created attachment 388687 Patch 1610663 5 388687 koivisto 2020-01-24 07:35:53 -0800 Comment on attachment 388687 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388687&action=review > Source/WebCore/rendering/TextPainter.cpp:219 > +#if ENABLE(LAYOUT_FORMATTING_CONTEXT) > + GlyphDisplayListCache<Display::Run>::singleton().clear(); > +#endif Could have runtime check too to avoid unnecessary construction of the singleton. 1610664 6 388688 zalan 2020-01-24 07:39:43 -0800 Created attachment 388688 Patch 1610695 7 388688 commit-queue 2020-01-24 08:42:32 -0800 Comment on attachment 388688 Patch Clearing flags on attachment: 388688 Committed r255074: <https://trac.webkit.org/changeset/255074> 1610696 8 commit-queue 2020-01-24 08:42:34 -0800 All reviewed patches have been landed. Closing bug. 388686 2020-01-24 07:28:27 -0800 2020-01-24 07:32:55 -0800 Patch bug-206744-20200124072827.patch text/plain 1604 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDE0NGQwOTBiMGMwZGQ5 YWU5NzYyNzc2YTc4OWJjYTU0OTI3YmQ2NS4uNDY4ZGM4YWViNTM1NTU3NGY3N2I3NzFkNjEzMTg2 MDJiZjQ3MTdlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAxLTI0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bUGFpbnRpbmddIEFk ZCBEaXNwbGF5OjpSdW4gY2xlYW51cCB0byBUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERpc3BsYXlM aXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NzQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODg2NzExMj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9UZXh0UGFpbnRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERpc3BsYXlMaXN0 cyk6CisKIDIwMjAtMDEtMjQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gTGluZUxheW91dDo6cGFpbnQgc2hvdWxkIHRha2UgYWR2 YW50YWdlIG9mIHRoZSBnbHlwaCBkaXNwbGF5IGxpc3QgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvVGV4dFBhaW50ZXIuY3BwCmluZGV4IDVhMWM5ODRlMTk2OGJkMmFlYzY3MDdjZGI2NDE2 NDNiNzM3NGZkYWIuLmQ2ZjUwOTM4NmNmMWY0NzA1NjhiZGNlZDFkNWIwMDIxZTY5NjFhYjYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcApAQCAtMjQsNiArMjQsNyBA QAogI2luY2x1ZGUgIlRleHRQYWludGVyLmgiCiAKICNpbmNsdWRlICJEaXNwbGF5TGlzdFJlcGxh eWVyLmgiCisjaW5jbHVkZSAiRGlzcGxheVJ1bi5oIgogI2luY2x1ZGUgIkZpbHRlck9wZXJhdGlv bnMuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJJbmxpbmVUZXh0 Qm94LmgiCkBAIC0yMTMsNiArMjE0LDcgQEAgdm9pZCBUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERp c3BsYXlMaXN0cygpCiB7CiAgICAgR2x5cGhEaXNwbGF5TGlzdENhY2hlPElubGluZVRleHRCb3g+ OjpzaW5nbGV0b24oKS5jbGVhcigpOwogICAgIEdseXBoRGlzcGxheUxpc3RDYWNoZTxTaW1wbGVM aW5lTGF5b3V0OjpSdW4+OjpzaW5nbGV0b24oKS5jbGVhcigpOworICAgIEdseXBoRGlzcGxheUxp c3RDYWNoZTxEaXNwbGF5OjpSdW4+OjpzaW5nbGV0b24oKS5jbGVhcigpOwogfQogCiBib29sIFRl eHRQYWludGVyOjpzaG91bGRVc2VHbHlwaERpc3BsYXlMaXN0KGNvbnN0IFBhaW50SW5mbyYgcGFp bnRJbmZvKQo= 388687 2020-01-24 07:34:37 -0800 2020-01-24 07:39:41 -0800 Patch bug-206744-20200124073437.patch text/plain 1651 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDE0NGQwOTBiMGMwZGQ5 YWU5NzYyNzc2YTc4OWJjYTU0OTI3YmQ2NS4uNDY4ZGM4YWViNTM1NTU3NGY3N2I3NzFkNjEzMTg2 MDJiZjQ3MTdlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAxLTI0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bUGFpbnRpbmddIEFk ZCBEaXNwbGF5OjpSdW4gY2xlYW51cCB0byBUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERpc3BsYXlM aXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NzQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODg2NzExMj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9UZXh0UGFpbnRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERpc3BsYXlMaXN0 cyk6CisKIDIwMjAtMDEtMjQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gTGluZUxheW91dDo6cGFpbnQgc2hvdWxkIHRha2UgYWR2 YW50YWdlIG9mIHRoZSBnbHlwaCBkaXNwbGF5IGxpc3QgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvVGV4dFBhaW50ZXIuY3BwCmluZGV4IDVhMWM5ODRlMTk2OGJkMmFlYzY3MDdjZGI2NDE2 NDNiNzM3NGZkYWIuLjhkNDRiOTAyNzMzYWUyNWIwODE2MThjNTYxZmM1N2ZmZGM4NzVhZGEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcApAQCAtMjQsNiArMjQsNyBA QAogI2luY2x1ZGUgIlRleHRQYWludGVyLmgiCiAKICNpbmNsdWRlICJEaXNwbGF5TGlzdFJlcGxh eWVyLmgiCisjaW5jbHVkZSAiRGlzcGxheVJ1bi5oIgogI2luY2x1ZGUgIkZpbHRlck9wZXJhdGlv bnMuaCIKICNpbmNsdWRlICJHcmFwaGljc0NvbnRleHQuaCIKICNpbmNsdWRlICJJbmxpbmVUZXh0 Qm94LmgiCkBAIC0yMTMsNiArMjE0LDkgQEAgdm9pZCBUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERp c3BsYXlMaXN0cygpCiB7CiAgICAgR2x5cGhEaXNwbGF5TGlzdENhY2hlPElubGluZVRleHRCb3g+ OjpzaW5nbGV0b24oKS5jbGVhcigpOwogICAgIEdseXBoRGlzcGxheUxpc3RDYWNoZTxTaW1wbGVM aW5lTGF5b3V0OjpSdW4+OjpzaW5nbGV0b24oKS5jbGVhcigpOworI2lmIEVOQUJMRShMQVlPVVRf Rk9STUFUVElOR19DT05URVhUKQorICAgIEdseXBoRGlzcGxheUxpc3RDYWNoZTxEaXNwbGF5OjpS dW4+OjpzaW5nbGV0b24oKS5jbGVhcigpOworI2VuZGlmCiB9CiAKIGJvb2wgVGV4dFBhaW50ZXI6 OnNob3VsZFVzZUdseXBoRGlzcGxheUxpc3QoY29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8pCg== 388688 2020-01-24 07:39:43 -0800 2020-01-24 08:42:32 -0800 Patch bug-206744-20200124073942.patch text/plain 1908 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDE0NGQwOTBiMGMwZGQ5 YWU5NzYyNzc2YTc4OWJjYTU0OTI3YmQ2NS4uNWNiMDgxYjhlNWM0ZTA1ZTI0ZmMwMmRjZmZhZWRj MDdhOTQ0ZDM4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIwLTAxLTI0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bUGFpbnRpbmddIEFk ZCBEaXNwbGF5OjpSdW4gY2xlYW51cCB0byBUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERpc3BsYXlM aXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NzQ0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODg2NzExMj4KKworICAgICAgICBSZXZpZXdl ZCBieSBBbnR0aSBLb2l2aXN0by4KKworICAgICAgICAqIHJlbmRlcmluZy9UZXh0UGFpbnRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0UGFpbnRlcjo6Y2xlYXJHbHlwaERpc3BsYXlMaXN0 cyk6CisKIDIwMjAtMDEtMjQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAg ICAgICBbTEZDXVtJbnRlZ3JhdGlvbl0gTGluZUxheW91dDo6cGFpbnQgc2hvdWxkIHRha2UgYWR2 YW50YWdlIG9mIHRoZSBnbHlwaCBkaXNwbGF5IGxpc3QgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvVGV4dFBhaW50ZXIuY3BwCmluZGV4IDVhMWM5ODRlMTk2OGJkMmFlYzY3MDdjZGI2NDE2 NDNiNzM3NGZkYWIuLjdjZGM2ODM1OGZkOWVhZWQ2NmRmNDI5NTczY2EwNjY5YjgzYmEyZDkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9UZXh0UGFpbnRlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1RleHRQYWludGVyLmNwcApAQCAtMjQsMTEgKzI0LDEz IEBACiAjaW5jbHVkZSAiVGV4dFBhaW50ZXIuaCIKIAogI2luY2x1ZGUgIkRpc3BsYXlMaXN0UmVw bGF5ZXIuaCIKKyNpbmNsdWRlICJEaXNwbGF5UnVuLmgiCiAjaW5jbHVkZSAiRmlsdGVyT3BlcmF0 aW9ucy5oIgogI2luY2x1ZGUgIkdyYXBoaWNzQ29udGV4dC5oIgogI2luY2x1ZGUgIklubGluZVRl eHRCb3guaCIKICNpbmNsdWRlICJSZW5kZXJDb21iaW5lVGV4dC5oIgogI2luY2x1ZGUgIlJlbmRl ckxheWVyLmgiCisjaW5jbHVkZSAiUnVudGltZUVuYWJsZWRGZWF0dXJlcy5oIgogI2luY2x1ZGUg IlNoYWRvd0RhdGEuaCIKICNpbmNsdWRlIDx3dGYvTmV2ZXJEZXN0cm95ZWQuaD4KIApAQCAtMjEz LDYgKzIxNSwxMCBAQCB2b2lkIFRleHRQYWludGVyOjpjbGVhckdseXBoRGlzcGxheUxpc3RzKCkK IHsKICAgICBHbHlwaERpc3BsYXlMaXN0Q2FjaGU8SW5saW5lVGV4dEJveD46OnNpbmdsZXRvbigp LmNsZWFyKCk7CiAgICAgR2x5cGhEaXNwbGF5TGlzdENhY2hlPFNpbXBsZUxpbmVMYXlvdXQ6OlJ1 bj46OnNpbmdsZXRvbigpLmNsZWFyKCk7CisjaWYgRU5BQkxFKExBWU9VVF9GT1JNQVRUSU5HX0NP TlRFWFQpCisgICAgaWYgKFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNoYXJlZEZlYXR1cmVzKCku bGF5b3V0Rm9ybWF0dGluZ0NvbnRleHRJbnRlZ3JhdGlvbkVuYWJsZWQoKSkKKyAgICAgICAgR2x5 cGhEaXNwbGF5TGlzdENhY2hlPERpc3BsYXk6OlJ1bj46OnNpbmdsZXRvbigpLmNsZWFyKCk7Cisj ZW5kaWYKIH0KIAogYm9vbCBUZXh0UGFpbnRlcjo6c2hvdWxkVXNlR2x5cGhEaXNwbGF5TGlzdChj b25zdCBQYWludEluZm8mIHBhaW50SW5mbykK