20673 2008-09-05 14:07:01 -0700 single-character strings are churning in the Identifier table 2008-09-05 21:58:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 90299 0 darin 2008-09-05 14:07:01 -0700 As an unintended result of the single-character string optimization I did last week, single character strings are being inserted into the identifier table over and over again. Easy to fix. 90300 1 23199 darin 2008-09-05 14:11:38 -0700 Created attachment 23199 patch 90346 2 23199 ggaren 2008-09-05 21:52:00 -0700 Comment on attachment 23199 patch r=me 90347 3 darin 2008-09-05 21:58:54 -0700 Committed revision 36124. 23199 2008-09-05 14:11:38 -0700 2008-09-05 21:52:00 -0700 patch SingleCharacterIdentifierPatch.txt text/plain 7567 darin SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM2MTE1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMzMgQEAKKzIwMDgtMDktMDUgIERhcmluIEFk bGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIC0gZml4IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMDY3MworICAgICAgICAgIHNpbmdsZS1jaGFyYWN0ZXIgc3RyaW5ncyBhcmUgY2h1cm5p bmcgaW4gdGhlIElkZW50aWZpZXIgdGFibGUKKworICAgICAgICBTdW5TcGlkZXIgb3ZlcmFsbCBp cyAxLjAwN3ggYXMgZmFzdAorICAgICAgICBTdW5TcGlkZXIgc3RyaW5nL2Zhc3RlciBpcyAxLjE2 N3ggYXMgZmFzdAorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUuZXhwOiBVcGRhdGVkLgorICAg ICAgICAqIGtqcy9TbWFsbFN0cmluZ3MuY3BwOgorICAgICAgICAoS0pTOjpTbWFsbFN0cmluZ3M6 OnNpbmdsZUNoYXJhY3RlclN0cmluZ1JlcCk6IEFkZGVkLgorICAgICAgICAqIGtqcy9TbWFsbFN0 cmluZ3MuaDogQWRkZWQgc2luZ2xlQ2hhcmFjdGVyU3RyaW5nUmVwIGZvciBjbGllbnRzIHRoYXQK KyAgICAgICAgbmVlZCBqdXN0IGEgVVN0cmluZywgbm90IGEgSlNTdHJpbmcuCisgICAgICAgICog a2pzL2lkZW50aWZpZXIuY3BwOgorICAgICAgICAoS0pTOjpJZGVudGlmaWVyOjphZGQpOiBBZGRl ZCBzcGVjaWFsIGNhc2VzIGZvciBzaW5nbGUgY2hhcmFjdGVyIHN0cmluZ3MKKyAgICAgICAgc28g dGhhdCB0aGUgVVN0cmluZzo6UmVwIHRoYXQgZW5kcyB1cCBpbiB0aGUgaWRlbnRpZmllciB0YWJs ZSBpcyB0aGUgb25lCisgICAgICAgIGZyb20gdGhlIHNpbmdsZS1jaGFyYWN0ZXIgc3RyaW5nIG9w dGltaXphdGlvbjsgb3RoZXJ3aXNlIHdlIGVuZCB1cCBoYXZpbmcKKyAgICAgICAgdG8gbG9vayBp dCB1cCBpbiB0aGUgaWRlbnRpZmllciB0YWJsZSBvdmVyIGFuZCBvdmVyIGFnYWluLgorICAgICAg ICAoS0pTOjpJZGVudGlmaWVyOjphZGRTbG93Q2FzZSk6IERpdHRvLgorICAgICAgICAoS0pTOjpJ ZGVudGlmaWVyOjpjaGVja1NhbWVJZGVudGlmaWVyVGFibGUpOiBNYWRlIHRoaXMgZnVuY3Rpb24g YW4gZW1wdHkKKyAgICAgICAgaW5saW5lIGluIHJlbGVhc2UgYnVpbGRzIHNvIHRoYXQgY2FsbGVy cyBkb24ndCBoYXZlIHRvIHB1dCAjaWZuZGVmIE5ERUJVRworICAgICAgICBhdCBlYWNoIGNhbGwg c2l0ZS4KKyAgICAgICAgKiBranMvaWRlbnRpZmllci5oOgorICAgICAgICAoS0pTOjpJZGVudGlm aWVyOjphZGQpOiBSZW1vdmVkICNpZm5kZWYgTkRFQlVHIGFyb3VuZCB0aGUgY2FsbHMgdG8KKyAg ICAgICAgY2hlY2tTYW1lSWRlbnRpZmllclRhYmxlLgorICAgICAgICAoS0pTOjpJZGVudGlmaWVy OjpjaGVja1NhbWVJZGVudGlmaWVyVGFibGUpOiBBZGRlZC4gRW1wdHkgaW5saW5lIHZlcnNpb24K KyAgICAgICAgZm9yIE5ERUJVRyBidWlsZHMuCisKIDIwMDgtMDktMDUgIEtldmluIE1jQ3VsbG91 Z2ggIDxrbWNjdWxsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIGFu ZCBBbGV4ZXkuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5leHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZXhwCShyZXZpc2lvbiAzNjEx MykKKysrIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLmV4cAkod29ya2luZyBjb3B5KQpA QCAtODYsOCArODYsNiBAQCBfX1oxNWpzUmVnRXhwRXhlY3V0ZVBLOEpTUmVnRXhwUEt0aWlQaWkK IF9fWk4xNE9wYXF1ZUpTU3RyaW5nNmNyZWF0ZUVSS04zS0pTN1VTdHJpbmdFCiBfX1pOM0tKUzEw SWRlbnRpZmllcjExYWRkU2xvd0Nhc2VFUE5TXzEySlNHbG9iYWxEYXRhRVBOU183VVN0cmluZzNS ZXBFCiBfX1pOM0tKUzEwSWRlbnRpZmllcjExYWRkU2xvd0Nhc2VFUE5TXzlFeGVjU3RhdGVFUE5T XzdVU3RyaW5nM1JlcEUKLV9fWk4zS0pTMTBJZGVudGlmaWVyMjRjaGVja1NhbWVJZGVudGlmaWVy VGFibGVFUE5TXzEySlNHbG9iYWxEYXRhRVBOU183VVN0cmluZzNSZXBFCi1fX1pOM0tKUzEwSWRl bnRpZmllcjI0Y2hlY2tTYW1lSWRlbnRpZmllclRhYmxlRVBOU185RXhlY1N0YXRlRVBOU183VVN0 cmluZzNSZXBFCiBfX1pOM0tKUzEwSWRlbnRpZmllcjNhZGRFUE5TXzlFeGVjU3RhdGVFUEtjCiBf X1pOM0tKUzEwSWRlbnRpZmllcjVlcXVhbEVQS05TXzdVU3RyaW5nM1JlcEVQS2MKIF9fWk4zS0pT MTB0aHJvd0Vycm9yRVBOU185RXhlY1N0YXRlRU5TXzlFcnJvclR5cGVFCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS9ranMvU21hbGxTdHJpbmdzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29y ZS9ranMvU21hbGxTdHJpbmdzLmNwcAkocmV2aXNpb24gMzYxMTMpCisrKyBKYXZhU2NyaXB0Q29y ZS9ranMvU21hbGxTdHJpbmdzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTAxLDQgKzEwMSwxMSBA QCB2b2lkIFNtYWxsU3RyaW5nczo6Y3JlYXRlU2luZ2xlQ2hhcmFjdGVyCiAgICAgbV9zaW5nbGVD aGFyYWN0ZXJTdHJpbmdzW2NoYXJhY3Rlcl0gPSBuZXcgKGV4ZWMpIEpTU3RyaW5nKG1fc3RvcmFn ZS0+cmVwKGNoYXJhY3RlciksIEpTU3RyaW5nOjpIYXNPdGhlck93bmVyKTsKIH0KIAorVVN0cmlu Zzo6UmVwKiBTbWFsbFN0cmluZ3M6OnNpbmdsZUNoYXJhY3RlclN0cmluZ1JlcCh1bnNpZ25lZCBj aGFyIGNoYXJhY3RlcikKK3sKKyAgICBpZiAoIW1fc3RvcmFnZSkKKyAgICAgICAgbV9zdG9yYWdl LnNldChuZXcgU21hbGxTdHJpbmdzU3RvcmFnZSk7CisgICAgcmV0dXJuIG1fc3RvcmFnZS0+cmVw KGNoYXJhY3Rlcik7Cit9CisKIH0KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2tqcy9TbWFsbFN0cmlu Z3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ranMvU21hbGxTdHJpbmdzLmgJKHJl dmlzaW9uIDM2MTEzKQorKysgSmF2YVNjcmlwdENvcmUva2pzL1NtYWxsU3RyaW5ncy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBACiAjaWZuZGVmIFNtYWxsU3RyaW5nc19oCiAjZGVm aW5lIFNtYWxsU3RyaW5nc19oCiAKKyNpbmNsdWRlICJ1c3RyaW5nLmgiCiAjaW5jbHVkZSA8d3Rm L093blB0ci5oPgogCiBuYW1lc3BhY2UgS0pTIHsKQEAgLTUyLDYgKzUzLDggQEAgbmFtZXNwYWNl IEtKUyB7CiAgICAgICAgICAgICAgICAgY3JlYXRlU2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGV4ZWMs IGNoYXJhY3Rlcik7CiAgICAgICAgICAgICByZXR1cm4gbV9zaW5nbGVDaGFyYWN0ZXJTdHJpbmdz W2NoYXJhY3Rlcl07CiAgICAgICAgIH0KKworICAgICAgICBVU3RyaW5nOjpSZXAqIHNpbmdsZUNo YXJhY3RlclN0cmluZ1JlcCh1bnNpZ25lZCBjaGFyIGNoYXJhY3Rlcik7CiAgICAgICAgIAogICAg ICAgICB2b2lkIG1hcmsoKTsKICAgICAgICAgCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvaWRl bnRpZmllci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUva2pzL2lkZW50aWZpZXIu Y3BwCShyZXZpc2lvbiAzNjExMykKKysrIEphdmFTY3JpcHRDb3JlL2tqcy9pZGVudGlmaWVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtMTI5LDExICsxMjksMTIgQEAgUGFzc1JlZlB0cjxVU3RyaW5n OjpSZXA+IElkZW50aWZpZXI6OmFkZAogICAgICAgICBVU3RyaW5nOjpSZXA6Om51bGwuaGFzaCgp OwogICAgICAgICByZXR1cm4gJlVTdHJpbmc6OlJlcDo6bnVsbDsKICAgICB9Ci0KICAgICBpZiAo IWNbMF0pIHsKICAgICAgICAgVVN0cmluZzo6UmVwOjplbXB0eS5oYXNoKCk7CiAgICAgICAgIHJl dHVybiAmVVN0cmluZzo6UmVwOjplbXB0eTsKICAgICB9CisgICAgaWYgKCFjWzFdKQorICAgICAg ICByZXR1cm4gYWRkKGdsb2JhbERhdGEsIGdsb2JhbERhdGEtPnNtYWxsU3RyaW5ncy5zaW5nbGVD aGFyYWN0ZXJTdHJpbmdSZXAoc3RhdGljX2Nhc3Q8dW5zaWduZWQgY2hhcj4oY1sxXSkpKTsKIAog ICAgIElkZW50aWZpZXJUYWJsZSYgaWRlbnRpZmllclRhYmxlID0gKmdsb2JhbERhdGEtPmlkZW50 aWZpZXJUYWJsZTsKICAgICBMaXRlcmFsSWRlbnRpZmllclRhYmxlJiBsaXRlcmFsSWRlbnRpZmll clRhYmxlID0gaWRlbnRpZmllclRhYmxlLmxpdGVyYWxUYWJsZSgpOwpAQCAtMTg2LDExICsxODcs MTUgQEAgc3RydWN0IFVDaGFyQnVmZmVyVHJhbnNsYXRvcgogCiBQYXNzUmVmUHRyPFVTdHJpbmc6 OlJlcD4gSWRlbnRpZmllcjo6YWRkKEpTR2xvYmFsRGF0YSogZ2xvYmFsRGF0YSwgY29uc3QgVUNo YXIqIHMsIGludCBsZW5ndGgpCiB7CisgICAgaWYgKGxlbmd0aCA9PSAxKSB7CisgICAgICAgIFVD aGFyIGMgPSBzWzBdOworICAgICAgICBpZiAoYyA8PSAweEZGKQorICAgICAgICAgICAgcmV0dXJu IGFkZChnbG9iYWxEYXRhLCBnbG9iYWxEYXRhLT5zbWFsbFN0cmluZ3Muc2luZ2xlQ2hhcmFjdGVy U3RyaW5nUmVwKGMpKTsKKyAgICB9CiAgICAgaWYgKCFsZW5ndGgpIHsKICAgICAgICAgVVN0cmlu Zzo6UmVwOjplbXB0eS5oYXNoKCk7CiAgICAgICAgIHJldHVybiAmVVN0cmluZzo6UmVwOjplbXB0 eTsKICAgICB9Ci0gICAgCiAgICAgVUNoYXJCdWZmZXIgYnVmID0ge3MsIGxlbmd0aH07IAogICAg IHJldHVybiAqZ2xvYmFsRGF0YS0+aWRlbnRpZmllclRhYmxlLT5hZGQ8VUNoYXJCdWZmZXIsIFVD aGFyQnVmZmVyVHJhbnNsYXRvcj4oYnVmKS5maXJzdDsKIH0KQEAgLTIwMywxMiArMjA4LDE5IEBA IFBhc3NSZWZQdHI8VVN0cmluZzo6UmVwPiBJZGVudGlmaWVyOjphZGQKIFBhc3NSZWZQdHI8VVN0 cmluZzo6UmVwPiBJZGVudGlmaWVyOjphZGRTbG93Q2FzZShKU0dsb2JhbERhdGEqIGdsb2JhbERh dGEsIFVTdHJpbmc6OlJlcCogcikKIHsKICAgICBBU1NFUlQoIXItPmlkZW50aWZpZXJUYWJsZSgp KTsKLQotICAgIGlmIChyLT5sZW4gPT0gMCkgeworICAgIGlmIChyLT5sZW4gPT0gMSkgeworICAg ICAgICBVQ2hhciBjID0gci0+ZGF0YSgpWzBdOworICAgICAgICBpZiAoYyA8PSAweEZGKQorICAg ICAgICAgICAgciA9IGdsb2JhbERhdGEtPnNtYWxsU3RyaW5ncy5zaW5nbGVDaGFyYWN0ZXJTdHJp bmdSZXAoYyk7CisgICAgICAgICAgICBpZiAoci0+aWRlbnRpZmllclRhYmxlKCkpIHsKKyAgICAg ICAgICAgICAgICBjaGVja1NhbWVJZGVudGlmaWVyVGFibGUoZ2xvYmFsRGF0YSwgcik7CisgICAg ICAgICAgICAgICAgcmV0dXJuIHI7CisgICAgICAgICAgICB9CisgICAgfQorICAgIGlmICghci0+ bGVuKSB7CiAgICAgICAgIFVTdHJpbmc6OlJlcDo6ZW1wdHkuaGFzaCgpOwogICAgICAgICByZXR1 cm4gJlVTdHJpbmc6OlJlcDo6ZW1wdHk7CiAgICAgfQotCiAgICAgcmV0dXJuICpnbG9iYWxEYXRh LT5pZGVudGlmaWVyVGFibGUtPmFkZChyKS5maXJzdDsKIH0KIApAQCAtMjIzLDYgKzIzNSw3IEBA IHZvaWQgSWRlbnRpZmllcjo6cmVtb3ZlKFVTdHJpbmc6OlJlcCogcikKIH0KIAogI2lmbmRlZiBO REVCVUcKKwogdm9pZCBJZGVudGlmaWVyOjpjaGVja1NhbWVJZGVudGlmaWVyVGFibGUoRXhlY1N0 YXRlKiBleGVjLCBVU3RyaW5nOjpSZXAqIHJlcCkKIHsKICAgICBBU1NFUlQocmVwLT5pZGVudGlm aWVyVGFibGUoKSA9PSBleGVjLT5pZGVudGlmaWVyVGFibGUoKSk7CkBAIC0yMzIsMTQgKzI0NSw3 IEBAIHZvaWQgSWRlbnRpZmllcjo6Y2hlY2tTYW1lSWRlbnRpZmllclRhYmwKIHsKICAgICBBU1NF UlQocmVwLT5pZGVudGlmaWVyVGFibGUoKSA9PSBnbG9iYWxEYXRhLT5pZGVudGlmaWVyVGFibGUp OwogfQotI2Vsc2UKLXZvaWQgSWRlbnRpZmllcjo6Y2hlY2tTYW1lSWRlbnRpZmllclRhYmxlKEV4 ZWNTdGF0ZSosIFVTdHJpbmc6OlJlcCopCi17Ci19CiAKLXZvaWQgSWRlbnRpZmllcjo6Y2hlY2tT YW1lSWRlbnRpZmllclRhYmxlKEpTR2xvYmFsRGF0YSosIFVTdHJpbmc6OlJlcCopCi17Ci19CiAj ZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgS0pTCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ranMvaWRl bnRpZmllci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2tqcy9pZGVudGlmaWVyLmgJ KHJldmlzaW9uIDM2MTEzKQorKysgSmF2YVNjcmlwdENvcmUva2pzL2lkZW50aWZpZXIuaAkod29y a2luZyBjb3B5KQpAQCAtOTIsOSArOTIsNyBAQCBuYW1lc3BhY2UgS0pTIHsKICAgICAgICAgc3Rh dGljIFBhc3NSZWZQdHI8VVN0cmluZzo6UmVwPiBhZGQoRXhlY1N0YXRlKiBleGVjLCBVU3RyaW5n OjpSZXAqIHIpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmIChyLT5pZGVudGlmaWVyVGFibGUo KSkgewotI2lmbmRlZiBOREVCVUcKICAgICAgICAgICAgICAgICBjaGVja1NhbWVJZGVudGlmaWVy VGFibGUoZXhlYywgcik7Ci0jZW5kaWYKICAgICAgICAgICAgICAgICByZXR1cm4gcjsKICAgICAg ICAgICAgIH0KICAgICAgICAgICAgIHJldHVybiBhZGRTbG93Q2FzZShleGVjLCByKTsKQEAgLTEw Miw5ICsxMDAsNyBAQCBuYW1lc3BhY2UgS0pTIHsKICAgICAgICAgc3RhdGljIFBhc3NSZWZQdHI8 VVN0cmluZzo6UmVwPiBhZGQoSlNHbG9iYWxEYXRhKiBnbG9iYWxEYXRhLCBVU3RyaW5nOjpSZXAq IHIpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlmIChyLT5pZGVudGlmaWVyVGFibGUoKSkgewot I2lmbmRlZiBOREVCVUcKICAgICAgICAgICAgICAgICBjaGVja1NhbWVJZGVudGlmaWVyVGFibGUo Z2xvYmFsRGF0YSwgcik7Ci0jZW5kaWYKICAgICAgICAgICAgICAgICByZXR1cm4gcjsKICAgICAg ICAgICAgIH0KICAgICAgICAgICAgIHJldHVybiBhZGRTbG93Q2FzZShnbG9iYWxEYXRhLCByKTsK QEAgLTEzNSw2ICsxMzEsMTEgQEAgbmFtZXNwYWNlIEtKUyB7CiAgICAgSWRlbnRpZmllclRhYmxl KiBjcmVhdGVJZGVudGlmaWVyVGFibGUoKTsKICAgICB2b2lkIGRlbGV0ZUlkZW50aWZpZXJUYWJs ZShJZGVudGlmaWVyVGFibGUqKTsKIAorI2lmZGVmIE5ERUJVRworICAgIGlubGluZSB2b2lkIElk ZW50aWZpZXI6OmNoZWNrU2FtZUlkZW50aWZpZXJUYWJsZShFeGVjU3RhdGUqLCBVU3RyaW5nOjpS ZXAqKSB7IH0KKyAgICBpbmxpbmUgdm9pZCBJZGVudGlmaWVyOjpjaGVja1NhbWVJZGVudGlmaWVy VGFibGUoSlNHbG9iYWxEYXRhKiwgVVN0cmluZzo6UmVwKikgeyB9CisjZW5kaWYKKwogfSAvLyBu YW1lc3BhY2UgS0pTCiAKICNlbmRpZiAvLyBLSlNfSURFTlRJRklFUl9ICg==