206720 2020-01-23 17:18:17 -0800 Break the dependency between jsc and DerivedSources 2020-01-27 16:30:52 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 206566 206758 206851 1 rmorisset rmorisset ap commit-queue ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1610423 0 rmorisset 2020-01-23 17:18:17 -0800 According to Tadeu, the slowdown of production builds (by more than 20%) when he landed his bytecode patch was caused by a new dependency of the jsc binary on DerivedSources/, which was needed because of DerivedSources/BytecodeStructs.h being included in CommonSlowPaths.h which is transitively included in jsc.cpp. Now that BytecodeStructs.h is no longer included in CommonSlowPaths.cpp (see https://bugs.webkit.org/show_bug.cgi?id=206566), I'd like to see if the dependency can be safely removed, to recover this compile time regression. 1610432 1 388627 rmorisset 2020-01-23 17:27:46 -0800 Created attachment 388627 Patch 1610495 2 388627 mark.lam 2020-01-23 20:03:59 -0800 Comment on attachment 388627 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388627&action=review > Source/JavaScriptCore/ChangeLog:9 > + Now that BytecodeStructs.h is no longer included in CommonSlowPaths.cpp (see https://bugs.webkit.org/show_bug.cgi?id=206566), I'm trying to break the dependency, to recover from this compile time regression. I think you mean CommonSlowPaths.h here. 1610496 3 rmorisset 2020-01-23 20:06:30 -0800 (In reply to Mark Lam from comment #2) > Comment on attachment 388627 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388627&action=review > > > Source/JavaScriptCore/ChangeLog:9 > > + Now that BytecodeStructs.h is no longer included in CommonSlowPaths.cpp (see https://bugs.webkit.org/show_bug.cgi?id=206566), I'm trying to break the dependency, to recover from this compile time regression. > > I think you mean CommonSlowPaths.h here. Yes, it was a typo 1610497 4 388646 rmorisset 2020-01-23 20:08:25 -0800 Created attachment 388646 Patch Fixed the typo in the changelog. 1610511 5 388646 commit-queue 2020-01-23 20:52:34 -0800 Comment on attachment 388646 Patch Clearing flags on attachment: 388646 Committed r255052: <https://trac.webkit.org/changeset/255052> 1610512 6 commit-queue 2020-01-23 20:52:36 -0800 All reviewed patches have been landed. Closing bug. 1610513 7 webkit-bug-importer 2020-01-23 20:53:13 -0800 <rdar://problem/58858767> 1610733 8 commit-queue 2020-01-24 09:55:10 -0800 Re-opened since this is blocked by bug 206758 388627 2020-01-23 17:27:46 -0800 2020-01-23 20:08:25 -0800 Patch patch206720 text/plain 3460 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGIwNTc3ZmFhODk5Li41ZGIxMGY0ZjBmOSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMjMgIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBCcmVhayB0aGUgZGVw ZW5kZW5jeSBiZXR3ZWVuIGpzYyBhbmQgRGVyaXZlZFNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjcyMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byBUYWRldSwgdGhlIHNs b3dkb3duIG9mIHByb2R1Y3Rpb24gYnVpbGRzIChieSBtb3JlIHRoYW4gMjAlKSB3aGVuIGhlIGxh bmRlZCBoaXMgYnl0ZWNvZGUgcGF0Y2ggd2FzIGNhdXNlZCBieSBhIG5ldyBkZXBlbmRlbmN5IG9m IHRoZSBqc2MgYmluYXJ5IG9uIERlcml2ZWRTb3VyY2VzLywgd2hpY2ggd2FzIG5lZWRlZCBiZWNh dXNlIG9mIERlcml2ZWRTb3VyY2VzL0J5dGVjb2RlU3RydWN0cy5oIGJlaW5nIGluY2x1ZGVkIGlu IENvbW1vblNsb3dQYXRocy5oIHdoaWNoIGlzIHRyYW5zaXRpdmVseSBpbmNsdWRlZCBpbiBqc2Mu Y3BwLgorICAgICAgICBOb3cgdGhhdCBCeXRlY29kZVN0cnVjdHMuaCBpcyBubyBsb25nZXIgaW5j bHVkZWQgaW4gQ29tbW9uU2xvd1BhdGhzLmNwcCAoc2VlIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDY1NjYpLCBJJ20gdHJ5aW5nIHRvIGJyZWFrIHRoZSBkZXBlbmRl bmN5LCB0byByZWNvdmVyIGZyb20gdGhpcyBjb21waWxlIHRpbWUgcmVncmVzc2lvbi4KKworICAg ICAgICAqIENvbmZpZ3VyYXRpb25zL0pTQy54Y2NvbmZpZzoKKyAgICAgICAgKiBKYXZhU2NyaXB0 Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorCiAyMDIwLTAxLTIzICBSb2JpbiBNb3Jp c3NldCAgPHJtb3Jpc3NldEBhcHBsZS5jb20+CiAKICAgICAgICAgRG9uJ3QgaW5jbHVkZSBCeXRl Y29kZVN0cnVjdHMuaCBpbiBDb21tb25TbG93UGF0aHMuaApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0pTQy54Y2NvbmZpZyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9Db25maWd1cmF0aW9ucy9KU0MueGNjb25maWcKaW5kZXggNDk0MGZmYzdjZTIuLjk0 OGU1OTRhNDc3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlv bnMvSlNDLnhjY29uZmlnCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9Db25maWd1cmF0aW9u cy9KU0MueGNjb25maWcKQEAgLTM3LDQgKzM3LDMgQEAgT1RIRVJfQ09ERV9TSUdOX0ZMQUdTW3Nk az1pcGhvbmUqXSA9IC1pIGNvbS5hcHBsZS5qc2M7CiAKIC8vIEV4cGxpY2l0bHkgYWRkIHRoZSBQ cml2YXRlSGVhZGVycyBkaXJlY3RvcnkgdG8gdGhlIHNlYXJjaCBwYXRoIHNvIHRoYXQgZ2VuZXJh dGVkIGhlYWRlciBmaWxlcyBjYW4gYmUgZm91bmQgaW4gcHJvZHVjdGlvbiBidWlsZHMuCiBIRUFE RVJfU0VBUkNIX1BBVEhTID0gIiQoSkFWQVNDUklQVENPUkVfRlJBTUVXT1JLU19ESVIpL0phdmFT Y3JpcHRDb3JlLmZyYW1ld29yay9Qcml2YXRlSGVhZGVycyIgJChpbmhlcml0ZWQpOwotSEVBREVS X1NFQVJDSF9QQVRIUyA9ICIke0JVSUxUX1BST0RVQ1RTX0RJUn0vRGVyaXZlZFNvdXJjZXMvSmF2 YVNjcmlwdENvcmUiICQoSEVBREVSX1NFQVJDSF9QQVRIUyk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvaiBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5w Ynhwcm9qCmluZGV4IGI0YTUxNGM1N2Q3Li4wZDc2YzI2MTZjMSAxMDA2NDQKLS0tIGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oK KysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9q ZWN0LnBieHByb2oKQEAgLTIwODcsMTMgKzIwODcsNiBAQAogCQkJcmVtb3RlR2xvYmFsSURTdHJp bmcgPSBFMUFDMkUyNzIwRjdCOTRDMDBCMDg5N0Q7CiAJCQlyZW1vdGVJbmZvID0gIlVubG9jayBL ZXljaGFpbiI7CiAJCX07Ci0JCTE0RDlEOUQ5MjE4NDYyQjUwMDkxMjZDMiAvKiBQQlhDb250YWlu ZXJJdGVtUHJveHkgKi8gPSB7Ci0JCQlpc2EgPSBQQlhDb250YWluZXJJdGVtUHJveHk7Ci0JCQlj b250YWluZXJQb3J0YWwgPSAwODY3RDY5MEZFODQwMjhGQzAyQUFDMDcgLyogUHJvamVjdCBvYmpl Y3QgKi87Ci0JCQlwcm94eVR5cGUgPSAxOwotCQkJcmVtb3RlR2xvYmFsSURTdHJpbmcgPSA2NUZC M0Y2NjA5RDExRTkxMDBGNDlERUI7Ci0JCQlyZW1vdGVJbmZvID0gIkRlcml2ZWQgU291cmNlcyI7 Ci0JCX07CiAJCTUyQ0QwRjY1MjI0MkY1QTMwMDRBMThBNSAvKiBQQlhDb250YWluZXJJdGVtUHJv eHkgKi8gPSB7CiAJCQlpc2EgPSBQQlhDb250YWluZXJJdGVtUHJveHk7CiAJCQljb250YWluZXJQ b3J0YWwgPSAwODY3RDY5MEZFODQwMjhGQzAyQUFDMDcgLyogUHJvamVjdCBvYmplY3QgKi87CkBA IC0xMDYyMyw3ICsxMDYxNiw2IEBACiAJCQlidWlsZFJ1bGVzID0gKAogCQkJKTsKIAkJCWRlcGVu ZGVuY2llcyA9ICgKLQkJCQkxNEQ5RDlEQTIxODQ2MkI1MDA5MTI2QzIgLyogUEJYVGFyZ2V0RGVw ZW5kZW5jeSAqLywKIAkJCSk7CiAJCQluYW1lID0ganNjOwogCQkJcHJvZHVjdEluc3RhbGxQYXRo ID0gL3Vzci9sb2NhbC9iaW47CkBAIC0xMTQzMywxMSArMTE0MjUsNiBAQAogCQkJdGFyZ2V0ID0g RTFBQzJFMjcyMEY3Qjk0QzAwQjA4OTdEIC8qIFVubG9jayBLZXljaGFpbiAqLzsKIAkJCXRhcmdl dFByb3h5ID0gMTRDRkIxMTgyMzAzNUY2OTAwRjAwNDhDIC8qIFBCWENvbnRhaW5lckl0ZW1Qcm94 eSAqLzsKIAkJfTsKLQkJMTREOUQ5REEyMTg0NjJCNTAwOTEyNkMyIC8qIFBCWFRhcmdldERlcGVu ZGVuY3kgKi8gPSB7Ci0JCQlpc2EgPSBQQlhUYXJnZXREZXBlbmRlbmN5OwotCQkJdGFyZ2V0ID0g NjVGQjNGNjYwOUQxMUU5MTAwRjQ5REVCIC8qIERlcml2ZWQgU291cmNlcyAqLzsKLQkJCXRhcmdl dFByb3h5ID0gMTREOUQ5RDkyMTg0NjJCNTAwOTEyNkMyIC8qIFBCWENvbnRhaW5lckl0ZW1Qcm94 eSAqLzsKLQkJfTsKIAkJNTJDRDBGNjYyMjQyRjVBMzAwNEExOEE1IC8qIFBCWFRhcmdldERlcGVu ZGVuY3kgKi8gPSB7CiAJCQlpc2EgPSBQQlhUYXJnZXREZXBlbmRlbmN5OwogCQkJdGFyZ2V0ID0g NTJDRDBGNTkyMjQyRjU2OTAwNEExOEE1IC8qIHRlc3RkZmcgKi87Cg== 388646 2020-01-23 20:08:25 -0800 2020-01-23 20:52:34 -0800 Patch patch206720 text/plain 3452 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGIwNTc3ZmFhODk5Li41ZGIxMGY0ZjBmOSAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMjMgIFJvYmlu IE1vcmlzc2V0ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KKworICAgICAgICBCcmVhayB0aGUgZGVw ZW5kZW5jeSBiZXR3ZWVuIGpzYyBhbmQgRGVyaXZlZFNvdXJjZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjcyMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE1hcmsgTGFtLgorCisgICAgICAgIEFjY29yZGluZyB0byBUYWRldSwgdGhlIHNsb3dkb3du IG9mIHByb2R1Y3Rpb24gYnVpbGRzIChieSBtb3JlIHRoYW4gMjAlKSB3aGVuIGhlIGxhbmRlZCBo aXMgYnl0ZWNvZGUgcGF0Y2ggd2FzIGNhdXNlZCBieSBhIG5ldyBkZXBlbmRlbmN5IG9mIHRoZSBq c2MgYmluYXJ5IG9uIERlcml2ZWRTb3VyY2VzLywgd2hpY2ggd2FzIG5lZWRlZCBiZWNhdXNlIG9m IERlcml2ZWRTb3VyY2VzL0J5dGVjb2RlU3RydWN0cy5oIGJlaW5nIGluY2x1ZGVkIGluIENvbW1v blNsb3dQYXRocy5oIHdoaWNoIGlzIHRyYW5zaXRpdmVseSBpbmNsdWRlZCBpbiBqc2MuY3BwLgor ICAgICAgICBOb3cgdGhhdCBCeXRlY29kZVN0cnVjdHMuaCBpcyBubyBsb25nZXIgaW5jbHVkZWQg aW4gQ29tbW9uU2xvd1BhdGhzLmggKHNlZSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA2NTY2KSwgSSdtIHRyeWluZyB0byBicmVhayB0aGUgZGVwZW5kZW5jeSwgdG8g cmVjb3ZlciBmcm9tIHRoaXMgY29tcGlsZSB0aW1lIHJlZ3Jlc3Npb24uCisKKyAgICAgICAgKiBD b25maWd1cmF0aW9ucy9KU0MueGNjb25maWc6CisgICAgICAgICogSmF2YVNjcmlwdENvcmUueGNv ZGVwcm9qL3Byb2plY3QucGJ4cHJvajoKKwogMjAyMC0wMS0yMyAgUm9iaW4gTW9yaXNzZXQgIDxy bW9yaXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIERvbid0IGluY2x1ZGUgQnl0ZWNvZGVTdHJ1 Y3RzLmggaW4gQ29tbW9uU2xvd1BhdGhzLmgKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9Db25maWd1cmF0aW9ucy9KU0MueGNjb25maWcgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv Q29uZmlndXJhdGlvbnMvSlNDLnhjY29uZmlnCmluZGV4IDQ5NDBmZmM3Y2UyLi45NDhlNTk0YTQ3 NyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NvbmZpZ3VyYXRpb25zL0pTQy54 Y2NvbmZpZworKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ29uZmlndXJhdGlvbnMvSlNDLnhj Y29uZmlnCkBAIC0zNyw0ICszNywzIEBAIE9USEVSX0NPREVfU0lHTl9GTEFHU1tzZGs9aXBob25l Kl0gPSAtaSBjb20uYXBwbGUuanNjOwogCiAvLyBFeHBsaWNpdGx5IGFkZCB0aGUgUHJpdmF0ZUhl YWRlcnMgZGlyZWN0b3J5IHRvIHRoZSBzZWFyY2ggcGF0aCBzbyB0aGF0IGdlbmVyYXRlZCBoZWFk ZXIgZmlsZXMgY2FuIGJlIGZvdW5kIGluIHByb2R1Y3Rpb24gYnVpbGRzLgogSEVBREVSX1NFQVJD SF9QQVRIUyA9ICIkKEpBVkFTQ1JJUFRDT1JFX0ZSQU1FV09SS1NfRElSKS9KYXZhU2NyaXB0Q29y ZS5mcmFtZXdvcmsvUHJpdmF0ZUhlYWRlcnMiICQoaW5oZXJpdGVkKTsKLUhFQURFUl9TRUFSQ0hf UEFUSFMgPSAiJHtCVUlMVF9QUk9EVUNUU19ESVJ9L0Rlcml2ZWRTb3VyY2VzL0phdmFTY3JpcHRD b3JlIiAkKEhFQURFUl9TRUFSQ0hfUEFUSFMpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL0phdmFTY3JpcHRDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpp bmRleCBiNGE1MTRjNTdkNy4uMGQ3NmMyNjE2YzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhw cm9qCkBAIC0yMDg3LDEzICsyMDg3LDYgQEAKIAkJCXJlbW90ZUdsb2JhbElEU3RyaW5nID0gRTFB QzJFMjcyMEY3Qjk0QzAwQjA4OTdEOwogCQkJcmVtb3RlSW5mbyA9ICJVbmxvY2sgS2V5Y2hhaW4i OwogCQl9OwotCQkxNEQ5RDlEOTIxODQ2MkI1MDA5MTI2QzIgLyogUEJYQ29udGFpbmVySXRlbVBy b3h5ICovID0gewotCQkJaXNhID0gUEJYQ29udGFpbmVySXRlbVByb3h5OwotCQkJY29udGFpbmVy UG9ydGFsID0gMDg2N0Q2OTBGRTg0MDI4RkMwMkFBQzA3IC8qIFByb2plY3Qgb2JqZWN0ICovOwot CQkJcHJveHlUeXBlID0gMTsKLQkJCXJlbW90ZUdsb2JhbElEU3RyaW5nID0gNjVGQjNGNjYwOUQx MUU5MTAwRjQ5REVCOwotCQkJcmVtb3RlSW5mbyA9ICJEZXJpdmVkIFNvdXJjZXMiOwotCQl9Owog CQk1MkNEMEY2NTIyNDJGNUEzMDA0QTE4QTUgLyogUEJYQ29udGFpbmVySXRlbVByb3h5ICovID0g ewogCQkJaXNhID0gUEJYQ29udGFpbmVySXRlbVByb3h5OwogCQkJY29udGFpbmVyUG9ydGFsID0g MDg2N0Q2OTBGRTg0MDI4RkMwMkFBQzA3IC8qIFByb2plY3Qgb2JqZWN0ICovOwpAQCAtMTA2MjMs NyArMTA2MTYsNiBAQAogCQkJYnVpbGRSdWxlcyA9ICgKIAkJCSk7CiAJCQlkZXBlbmRlbmNpZXMg PSAoCi0JCQkJMTREOUQ5REEyMTg0NjJCNTAwOTEyNkMyIC8qIFBCWFRhcmdldERlcGVuZGVuY3kg Ki8sCiAJCQkpOwogCQkJbmFtZSA9IGpzYzsKIAkJCXByb2R1Y3RJbnN0YWxsUGF0aCA9IC91c3Iv bG9jYWwvYmluOwpAQCAtMTE0MzMsMTEgKzExNDI1LDYgQEAKIAkJCXRhcmdldCA9IEUxQUMyRTI3 MjBGN0I5NEMwMEIwODk3RCAvKiBVbmxvY2sgS2V5Y2hhaW4gKi87CiAJCQl0YXJnZXRQcm94eSA9 IDE0Q0ZCMTE4MjMwMzVGNjkwMEYwMDQ4QyAvKiBQQlhDb250YWluZXJJdGVtUHJveHkgKi87CiAJ CX07Ci0JCTE0RDlEOURBMjE4NDYyQjUwMDkxMjZDMiAvKiBQQlhUYXJnZXREZXBlbmRlbmN5ICov ID0gewotCQkJaXNhID0gUEJYVGFyZ2V0RGVwZW5kZW5jeTsKLQkJCXRhcmdldCA9IDY1RkIzRjY2 MDlEMTFFOTEwMEY0OURFQiAvKiBEZXJpdmVkIFNvdXJjZXMgKi87Ci0JCQl0YXJnZXRQcm94eSA9 IDE0RDlEOUQ5MjE4NDYyQjUwMDkxMjZDMiAvKiBQQlhDb250YWluZXJJdGVtUHJveHkgKi87Ci0J CX07CiAJCTUyQ0QwRjY2MjI0MkY1QTMwMDRBMThBNSAvKiBQQlhUYXJnZXREZXBlbmRlbmN5ICov ID0gewogCQkJaXNhID0gUEJYVGFyZ2V0RGVwZW5kZW5jeTsKIAkJCXRhcmdldCA9IDUyQ0QwRjU5 MjI0MkY1NjkwMDRBMThBNSAvKiB0ZXN0ZGZnICovOwo=