206707 2020-01-23 15:42:06 -0800 run-webkit-tests: Handle case where device socket make handle invalid 2020-01-24 09:19:48 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain commit-queue ews-watchlist glenn slewis webkit-bug-importer oldest_to_newest 1610364 0 jbedard 2020-01-23 15:42:06 -0800 If the socket connecting to a device closes before the file handle does, run-webkit-tests may raise an exception. We should gracefully handle this exception. Note that this is Python 3 fallout. 1610388 1 388608 jbedard 2020-01-23 16:06:56 -0800 Created attachment 388608 Patch 1610409 2 388608 aakash_jain 2020-01-23 16:43:26 -0800 Comment on attachment 388608 Patch rs=me 1610411 3 388617 jbedard 2020-01-23 16:49:08 -0800 Created attachment 388617 Patch 1610676 4 388617 commit-queue 2020-01-24 07:59:22 -0800 Comment on attachment 388617 Patch Rejecting attachment 388617 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 388617, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Traceback (most recent call last): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 80, in <module> main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: https://webkit-queues.webkit.org/results/13311033 1610684 5 388695 jbedard 2020-01-24 08:13:42 -0800 Created attachment 388695 Patch for landing 1610712 6 388695 commit-queue 2020-01-24 09:18:34 -0800 Comment on attachment 388695 Patch for landing Clearing flags on attachment: 388695 Committed r255075: <https://trac.webkit.org/changeset/255075> 1610713 7 commit-queue 2020-01-24 09:18:36 -0800 All reviewed patches have been landed. Closing bug. 1610715 8 webkit-bug-importer 2020-01-24 09:19:48 -0800 <rdar://problem/58869757> 388608 2020-01-23 16:06:56 -0800 2020-01-23 16:49:05 -0800 Patch bug-206707-20200123160655.patch text/plain 1952 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTA0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTIzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzOiBIYW5kbGUgY2FzZSB3aGVyZSBkZXZpY2Ug c29ja2V0IG1ha2UgaGFuZGxlIGludmFsaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwNjcwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3NpbXVsYXRvcl9wcm9j ZXNzLnB5OgorICAgICAgICAoU2ltdWxhdG9yUHJvY2Vzcy5Ob25CbG9ja2luZ0ZpbGVGcm9tU29j a2V0LmNsb3NlKTogQ2F0Y2ggSU9FcnJvciB3aGVuIGNsb3NpbmcgZmlsZS4KKwogMjAyMC0wMS0y MiAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5AYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdFRl c3RSdW5uZXI6IHVzZSBhZCBob2Mgc2lnbmluZyBmb3IgaW50ZXJuYWwgUHJvZHVjdGlvbiBidWls ZHMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJvY2Vzcy5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3By b2Nlc3MucHkJKHJldmlzaW9uIDI1NDk5OSkKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9zaW11bGF0b3JfcHJvY2Vzcy5weQkod29ya2luZyBjb3B5KQpAQCAtNjcsMTEgKzY3LDE1IEBA IGNsYXNzIFNpbXVsYXRvclByb2Nlc3MoU2VydmVyUHJvY2Vzcyk6CiAgICAgICAgICAgICByZXR1 cm4gZ2V0YXR0cihzZWxmLl9maWxlLCBuYW1lKQogCiAgICAgICAgIGRlZiBjbG9zZShzZWxmKToK LSAgICAgICAgICAgIHJlc3VsdCA9IHNlbGYuX2ZpbGUuY2xvc2UoKQotICAgICAgICAgICAgIyBD bG9zaW5nIHRoZSBmaWxlIGltcGxpY2l0bHkgY2xvc2VzIHRoZSBzb2NrZXQgaW4gUHl0aG9uIDMK LSAgICAgICAgICAgIGlmIHN5cy52ZXJzaW9uX2luZm8gPCAoMywgMCk6Ci0gICAgICAgICAgICAg ICAgc2VsZi5zb2NrZXQuY2xvc2UoKQotICAgICAgICAgICAgcmV0dXJuIHJlc3VsdAorICAgICAg ICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIHJlc3VsdCA9IHNlbGYuX2ZpbGUuY2xvc2UoKQor ICAgICAgICAgICAgICAgICMgQ2xvc2luZyB0aGUgZmlsZSBpbXBsaWNpdGx5IGNsb3NlcyB0aGUg c29ja2V0IGluIFB5dGhvbiAzCisgICAgICAgICAgICAgICAgaWYgc3lzLnZlcnNpb25faW5mbyA8 ICgzLCAwKToKKyAgICAgICAgICAgICAgICAgICAgc2VsZi5zb2NrZXQuY2xvc2UoKQorICAgICAg ICAgICAgICAgIHJldHVybiByZXN1bHQKKyAgICAgICAgICAgIGV4Y2VwdCBJT0Vycm9yOgorICAg ICAgICAgICAgICAgICMgSWYgdGhlIGZpbGUgZGVzY3JpcHRvciBpcyBiYWQsIHdlIGRvbid0IGhh dmUgdG8gd29ycnkgYWJvdXQgY2xvc2luZyBpdAorICAgICAgICAgICAgICAgIHBhc3MKIAogICAg IGRlZiBfX2luaXRfXyhzZWxmLCBwb3J0X29iaiwgbmFtZSwgY21kLCBlbnY9Tm9uZSwgdW5pdmVy c2FsX25ld2xpbmVzPUZhbHNlLCB0cmVhdF9ub19kYXRhX2FzX2NyYXNoPUZhbHNlLCB0YXJnZXRf aG9zdD1Ob25lLCBjcmFzaF9tZXNzYWdlPU5vbmUpOgogICAgICAgICBlbnZbJ1BPUlQnXSA9IHN0 cih0YXJnZXRfaG9zdC5saXN0ZW5pbmdfcG9ydCgpKSAgIyBUaGUgdGFyZ2V0X2hvc3Qgc2hvdWxk IGJlIGEgZGV2aWNlLgo= 388617 2020-01-23 16:49:08 -0800 2020-01-24 08:13:39 -0800 Patch bug-206707-20200123164907.patch text/plain 1954 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTA0MSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACiswMjAtMDEtMjMgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29t PgorCisgICAgICAgIHJ1bi13ZWJraXQtdGVzdHM6IEhhbmRsZSBjYXNlIHdoZXJlIGRldmljZSBz b2NrZXQgbWFrZSBoYW5kbGUgaW52YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NzA3CisKKyAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkgQWFr YXNoIEphaW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3By b2Nlc3MucHk6CisgICAgICAgIChTaW11bGF0b3JQcm9jZXNzLk5vbkJsb2NraW5nRmlsZUZyb21T b2NrZXQuY2xvc2UpOiBDYXRjaCBJT0Vycm9yIHdoZW4gY2xvc2luZyBmaWxlLgorCiAyMDIwLTAx LTIyICBKaWV3ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0 VGVzdFJ1bm5lcjogdXNlIGFkIGhvYyBzaWduaW5nIGZvciBpbnRlcm5hbCBQcm9kdWN0aW9uIGJ1 aWxkcwpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NpbXVsYXRvcl9wcm9jZXNz LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3Jf cHJvY2Vzcy5weQkocmV2aXNpb24gMjU0OTk5KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9w b3J0L3NpbXVsYXRvcl9wcm9jZXNzLnB5CSh3b3JraW5nIGNvcHkpCkBAIC02NywxMSArNjcsMTUg QEAgY2xhc3MgU2ltdWxhdG9yUHJvY2VzcyhTZXJ2ZXJQcm9jZXNzKToKICAgICAgICAgICAgIHJl dHVybiBnZXRhdHRyKHNlbGYuX2ZpbGUsIG5hbWUpCiAKICAgICAgICAgZGVmIGNsb3NlKHNlbGYp OgotICAgICAgICAgICAgcmVzdWx0ID0gc2VsZi5fZmlsZS5jbG9zZSgpCi0gICAgICAgICAgICAj IENsb3NpbmcgdGhlIGZpbGUgaW1wbGljaXRseSBjbG9zZXMgdGhlIHNvY2tldCBpbiBQeXRob24g MwotICAgICAgICAgICAgaWYgc3lzLnZlcnNpb25faW5mbyA8ICgzLCAwKToKLSAgICAgICAgICAg ICAgICBzZWxmLnNvY2tldC5jbG9zZSgpCi0gICAgICAgICAgICByZXR1cm4gcmVzdWx0CisgICAg ICAgICAgICB0cnk6CisgICAgICAgICAgICAgICAgcmVzdWx0ID0gc2VsZi5fZmlsZS5jbG9zZSgp CisgICAgICAgICAgICAgICAgIyBDbG9zaW5nIHRoZSBmaWxlIGltcGxpY2l0bHkgY2xvc2VzIHRo ZSBzb2NrZXQgaW4gUHl0aG9uIDMKKyAgICAgICAgICAgICAgICBpZiBzeXMudmVyc2lvbl9pbmZv IDwgKDMsIDApOgorICAgICAgICAgICAgICAgICAgICBzZWxmLnNvY2tldC5jbG9zZSgpCisgICAg ICAgICAgICAgICAgcmV0dXJuIHJlc3VsdAorICAgICAgICAgICAgZXhjZXB0IElPRXJyb3I6Cisg ICAgICAgICAgICAgICAgIyBJZiB0aGUgZmlsZSBkZXNjcmlwdG9yIGlzIGJhZCwgd2UgZG9uJ3Qg aGF2ZSB0byB3b3JyeSBhYm91dCBjbG9zaW5nIGl0CisgICAgICAgICAgICAgICAgcGFzcwogCiAg ICAgZGVmIF9faW5pdF9fKHNlbGYsIHBvcnRfb2JqLCBuYW1lLCBjbWQsIGVudj1Ob25lLCB1bml2 ZXJzYWxfbmV3bGluZXM9RmFsc2UsIHRyZWF0X25vX2RhdGFfYXNfY3Jhc2g9RmFsc2UsIHRhcmdl dF9ob3N0PU5vbmUsIGNyYXNoX21lc3NhZ2U9Tm9uZSk6CiAgICAgICAgIGVudlsnUE9SVCddID0g c3RyKHRhcmdldF9ob3N0Lmxpc3RlbmluZ19wb3J0KCkpICAjIFRoZSB0YXJnZXRfaG9zdCBzaG91 bGQgYmUgYSBkZXZpY2UuCg== 388695 2020-01-24 08:13:42 -0800 2020-01-24 09:18:34 -0800 Patch for landing bug-206707-20200124081341.patch text/plain 1959 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NTA3MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTIzICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBydW4td2Via2l0LXRlc3RzOiBIYW5kbGUgY2FzZSB3aGVyZSBkZXZpY2Ug c29ja2V0IG1ha2UgaGFuZGxlIGludmFsaWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIwNjcwNworCisgICAgICAgIFJldmlld2VkIGJ5IFN0ZXBoYW5p ZSBMZXdpcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9zaW11bGF0b3JfcHJv Y2Vzcy5weToKKyAgICAgICAgKFNpbXVsYXRvclByb2Nlc3MuTm9uQmxvY2tpbmdGaWxlRnJvbVNv Y2tldC5jbG9zZSk6IENhdGNoIElPRXJyb3Igd2hlbiBjbG9zaW5nIGZpbGUuCisKIDIwMjAtMDEt MjQgIENhcmxvcyBBbGJlcnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gQVBJIHRlc3QgcnVubmVyIGZhaWxzIHdpdGggZXJyb3I6IHRvbyBtYW55IG9w ZW4gZmlsZXMuCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2ltdWxhdG9yX3By b2Nlc3MucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NpbXVs YXRvcl9wcm9jZXNzLnB5CShyZXZpc2lvbiAyNTUwNzIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvc2ltdWxhdG9yX3Byb2Nlc3MucHkJKHdvcmtpbmcgY29weSkKQEAgLTY3LDExICs2 NywxNSBAQCBjbGFzcyBTaW11bGF0b3JQcm9jZXNzKFNlcnZlclByb2Nlc3MpOgogICAgICAgICAg ICAgcmV0dXJuIGdldGF0dHIoc2VsZi5fZmlsZSwgbmFtZSkKIAogICAgICAgICBkZWYgY2xvc2Uo c2VsZik6Ci0gICAgICAgICAgICByZXN1bHQgPSBzZWxmLl9maWxlLmNsb3NlKCkKLSAgICAgICAg ICAgICMgQ2xvc2luZyB0aGUgZmlsZSBpbXBsaWNpdGx5IGNsb3NlcyB0aGUgc29ja2V0IGluIFB5 dGhvbiAzCi0gICAgICAgICAgICBpZiBzeXMudmVyc2lvbl9pbmZvIDwgKDMsIDApOgotICAgICAg ICAgICAgICAgIHNlbGYuc29ja2V0LmNsb3NlKCkKLSAgICAgICAgICAgIHJldHVybiByZXN1bHQK KyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICByZXN1bHQgPSBzZWxmLl9maWxlLmNs b3NlKCkKKyAgICAgICAgICAgICAgICAjIENsb3NpbmcgdGhlIGZpbGUgaW1wbGljaXRseSBjbG9z ZXMgdGhlIHNvY2tldCBpbiBQeXRob24gMworICAgICAgICAgICAgICAgIGlmIHN5cy52ZXJzaW9u X2luZm8gPCAoMywgMCk6CisgICAgICAgICAgICAgICAgICAgIHNlbGYuc29ja2V0LmNsb3NlKCkK KyAgICAgICAgICAgICAgICByZXR1cm4gcmVzdWx0CisgICAgICAgICAgICBleGNlcHQgSU9FcnJv cjoKKyAgICAgICAgICAgICAgICAjIElmIHRoZSBmaWxlIGRlc2NyaXB0b3IgaXMgYmFkLCB3ZSBk b24ndCBoYXZlIHRvIHdvcnJ5IGFib3V0IGNsb3NpbmcgaXQKKyAgICAgICAgICAgICAgICBwYXNz CiAKICAgICBkZWYgX19pbml0X18oc2VsZiwgcG9ydF9vYmosIG5hbWUsIGNtZCwgZW52PU5vbmUs IHVuaXZlcnNhbF9uZXdsaW5lcz1GYWxzZSwgdHJlYXRfbm9fZGF0YV9hc19jcmFzaD1GYWxzZSwg dGFyZ2V0X2hvc3Q9Tm9uZSwgY3Jhc2hfbWVzc2FnZT1Ob25lKToKICAgICAgICAgZW52WydQT1JU J10gPSBzdHIodGFyZ2V0X2hvc3QubGlzdGVuaW5nX3BvcnQoKSkgICMgVGhlIHRhcmdldF9ob3N0 IHNob3VsZCBiZSBhIGRldmljZS4K