20669 2008-09-05 10:52:32 -0700 WebCore/css/makeprop.pl silently fails if gperf fails 2008-10-01 18:47:55 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 evan webkit-unassigned oldest_to_newest 90284 0 evan 2008-09-05 10:52:32 -0700 If gperf fails (for example, it's not installed), makeprop.pl goes on its merry way, leading to a confusing compiler error elsewhere. 90285 1 23196 evan 2008-09-05 10:55:54 -0700 Created attachment 23196 trivial patch I am embarrassed for this patch, since it is not even against your tree. If I get a chance I will upload a better one. 90324 2 eric 2008-09-05 15:43:15 -0700 I expect it should still apply though. We need to get you a copy of the real webkit. :) 90325 3 eric 2008-09-05 15:48:50 -0700 Needs a ChangeLog too. 93639 4 24002 evan 2008-10-01 18:41:08 -0700 Created attachment 24002 Die if gperf fails. WebCore/ChangeLog | 7 +++++++ WebCore/css/makeprop.pl | 2 +- 2 files changed, 8 insertions(+), 1 deletions(-) 93642 5 24002 eric 2008-10-01 18:47:16 -0700 Comment on attachment 24002 Die if gperf fails. Looks fine. 93643 6 eric 2008-10-01 18:47:55 -0700 r37178 23196 2008-09-05 10:55:54 -0700 2008-10-01 18:41:20 -0700 trivial patch gperf.patch text/plain 713 evan ZGlmZiAtLWdpdCBhL3dlYmtpdC9wZW5kaW5nL21ha2Vwcm9wLnBsIGIvd2Via2l0L3BlbmRpbmcv bWFrZXByb3AucGwKaW5kZXggNTE5ZjY3ZC4uMDhlMjBmOSAxMDA2NDQKLS0tIGEvd2Via2l0L3Bl bmRpbmcvbWFrZXByb3AucGwKKysrIGIvd2Via2l0L3BlbmRpbmcvbWFrZXByb3AucGwKQEAgLTg5 LDcgKzg5LDcgQEAgRU9GCiAKIGNsb3NlIEhFQURFUjsKIAotc3lzdGVtKCJncGVyZiAtYSAtTCBB TlNJLUMgLUUgLUMgLWMgLW8gLXQgLS1rZXktcG9zaXRpb25zPVwiKlwiIC1OZmluZFByb3AgLUho YXNoX3Byb3AgLVd3b3JkbGlzdF9wcm9wIC1EIC1zIDIgQ1NTUHJvcGVydHlOYW1lcy5ncGVyZiA+ IENTU1Byb3BlcnR5TmFtZXMuYyIpOworc3lzdGVtKCJncGVyZiAtYSAtTCBBTlNJLUMgLUUgLUMg LWMgLW8gLXQgLS1rZXktcG9zaXRpb25zPVwiKlwiIC1OZmluZFByb3AgLUhoYXNoX3Byb3AgLVd3 b3JkbGlzdF9wcm9wIC1EIC1zIDIgQ1NTUHJvcGVydHlOYW1lcy5ncGVyZiA+IENTU1Byb3BlcnR5 TmFtZXMuYyIpID09IDAgfHwgZGllICJjYWxsaW5nIGdwZXJmIGZhaWxlZDogJD8iOwogCiBvcGVu IEMsICI+PkNTU1Byb3BlcnR5TmFtZXMuYyIgfHwgZGllICJDb3VsZCBub3Qgb3BlbiBDU1NQcm9w ZXJ0eU5hbWVzLmMgZm9yIHdyaXRpbmciOwogcHJpbnQgQyAgInN0YXRpYyBjb25zdCBjaGFyICog Y29uc3QgcHJvcGVydHlMaXN0W10gPSB7XG4iOwo= 24002 2008-10-01 18:41:08 -0700 2008-10-01 18:47:16 -0700 Die if gperf fails. Die-if-gperf-fails..patch text/plain 1131 evan MmRhMGRkMDhiZDkzZTZhZjJmMjk5YmQ4Y2EzNThiMzU2YTE1YTBmZQpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4NGY2NTQxLi4xNTkyODZh IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDEwIEBACisyMDA4LTEwLTAxICBFdmFuIE1hcnRpbiAgPGV2YW5AY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Y3NzL21ha2Vwcm9wLnBsOgorICAgICAgICBEaWUgaWYgZ3BlcmYgZmFpbHMuCisKIDIwMDgtMTAt MDEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBNYXJrIFJvd2UuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9tYWtlcHJvcC5wbCBiL1dlYkNv cmUvY3NzL21ha2Vwcm9wLnBsCmluZGV4IDVkNzRiMDUuLmJjOTc5ZjkgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvY3NzL21ha2Vwcm9wLnBsCisrKyBiL1dlYkNvcmUvY3NzL21ha2Vwcm9wLnBsCkBAIC05 Myw3ICs5Myw3IEBAIEVPRgogCiBjbG9zZSBIRUFERVI7CiAKLXN5c3RlbSgiZ3BlcmYgLWEgLUwg QU5TSS1DIC1FIC1DIC1jIC1vIC10IC0ta2V5LXBvc2l0aW9ucz1cIipcIiAtTmZpbmRQcm9wIC1I aGFzaF9wcm9wIC1Xd29yZGxpc3RfcHJvcCAtRCAtcyAyIENTU1Byb3BlcnR5TmFtZXMuZ3BlcmYg PiBDU1NQcm9wZXJ0eU5hbWVzLmNwcCIpOworc3lzdGVtKCJncGVyZiAtYSAtTCBBTlNJLUMgLUUg LUMgLWMgLW8gLXQgLS1rZXktcG9zaXRpb25zPVwiKlwiIC1OZmluZFByb3AgLUhoYXNoX3Byb3Ag LVd3b3JkbGlzdF9wcm9wIC1EIC1zIDIgQ1NTUHJvcGVydHlOYW1lcy5ncGVyZiA+IENTU1Byb3Bl cnR5TmFtZXMuY3BwIikgPT0gMCB8fCBkaWUgImNhbGxpbmcgZ3BlcmYgZmFpbGVkOiAkPyI7CiAK IG9wZW4gQywgIj4+Q1NTUHJvcGVydHlOYW1lcy5jcHAiIHx8IGRpZSAiQ291bGQgbm90IG9wZW4g Q1NTUHJvcGVydHlOYW1lcy5jcHAgZm9yIHdyaXRpbmciOwogcHJpbnQgQyAic3RhdGljIGNvbnN0 IGNoYXIgKiBjb25zdCBwcm9wZXJ0eU5hbWVTdHJpbmdzWyRudW1dID0ge1xuIjsK