206681 2020-01-23 11:00:42 -0800 REGRESSION: [iOS] http/wpt/cache-storage/quota-third-party.https.html is flaky failing. 2020-01-28 14:35:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j katherine_cheney commit-queue katherine_cheney ryanhaddad tsavell webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1610204 0 Lawrence.j 2020-01-23 11:00:42 -0800 http/wpt/cache-storage/quota-third-party.https.html Description: This test is flaky failing on iOS. History: https://results.webkit.org/?limit=5000&suite=layout-tests&test=http%2Fwpt%2Fcache-storage%2Fquota-third-party.https.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/quota-third-party.https-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/wpt/cache-storage/quota-third-party.https-actual.txt @@ -1,8 +1,8 @@ -CONSOLE MESSAGE: Cache API operation failed: Quota exceeded -CONSOLE MESSAGE: Cache API operation failed: Quota exceeded +CONSOLE MESSAGE: Cache API operation failed: Failed writing data to the file system +CONSOLE MESSAGE: Cache API operation failed: Internal error PASS same origin iframe has regular quota -PASS cross origin iframe has reduced quota +FAIL cross origin iframe has reduced quota assert_equals: expected "FAIL" but got "UNEXPECTED" PASS cross origin iframe has reduced quota after resetting quota 1610229 1 webkit-bug-importer 2020-01-23 11:38:16 -0800 <rdar://problem/58842429> 1610295 2 ryanhaddad 2020-01-23 13:33:33 -0800 This appears to be a recent regression, starting on or around r254397. 1611653 3 388925 Lawrence.j 2020-01-27 15:18:55 -0800 Created attachment 388925 Update Test Expectations 1611654 4 388925 tsavell 2020-01-27 15:20:54 -0800 Comment on attachment 388925 Update Test Expectations Clearing flags on attachment: 388925 Committed r255185: <https://trac.webkit.org/changeset/255185> 1611926 5 katherine_cheney 2020-01-28 08:13:12 -0800 *** Bug 206857 has been marked as a duplicate of this bug. *** 1611966 6 389012 katherine_cheney 2020-01-28 09:02:32 -0800 Created attachment 389012 Patch 1611992 7 389012 youennf 2020-01-28 09:30:01 -0800 Comment on attachment 389012 Patch r=me but I think we should consider turning off the behavior that removes "websitedata store" for iframes. View in context: https://bugs.webkit.org/attachment.cgi?id=389012&action=review > LayoutTests/ChangeLog:9 > + the origin's cache was deleted before the test finished. I wonder whether we should turn off this behavior by default for tests and enable it for specific tests that actually require that behavior. My fear is that other tests might end up have similar issues and we will have difficulties understanding why, or fixing them if WPT. > LayoutTests/http/wpt/cache-storage/quota-third-party.https.html:13 > + testRunner.setStatisticsHasHadUserInteraction("https://127.0.0.1:9443", true, start()); Should it be start instead of start()? Or can we not pass any function at all and not have any start function? 1612022 8 katherine_cheney 2020-01-28 10:04:45 -0800 (In reply to youenn fablet from comment #7) > Comment on attachment 389012 [details] > Patch > > r=me but I think we should consider turning off the behavior that removes > "websitedata store" for iframes. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389012&action=review > > > LayoutTests/ChangeLog:9 > > + the origin's cache was deleted before the test finished. > > I wonder whether we should turn off this behavior by default for tests and > enable it for specific tests that actually require that behavior. > My fear is that other tests might end up have similar issues and we will > have difficulties understanding why, or fixing them if WPT. > I agree. Processing ITP domains at random times has caused flaky tests in the past, so I'm wondering if there is an even more general solution that might fix more flakiness than just caches. I'll look into it! > > LayoutTests/http/wpt/cache-storage/quota-third-party.https.html:13 > > + testRunner.setStatisticsHasHadUserInteraction("https://127.0.0.1:9443", true, start()); > > Should it be start instead of start()? > Or can we not pass any function at all and not have any start function? You're right, the start function is not needed. Patch for landing will remove it. 1612024 9 389024 katherine_cheney 2020-01-28 10:08:20 -0800 Created attachment 389024 Patch for landing 1612033 10 katherine_cheney 2020-01-28 10:17:58 -0800 (In reply to katherine_cheney from comment #8) > (In reply to youenn fablet from comment #7) > > Comment on attachment 389012 [details] > > Patch > > > > r=me but I think we should consider turning off the behavior that removes > > "websitedata store" for iframes. > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=389012&action=review > > > > > LayoutTests/ChangeLog:9 > > > + the origin's cache was deleted before the test finished. > > > > I wonder whether we should turn off this behavior by default for tests and > > enable it for specific tests that actually require that behavior. > > My fear is that other tests might end up have similar issues and we will > > have difficulties understanding why, or fixing them if WPT. > > > > I agree. Processing ITP domains at random times has caused flaky tests in > the past, so I'm wondering if there is an even more general solution that > might fix more flakiness than just caches. I'll look into it! > On the other hand, though, if we are trying to test actual behavior and persistence of website data (i.e. caches, cookies, etc), maybe it could lead to ineffective testing to keep ITP's handling of these off by default in tests, because it won't mimic real situations. ITP's behavior probably shouldn't just be on for ITP tests, because it affects so many other areas of WebKit. > > > LayoutTests/http/wpt/cache-storage/quota-third-party.https.html:13 > > > + testRunner.setStatisticsHasHadUserInteraction("https://127.0.0.1:9443", true, start()); > > > > Should it be start instead of start()? > > Or can we not pass any function at all and not have any start function? > > You're right, the start function is not needed. Patch for landing will > remove it. 1612068 11 commit-queue 2020-01-28 11:06:01 -0800 The commit-queue encountered the following flaky tests while processing attachment 389024: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1612069 12 389024 commit-queue 2020-01-28 11:06:40 -0800 Comment on attachment 389024 Patch for landing Clearing flags on attachment: 389024 Committed r255263: <https://trac.webkit.org/changeset/255263> 1612070 13 commit-queue 2020-01-28 11:06:42 -0800 All reviewed patches have been landed. Closing bug. 1612081 14 youennf 2020-01-28 11:24:36 -0800 > > I agree. Processing ITP domains at random times has caused flaky tests in > > the past, so I'm wondering if there is an even more general solution that > > might fix more flakiness than just caches. I'll look into it! Did these issues show up some bugs in implementation or in tests mainly? > On the other hand, though, if we are trying to test actual behavior and > persistence of website data (i.e. caches, cookies, etc), maybe it could lead > to ineffective testing to keep ITP's handling of these off by default in > tests, because it won't mimic real situations. ITP's behavior probably > shouldn't just be on for ITP tests, because it affects so many other areas > of WebKit. Layout tests are almost run without any history. For instance, WebsiteDataStore data is removed before each test. This is very far from a typical situation where ITP would kick in and do useful processing. I might be wrong but I do not think we get a lot of value there from ITP testing functionality. Maybe we get some threading issues from these tests but wound't be the IPT specific testing be sufficient for that as well. 1612180 15 katherine_cheney 2020-01-28 14:35:30 -0800 (In reply to youenn fablet from comment #14) > > > I agree. Processing ITP domains at random times has caused flaky tests in > > > the past, so I'm wondering if there is an even more general solution that > > > might fix more flakiness than just caches. I'll look into it! > > Did these issues show up some bugs in implementation or in tests mainly? > Only tests (see https://bugs.webkit.org/show_bug.cgi?id=197285 for example). Processing is pretty much always good in implementation. > > On the other hand, though, if we are trying to test actual behavior and > > persistence of website data (i.e. caches, cookies, etc), maybe it could lead > > to ineffective testing to keep ITP's handling of these off by default in > > tests, because it won't mimic real situations. ITP's behavior probably > > shouldn't just be on for ITP tests, because it affects so many other areas > > of WebKit. > > Layout tests are almost run without any history. For instance, > WebsiteDataStore data is removed before each test. > This is very far from a typical situation where ITP would kick in and do > useful processing. > I might be wrong but I do not think we get a lot of value there from ITP > testing functionality. Maybe we get some threading issues from these tests > but wound't be the IPT specific testing be sufficient for that as well. I see what you're saying, and I agree it could help prevent hours spent looking into a flaky test like I had to do. I'll file a new radar for this. Thanks for your feedback Youenn! 388925 2020-01-27 15:18:55 -0800 2020-01-27 17:06:42 -0800 Update Test Expectations bug-206681-20200127151854.patch text/plain 1383 Lawrence.j U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MTg0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMTU3ZTE5NzYyMWM1NzdmMDIzYzdk NTk0NTFjMjVkNDkzNDk5OGY1NS4uYjlhNDkxZTI1MDc0MWZiYzE5MTA5NGUyMjQxYzIyOTdlYzc1 MWM4NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIwLTAxLTI3ICBKYXNvbiBMYXdyZW5jZSAg PGxhd3JlbmNlLmpAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFtpT1NdIGh0dHAv d3B0L2NhY2hlLXN0b3JhZ2UvcXVvdGEtdGhpcmQtcGFydHkuaHR0cHMuaHRtbCBpcyBmbGFreSBm YWlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjA2NjgxCisKKyAgICAgICAgVW5yZXZpZXdlZCB0ZXN0IGdhcmRlbmluZworCisgICAgICAgICog cGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorCiAyMDIwLTAxLTI3ICBKYWNvYiBV cGhvZmYgIDxqYWNvYl91cGhvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFsgbWFjT1MgXSBpbnNw ZWN0b3IvaGVhcC90cmFja2luZy5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDI4YzZlZTYzZmVhNWFh ZDc5ODAzZDI2ODI4YmE4MWJmZDJjMTA2ZDEuLjczZjI0MzExZThjMzNlMmM4ODZiMDkzYTYwOGUw ODFiNjRmZGI0MGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVz dEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBl Y3RhdGlvbnMKQEAgLTEzNTYsNCArMTM1Niw0IEBAIHdlYmtpdC5vcmcvYi8yMDY2NjcgbGVnYWN5 LWFuaW1hdGlvbi1lbmdpbmUvYW5pbWF0aW9ucy9zdG9wLWFuaW1hdGlvbi1vbi1zdXNwZW5kCiAK IHdlYmtpdC5vcmcvYi8yMDY2ODIgYW5pbWF0aW9ucy9wbGF5LXN0YXRlLXBhdXNlZC5odG1sIFsg UGFzcyBGYWlsdXJlIF0KIAotd2Via2l0Lm9yZy9iLzIwNjY3OCBbIFJlbGVhc2UgXSBjb21wb3Np dGluZy92aWRlby9wb3N0ZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBdClwgTm8gbmV3bGluZSBhdCBl bmQgb2YgZmlsZQord2Via2l0Lm9yZy9iLzIwNjY4MSBodHRwL3dwdC9jYWNoZS1zdG9yYWdlL3F1 b3RhLXRoaXJkLXBhcnR5Lmh0dHBzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQpcIE5vIG5ld2xpbmUg YXQgZW5kIG9mIGZpbGUK 389012 2020-01-28 09:02:32 -0800 2020-01-28 10:08:19 -0800 Patch bug-206681-20200128090231.patch text/plain 4146 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MjM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2NhZTY0ZjY5ODc0MWZiMTZjMmNh NTEwMTBiYmQ5OWRiMGEwYzdhZC4uYzZmZThkNmE3NWYzMDY0NWViZTYyYjdiNmM2OTU3ZDRmZjk5 NzdjOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTI4ICBLYXRlIENoZW5leSAgPGth dGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFtpT1NdIGh0 dHAvd3B0L2NhY2hlLXN0b3JhZ2UvcXVvdGEtdGhpcmQtcGFydHkuaHR0cHMuaHRtbCBpcyBmbGFr eSBmYWlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA2NjgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODg0MjQyOT4KKworICAgICAgICBM b2dzIHVzZXIgaW50ZXJhY3Rpb24gZm9yIHRoZSB0ZXN0IG9yaWdpbiB0byBhdm9pZCBjbGVhcmlu ZyB3ZWJzaXRlCisgICAgICAgIGRhdGEgYWZ0ZXIgdGhlIGZyYW1lIG5hdmlnYXRpb24uIFRoaXMg d2FzIGNhdXNpbmcgZmxha3kgZmFpbHVyZXMgaWYKKyAgICAgICAgdGhlIG9yaWdpbidzIGNhY2hl IHdhcyBkZWxldGVkIGJlZm9yZSB0aGUgdGVzdCBmaW5pc2hlZC4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0dHAvd3B0L2NhY2hlLXN0b3JhZ2Uv cXVvdGEtdGhpcmQtcGFydHkuaHR0cHMuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mtd2sy L1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjAtMDEtMjggIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5A YXBwbGUuY29tPgogCiAgICAgICAgIEJsb2IgbWVkaWEgbG9hZGluZyBkb2VzIG5vdCB3b3JrIHdp dGggR1BVUHJvY2VzcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvY2FjaGUtc3Rv cmFnZS9xdW90YS10aGlyZC1wYXJ0eS5odHRwcy5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQv Y2FjaGUtc3RvcmFnZS9xdW90YS10aGlyZC1wYXJ0eS5odHRwcy5odG1sCmluZGV4IGE5ZjQ4NmQ2 ZTc4MjUzMTNlZTJkZTI2OWM2ZjhlMDcyNWQ1MWZjYTEuLmJjMWMzMmU0NTNiYTkyYmNkMDc3NGU1 Y2RmZGNhMDdmYzdlZDlhZjQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0dHAvd3B0L2NhY2hl LXN0b3JhZ2UvcXVvdGEtdGhpcmQtcGFydHkuaHR0cHMuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9o dHRwL3dwdC9jYWNoZS1zdG9yYWdlL3F1b3RhLXRoaXJkLXBhcnR5Lmh0dHBzLmh0bWwKQEAgLTcs NiArNywxMiBAQAogICAgIDwvaGVhZD4KIDxib2R5PgogICAgIDxzY3JpcHQ+CitpZiAod2luZG93 LnRlc3RSdW5uZXIpIHsKKyAgICAvLyBMb2cgdXNlciBpbnRlcmFjdGlvbiBmb3IgdGhpcyBkb21h aW4gdG8gYXZvaWQgZGVsZXRpbmcgaXRzCisgICAgLy8gd2Vic2l0ZSBkYXRhIChpbmNsdWRpbmcg Y2FjaGVzKSB3aGVuIGEgZnJhbWUgbmF2aWdhdGlvbiBvY2N1cnMuCisgICAgdGVzdFJ1bm5lci5z ZXRTdGF0aXN0aWNzSGFzSGFkVXNlckludGVyYWN0aW9uKCJodHRwczovLzEyNy4wLjAuMTo5NDQz IiwgdHJ1ZSwgc3RhcnQoKSk7Cit9CisKIGZ1bmN0aW9uIGxvYWRfaWZyYW1lKHVybCkgewogICAg IHJldHVybiBuZXcgUHJvbWlzZShmdW5jdGlvbihyZXNvbHZlKSB7CiAgICAgICAgIHZhciBmcmFt ZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lmcmFtZScpOwpAQCAtMTYsMjIgKzIyLDIzIEBA IGZ1bmN0aW9uIGxvYWRfaWZyYW1lKHVybCkgewogICAgIH0pOwogfQogCi1wcm9taXNlX3Rlc3Qo YXN5bmMgKCkgPT4gewotICAgIGFzc2VydF9lcXVhbHMoYXdhaXQgbG9hZF9pZnJhbWUoInJlc291 cmNlcy9xdW90YS10aGlyZC1wYXJ0eS1pZnJhbWUuaHRtbCIpLCAiUEFTUyIpOwotfSwgInNhbWUg b3JpZ2luIGlmcmFtZSBoYXMgcmVndWxhciBxdW90YSIpOworZnVuY3Rpb24gc3RhcnQoKSB7Cisg ICAgcHJvbWlzZV90ZXN0KGFzeW5jICgpID0+IHsKKyAgICAgICAgYXNzZXJ0X2VxdWFscyhhd2Fp dCBsb2FkX2lmcmFtZSgicmVzb3VyY2VzL3F1b3RhLXRoaXJkLXBhcnR5LWlmcmFtZS5odG1sIiks ICJQQVNTIik7CisgICAgfSwgInNhbWUgb3JpZ2luIGlmcmFtZSBoYXMgcmVndWxhciBxdW90YSIp OwogCi1wcm9taXNlX3Rlc3QoYXN5bmMgKCkgPT4gewotICAgIGFzc2VydF9lcXVhbHMoYXdhaXQg bG9hZF9pZnJhbWUoImh0dHBzOi8vMTI3LjAuMC4xOjk0NDMvV2ViS2l0L2NhY2hlLXN0b3JhZ2Uv cmVzb3VyY2VzL3F1b3RhLXRoaXJkLXBhcnR5LWlmcmFtZS5odG1sIiksICJGQUlMIik7Ci19LCAi Y3Jvc3Mgb3JpZ2luIGlmcmFtZSBoYXMgcmVkdWNlZCBxdW90YSIpOworICAgIHByb21pc2VfdGVz dChhc3luYyAoKSA9PiB7CisgICAgICAgIGFzc2VydF9lcXVhbHMoYXdhaXQgbG9hZF9pZnJhbWUo Imh0dHBzOi8vMTI3LjAuMC4xOjk0NDMvV2ViS2l0L2NhY2hlLXN0b3JhZ2UvcmVzb3VyY2VzL3F1 b3RhLXRoaXJkLXBhcnR5LWlmcmFtZS5odG1sIiksICJGQUlMIik7CisgICAgfSwgImNyb3NzIG9y aWdpbiBpZnJhbWUgaGFzIHJlZHVjZWQgcXVvdGEiKTsKIAotcHJvbWlzZV90ZXN0KGFzeW5jICgp ID0+IHsKLSAgICAvLyBDbGVhciBET01DYWNoZXMgdG8gcmVzZXQgcXVvdGFzLgotICAgIGlmICh3 aW5kb3cudGVzdFJ1bm5lcikKLSAgICAgICAgdGVzdFJ1bm5lci5jbGVhckRPTUNhY2hlcygpOwot Ci0gICAgYXNzZXJ0X2VxdWFscyhhd2FpdCBsb2FkX2lmcmFtZSgiaHR0cHM6Ly8xMjcuMC4wLjE6 OTQ0My9XZWJLaXQvY2FjaGUtc3RvcmFnZS9yZXNvdXJjZXMvcXVvdGEtdGhpcmQtcGFydHktaWZy YW1lLmh0bWwiKSwgIkZBSUwiKTsKLX0sICJjcm9zcyBvcmlnaW4gaWZyYW1lIGhhcyByZWR1Y2Vk IHF1b3RhIGFmdGVyIHJlc2V0dGluZyBxdW90YSIpOworICAgIHByb21pc2VfdGVzdChhc3luYyAo KSA9PiB7CisgICAgICAgIC8vIENsZWFyIERPTUNhY2hlcyB0byByZXNldCBxdW90YXMuCisgICAg ICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgIHRlc3RSdW5uZXIuY2xlYXJE T01DYWNoZXMoKTsKIAorICAgICAgICBhc3NlcnRfZXF1YWxzKGF3YWl0IGxvYWRfaWZyYW1lKCJo dHRwczovLzEyNy4wLjAuMTo5NDQzL1dlYktpdC9jYWNoZS1zdG9yYWdlL3Jlc291cmNlcy9xdW90 YS10aGlyZC1wYXJ0eS1pZnJhbWUuaHRtbCIpLCAiRkFJTCIpOworICAgIH0sICJjcm9zcyBvcmln aW4gaWZyYW1lIGhhcyByZWR1Y2VkIHF1b3RhIGFmdGVyIHJlc2V0dGluZyBxdW90YSIpOworfQog ICAgIDwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v aW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDViYjgwZDQ3MjljMzgwN2I0OTI1MzE3ZTA1 NzIxNzU4Mjk2MzQyNzQuLjdhMTg1N2Q0NWU1MDhmYTEwM2Q3Njk1NjZlMTBmOTIyNWYyOTdiNzYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAg LTEzNTUsOCArMTM1NSw2IEBAIHdlYmtpdC5vcmcvYi8yMDY2NjcgbGVnYWN5LWFuaW1hdGlvbi1l bmdpbmUvYW5pbWF0aW9ucy9zdG9wLWFuaW1hdGlvbi1vbi1zdXNwZW5kCiAKIHdlYmtpdC5vcmcv Yi8yMDY2ODIgYW5pbWF0aW9ucy9wbGF5LXN0YXRlLXBhdXNlZC5odG1sIFsgUGFzcyBGYWlsdXJl IF0KIAotd2Via2l0Lm9yZy9iLzIwNjY4MSBodHRwL3dwdC9jYWNoZS1zdG9yYWdlL3F1b3RhLXRo aXJkLXBhcnR5Lmh0dHBzLmh0bWwgWyBQYXNzIEZhaWx1cmUgXQotCiB3ZWJraXQub3JnL2IvMjA2 Njc4IFsgUmVsZWFzZSBdIGNvbXBvc2l0aW5nL3ZpZGVvL3Bvc3Rlci5odG1sIFsgUGFzcyBGYWls dXJlIF0KIAogd2Via2l0Lm9yZy9iLzIwNjY4NSBbIERlYnVnIF0gYW5pbWF0aW9ucy9hbmltYXRp b24tZGlyZWN0aW9uLW5vcm1hbC5odG1sIFsgUGFzcyBGYWlsdXJlIF0K 389024 2020-01-28 10:08:20 -0800 2020-01-28 11:06:40 -0800 Patch for landing bug-206681-20200128100819.patch text/plain 2830 katherine_cheney U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MjM4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2NhZTY0ZjY5ODc0MWZiMTZjMmNh NTEwMTBiYmQ5OWRiMGEwYzdhZC4uNGJjNjMxN2Q2ZmJlZWNlNjVjMzQwOWYwZGJhMWY4MDQxNmU4 ZWVjMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIwLTAxLTI4ICBLYXRlIENoZW5leSAgPGth dGhlcmluZV9jaGVuZXlAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT046IFtpT1NdIGh0 dHAvd3B0L2NhY2hlLXN0b3JhZ2UvcXVvdGEtdGhpcmQtcGFydHkuaHR0cHMuaHRtbCBpcyBmbGFr eSBmYWlsaW5nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA2NjgxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODg0MjQyOT4KKworICAgICAgICBM b2dzIHVzZXIgaW50ZXJhY3Rpb24gZm9yIHRoZSB0ZXN0IG9yaWdpbiB0byBhdm9pZCBjbGVhcmlu ZyB3ZWJzaXRlCisgICAgICAgIGRhdGEgYWZ0ZXIgdGhlIGZyYW1lIG5hdmlnYXRpb24uIFRoaXMg d2FzIGNhdXNpbmcgZmxha3kgZmFpbHVyZXMgaWYKKyAgICAgICAgdGhlIG9yaWdpbidzIGNhY2hl IHdhcyBkZWxldGVkIGJlZm9yZSB0aGUgdGVzdCBmaW5pc2hlZC4KKworICAgICAgICBSZXZpZXdl ZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgICogaHR0cC93cHQvY2FjaGUtc3RvcmFnZS9x dW90YS10aGlyZC1wYXJ0eS5odHRwcy5odG1sOgorICAgICAgICAqIHBsYXRmb3JtL2lvcy13azIv VGVzdEV4cGVjdGF0aW9uczoKKwogMjAyMC0wMS0yOCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgQmxvYiBtZWRpYSBsb2FkaW5nIGRvZXMgbm90IHdvcmsgd2l0 aCBHUFVQcm9jZXNzCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3dwdC9jYWNoZS1zdG9y YWdlL3F1b3RhLXRoaXJkLXBhcnR5Lmh0dHBzLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9j YWNoZS1zdG9yYWdlL3F1b3RhLXRoaXJkLXBhcnR5Lmh0dHBzLmh0bWwKaW5kZXggYTlmNDg2ZDZl NzgyNTMxM2VlMmRlMjY5YzZmOGUwNzI1ZDUxZmNhMS4uYThlYzg3NTkwMjQwZGEyYTI0MGVhMTI4 M2Q2OTNmYzcxMTI5ZjZjYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvY2FjaGUt c3RvcmFnZS9xdW90YS10aGlyZC1wYXJ0eS5odHRwcy5odG1sCisrKyBiL0xheW91dFRlc3RzL2h0 dHAvd3B0L2NhY2hlLXN0b3JhZ2UvcXVvdGEtdGhpcmQtcGFydHkuaHR0cHMuaHRtbApAQCAtNyw2 ICs3LDEyIEBACiAgICAgPC9oZWFkPgogPGJvZHk+CiAgICAgPHNjcmlwdD4KK2lmICh3aW5kb3cu dGVzdFJ1bm5lcikgeworICAgIC8vIExvZyB1c2VyIGludGVyYWN0aW9uIGZvciB0aGlzIGRvbWFp biB0byBhdm9pZCBkZWxldGluZyBpdHMKKyAgICAvLyB3ZWJzaXRlIGRhdGEgKGluY2x1ZGluZyBj YWNoZXMpIHdoZW4gYSBmcmFtZSBuYXZpZ2F0aW9uIG9jY3Vycy4KKyAgICB0ZXN0UnVubmVyLnNl dFN0YXRpc3RpY3NIYXNIYWRVc2VySW50ZXJhY3Rpb24oImh0dHBzOi8vMTI3LjAuMC4xOjk0NDMi LCB0cnVlKTsKK30KKwogZnVuY3Rpb24gbG9hZF9pZnJhbWUodXJsKSB7CiAgICAgcmV0dXJuIG5l dyBQcm9taXNlKGZ1bmN0aW9uKHJlc29sdmUpIHsKICAgICAgICAgdmFyIGZyYW1lID0gZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgnaWZyYW1lJyk7CkBAIC0zMSw3ICszNyw2IEBAIHByb21pc2VfdGVz dChhc3luYyAoKSA9PiB7CiAKICAgICBhc3NlcnRfZXF1YWxzKGF3YWl0IGxvYWRfaWZyYW1lKCJo dHRwczovLzEyNy4wLjAuMTo5NDQzL1dlYktpdC9jYWNoZS1zdG9yYWdlL3Jlc291cmNlcy9xdW90 YS10aGlyZC1wYXJ0eS1pZnJhbWUuaHRtbCIpLCAiRkFJTCIpOwogfSwgImNyb3NzIG9yaWdpbiBp ZnJhbWUgaGFzIHJlZHVjZWQgcXVvdGEgYWZ0ZXIgcmVzZXR0aW5nIHF1b3RhIik7Ci0KICAgICA8 L3NjcmlwdD4KIDwvYm9keT4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13 azIvVGVzdEV4cGVjdGF0aW9ucwppbmRleCA1YmI4MGQ0NzI5YzM4MDdiNDkyNTMxN2UwNTcyMTc1 ODI5NjM0Mjc0Li43YTE4NTdkNDVlNTA4ZmExMDNkNzY5NTY2ZTEwZjkyMjVmMjk3Yjc2IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMzU1 LDggKzEzNTUsNiBAQCB3ZWJraXQub3JnL2IvMjA2NjY3IGxlZ2FjeS1hbmltYXRpb24tZW5naW5l L2FuaW1hdGlvbnMvc3RvcC1hbmltYXRpb24tb24tc3VzcGVuZAogCiB3ZWJraXQub3JnL2IvMjA2 NjgyIGFuaW1hdGlvbnMvcGxheS1zdGF0ZS1wYXVzZWQuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiAK LXdlYmtpdC5vcmcvYi8yMDY2ODEgaHR0cC93cHQvY2FjaGUtc3RvcmFnZS9xdW90YS10aGlyZC1w YXJ0eS5odHRwcy5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzIwNjY3OCBb IFJlbGVhc2UgXSBjb21wb3NpdGluZy92aWRlby9wb3N0ZXIuaHRtbCBbIFBhc3MgRmFpbHVyZSBd CiAKIHdlYmtpdC5vcmcvYi8yMDY2ODUgWyBEZWJ1ZyBdIGFuaW1hdGlvbnMvYW5pbWF0aW9uLWRp cmVjdGlvbi1ub3JtYWwuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCg==