206675 2020-01-23 10:22:06 -0800 REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing 2020-01-27 10:39:07 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jacob_uphoff cdumez cdumez commit-queue dino sabouhallawa simon.fraser thorton tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1610177 0 jacob_uphoff 2020-01-23 10:22:06 -0800 fast/animation/request-animation-frame.html is flaky failing on Mojave wk2 starting around commit 254128 I did not try to reproduce History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fanimation%2Frequest-animation-frame.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS callbackInvoked is true +FAIL callbackInvoked should be true. Was false. PASS successfullyParsed is true TEST COMPLETE 1610190 1 tsavell 2020-01-23 10:41:52 -0800 This looks like it was fixed for a time around 254405 then broke again around 254790 1610191 2 webkit-bug-importer 2020-01-23 10:41:53 -0800 <rdar://problem/58839955> 1611429 3 388864 cdumez 2020-01-27 08:49:59 -0800 Created attachment 388864 Patch 1611433 4 388864 sabouhallawa 2020-01-27 08:59:42 -0800 Comment on attachment 388864 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388864&action=review > LayoutTests/fast/animation/request-animation-frame.html:8 > <span id="e"></span> > <span id="f"></span> Do we still need these two elements? 1611443 5 cdumez 2020-01-27 09:41:19 -0800 (In reply to Said Abou-Hallawa from comment #4) > Comment on attachment 388864 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388864&action=review > > > LayoutTests/fast/animation/request-animation-frame.html:8 > > <span id="e"></span> > > <span id="f"></span> > > Do we still need these two elements? No, will drop' em 1611444 6 388868 cdumez 2020-01-27 09:41:34 -0800 Created attachment 388868 Patch 1611472 7 388868 commit-queue 2020-01-27 10:39:05 -0800 Comment on attachment 388868 Patch Clearing flags on attachment: 388868 Committed r255153: <https://trac.webkit.org/changeset/255153> 1611473 8 commit-queue 2020-01-27 10:39:07 -0800 All reviewed patches have been landed. Closing bug. 388864 2020-01-27 08:49:59 -0800 2020-01-27 09:41:32 -0800 Patch bug-206675-20200127084959.patch text/plain 3182 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MTQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmJkZTM5ZGIxZDQ3YTI4NWQ3ZDVk MTI5NGVhMWQ3M2NmMTE0NjIxZS4uYzk0YTM0MWZkN2Q3OTMwZDczZWFkNWQwNWIwYzQyMTEwN2Y0 ZTAyNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTI3ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW01hYyB3azJdIGZhc3QvYW5p bWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLmh0bWwgaXMgZmxha3kgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2Njc1CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81ODgzOTk1NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBSZXdyaXRlIHRlc3QgdG8gc3RvcCByZWx5aW5nIG9uIG9y ZGVyaW5nIGJldHdlZW4gcmVxdWVzdEFuaW1hdGlvbkZyYW1lKCkgYW5kIHNldFRpbWVvdXQoKS4K KworICAgICAgICAqIGZhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2FuaW1hdGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1mcmFt ZS5odG1sOgorCiAyMDIwLTAxLTI3ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4K IAogICAgICAgICBbTWFjIHdrMiBSZWxlYXNlXSBmYXN0L2RvbS9mcmFtZS1zcmMtamF2YXNjcmlw dC11cmwtYXN5bmMuaHRtbCBmbGFreSBmYWlsaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L2FuaW1hdGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1mcmFtZS1leHBlY3RlZC50eHQgYi9MYXlv dXRUZXN0cy9mYXN0L2FuaW1hdGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1mcmFtZS1leHBlY3RlZC50 eHQKaW5kZXggMjVmZDg5ZGU1ZDI4MmM1YmYwN2M0NjU4NjE4YTMzYjkyMWUxM2RiOS4uZDk3YTYy OTg4Y2EyOWM3ZWU0YWYwZDFmMzZkZjJhNjA3MWYxZjhhOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvZmFzdC9hbmltYXRpb24vcmVxdWVzdC1hbmltYXRpb24tZnJhbWUtZXhwZWN0ZWQudHh0Cisr KyBiL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLWV4 cGVjdGVkLnR4dApAQCAtMyw3ICszLDExIEBAIFRlc3RzIGJhc2ljIHVzZSBvZiByZXF1ZXN0QW5p bWF0aW9uRnJhbWUKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAogCi1QQVNTIGNhbGxiYWNr SW52b2tlZCBpcyB0cnVlCitQQVNTIHJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMg Y2FsbGVkCitQQVNTIHJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVkCitQ QVNTIHJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVkCitQQVNTIHJlcXVl c3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVkCitQQVNTIHJlcXVlc3RBbmltYXRp b25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVkCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0 cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0 aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2FuaW1h dGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1mcmFtZS5odG1sCmluZGV4IDA0OGM0Y2VmZjUxNGM1ZTZm NDNkNDA1YzE2ZmNhZjlkNGE0OTdiYmUuLjM5YjhhNzBlMzMyN2VjYmViNWY1N2FlNTc5NzQ3YjA3 NmUyNWE5OTMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uL3JlcXVlc3Qt YW5pbWF0aW9uLWZyYW1lLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9hbmltYXRpb24vcmVx dWVzdC1hbmltYXRpb24tZnJhbWUuaHRtbApAQCAtMSwzNSArMSwzMCBAQAogPCFET0NUWVBFIGh0 bWw+CiA8aHRtbD4KIDxoZWFkPgotPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3Qu anMiPjwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+CiA8c3BhbiBpZD0iZSI+PC9zcGFuPgogPHNw YW4gaWQ9ImYiPjwvc3Bhbj4KIDxzY3JpcHQ+CiBkZXNjcmlwdGlvbigiVGVzdHMgYmFzaWMgdXNl IG9mIHJlcXVlc3RBbmltYXRpb25GcmFtZSIpOwotCi12YXIgZSA9IGRvY3VtZW50LmdldEVsZW1l bnRCeUlkKCJlIik7Ci12YXIgY2FsbGJhY2tJbnZva2VkID0gZmFsc2U7Ci13aW5kb3cucmVxdWVz dEFuaW1hdGlvbkZyYW1lKGZ1bmN0aW9uKCkgewotICAgIGNhbGxiYWNrSW52b2tlZCA9IHRydWU7 Ci19LCBlKTsKK2pzVGVzdElzQXN5bmMgPSB0cnVlOwogCiBpZiAod2luZG93LnRlc3RSdW5uZXIp CiAgICAgdGVzdFJ1bm5lci5kaXNwbGF5QW5kVHJhY2tSZXBhaW50cygpOwogCi1zZXRUaW1lb3V0 KGZ1bmN0aW9uKCkgewotICAgIHNob3VsZEJlVHJ1ZSgiY2FsbGJhY2tJbnZva2VkIik7Ci19LCAx MDApOworbGV0IGNhbGxiYWNrQ291bnQgPSAwOworbGV0IHJBRkNhbGxiYWNrID0gKCkgPT4gewor ICAgIHRlc3RQYXNzZWQoInJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVk Iik7CisgICAgY2FsbGJhY2tDb3VudCsrOworICAgIGlmIChjYWxsYmFja0NvdW50IDwgNSkKKyAg ICAgICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKHJBRkNhbGxiYWNrKTsKKyAgICBlbHNlCisgICAg ICAgZmluaXNoSlNUZXN0KCk7Cit9CiAKLWlmICh3aW5kb3cudGVzdFJ1bm5lcikKLSAgICB0ZXN0 UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK3JlcXVlc3RBbmltYXRpb25GcmFtZShyQUZDYWxsYmFj ayk7CiAKLXNldFRpbWVvdXQoZnVuY3Rpb24oKSB7Ci0gICAgaXNTdWNjZXNzZnVsbHlQYXJzZWQo KTsKLSAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgICAgIHRlc3RSdW5uZXIubm90aWZ5 RG9uZSgpOwotfSwgMjAwKTsKIDwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgo= 388868 2020-01-27 09:41:34 -0800 2020-01-27 10:39:05 -0800 Patch bug-206675-20200127094133.patch text/plain 3185 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MTQ3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZmJkZTM5ZGIxZDQ3YTI4NWQ3ZDVk MTI5NGVhMWQ3M2NmMTE0NjIxZS4uZTNhODQ2YzZlOWRkOTc4OTk0Mjg5MTdkNDdiN2QxNmYwNmU2 ZjQwZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTI3ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW01hYyB3azJdIGZhc3QvYW5p bWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLmh0bWwgaXMgZmxha3kgZmFpbGluZworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2Njc1CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81ODgzOTk1NT4KKworICAgICAgICBSZXZpZXdlZCBieSBTYWlk IEFib3UtSGFsbGF3YS4KKworICAgICAgICBSZXdyaXRlIHRlc3QgdG8gc3RvcCByZWx5aW5nIG9u IG9yZGVyaW5nIGJldHdlZW4gcmVxdWVzdEFuaW1hdGlvbkZyYW1lKCkgYW5kIHNldFRpbWVvdXQo KS4KKworICAgICAgICAqIGZhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLWV4 cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2FuaW1hdGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1m cmFtZS5odG1sOgorCiAyMDIwLTAxLTI3ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KIAogICAgICAgICBbTWFjIHdrMiBSZWxlYXNlXSBmYXN0L2RvbS9mcmFtZS1zcmMtamF2YXNj cmlwdC11cmwtYXN5bmMuaHRtbCBmbGFreSBmYWlsaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2FuaW1hdGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1mcmFtZS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2FuaW1hdGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1mcmFtZS1leHBlY3Rl ZC50eHQKaW5kZXggMjVmZDg5ZGU1ZDI4MmM1YmYwN2M0NjU4NjE4YTMzYjkyMWUxM2RiOS4uZDk3 YTYyOTg4Y2EyOWM3ZWU0YWYwZDFmMzZkZjJhNjA3MWYxZjhhOSAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvZmFzdC9hbmltYXRpb24vcmVxdWVzdC1hbmltYXRpb24tZnJhbWUtZXhwZWN0ZWQudHh0 CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1l LWV4cGVjdGVkLnR4dApAQCAtMyw3ICszLDExIEBAIFRlc3RzIGJhc2ljIHVzZSBvZiByZXF1ZXN0 QW5pbWF0aW9uRnJhbWUKIE9uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFT UyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KIAogCi1QQVNTIGNhbGxi YWNrSW52b2tlZCBpcyB0cnVlCitQQVNTIHJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3 YXMgY2FsbGVkCitQQVNTIHJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVk CitQQVNTIHJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVkCitQQVNTIHJl cXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVkCitQQVNTIHJlcXVlc3RBbmlt YXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2FsbGVkCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBp cyB0cnVlCiAKIFRFU1QgQ09NUExFVEUKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvYW5p bWF0aW9uL3JlcXVlc3QtYW5pbWF0aW9uLWZyYW1lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Fu aW1hdGlvbi9yZXF1ZXN0LWFuaW1hdGlvbi1mcmFtZS5odG1sCmluZGV4IDA0OGM0Y2VmZjUxNGM1 ZTZmNDNkNDA1YzE2ZmNhZjlkNGE0OTdiYmUuLmJhOTQ4NjBjZDljMjc1MDdkMTgxNTkzNjJmNTI3 YjE4NDczNTc3MjUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvYW5pbWF0aW9uL3JlcXVl c3QtYW5pbWF0aW9uLWZyYW1lLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9hbmltYXRpb24v cmVxdWVzdC1hbmltYXRpb24tZnJhbWUuaHRtbApAQCAtMSwzNSArMSwyOCBAQAogPCFET0NUWVBF IGh0bWw+CiA8aHRtbD4KIDxoZWFkPgotPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10 ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QuanMiPjwvc2NyaXB0PgogPC9oZWFkPgogPGJvZHk+Ci08c3BhbiBpZD0iZSI+PC9zcGFuPgot PHNwYW4gaWQ9ImYiPjwvc3Bhbj4KIDxzY3JpcHQ+CiBkZXNjcmlwdGlvbigiVGVzdHMgYmFzaWMg dXNlIG9mIHJlcXVlc3RBbmltYXRpb25GcmFtZSIpOwotCi12YXIgZSA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJlIik7Ci12YXIgY2FsbGJhY2tJbnZva2VkID0gZmFsc2U7Ci13aW5kb3cucmVx dWVzdEFuaW1hdGlvbkZyYW1lKGZ1bmN0aW9uKCkgewotICAgIGNhbGxiYWNrSW52b2tlZCA9IHRy dWU7Ci19LCBlKTsKK2pzVGVzdElzQXN5bmMgPSB0cnVlOwogCiBpZiAod2luZG93LnRlc3RSdW5u ZXIpCiAgICAgdGVzdFJ1bm5lci5kaXNwbGF5QW5kVHJhY2tSZXBhaW50cygpOwogCi1zZXRUaW1l b3V0KGZ1bmN0aW9uKCkgewotICAgIHNob3VsZEJlVHJ1ZSgiY2FsbGJhY2tJbnZva2VkIik7Ci19 LCAxMDApOworbGV0IGNhbGxiYWNrQ291bnQgPSAwOworbGV0IHJBRkNhbGxiYWNrID0gKCkgPT4g eworICAgIHRlc3RQYXNzZWQoInJlcXVlc3RBbmltYXRpb25GcmFtZSBjYWxsYmFjayB3YXMgY2Fs bGVkIik7CisgICAgY2FsbGJhY2tDb3VudCsrOworICAgIGlmIChjYWxsYmFja0NvdW50IDwgNSkK KyAgICAgICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKHJBRkNhbGxiYWNrKTsKKyAgICBlbHNlCisg ICAgICAgZmluaXNoSlNUZXN0KCk7Cit9CiAKLWlmICh3aW5kb3cudGVzdFJ1bm5lcikKLSAgICB0 ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKK3JlcXVlc3RBbmltYXRpb25GcmFtZShyQUZDYWxs YmFjayk7CiAKLXNldFRpbWVvdXQoZnVuY3Rpb24oKSB7Ci0gICAgaXNTdWNjZXNzZnVsbHlQYXJz ZWQoKTsKLSAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCi0gICAgICAgIHRlc3RSdW5uZXIubm90 aWZ5RG9uZSgpOwotfSwgMjAwKTsKIDwvc2NyaXB0PgogPC9ib2R5PgogPC9odG1sPgo=