206672 2020-01-23 10:06:43 -0800 REGRESSION: [iOS release] http/tests/security/window-named-proto.html is a flaky timing out 2020-01-31 01:07:12 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j jiewen_tan achristensen cdumez commit-queue ggaren jiewen_tan koivisto rniwa tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1610164 0 Lawrence.j 2020-01-23 10:06:43 -0800 http/tests/security/window-named-proto.html Description: This test is timing out. It looks like this regressed around 252941. I have not tried to reproduce this. History: https://results.webkit.org/?limit=50000&suite=layout-tests&test=http%2Ftests%2Fsecurity%2Fwindow-named-proto.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/security/window-named-proto-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/http/tests/security/window-named-proto-actual.txt @@ -1,2 +1,3 @@ -CONSOLE MESSAGE: line 2: TypeError: null is not an object (evaluating 'document.body.innerHTML') +#PID UNRESPONSIVE - WebKitTestRunnerApp (pid 29959) +FAIL: Timed out waiting for notifyDone to be called 1610165 1 webkit-bug-importer 2020-01-23 10:07:09 -0800 <rdar://problem/58838583> 1610722 2 tsavell 2020-01-24 09:35:25 -0800 This is a highly intermittent timeout on iOS iOS Release 1611004 3 ap 2020-01-24 23:20:55 -0800 When I increase history limit, I see even older timeouts, starting with r251319. It is pretty rare, so history doesn't point at the culprit, but this is sort of consistent with HTML event loop changes. 1613131 4 389286 jiewen_tan 2020-01-30 14:05:27 -0800 Created attachment 389286 Patch 1613136 5 389288 jiewen_tan 2020-01-30 14:09:40 -0800 Created attachment 389288 Patch 1613148 6 389288 rniwa 2020-01-30 14:33:53 -0800 Comment on attachment 389288 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389288&action=review > Source/WebCore/platform/network/DataURLDecoder.cpp:46 > - static auto& queue = WorkQueue::create("org.webkit.DataURLDecoder").leakRef(); > + static auto& queue = WorkQueue::create("org.webkit.DataURLDecoder", WorkQueue::Type::Serial, WorkQueue::QOS::UserInitiated).leakRef(); Hm... what's the default QOS? I thought all threads we start will be at least user initiated by default? 1613154 7 jiewen_tan 2020-01-30 14:44:29 -0800 (In reply to Ryosuke Niwa from comment #6) > Comment on attachment 389288 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=389288&action=review > > > Source/WebCore/platform/network/DataURLDecoder.cpp:46 > > - static auto& queue = WorkQueue::create("org.webkit.DataURLDecoder").leakRef(); > > + static auto& queue = WorkQueue::create("org.webkit.DataURLDecoder", WorkQueue::Type::Serial, WorkQueue::QOS::UserInitiated).leakRef(); > > Hm... what's the default QOS? I thought all threads we start will be at > least user initiated by default? static Ref<WorkQueue> create(const char* name, Type = Type::Serial, QOS = QOS::Default); 1613161 8 389288 cdumez 2020-01-30 14:57:46 -0800 Comment on attachment 389288 Patch Makes sense to use user-initiated IMO since this is the priority on the WebContent process' main thread and since this thread getting pre-empted would slow down a load, which would be visible to the user. 1613165 9 rniwa 2020-01-30 15:11:38 -0800 (In reply to Chris Dumez from comment #8) > Comment on attachment 389288 [details] > Patch > > Makes sense to use user-initiated IMO since this is the priority on the > WebContent process' main thread and since this thread getting pre-empted > would slow down a load, which would be visible to the user. FWIW, I'm pretty sure WebContent's main thread runs at user interactive QOS, which is slightly higher priority than user-initiated QOS. 1613166 10 cdumez 2020-01-30 15:18:17 -0800 (In reply to Ryosuke Niwa from comment #9) > (In reply to Chris Dumez from comment #8) > > Comment on attachment 389288 [details] > > Patch > > > > Makes sense to use user-initiated IMO since this is the priority on the > > WebContent process' main thread and since this thread getting pre-empted > > would slow down a load, which would be visible to the user. > > FWIW, I'm pretty sure WebContent's main thread runs at user interactive QOS, > which is slightly higher priority than user-initiated QOS. Not 100% sure about that, would need to be validated on device to be sure. Either way, I do think that using user-initiated for data url is better than Default. I think it would be riskier to use UserInteractive. 1613301 11 389288 jiewen_tan 2020-01-31 00:23:53 -0800 Comment on attachment 389288 Patch Chris, thanks for r+ this patch. 1613304 12 389288 commit-queue 2020-01-31 01:07:10 -0800 Comment on attachment 389288 Patch Clearing flags on attachment: 389288 Committed r255487: <https://trac.webkit.org/changeset/255487> 1613305 13 commit-queue 2020-01-31 01:07:12 -0800 All reviewed patches have been landed. Closing bug. 389286 2020-01-30 14:05:27 -0800 2020-01-30 14:09:39 -0800 Patch bug-206672-20200130140527.patch text/plain 1624 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2EwMDFjMmFmNDMwYmFm NWUwNzVhYTI5YWJmMzBlNzA1MTA5N2M3My4uZjA0Nzk2N2IxMWE2ZDQzMTQ5ZjI1NmEyZjgyMDhj ZjM3NzNiODIyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTMwICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lP UyByZWxlYXNlXSBodHRwL3Rlc3RzL3NlY3VyaXR5L3dpbmRvdy1uYW1lZC1wcm90by5odG1sIGlz IGEgZmxha3kgdGltaW5nIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA2NjcyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODgzODU4Mz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEg c3BlY3VsYXRpdmUgZml4IHRvIGluY3JlYXNlIHRoZSBwcmlvcml0eSBvZiB0aGUgRGF0YVVSTERl Y29kZXIncyBXb3JrUXVldWUgc3VjaCB0aGF0CisgICAgICAgIGl0IGlzIGxlc3MgbGlrZWx5IHRv IGJlIHByZWVtcHRlZC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9EYXRhVVJMRGVjb2Rlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEYXRhVVJMRGVjb2Rlcjo6ZGVjb2RlUXVldWUpOgorCiAyMDIwLTAxLTI4ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm9wZXJseSBj bGVhciBwZW5kaW5nIGNoYW5nZXMgZHVyaW5nIEFYSXNvbGF0ZWRUcmVlIHJlbW92YWwgYW5kIGFw cGx5UGVuZGluZ0NoYW5nZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0RhdGFVUkxEZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvRGF0YVVSTERlY29kZXIuY3BwCmluZGV4IGI1NDFmNjJlZTAwNTIwMzYyYzE1NTdmN2NhNDk2 NGEyMzdiODc0OWQuLjM1OTYwNTM5YTFmMjI4ZmNjMzBjNTY0MTJjMzRkYjE2NGQ5YzQzY2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIu Y3BwCkBAIC00Myw3ICs0Myw3IEBAIG5hbWVzcGFjZSBEYXRhVVJMRGVjb2RlciB7CiAKIHN0YXRp YyBXb3JrUXVldWUmIGRlY29kZVF1ZXVlKCkKIHsKLSAgICBzdGF0aWMgYXV0byYgcXVldWUgPSBX b3JrUXVldWU6OmNyZWF0ZSgib3JnLndlYmtpdC5EYXRhVVJMRGVjb2RlciIpLmxlYWtSZWYoKTsK KyAgICBzdGF0aWMgYXV0byYgcXVldWUgPSBXb3JrUXVldWU6OmNyZWF0ZSgib3JnLndlYmtpdC5E YXRhVVJMRGVjb2RlciIsIFR5cGU6OlNlcmlhbCwgUU9TOjpVc2VySW5pdGlhdGVkKS5sZWFrUmVm KCk7CiAgICAgcmV0dXJuIHF1ZXVlOwogfQogCg== 389288 2020-01-30 14:09:40 -0800 2020-01-31 01:07:10 -0800 Patch bug-206672-20200130140939.patch text/plain 1646 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MzE0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2EwMDFjMmFmNDMwYmFm NWUwNzVhYTI5YWJmMzBlNzA1MTA5N2M3My4uZjA0Nzk2N2IxMWE2ZDQzMTQ5ZjI1NmEyZjgyMDhj ZjM3NzNiODIyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTMwICBKaWV3 ZW4gVGFuICA8amlld2VuX3RhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogW2lP UyByZWxlYXNlXSBodHRwL3Rlc3RzL3NlY3VyaXR5L3dpbmRvdy1uYW1lZC1wcm90by5odG1sIGlz IGEgZmxha3kgdGltaW5nIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA2NjcyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODgzODU4Mz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIGEg c3BlY3VsYXRpdmUgZml4IHRvIGluY3JlYXNlIHRoZSBwcmlvcml0eSBvZiB0aGUgRGF0YVVSTERl Y29kZXIncyBXb3JrUXVldWUgc3VjaCB0aGF0CisgICAgICAgIGl0IGlzIGxlc3MgbGlrZWx5IHRv IGJlIHByZWVtcHRlZC4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisg ICAgICAgICogcGxhdGZvcm0vbmV0d29yay9EYXRhVVJMRGVjb2Rlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpEYXRhVVJMRGVjb2Rlcjo6ZGVjb2RlUXVldWUpOgorCiAyMDIwLTAxLTI4ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm9wZXJseSBj bGVhciBwZW5kaW5nIGNoYW5nZXMgZHVyaW5nIEFYSXNvbGF0ZWRUcmVlIHJlbW92YWwgYW5kIGFw cGx5UGVuZGluZ0NoYW5nZXMuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL0RhdGFVUkxEZWNvZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvRGF0YVVSTERlY29kZXIuY3BwCmluZGV4IGI1NDFmNjJlZTAwNTIwMzYyYzE1NTdmN2NhNDk2 NGEyMzdiODc0OWQuLmFmYjgxMzNlNWY0ZmI2MWEzZGM1YmI0Mjk2NjFiMWZhY2Y0NTJjNzIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvRGF0YVVSTERlY29kZXIu Y3BwCkBAIC00Myw3ICs0Myw3IEBAIG5hbWVzcGFjZSBEYXRhVVJMRGVjb2RlciB7CiAKIHN0YXRp YyBXb3JrUXVldWUmIGRlY29kZVF1ZXVlKCkKIHsKLSAgICBzdGF0aWMgYXV0byYgcXVldWUgPSBX b3JrUXVldWU6OmNyZWF0ZSgib3JnLndlYmtpdC5EYXRhVVJMRGVjb2RlciIpLmxlYWtSZWYoKTsK KyAgICBzdGF0aWMgYXV0byYgcXVldWUgPSBXb3JrUXVldWU6OmNyZWF0ZSgib3JnLndlYmtpdC5E YXRhVVJMRGVjb2RlciIsIFdvcmtRdWV1ZTo6VHlwZTo6U2VyaWFsLCBXb3JrUXVldWU6OlFPUzo6 VXNlckluaXRpYXRlZCkubGVha1JlZigpOwogICAgIHJldHVybiBxdWV1ZTsKIH0KIAo=