206669 2020-01-23 09:46:02 -0800 [iOS] REGRESSION(r254699) : fast/forms/interactive-validation-remove-node-in-handler.html is timing out 2020-01-24 20:24:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 Lawrence.j rniwa commit-queue rniwa simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1610144 0 Lawrence.j 2020-01-23 09:46:02 -0800 fast/forms/interactive-validation-remove-node-in-handler.html Description: This test is timing out. It looks like this regressed around 254700. I have not tried to reproduce this. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Finteractive-validation-remove-node-in-handler.html Diff: --- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/forms/interactive-validation-remove-node-in-handler-expected.txt +++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/forms/interactive-validation-remove-node-in-handler-actual.txt @@ -1,8 +1 @@ -Should not crash or have an assertion failure if a node was removed during an "invalid" event dispatching for the node. - -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". - - -PASS The form was submitted. -TEST COMPLETE - +TestController::platformResetPreferencesToConsistentValues - Failed to remove presented view controller 1610145 1 webkit-bug-importer 2020-01-23 09:46:34 -0800 <rdar://problem/58837865> 1610965 2 rniwa 2020-01-24 18:41:37 -0800 r254700 only affects WK1 so it can’t be it. It’s most certainly https://trac.webkit.org/r254699. 1610966 3 rniwa 2020-01-24 18:42:29 -0800 Reproduction: run-webkit-tests --debug --ios-simulator --no-retry fast/forms/interactive-validation-remove-node-in-handler.html 1610967 4 rniwa 2020-01-24 18:42:51 -0800 (In reply to Ryosuke Niwa from comment #3) > Reproduction: > run-webkit-tests --debug --ios-simulator --no-retry > fast/forms/interactive-validation-remove-node-in-handler.html Oops, this doesn't work. This does: run-webkit-tests --debug --ios-simulator --no-retry fast/forms/interactive-validation-prevented.html fast/forms/interactive-validation-remove-node-in-handler.html 1610981 5 388756 rniwa 2020-01-24 19:24:15 -0800 Created attachment 388756 Fixes interactive-validation-prevented.html 1610982 6 rniwa 2020-01-24 19:27:36 -0800 I can definitely dismiss the invalidation bubble manually. I'm not certain why WTR doesn't dismiss these bubbles automatically but there are other tests that manually dismiss invalidation bubbles (fast/forms/interactive-validation-select-crash.html) so do that for now. 1610984 7 rniwa 2020-01-24 19:48:34 -0800 (In reply to Ryosuke Niwa from comment #6) > I can definitely dismiss the invalidation bubble manually. I'm not certain > why WTR doesn't dismiss these bubbles automatically but there are other > tests that manually dismiss invalidation bubbles > (fast/forms/interactive-validation-select-crash.html) so do that for now. Apparently Simon deiced that it's better for each test to be cleaning itself up instead of automatically doing it in the test runner so this is expected. 1610986 8 388756 rniwa 2020-01-24 20:24:11 -0800 Comment on attachment 388756 Fixes interactive-validation-prevented.html Clearing flags on attachment: 388756 Committed r255115: <https://trac.webkit.org/changeset/255115> 1610987 9 rniwa 2020-01-24 20:24:13 -0800 All reviewed patches have been landed. Closing bug. 388756 2020-01-24 19:24:15 -0800 2020-01-24 20:24:11 -0800 Fixes interactive-validation-prevented.html bug-206669-20200124192414.patch text/plain 1636 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MDk0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmQ1YTg4OWI5YzYxMGRhYzY1YTdh NGU4N2YyOTY1OWRmMmViNWIzOC4uMGY2ZDZmNTFmZWFiYjQ4YWIwZTQ0MTcxZTdhNGNlMWUwOGQ5 ZTEzYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAxLTI0ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFtpT1NdIFJFR1JFU1NJT04ocjI1NDY5OSkgOiBm YXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tcmVtb3ZlLW5vZGUtaW4taGFuZGxlci5o dG1sIGlzIHRpbWluZyBvdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNjY2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZSB0aW1lb3V0IHdhcyBjYXVzZWQgYnkgdGhlIGludmFsaWRhdGlvbiBidWJi bGUgaW4gaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1wcmV2ZW50ZWQuaHRtbCBuZXZlciBnZXR0aW5n IGNsb3NlZC4KKyAgICAgICAgQWRkcmVzcyB0aGUgaXNzdWUgYnkgZXhwbGljaXRseSBkaXNtaXNz aW5nIHRoZSBpbnZhbGlkYXRpb24gYnViYmxlIGJ5IHNldHRpbmcgYSB2YWx1ZSB0byB0aGUgaW5w dXQgZWxlbWVudC4KKworICAgICAgICAqIGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlv bi1wcmV2ZW50ZWQuaHRtbDoKKwogMjAyMC0wMS0yNCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIE1lZGlhUmVjb3JkZXIucmVxdWVz dERhdGEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFs aWRhdGlvbi1wcmV2ZW50ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3Rp dmUtdmFsaWRhdGlvbi1wcmV2ZW50ZWQuaHRtbAppbmRleCAwNTc5N2IxYjFjZDQwZmY0YTQyZmU5 M2JiOWZmNmI3ZDAyOWM1MzdiLi4xYjk1NTZhMTA2NDA3ODMwMWYwMTgyNWFkNDgxZTk3Nzg1MTc1 MWJkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlk YXRpb24tcHJldmVudGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFj dGl2ZS12YWxpZGF0aW9uLXByZXZlbnRlZC5odG1sCkBAIC0yNyw2ICsyNyw3IEBAIGZ1bmN0aW9u IHN0YXJ0T3JWZXJpZnkoKSB7CiAgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCdzJyku Y2xpY2soKTsKICAgICAgICAgdGVzdFBhc3NlZCgnVGhlIGZvcm0gd2FzIG5vdCBzdWJtaXR0ZWQn KTsKICAgICAgICAgc2hvdWxkQmUoJ2RvY3VtZW50LmFjdGl2ZUVsZW1lbnQnLCAnZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoImkyIiknKTsKKyAgICAgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J2kyJykudmFsdWUgPSAnZm9vJzsgLy8gQ2xvc2UgdGhlIGludmFsaWRhdGlvbiBidWJibGUuCiAg ICAgICAgIGRlYnVnKCdURVNUIENPTVBMRVRFJyk7CiAgICAgfQogCg==