206662 2020-01-23 07:34:55 -0800 [GTK] Reduce the maximum time we wait for draw events in DrawingMonitor 2020-01-24 00:48:55 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=161242 Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply clopez cmarcelo ews-watchlist gyuyoung.kim luiz noam ryuan.choi sergio zeno oldest_to_newest 1610089 0 cgarcia 2020-01-23 07:34:55 -0800 1 second is too much, we can wait up to 100_ms instead and wait for the next frame after 16_ms. We should also ensure there's a draw event since this is called from dispatchAfterEnsuringDrawing(). 1610090 1 388541 cgarcia 2020-01-23 07:36:46 -0800 Created attachment 388541 Patch 1610113 2 388541 clopez 2020-01-23 08:37:47 -0800 Comment on attachment 388541 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388541&action=review r=me > Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:413 > + gtk_widget_queue_draw(m_webPage.viewWidget()); why this was not needed before? 1610561 3 cgarcia 2020-01-24 00:47:46 -0800 Committed r255060: <https://trac.webkit.org/changeset/255060> 1610562 4 cgarcia 2020-01-24 00:48:55 -0800 (In reply to Carlos Alberto Lopez Perez from comment #2) > Comment on attachment 388541 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388541&action=review > > r=me > > > Source/WebKit/UIProcess/CoordinatedGraphics/DrawingAreaProxyCoordinatedGraphics.cpp:413 > > + gtk_widget_queue_draw(m_webPage.viewWidget()); > > why this was not needed before? In some cases, like when there's an animation or after a force repaint, there's already a draw scheduled. When there wasn't we ended up waiting 1 second. Now we ensure a draw, like expected. It doesn't hurt if there was a draw already scheduled. 388541 2020-01-23 07:36:46 -0800 2020-01-23 08:37:47 -0800 Patch wk2-drawing-monitor.diff text/plain 2781 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggODNjZDU2MGY0ZjYuLjk5MTNjYjEyMWM3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDIwLTAxLTIzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBSZWR1Y2UgdGhlIG1heGltdW0gdGltZSB3ZSB3YWl0IGZv ciBkcmF3IGV2ZW50cyBpbiBEcmF3aW5nTW9uaXRvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NjYyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgMSBzZWNvbmQgaXMgdG9vIG11Y2gsIHdlIGNhbiB3YWl0 IHVwIHRvIDEwMF9tcyBpbnN0ZWFkIGFuZCB3YWl0IGZvciB0aGUgbmV4dCBmcmFtZSBhZnRlciAx Nl9tcy4gV2Ugc2hvdWxkIGFsc28KKyAgICAgICAgZW5zdXJlIHRoZXJlJ3MgYSBkcmF3IGV2ZW50 IHNpbmNlIHRoaXMgaXMgY2FsbGVkIGZyb20gZGlzcGF0Y2hBZnRlckVuc3VyaW5nRHJhd2luZygp LgorCisgICAgICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvRHJhd2luZ0FyZWFQ cm94eUNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJl YVByb3h5Q29vcmRpbmF0ZWRHcmFwaGljczo6RHJhd2luZ01vbml0b3I6OnN0YXJ0KToKKyAgICAg ICAgKFdlYktpdDo6RHJhd2luZ0FyZWFQcm94eUNvb3JkaW5hdGVkR3JhcGhpY3M6OkRyYXdpbmdN b25pdG9yOjpkaWREcmF3KToKKwogMjAyMC0wMS0yMSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9y aS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBbV2luXVtXSzJdIFByZXNzaW5nIHNwYWNlIGtl eSBvbiB0ZXh0IGlucHV0IGZvcm0gc2Nyb2xscyB0aGUgcGFnZQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3aW5nQXJlYVByb3h5Q29v cmRpbmF0ZWRHcmFwaGljcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db29yZGluYXRl ZEdyYXBoaWNzL0RyYXdpbmdBcmVhUHJveHlDb29yZGluYXRlZEdyYXBoaWNzLmNwcAppbmRleCA5 NjkzODA5ZTM0ZS4uNzFjODlhOThlZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvRHJhd2luZ0FyZWFQcm94eUNvb3JkaW5hdGVkR3JhcGhp Y3MuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3Mv RHJhd2luZ0FyZWFQcm94eUNvb3JkaW5hdGVkR3JhcGhpY3MuY3BwCkBAIC00MTAsOCArNDEwLDkg QEAgdm9pZCBEcmF3aW5nQXJlYVByb3h5Q29vcmRpbmF0ZWRHcmFwaGljczo6RHJhd2luZ01vbml0 b3I6OnN0YXJ0KFdURjo6RnVuY3Rpb248dm8KICAgICBtX3N0YXJ0VGltZSA9IE1vbm90b25pY1Rp bWU6Om5vdygpOwogICAgIG1fY2FsbGJhY2sgPSBXVEZNb3ZlKGNhbGxiYWNrKTsKICNpZiBQTEFU Rk9STShHVEspCisgICAgZ3RrX3dpZGdldF9xdWV1ZV9kcmF3KG1fd2ViUGFnZS52aWV3V2lkZ2V0 KCkpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChtX3dlYlBhZ2Uudmlld1dpZGdldCgp LCAiZHJhdyIsIHJlaW50ZXJwcmV0X2Nhc3Q8R0NhbGxiYWNrPih3ZWJWaWV3RHJhd0NhbGxiYWNr KSwgdGhpcyk7Ci0gICAgbV90aW1lci5zdGFydE9uZVNob3QoMV9zKTsKKyAgICBtX3RpbWVyLnN0 YXJ0T25lU2hvdCgxMDBfbXMpOwogI2Vsc2UKICAgICBtX3RpbWVyLnN0YXJ0T25lU2hvdCgwX3Mp OwogI2VuZGlmCkBAIC00MzIsMTMgKzQzMywxMyBAQCB2b2lkIERyYXdpbmdBcmVhUHJveHlDb29y ZGluYXRlZEdyYXBoaWNzOjpEcmF3aW5nTW9uaXRvcjo6c3RvcCgpCiAKIHZvaWQgRHJhd2luZ0Fy ZWFQcm94eUNvb3JkaW5hdGVkR3JhcGhpY3M6OkRyYXdpbmdNb25pdG9yOjpkaWREcmF3KCkKIHsK LSAgICAvLyBXZSB3YWl0IHVwIHRvIDEgc2Vjb25kIGZvciBkcmF3IGV2ZW50cy4gSWYgdGhlcmUg YXJlIHNldmVyYWwgZHJhdyBldmVudHMgcXVldWVkIHF1aWNrbHksCisgICAgLy8gV2Ugd2FpdCB1 cCB0byAxMDAgbWlsbGlzZWNvbmRzIGZvciBkcmF3IGV2ZW50cy4gSWYgdGhlcmUgYXJlIHNldmVy YWwgZHJhdyBldmVudHMgcXVldWVkIHF1aWNrbHksCiAgICAgLy8gd2Ugd2FudCB0byB3YWl0IHVu dGlsIGFsbCBvZiB0aGVtIGhhdmUgYmVlbiBwcm9jZXNzZWQsIHNvIGFmdGVyIHJlY2VpdmluZyBh IGRyYXcsIHdlIHdhaXQKLSAgICAvLyB1cCB0byAxMDBtcyBmb3IgdGhlIG5leHQgb25lIG9yIHN0 b3AuCi0gICAgaWYgKE1vbm90b25pY1RpbWU6Om5vdygpIC0gbV9zdGFydFRpbWUgPiAxX3MpCisg ICAgLy8gZm9yIHRoZSBuZXh0IGZyYW1lIG9yIHN0b3AuCisgICAgaWYgKE1vbm90b25pY1RpbWU6 Om5vdygpIC0gbV9zdGFydFRpbWUgPiAxMDBfbXMpCiAgICAgICAgIHN0b3AoKTsKICAgICBlbHNl Ci0gICAgICAgIG1fdGltZXIuc3RhcnRPbmVTaG90KDEwMF9tcyk7CisgICAgICAgIG1fdGltZXIu c3RhcnRPbmVTaG90KDE2X21zKTsKIH0KIAogdm9pZCBEcmF3aW5nQXJlYVByb3h5Q29vcmRpbmF0 ZWRHcmFwaGljczo6ZGlzcGF0Y2hBZnRlckVuc3VyaW5nRHJhd2luZyhXVEY6OkZ1bmN0aW9uPHZv aWQoQ2FsbGJhY2tCYXNlOjpFcnJvcik+JiYgY2FsbGJhY2tGdW5jdGlvbikK