206637 2020-01-22 18:29:56 -0800 `FALLTHROUGH` macro isn't properly defined when building Objective-C files using Clang 2020-01-30 16:15:55 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 conrad_shultz conrad_shultz benjamin cdumez cmarcelo commit-queue conrad_shultz darin dbates ews-watchlist webkit-bug-importer oldest_to_newest 1609912 0 conrad_shultz 2020-01-22 18:29:56 -0800 In the non-C++ case, FALLTHROUGH is defined only when using GCC. 1609913 1 conrad_shultz 2020-01-22 18:30:34 -0800 <rdar://problem/58807878> 1609915 2 webkit-bug-importer 2020-01-22 18:30:49 -0800 <rdar://problem/58820324> 1609918 3 conrad_shultz 2020-01-22 18:32:16 -0800 <rdar://problem/58807878> 1609919 4 388506 conrad_shultz 2020-01-22 18:36:36 -0800 Created attachment 388506 Patch 1609944 5 388506 darin 2020-01-22 20:47:37 -0800 Comment on attachment 388506 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388506&action=review > Source/WTF/wtf/Compiler.h:207 > -#if COMPILER(GCC) > +#if COMPILER(GCC) || (COMPILER(CLANG) && __has_attribute(fallthrough)) Why doesn’t the section above with __has_cpp_attribute work? I believe that’s what’s supposed to cover this. 1609945 6 388506 darin 2020-01-22 20:48:02 -0800 Comment on attachment 388506 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388506&action=review >> Source/WTF/wtf/Compiler.h:207 >> +#if COMPILER(GCC) || (COMPILER(CLANG) && __has_attribute(fallthrough)) > > Why doesn’t the section above with __has_cpp_attribute work? I believe that’s what’s supposed to cover this. Oh, non-C++, I see 1609947 7 388506 darin 2020-01-22 20:48:43 -0800 Comment on attachment 388506 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388506&action=review >>> Source/WTF/wtf/Compiler.h:207 >>> +#if COMPILER(GCC) || (COMPILER(CLANG) && __has_attribute(fallthrough)) >> >> Why doesn’t the section above with __has_cpp_attribute work? I believe that’s what’s supposed to cover this. > > Oh, non-C++, I see Since all the versions of CLANG we compile with have this support, I suggest just writing: #if COMPILE(GCC_COMPATIBLE) 1610346 8 conrad_shultz 2020-01-23 15:07:26 -0800 (In reply to Darin Adler from comment #7) > Comment on attachment 388506 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388506&action=review > > >>> Source/WTF/wtf/Compiler.h:207 > >>> +#if COMPILER(GCC) || (COMPILER(CLANG) && __has_attribute(fallthrough)) > >> > >> Why doesn’t the section above with __has_cpp_attribute work? I believe that’s what’s supposed to cover this. > > > > Oh, non-C++, I see > > Since all the versions of CLANG we compile with have this support, I suggest > just writing: > > #if COMPILE(GCC_COMPATIBLE) In my testing, I found this wasn't always true, so I'd prefer to leave the `__has_attribute` check. Thanks for the review, will sort out what's going on with Windows before landing. 1612154 9 389056 conrad_shultz 2020-01-28 13:53:46 -0800 Created attachment 389056 Patch 1613078 10 389274 conrad_shultz 2020-01-30 11:55:53 -0800 Created attachment 389274 Patch 1613195 11 commit-queue 2020-01-30 16:15:17 -0800 The commit-queue encountered the following flaky tests while processing attachment 389274: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1613196 12 389274 commit-queue 2020-01-30 16:15:53 -0800 Comment on attachment 389274 Patch Clearing flags on attachment: 389274 Committed r255467: <https://trac.webkit.org/changeset/255467> 1613197 13 commit-queue 2020-01-30 16:15:55 -0800 All reviewed patches have been landed. Closing bug. 388506 2020-01-22 18:36:36 -0800 2020-01-28 13:53:45 -0800 Patch bug-206637-20200122183635.patch text/plain 1309 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0OTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUwZjVkOTc4OWVmODYwZDMyNWUxOGVk NzEzMzA1MjJhMTFjZTY0OWEuLjY3YTFlNjdkMjk5NjFjMjc3Yzk4ZWRlZjk3M2UxYzgzYjYzNTBi NzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDEtMjIgIENvbnJhZCBTaHVsdHogIDxjb25y YWRfc2h1bHR6QGFwcGxlLmNvbT4KKworICAgICAgICBgRkFMTFRIUk9VR0hgIG1hY3JvIGlzbid0 IHByb3Blcmx5IGRlZmluZWQgd2hlbiBidWlsZGluZyBPYmplY3RpdmUtQyBmaWxlcyB1c2luZyBD bGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxs b3cgdGhlIGBGQUxMVEhST1VHSGAgbWFjcm8gdG8gYmUgZGVmaW5lZCBwcm9wZXJseSB3aGVuIGJ1 aWxkaW5nIHdpdGggZWl0aGVyIEdDQworICAgICAgICBvciBDbGFuZy4KKworICAgICAgICAqIHd0 Zi9Db21waWxlci5oOgorCiAyMDIwLTAxLTIyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBs ZS5jb20+CiAKICAgICAgICAgW0pTQ10gRGF0ZU1hdGggc2hvdWxkIGFjY2VwdCBtb3JlIElTTy04 NjAxIHRpbWV6b25lIGRlc2lnbmF0b3JzIGV2ZW4gaWYgdGhleSBhcmUgbm90IGluY2x1ZGVkIGlu IEVDTUEyNjIgdG8gcHJvZHVjZSBleHBlY3RlZCByZXN1bHRzIGluIHRoZSB3aWxkIGNvZGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Db21w aWxlci5oCmluZGV4IDE0MWI1MDk1MzFjYWJhMDQ1YjM5NTkwMjc2NDE0MjgxYWNmNmI4YTcuLjg3 ODI4OWVhMWVlNjc5OTI2Y2ViNzkzYTdjMjk5NmVjMzNlMTc4OTQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL0NvbXBpbGVyLmgKKysrIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaApAQCAt MjA0LDcgKzIwNCw3IEBACiAKICNlbGlmICFkZWZpbmVkKEZBTExUSFJPVUdIKSAmJiAhZGVmaW5l ZChfX2NwbHVzcGx1cykKIAotI2lmIENPTVBJTEVSKEdDQykKKyNpZiBDT01QSUxFUihHQ0MpIHx8 IChDT01QSUxFUihDTEFORykgJiYgX19oYXNfYXR0cmlidXRlKGZhbGx0aHJvdWdoKSkKICNkZWZp bmUgRkFMTFRIUk9VR0ggX19hdHRyaWJ1dGVfXyAoKGZhbGx0aHJvdWdoKSkKICNlbmRpZgogCg== 389056 2020-01-28 13:53:46 -0800 2020-01-30 11:55:52 -0800 Patch bug-206637-20200128135345.patch text/plain 1327 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0OTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUwZjVkOTc4OWVmODYwZDMyNWUxOGVk NzEzMzA1MjJhMTFjZTY0OWEuLjY3YTFlNjdkMjk5NjFjMjc3Yzk4ZWRlZjk3M2UxYzgzYjYzNTBi NzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDEtMjIgIENvbnJhZCBTaHVsdHogIDxjb25y YWRfc2h1bHR6QGFwcGxlLmNvbT4KKworICAgICAgICBgRkFMTFRIUk9VR0hgIG1hY3JvIGlzbid0 IHByb3Blcmx5IGRlZmluZWQgd2hlbiBidWlsZGluZyBPYmplY3RpdmUtQyBmaWxlcyB1c2luZyBD bGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWxs b3cgdGhlIGBGQUxMVEhST1VHSGAgbWFjcm8gdG8gYmUgZGVmaW5lZCBwcm9wZXJseSB3aGVuIGJ1 aWxkaW5nIHdpdGggZWl0aGVyIEdDQworICAgICAgICBvciBDbGFuZy4KKworICAgICAgICAqIHd0 Zi9Db21waWxlci5oOgorCiAyMDIwLTAxLTIyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBs ZS5jb20+CiAKICAgICAgICAgW0pTQ10gRGF0ZU1hdGggc2hvdWxkIGFjY2VwdCBtb3JlIElTTy04 NjAxIHRpbWV6b25lIGRlc2lnbmF0b3JzIGV2ZW4gaWYgdGhleSBhcmUgbm90IGluY2x1ZGVkIGlu IEVDTUEyNjIgdG8gcHJvZHVjZSBleHBlY3RlZCByZXN1bHRzIGluIHRoZSB3aWxkIGNvZGUKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Db21w aWxlci5oCmluZGV4IDE0MWI1MDk1MzFjYWJhMDQ1YjM5NTkwMjc2NDE0MjgxYWNmNmI4YTcuLmYx NjljZDU5MDNiY2E3NjVlNTAzYzEyYWFlYTQyMTcwNzNkZmYzZjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL0NvbXBpbGVyLmgKKysrIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaApAQCAt MjA0LDcgKzIwNCw3IEBACiAKICNlbGlmICFkZWZpbmVkKEZBTExUSFJPVUdIKSAmJiAhZGVmaW5l ZChfX2NwbHVzcGx1cykKIAotI2lmIENPTVBJTEVSKEdDQykKKyNpZiBDT01QSUxFUihHQ0NfQ09N UEFUSUJMRSkgJiYgZGVmaW5lZChfX2hhc19hdHRyaWJ1dGUpICYmIF9faGFzX2F0dHJpYnV0ZShm YWxsdGhyb3VnaCkKICNkZWZpbmUgRkFMTFRIUk9VR0ggX19hdHRyaWJ1dGVfXyAoKGZhbGx0aHJv dWdoKSkKICNlbmRpZgogCg== 389274 2020-01-30 11:55:53 -0800 2020-01-30 16:15:53 -0800 Patch bug-206637-20200130115552.patch text/plain 1492 conrad_shultz U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0OTM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDUwZjVkOTc4OWVmODYwZDMyNWUxOGVk NzEzMzA1MjJhMTFjZTY0OWEuLmQwN2EwMzc2MjI2MzQ3MzIzMjAzMGI2NGY3YjIwMTVjNTVjYWIw NTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjAtMDEtMjIgIENvbnJhZCBTaHVsdHogIDxjb25y YWRfc2h1bHR6QGFwcGxlLmNvbT4KKworICAgICAgICBgRkFMTFRIUk9VR0hgIG1hY3JvIGlzbid0 IHByb3Blcmx5IGRlZmluZWQgd2hlbiBidWlsZGluZyBPYmplY3RpdmUtQyBmaWxlcyB1c2luZyBD bGFuZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NjM3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgQWxsb3cg dGhlIGBGQUxMVEhST1VHSGAgbWFjcm8gdG8gYmUgZGVmaW5lZCBwcm9wZXJseSB3aGVuIGJ1aWxk aW5nIHdpdGggZWl0aGVyIEdDQworICAgICAgICBvciBDbGFuZy4KKworICAgICAgICAqIHd0Zi9D b21waWxlci5oOgorCiAyMDIwLTAxLTIyICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5j b20+CiAKICAgICAgICAgW0pTQ10gRGF0ZU1hdGggc2hvdWxkIGFjY2VwdCBtb3JlIElTTy04NjAx IHRpbWV6b25lIGRlc2lnbmF0b3JzIGV2ZW4gaWYgdGhleSBhcmUgbm90IGluY2x1ZGVkIGluIEVD TUEyNjIgdG8gcHJvZHVjZSBleHBlY3RlZCByZXN1bHRzIGluIHRoZSB3aWxkIGNvZGUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XVEYvd3RmL0NvbXBpbGVyLmggYi9Tb3VyY2UvV1RGL3d0Zi9Db21waWxl ci5oCmluZGV4IDE0MWI1MDk1MzFjYWJhMDQ1YjM5NTkwMjc2NDE0MjgxYWNmNmI4YTcuLjQzNzRj YjNhZjIzYzg5YmI1MzQ5NDY5ZGM4OGVmYzY0NDYxNGE0N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X VEYvd3RmL0NvbXBpbGVyLmgKKysrIGIvU291cmNlL1dURi93dGYvQ29tcGlsZXIuaApAQCAtMjA0 LDkgKzIwNCwxMiBAQAogCiAjZWxpZiAhZGVmaW5lZChGQUxMVEhST1VHSCkgJiYgIWRlZmluZWQo X19jcGx1c3BsdXMpCiAKLSNpZiBDT01QSUxFUihHQ0MpCisjaWYgQ09NUElMRVIoR0NDX0NPTVBB VElCTEUpICYmIGRlZmluZWQoX19oYXNfYXR0cmlidXRlKQorLy8gQnJlYWsgb3V0IHRoaXMgI2lm IHRvIHNhdGlzeSBzb21lIHZlcnNpb25zIFdpbmRvd3MgY29tcGlsZXJzLgorI2lmIF9faGFzX2F0 dHJpYnV0ZShmYWxsdGhyb3VnaCkKICNkZWZpbmUgRkFMTFRIUk9VR0ggX19hdHRyaWJ1dGVfXyAo KGZhbGx0aHJvdWdoKSkKICNlbmRpZgorI2VuZGlmCiAKICNlbmRpZiAvLyAhZGVmaW5lZChGQUxM VEhST1VHSCkgJiYgZGVmaW5lZChfX2NwbHVzcGx1cykgJiYgZGVmaW5lZChfX2hhc19jcHBfYXR0 cmlidXRlKQogCg==