206625 2020-01-22 16:02:48 -0800 Try adding glBindFramebuffer flush workaround to ANGLE as remedy for flaky WebGL tests 2020-07-08 16:01:07 -0700 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206318 205483 214104 1 kbr kbr commit-queue dino ews-watchlist graouts jdarpinian justin_fan kondapallykalyan webkit-bug-importer oldest_to_newest 1609828 0 kbr 2020-01-22 16:02:48 -0800 An attempt was made recently in bug 205483 / https://trac.webkit.org/changeset/253926 to switch WebKit's WebGL implementation to use ANGLE by default. Unfortunately, a significant number of tests became flaky after that transition, as can be seen from the bugs linked from bug 205483. Some of these flakes have been triaged and a couple have been addressed. However, a few of the most concerning bugs have not been reproducible on any machines except the bots. ANGLE virtualizes OpenGL contexts on top of one hardware context; this is probably the essential difference compared to WebKit's current WebGL backend, which uses a separate CGLContextObj per WebGL context. Chromium on Mac using ANGLE (which is not the current shipping configuration, but is being tested) does not exhibit these flakes. We suspect that some glFlushes which were added to Chromium to address unexplained crashes in the OpenGL driver may be the reason. There is a known driver bug affecting Intel GPUs on a couple of configurations described in https://bugs.chromium.org/p/chromium/issues/detail?id=1018028 . There is a hypothesis that adding that workaround - amounting to calling glFlush before glBindFramebuffer - might work around the widespread flakiness seen on the bots with the ANGLE switch. After ANGLE is updated in bug 206318, we plan to add that workaround to WebKit's copy of ANGLE, and then try switching ANGLE on again. If the tests aren't flaky, we can try disabling the workaround and see whether that workaround is responsible. If they are still flaky, we can disable ANGLE again and redouble our efforts to reproduce the flakiness and find a more robust workaround. 1610454 1 kbr 2020-01-23 18:02:16 -0800 ANGLE was rolled but was reverted. A new ANGLE roll will have to be done before this is attempted. 1615477 2 389929 kbr 2020-02-05 18:30:34 -0800 Created attachment 389929 Patch 1615478 3 ews-watchlist 2020-02-05 18:31:40 -0800 Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE 1615479 4 kbr 2020-02-05 18:32:05 -0800 ANGLE has been rolled forward - should consider adding this driver bug workaround now. Tested minimally locally, but even without this patch, wasn't able to reproduce the flaky failures that were seen on the WebKit test bots. 1615852 5 389929 commit-queue 2020-02-06 14:59:47 -0800 Comment on attachment 389929 Patch Rejecting attachment 389929 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 389929, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Traceback (most recent call last): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 80, in <module> main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: https://webkit-queues.webkit.org/results/13318059 1615890 6 389929 kbr 2020-02-06 15:36:32 -0800 Comment on attachment 389929 Patch Could we try the CQ again? I think the r/cq bits got set in the wrong order. 1616373 7 389929 commit-queue 2020-02-07 14:31:27 -0800 Comment on attachment 389929 Patch Rejecting attachment 389929 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 389929, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Traceback (most recent call last): File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 80, in <module> main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch", line 75, in main WebKitPatch(os.path.abspath(__file__)).main() File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main result = command.check_arguments_and_execute(options, args, self) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute self._sequence.run_and_handle_errors(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors self._run(tool, options, state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run step(tool, options).run(state) File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 54, in run if changelog_entry.has_valid_reviewer(): AttributeError: 'NoneType' object has no attribute 'has_valid_reviewer' Full output: https://webkit-queues.webkit.org/results/13318772 1616393 8 jdarpinian 2020-02-07 15:01:17 -0800 Hmm. In the past this happened to me when I accidentally deleted the "Reviewed by NOBODY (OOPS!)." line from my changelog. But your change seems to have that. Is the formatting somehow different than it normally expects? 1616396 9 kbr 2020-02-07 15:03:23 -0800 (In reply to James Darpinian from comment #8) > Hmm. In the past this happened to me when I accidentally deleted the > "Reviewed by NOBODY (OOPS!)." line from my changelog. But your change seems > to have that. Is the formatting somehow different than it normally expects? Based on the emails I got, I think the cq+ bit was accidentally set just before the r+ bit. 1616408 10 390135 kbr 2020-02-07 15:23:06 -0800 Created attachment 390135 Patch 1616410 11 kbr 2020-02-07 15:23:55 -0800 Argh - in the old patch I somehow deleted the leading "2" in "2020" - so the date was invalid. Fixed in the revised patch. 1616434 12 390135 commit-queue 2020-02-07 16:03:32 -0800 Comment on attachment 390135 Patch Clearing flags on attachment: 390135 Committed r256076: <https://trac.webkit.org/changeset/256076> 1616435 13 commit-queue 2020-02-07 16:03:34 -0800 All reviewed patches have been landed. Closing bug. 1616438 14 webkit-bug-importer 2020-02-07 16:07:51 -0800 <rdar://problem/59277628> 389929 2020-02-05 18:30:34 -0800 2020-02-07 15:23:04 -0800 Patch bug-206625-20200205183033.patch text/plain 3560 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1ODY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOGFiNjViN2JmNjY3MzQ1NmUzNTNkOWU2YjQwMWQ3MTZhMDdhZGJmOS4uMDllNjUxNzQyYzRj YTdiNTBhNzQwZWNjNzE2MWM1NDY4MTFhNWQwNSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACiswMjAtMDItMDUgIEtlbm5ldGggUnVzc2VsbCAgPGtickBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgVHJ5IGFkZGluZyBnbEJpbmRGcmFtZWJ1ZmZlciBmbHVzaCB3 b3JrYXJvdW5kIHRvIEFOR0xFIGFzIHJlbWVkeSBmb3IgZmxha3kgV2ViR0wgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjYyNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5jbHVkZS9wbGF0 Zm9ybS9GZWF0dXJlc0dMLmg6CisgICAgICAgICogc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL1N0 YXRlTWFuYWdlckdMLmNwcDoKKyAgICAgICAgKHJ4OjpTdGF0ZU1hbmFnZXJHTDo6YmluZEZyYW1l YnVmZmVyKToKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvcmVuZGVyZXJnbF91 dGlscy5jcHA6CisgICAgICAgIChyeDo6bmF0aXZlZ2xfZ2w6OkluaXRpYWxpemVGZWF0dXJlcyk6 CisKIDIwMjAtMDItMDUgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAg IEZpeCBNYWNDYXRhbHlzdCBidWlsZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL2luY2x1ZGUvcGxhdGZvcm0vRmVhdHVyZXNHTC5oIGIvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvaW5jbHVkZS9wbGF0Zm9ybS9GZWF0dXJlc0dMLmgKaW5kZXggZTc0MDM3MjJjYWUyOGFmNTYz NTIxZTkzODM4YTBmNmJjZDRkNTBlZS4uMGY2NDlkYjJhZDBjMDM5MDFkZmQyNzhiNzNhNmExODZm YjcwYzk4YyAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9wbGF0 Zm9ybS9GZWF0dXJlc0dMLmgKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvaW5jbHVkZS9w bGF0Zm9ybS9GZWF0dXJlc0dMLmgKQEAgLTQxMSw2ICs0MTEsMTIgQEAgc3RydWN0IEZlYXR1cmVz R0wgOiBGZWF0dXJlU2V0QmFzZQogICAgICAgICAicmV3cml0ZV9yb3dfbWFqb3JfbWF0cmljZXMi LCBGZWF0dXJlQ2F0ZWdvcnk6Ok9wZW5HTFdvcmthcm91bmRzLAogICAgICAgICAiUmV3cml0ZSBy b3cgbWFqb3IgbWF0cmljZXMgaW4gc2hhZGVycyBhcyBjb2x1bW4gbWFqb3IgYXMgYSBkcml2ZXIg YnVnIHdvcmthcm91bmQiLAogICAgICAgICAmbWVtYmVycywgImh0dHA6Ly9hbmdsZWJ1Zy5jb20v MjI3MyJ9OworCisgICAgLy8gRmx1c2ggYmVmb3JlIGdsQmluZEZyYW1lYnVmZmVyIGFzIGEgZHJp dmVyIGJ1ZyB3b3JrYXJvdW5kIGlmIG5lY2Vzc2FyeS4KKyAgICBGZWF0dXJlIGZsdXNoQmVmb3Jl QmluZEZyYW1lYnVmZmVyID0geworICAgICAgICAiZmx1c2hfYmVmb3JlX2JpbmRmcmFtZWJ1ZmZl ciIsIEZlYXR1cmVDYXRlZ29yeTo6T3BlbkdMV29ya2Fyb3VuZHMsCisgICAgICAgICJGbHVzaCBi ZWZvcmUgZ2xCaW5kRnJhbWVidWZmZXIgYXMgYSBkcml2ZXIgYnVnIHdvcmthcm91bmQiLAorICAg ICAgICAmbWVtYmVycywgImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MDY2MjUifTsKIH07CiAKIGlubGluZSBGZWF0dXJlc0dMOjpGZWF0dXJlc0dMKCkgID0gZGVmYXVs dDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5k ZXJlci9nbC9TdGF0ZU1hbmFnZXJHTC5jcHAgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMv bGliQU5HTEUvcmVuZGVyZXIvZ2wvU3RhdGVNYW5hZ2VyR0wuY3BwCmluZGV4IDkzZjk3OTQ4NjYy NGQxMGU2MDRmNDIyNTkwMDRmM2U2YTk4OWIzOWMuLjY4OTcyNjYxZmYyMzQwMmM3ZGU3ZTIxOTVh YzUwMWYxZmFmNDc4ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9s aWJBTkdMRS9yZW5kZXJlci9nbC9TdGF0ZU1hbmFnZXJHTC5jcHAKKysrIGIvU291cmNlL1RoaXJk UGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL1N0YXRlTWFuYWdlckdMLmNwcApA QCAtNTg2LDYgKzU4Niw5IEBAIHZvaWQgU3RhdGVNYW5hZ2VyR0w6OnNldFBpeGVsUGFja0J1ZmZl cihjb25zdCBnbDo6QnVmZmVyICpwaXhlbEJ1ZmZlcikKIAogdm9pZCBTdGF0ZU1hbmFnZXJHTDo6 YmluZEZyYW1lYnVmZmVyKEdMZW51bSB0eXBlLCBHTHVpbnQgZnJhbWVidWZmZXIpCiB7CisgICAg aWYgKG1GZWF0dXJlcy5mbHVzaEJlZm9yZUJpbmRGcmFtZWJ1ZmZlci5lbmFibGVkKQorICAgICAg ICBtRnVuY3Rpb25zLT5mbHVzaCgpOworCiAgICAgc3dpdGNoICh0eXBlKQogICAgIHsKICAgICAg ICAgY2FzZSBHTF9GUkFNRUJVRkZFUjoKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L0FO R0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9yZW5kZXJlcmdsX3V0aWxzLmNwcCBiL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9yZW5kZXJlcmdsX3V0 aWxzLmNwcAppbmRleCA1N2M3ZGRmY2M0Y2M4ODc5NTA2ZjFiNWVhNjNiMzY3OTJkNzY4MTRjLi41 MWYxNzk3ZGY4ZjM0OThlNmM4MDEwMTdkNTM1ZGM5OWRmOGU1NjVmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvcmVuZGVyZXJnbF91 dGlscy5jcHAKKysrIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRl cmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3BwCkBAIC0xNjQ5LDYgKzE2NDksOSBAQCB2b2lkIElu aXRpYWxpemVGZWF0dXJlcyhjb25zdCBGdW5jdGlvbnNHTCAqZnVuY3Rpb25zLCBhbmdsZTo6RmVh dHVyZXNHTCAqZmVhdHVyZQogICAgICAgICAgICAgICAgICAgICAgICAgICAgIC8vIElzQXBwbGUo KSAmJiBmdW5jdGlvbnMtPnN0YW5kYXJkID09IFNUQU5EQVJEX0dMX0RFU0tUT1ApOwogICAgICAg ICAgICAgICAgICAgICAgICAgICAgIC8vIFRPRE8oYW5nbGVidWcuY29tLzIyNzMpOiBkaWFnbm9z ZSBjcmFzaGVzIHdpdGggdGhpcyB3b3JrYXJvdW5kLgogICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGZhbHNlKTsKKworICAgIC8vIGJ1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2 NjI1CisgICAgQU5HTEVfRkVBVFVSRV9DT05ESVRJT04oZmVhdHVyZXMsIGZsdXNoQmVmb3JlQmlu ZEZyYW1lYnVmZmVyLCBJc0FwcGxlKCkgJiYgaXNJbnRlbCk7CiB9CiAKIHZvaWQgSW5pdGlhbGl6 ZUZyb250ZW5kRmVhdHVyZXMoY29uc3QgRnVuY3Rpb25zR0wgKmZ1bmN0aW9ucywgYW5nbGU6OkZy b250ZW5kRmVhdHVyZXMgKmZlYXR1cmVzKQo= 390135 2020-02-07 15:23:06 -0800 2020-02-07 16:03:32 -0800 Patch bug-206625-20200207152305.patch text/plain 3559 kbr U3VidmVyc2lvbiBSZXZpc2lvbjogMjU2MDcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOGFiNjViN2JmNjY3MzQ1NmUzNTNkOWU2YjQwMWQ3MTZhMDdhZGJmOS4uZThhM2Y4OWJmYTA5 ZDI2ZmU3ZDczM2UxNjdlOGFjYmZkOTk0ZTc0OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAyLTA1ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAY2hy b21pdW0ub3JnPgorCisgICAgICAgIFRyeSBhZGRpbmcgZ2xCaW5kRnJhbWVidWZmZXIgZmx1c2gg d29ya2Fyb3VuZCB0byBBTkdMRSBhcyByZW1lZHkgZm9yIGZsYWt5IFdlYkdMIHRlc3RzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY2MjUKKworICAg ICAgICBSZXZpZXdlZCBieSBEZWFuIEphY2tzb24uCisKKyAgICAgICAgKiBpbmNsdWRlL3BsYXRm b3JtL0ZlYXR1cmVzR0wuaDoKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvU3Rh dGVNYW5hZ2VyR0wuY3BwOgorICAgICAgICAocng6OlN0YXRlTWFuYWdlckdMOjpiaW5kRnJhbWVi dWZmZXIpOgorICAgICAgICAqIHNyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9yZW5kZXJlcmdsX3V0 aWxzLmNwcDoKKyAgICAgICAgKHJ4OjpuYXRpdmVnbF9nbDo6SW5pdGlhbGl6ZUZlYXR1cmVzKToK KwogMjAyMC0wMi0wNSAgRGVhbiBKYWNrc29uICA8ZGlub0BhcHBsZS5jb20+CiAKICAgICAgICAg Rml4IE1hY0NhdGFseXN0IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvaW5jbHVkZS9wbGF0Zm9ybS9GZWF0dXJlc0dMLmggYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdM RS9pbmNsdWRlL3BsYXRmb3JtL0ZlYXR1cmVzR0wuaAppbmRleCBlNzQwMzcyMmNhZTI4YWY1NjM1 MjFlOTM4MzhhMGY2YmNkNGQ1MGVlLi4wZjY0OWRiMmFkMGMwMzkwMWRmZDI3OGI3M2E2YTE4NmZi NzBjOThjIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL3BsYXRm b3JtL0ZlYXR1cmVzR0wuaAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9pbmNsdWRlL3Bs YXRmb3JtL0ZlYXR1cmVzR0wuaApAQCAtNDExLDYgKzQxMSwxMiBAQCBzdHJ1Y3QgRmVhdHVyZXNH TCA6IEZlYXR1cmVTZXRCYXNlCiAgICAgICAgICJyZXdyaXRlX3Jvd19tYWpvcl9tYXRyaWNlcyIs IEZlYXR1cmVDYXRlZ29yeTo6T3BlbkdMV29ya2Fyb3VuZHMsCiAgICAgICAgICJSZXdyaXRlIHJv dyBtYWpvciBtYXRyaWNlcyBpbiBzaGFkZXJzIGFzIGNvbHVtbiBtYWpvciBhcyBhIGRyaXZlciBi dWcgd29ya2Fyb3VuZCIsCiAgICAgICAgICZtZW1iZXJzLCAiaHR0cDovL2FuZ2xlYnVnLmNvbS8y MjczIn07CisKKyAgICAvLyBGbHVzaCBiZWZvcmUgZ2xCaW5kRnJhbWVidWZmZXIgYXMgYSBkcml2 ZXIgYnVnIHdvcmthcm91bmQgaWYgbmVjZXNzYXJ5LgorICAgIEZlYXR1cmUgZmx1c2hCZWZvcmVC aW5kRnJhbWVidWZmZXIgPSB7CisgICAgICAgICJmbHVzaF9iZWZvcmVfYmluZGZyYW1lYnVmZmVy IiwgRmVhdHVyZUNhdGVnb3J5OjpPcGVuR0xXb3JrYXJvdW5kcywKKyAgICAgICAgIkZsdXNoIGJl Zm9yZSBnbEJpbmRGcmFtZWJ1ZmZlciBhcyBhIGRyaXZlciBidWcgd29ya2Fyb3VuZCIsCisgICAg ICAgICZtZW1iZXJzLCAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIw NjYyNSJ9OwogfTsKIAogaW5saW5lIEZlYXR1cmVzR0w6OkZlYXR1cmVzR0woKSAgPSBkZWZhdWx0 OwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRl cmVyL2dsL1N0YXRlTWFuYWdlckdMLmNwcCBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9s aWJBTkdMRS9yZW5kZXJlci9nbC9TdGF0ZU1hbmFnZXJHTC5jcHAKaW5kZXggOTNmOTc5NDg2NjI0 ZDEwZTYwNGY0MjI1OTAwNGYzZTZhOTg5YjM5Yy4uNjg5NzI2NjFmZjIzNDAyYzdkZTdlMjE5NWFj NTAxZjFmYWY0Nzg4OCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xp YkFOR0xFL3JlbmRlcmVyL2dsL1N0YXRlTWFuYWdlckdMLmNwcAorKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvZ2wvU3RhdGVNYW5hZ2VyR0wuY3BwCkBA IC01ODYsNiArNTg2LDkgQEAgdm9pZCBTdGF0ZU1hbmFnZXJHTDo6c2V0UGl4ZWxQYWNrQnVmZmVy KGNvbnN0IGdsOjpCdWZmZXIgKnBpeGVsQnVmZmVyKQogCiB2b2lkIFN0YXRlTWFuYWdlckdMOjpi aW5kRnJhbWVidWZmZXIoR0xlbnVtIHR5cGUsIEdMdWludCBmcmFtZWJ1ZmZlcikKIHsKKyAgICBp ZiAobUZlYXR1cmVzLmZsdXNoQmVmb3JlQmluZEZyYW1lYnVmZmVyLmVuYWJsZWQpCisgICAgICAg IG1GdW5jdGlvbnMtPmZsdXNoKCk7CisKICAgICBzd2l0Y2ggKHR5cGUpCiAgICAgewogICAgICAg ICBjYXNlIEdMX0ZSQU1FQlVGRkVSOgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5H TEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRpbHMuY3BwIGIvU291cmNl L1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFOR0xFL3JlbmRlcmVyL2dsL3JlbmRlcmVyZ2xfdXRp bHMuY3BwCmluZGV4IDU3YzdkZGZjYzRjYzg4Nzk1MDZmMWI1ZWE2M2IzNjc5MmQ3NjgxNGMuLjUx ZjE3OTdkZjhmMzQ5OGU2YzgwMTAxN2Q1MzVkYzk5ZGY4ZTU2NWYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9nbC9yZW5kZXJlcmdsX3V0 aWxzLmNwcAorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVy ZXIvZ2wvcmVuZGVyZXJnbF91dGlscy5jcHAKQEAgLTE2NDksNiArMTY0OSw5IEBAIHZvaWQgSW5p dGlhbGl6ZUZlYXR1cmVzKGNvbnN0IEZ1bmN0aW9uc0dMICpmdW5jdGlvbnMsIGFuZ2xlOjpGZWF0 dXJlc0dMICpmZWF0dXJlCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gSXNBcHBsZSgp ICYmIGZ1bmN0aW9ucy0+c3RhbmRhcmQgPT0gU1RBTkRBUkRfR0xfREVTS1RPUCk7CiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLy8gVE9ETyhhbmdsZWJ1Zy5jb20vMjI3Myk6IGRpYWdub3Nl IGNyYXNoZXMgd2l0aCB0aGlzIHdvcmthcm91bmQuCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgZmFsc2UpOworCisgICAgLy8gYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY2 MjUKKyAgICBBTkdMRV9GRUFUVVJFX0NPTkRJVElPTihmZWF0dXJlcywgZmx1c2hCZWZvcmVCaW5k RnJhbWVidWZmZXIsIElzQXBwbGUoKSAmJiBpc0ludGVsKTsKIH0KIAogdm9pZCBJbml0aWFsaXpl RnJvbnRlbmRGZWF0dXJlcyhjb25zdCBGdW5jdGlvbnNHTCAqZnVuY3Rpb25zLCBhbmdsZTo6RnJv bnRlbmRGZWF0dXJlcyAqZmVhdHVyZXMpCg==