206618 2020-01-22 15:23:52 -0800 Fix iOS 13.2 iphoneos build 2020-01-23 08:24:17 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206620 InRadar P2 Normal --- 1 jbedard jbedard aakash_jain ap commit-queue dbates ews-watchlist jlewis3 krollin webkit-bug-importer oldest_to_newest 1609774 0 jbedard 2020-01-22 15:23:52 -0800 WebKit doesn't build on iOS 13.2 for iphoneos. We need to make a few modifications to our build scripts to make it build. 1609783 1 388477 jbedard 2020-01-22 15:35:56 -0800 Created attachment 388477 Patch 1609829 2 388477 ap 2020-01-22 16:05:32 -0800 Comment on attachment 388477 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388477&action=review > Tools/Scripts/webkitdirs.pm:884 > + push @options, "-IDEProvisioningProfileSupportRelaxed=YES"; Maybe limit this to embedded platforms? It will be a little confusing when looking at macOS logs for future unrelated failures. 1609858 3 jbedard 2020-01-22 16:52:56 -0800 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 388477 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388477&action=review > > > Tools/Scripts/webkitdirs.pm:884 > > + push @options, "-IDEProvisioningProfileSupportRelaxed=YES"; > > Maybe limit this to embedded platforms? It will be a little confusing when > looking at macOS logs for future unrelated failures. We could do this and fix our immediate problem. But https://bugs.webkit.org/show_bug.cgi?id=206620 would just end up undoing that. We don't pass platform arguments to webkitdirs when doing make, and I had trouble thinking up a situation where relaxing provisioning rules was wrong. If we think we want to continue passing platform specific arguments to xcodebuild, we need to pass the platform we're using to webkitdirs when running make. 1609869 4 388491 jbedard 2020-01-22 17:14:47 -0800 Created attachment 388491 Patch 1609873 5 jbedard 2020-01-22 17:19:17 -0800 Talked a bit with Alexey about this offline. My reason for applying this argument globally was some issues with https://bugs.webkit.org/show_bug.cgi?id=206620, but that is actually indicative of a larger bug in how make invokes webkitdirs. For now, we'll do this for embedded builds only, and address the make issues in https://bugs.webkit.org/show_bug.cgi?id=206620. 1610087 6 388491 commit-queue 2020-01-23 07:17:40 -0800 Comment on attachment 388491 Patch Rejecting attachment 388491 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 388491, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=388491&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=206618&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 388491 from bug 206618. Fetching: https://bugs.webkit.org/attachment.cgi?id=388491 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm Hunk #1 FAILED at 888. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13310391 1610109 7 jbedard 2020-01-23 08:23:30 -0800 Committed r254978: <https://trac.webkit.org/changeset/254978> 1610110 8 webkit-bug-importer 2020-01-23 08:24:17 -0800 <rdar://problem/58835552> 388477 2020-01-22 15:35:56 -0800 2020-01-22 17:14:38 -0800 Patch bug-206618-20200122153555.patch text/plain 1346 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NDk0OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggaU9TIDEzLjIgaXBob25lb3MgYnVpbGQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjYxOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBt OgorICAgICAgICAoWGNvZGVPcHRpb25zKTogUmVsYXggcHJvdmlzaW9uaW5nIHByb2ZpbGUgcnVs ZXMuCisKIDIwMjAtMDEtMjIgIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgog CiAgICAgICAgIHdlYmtpdHB5OiBXZWJTb2NrZXQgc2VydmVyIGRvZXNuJ3Qgc3VwcG9ydCBQeXRo b24gMyAoV29ya2Fyb3VuZCkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0JKHJldmlzaW9uIDI1NDg3NykK KysrIFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkod29ya2luZyBjb3B5KQpAQCAtODgxLDYg Kzg4MSw3IEBAIHN1YiBYY29kZU9wdGlvbnMKICAgICBteSBAb3B0aW9uczsKICAgICBwdXNoIEBv cHRpb25zLCAiLVVzZVNhbml0aXplZEJ1aWxkU3lzdGVtRW52aXJvbm1lbnQ9WUVTIjsKICAgICBw dXNoIEBvcHRpb25zLCAiLVNob3dCdWlsZE9wZXJhdGlvbkR1cmF0aW9uPVlFUyI7CisgICAgcHVz aCBAb3B0aW9ucywgIi1JREVQcm92aXNpb25pbmdQcm9maWxlU3VwcG9ydFJlbGF4ZWQ9WUVTIjsK ICAgICBwdXNoIEBvcHRpb25zLCAoIi1jb25maWd1cmF0aW9uIiwgJGNvbmZpZ3VyYXRpb24pOwog ICAgIHB1c2ggQG9wdGlvbnMsICgiLXhjY29uZmlnIiwgc291cmNlRGlyKCkgLiAiL1Rvb2xzL2Fz YW4vYXNhbi54Y2NvbmZpZyIsICJBU0FOX0lHTk9SRT0iIC4gc291cmNlRGlyKCkgLiAiL1Rvb2xz L2FzYW4vd2Via2l0LWFzYW4taWdub3JlLnR4dCIpIGlmICRhc2FuSXNFbmFibGVkOwogICAgIHB1 c2ggQG9wdGlvbnMsICgiR0NDX09QVElNSVpBVElPTl9MRVZFTD0kZm9yY2VPcHRpbWl6YXRpb25M ZXZlbCIpIGlmICRmb3JjZU9wdGltaXphdGlvbkxldmVsOwo= 388491 2020-01-22 17:14:47 -0800 2020-01-23 07:17:40 -0800 Patch bug-206618-20200122171446.patch text/plain 1449 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NDk1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggaU9TIDEzLjIgaXBob25lb3MgYnVpbGQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjYxOAorCisgICAgICAgIFJldmll d2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRp cnMucG06CisgICAgICAgIChYY29kZU9wdGlvbnMpOiBSZWxheCBwcm92aXNpb25pbmcgcHJvZmls ZSBydWxlcyBvbiBlbWJlZGRlZCBTREtzLgorCiAyMDIwLTAxLTIyICBCcmFkeSBFaWRzb24gIDxi ZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChyMjUzNTE5KTogW1dLV2Vi VmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6Y29tcGxldGlvbkhhbmRsZXI6XSBnaXZlcyBhIG5vbi1u aWwsIG5vbi1FcnJvciByZXN1bHQgZXZlbiB3aGVuIEphdmFTY3JpcHQgY2Fubm90IGJlIGV2YWx1 YXRlZApJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQkocmV2aXNpb24gMjU0OTUzKQorKysgVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtCSh3b3JraW5nIGNvcHkpCkBAIC04ODgsNyArODg4LDggQEAgc3Vi IFhjb2RlT3B0aW9ucwogICAgIHB1c2ggQG9wdGlvbnMsIEBiYXNlUHJvZHVjdERpck9wdGlvbjsK ICAgICBwdXNoIEBvcHRpb25zLCAiQVJDSFM9JGFyY2hpdGVjdHVyZSIgaWYgJGFyY2hpdGVjdHVy ZTsKICAgICBwdXNoIEBvcHRpb25zLCAiU0RLUk9PVD0keGNvZGVTREsiIGlmICR4Y29kZVNESzsK LSAgICBpZiAod2lsbFVzZUlPU0RldmljZVNESygpKSB7CisgICAgaWYgKHdpbGxVc2VJT1NEZXZp Y2VTREsoKSB8fCB3aWxsVXNlV2F0Y2hEZXZpY2VTREsoKSB8fCB3aWxsVXNlQXBwbGVUVkRldmlj ZVNESygpKSB7CisgICAgICAgIHB1c2ggQG9wdGlvbnMsICItSURFUHJvdmlzaW9uaW5nUHJvZmls ZVN1cHBvcnRSZWxheGVkPVlFUyI7CiAgICAgICAgIHB1c2ggQG9wdGlvbnMsICJFTkFCTEVfQklU Q09ERT1OTyI7CiAgICAgICAgIGlmIChoYXNJT1NEZXZlbG9wbWVudENlcnRpZmljYXRlKCkpIHsK ICAgICAgICAgICAgICMgRklYTUU6IE1heSBtYXRjaCBtb3JlIHRoYW4gb25lIGluc3RhbGxlZCBk ZXZlbG9wbWVudCBjZXJ0aWZpY2F0ZS4K