206610 2020-01-22 13:51:18 -0800 Crash in RenderBlockFlow::adjustLinePositionForPagination() with complex line without root box 2020-01-30 10:07:17 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Local Build Mac macOS 10.15 RESOLVED FIXED InRadar P2 Normal --- 1 dougk webkit-unassigned bfulgham commit-queue darin esprehn+autocc ews-watchlist glenn kondapallykalyan pdr sam simon.fraser webkit-bug-importer zalan oldest_to_newest 1609731 0 dougk 2020-01-22 13:51:18 -0800 If RenderBlockFlow::adjustLinePositionForPagination() encounters a line with no root box, the result will be a crash with a null pointer dereference. 1609732 1 dougk 2020-01-22 13:51:56 -0800 <rdar://problem/57073037> 1609756 2 388472 dougk 2020-01-22 14:38:38 -0800 Created attachment 388472 Patch 1609943 3 388472 sam 2020-01-22 20:35:15 -0800 Comment on attachment 388472 Patch Is everything in that test case needed to trigger the crash (there is a lot of craziness in there)? Seems like it can probably be reduced further? 1610163 4 dougk 2020-01-23 10:05:53 -0800 (In reply to Sam Weinig from comment #3) > Comment on attachment 388472 [details] > Patch > > Is everything in that test case needed to trigger the crash (there is a lot > of craziness in there)? Seems like it can probably be reduced further? Yeah, I tried to reduce the number of "strange" things in the test case that would still trigger the crash, and this was what I came up with. If someone more familiar with the code knows a more direct means to trigger the same state/crash, I can't say how happy I'd be to replace this test case. :) 1610215 5 388565 zalan 2020-01-23 11:20:15 -0800 Created attachment 388565 Test reduction 1610228 6 388472 zalan 2020-01-23 11:37:35 -0800 Comment on attachment 388472 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388472&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:1813 > + if (!firstRootBox) > + return; I think what we want here is to ignore the firstRootBox when it is nullptr but still call setPaginationStrut() (not that it matters since this is such an edge case) (and please use the attached test reduction) 1610683 7 sam 2020-01-24 08:11:55 -0800 (In reply to Doug Kelly from comment #4) > (In reply to Sam Weinig from comment #3) > > Comment on attachment 388472 [details] > > Patch > > > > Is everything in that test case needed to trigger the crash (there is a lot > > of craziness in there)? Seems like it can probably be reduced further? > > Yeah, I tried to reduce the number of "strange" things in the test case that > would still trigger the crash, and this was what I came up with. If someone > more familiar with the code knows a more direct means to trigger the same > state/crash, I can't say how happy I'd be to replace this test case. :) Oh drat, looks like Zalan beat me to it. His is good. 1610882 8 388731 dougk 2020-01-24 15:24:10 -0800 Created attachment 388731 Patch 1610885 9 dougk 2020-01-24 15:39:11 -0800 Thanks Zalan/Sam. :) Incorporated the suggestions, and the much simpler test case. 1611048 10 388731 darin 2020-01-25 09:05:15 -0800 Comment on attachment 388731 Patch Would be even better if the test covered correct behavior as well as the lack of a crash. 1611114 11 dougk 2020-01-25 15:38:40 -0800 (In reply to Darin Adler from comment #10) > Comment on attachment 388731 [details] > Patch > > Would be even better if the test covered correct behavior as well as the > lack of a crash. I agree — testing the behavior here would be best, but I’ll need help from someone (Sam or Zalan?) to understand what the correct behavior in this case is. Thanks! 1613016 12 388731 commit-queue 2020-01-30 10:07:15 -0800 Comment on attachment 388731 Patch Clearing flags on attachment: 388731 Committed r255437: <https://trac.webkit.org/changeset/255437> 1613017 13 commit-queue 2020-01-30 10:07:17 -0800 All reviewed patches have been landed. Closing bug. 388472 2020-01-22 14:38:38 -0800 2020-01-24 15:24:09 -0800 Patch bug-206610-20200122143837.patch text/plain 6086 dougk U3VidmVyc2lvbiBSZXZpc2lvbjogMjUzODIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjVlM2IwNWVjMjBhNzBl MmI0YmJhOWU4YzQxNzZjZjY2MGQxZGQxYS4uZWY1YmJhMmJlZDI0Yzc5OTM2NmJiMTIxYzM1MjEx OTEwYTJlMDk5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTIyICBEb3Vn IEtlbGx5ICA8ZG91Z2tAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFJlbmRlckJsb2Nr Rmxvdzo6YWRqdXN0TGluZVBvc2l0aW9uRm9yUGFnaW5hdGlvbigpIHdpdGggY29tcGxleCBsaW5l IHdpdGhvdXQgcm9vdCBib3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNjYxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZCBhIGNoZWNrIGZvciBhIG51bGwgcG9pbnRlciB3aGVuIGdldHRpbmcgZmly c3RSb290Qm94KCkgLS0gaWYgaXQgaXMgbnVsbCwgcmV0dXJuIGVhcmx5LgorCisgICAgICAgIFRl c3Q6IGZhc3QvdGV4dC9jb21wbGV4LXdpdGhvdXQtcm9vdC1ib3guaHRtbAorCisgICAgICAgICog cmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJC bG9ja0Zsb3c6OmFkanVzdExpbmVQb3NpdGlvbkZvclBhZ2luYXRpb24pOgorCiAyMDE5LTEyLTIw ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBJbnZhbGlkYXRl IG9ubHkgYWZmZWN0ZWQgZWxlbWVudHMgYWZ0ZXIgbWVkaWEgcXVlcnkgZXZhbHVhdGlvbiBjaGFu Z2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93 LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4 IDc0YzQwZGE5ZmJiNzJlMDgwM2U3ZjkwYzFhMmZhNzhmM2VlMTk0MzUuLjAzNjYwM2M2ZmNhN2Ex MDVmMjU1ZDVkMTlkNDM2ZTljNWQyNzUxNTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0xODA5LDYgKzE4MDksOCBAQCB2b2lkIFJlbmRlckJs b2NrRmxvdzo6YWRqdXN0TGluZVBvc2l0aW9uRm9yUGFnaW5hdGlvbihSb290SW5saW5lQm94KiBs aW5lQm94LCBMYQogICAgICAgICBpZiAoKChsaW5lQm94ID09IGZpcnN0Um9vdEJveCgpICYmIHRv dGFsTG9naWNhbEhlaWdodCA8IHBhZ2VMb2dpY2FsSGVpZ2h0QXROZXdPZmZzZXQpIHx8ICghc3R5 bGUoKS5oYXNBdXRvT3JwaGFucygpICYmIHN0eWxlKCkub3JwaGFucygpID49IGxpbmVJbmRleCkp CiAgICAgICAgICAgICAmJiAhaXNPdXRPZkZsb3dQb3NpdGlvbmVkKCkgJiYgIWlzVGFibGVDZWxs KCkpIHsKICAgICAgICAgICAgIGF1dG8gZmlyc3RSb290Qm94ID0gdGhpcy0+Zmlyc3RSb290Qm94 KCk7CisgICAgICAgICAgICBpZiAoIWZpcnN0Um9vdEJveCkKKyAgICAgICAgICAgICAgICByZXR1 cm47CiAgICAgICAgICAgICBhdXRvIGZpcnN0Um9vdEJveE92ZXJmbG93UmVjdCA9IGZpcnN0Um9v dEJveC0+bG9naWNhbFZpc3VhbE92ZXJmbG93UmVjdChmaXJzdFJvb3RCb3gtPmxpbmVUb3AoKSwg Zmlyc3RSb290Qm94LT5saW5lQm90dG9tKCkpOwogICAgICAgICAgICAgYXV0byBmaXJzdExpbmVV cHBlck92ZXJoYW5nID0gc3RkOjptYXgoLWZpcnN0Um9vdEJveE92ZXJmbG93UmVjdC55KCksIDBf bHUpOwogICAgICAgICAgICAgaWYgKG5lZWRzQXBwbGVNYWlsUGFnaW5hdGlvblF1aXJrKCpsaW5l Qm94KSkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCA0MWViN2MxODM5YWVhMGY3ZjU5NmZiY2U5ZTFkMDVjZmNkNWM1M2FlLi5m M2UxOGIzNmI2MWViMGFjNDE5YWFhZjJmZGQ5NTlkYzIxOGIzMmZlIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMjAtMDEtMjIgIERvdWcgS2VsbHkgIDxkb3Vna0BhcHBsZS5jb20+CisKKyAgICAg ICAgQ3Jhc2ggaW4gUmVuZGVyQmxvY2tGbG93OjphZGp1c3RMaW5lUG9zaXRpb25Gb3JQYWdpbmF0 aW9uKCkgd2l0aCBjb21wbGV4IGxpbmUgd2l0aG91dCByb290IGJveAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NjEwCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L3RleHQvY29tcGxleC13aXRo b3V0LXJvb3QtYm94LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC90ZXh0L2Nv bXBsZXgtd2l0aG91dC1yb290LWJveC5odG1sOiBBZGRlZC4KKwogMjAxOS0xMi0yMCAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIG1hcmsgaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy8yZGNvbnRleHQvd2lkZS1nYW11dC1jYW52YXMg YXMgZmxha3kuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3RleHQvY29tcGxleC13aXRo b3V0LXJvb3QtYm94LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jb21wbGV4 LXdpdGhvdXQtcm9vdC1ib3gtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjFiMTE2NDg5ZTIyODYy ZDBiMjJhZjdjNGEzMmFlYWU4ZTdjMjlmNGEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L3RleHQvY29tcGxleC13aXRob3V0LXJvb3QtYm94LWV4cGVjdGVkLnR4dApAQCAtMCww ICsxLDUgQEAKK0NPTlNPTEUgTUVTU0FHRTogbGluZSAyOTogUmVmZXJlbmNlRXJyb3I6IENhbid0 IGZpbmQgdmFyaWFibGU6IG5vbmV4aXN0ZW50CitUaGlzIHRlc3QgY29uZmlybXMgdGhhdCBhIGNv bXBsZXggbGluZSBsYXlvdXQgd2l0aCBubyByb290IGJveCBkb2VzIG5vdCBmYWlsLiBUZXN0IHBh c3NlcyBpZiBXZWJLaXQgZG9lcyBub3QgY3Jhc2guIFBBU1MKKworCisKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvdGV4dC9jb21wbGV4LXdpdGhvdXQtcm9vdC1ib3guaHRtbCBiL0xheW91 dFRlc3RzL2Zhc3QvdGV4dC9jb21wbGV4LXdpdGhvdXQtcm9vdC1ib3guaHRtbApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5jNmQ5ZjE2MWI3MmRkNTA2ODEwZjJmYTQ3YjM5YmYyNzMxZTZhNmJkCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2NvbXBsZXgtd2l0aG91dC1yb290LWJveC5odG1s CkBAIC0wLDAgKzEsNDggQEAKKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8c3R5bGU+Cisg ICAgICAgICAgICAqIHsgd2lkdGg6IDE2bW07IG92ZXJmbG93OiAtd2Via2l0LXBhZ2VkLXg7IHBh ZGRpbmctcmlnaHQ6IDMyNzY4dnc7IH0KKyAgICAgICAgPC9zdHlsZT4KKyAgICAgICAgPHNjcmlw dD4KKyAgICAgICAgICAgIGZ1bmN0aW9uIGxvYWRldmVudCgpIHsKKyAgICAgICAgICAgICAgICBk b2N1bWVudC5ib2R5Lm9mZnNldFdpZHRoOworICAgICAgICAgICAgICAgIGIuYXBwZW5kQ2hpbGQo YSk7CisgICAgICAgICAgICB9CisgICAgICAgICAgICBmdW5jdGlvbiBlcnJoYW5kbGVyKCkgewor ICAgICAgICAgICAgICAgIGMgPSBuZXcgQXVkaW8oKTsKKyAgICAgICAgICAgICAgICBkID0gbmV3 IE1lZGlhU291cmNlOworICAgICAgICAgICAgICAgIGMuc3JjID0gVVJMLmNyZWF0ZU9iamVjdFVS TChkKTsKKyAgICAgICAgICAgICAgICB0cnkgeworICAgICAgICAgICAgICAgICAgICBlID0gUGF0 aDJEKCk7CisgICAgICAgICAgICAgICAgICAgIGUuYmV6aWVyQ3VydmVUbyh1bmRlZmluZWQsIHVu ZGVmaW5lZCk7CisgICAgICAgICAgICAgICAgfSBjYXRjaChlKSB7fQorICAgICAgICAgICAgICAg IGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5k dW1wQXNUZXh0KCk7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVh ZD4KKyAgICA8Ym9keSBvbmxvYWQ9bG9hZGV2ZW50KCk+CisgICAgICAgIFRoaXMgdGVzdCBjb25m aXJtcyB0aGF0IGEgY29tcGxleCBsaW5lIGxheW91dCB3aXRoIG5vIHJvb3QgYm94IGRvZXMgbm90 IGZhaWwuICBUZXN0IHBhc3NlcyBpZiBXZWJLaXQgZG9lcyBub3QgY3Jhc2guICBQQVNTCisgICAg ICAgIDxzdmcgb25lcnJvcj0iZXJyaGFuZGxlcigpIj4KKyAgICAgICAgICAgIDxtYXJrZXIgc3R5 bGU9InRyYW5zZm9ybTogcmlnaHQ7IGxpc3Qtc3R5bGUtaW1hZ2U6IHVybChkYXRhOmltYWdlL2dp ZjtiYXNlNjQsUjBsR09EbGhFQUFRQU1RQUFPUkhIT1ZTS3VkZk91bHJTT3AzV095RFp1NlFkdkNj aFBHb2xmTzBvL1hCcy9mTndmalowZnJsMy96eTcvLy8vd0FBQUFBQUFBQUFBQUFBQUFBQUFBQUFB QUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUFBQUNINUJBa0FBQkFBTEFBQUFB QVFBQkFBQUFWVklDU09aR2xDUUFvc0o2bXU3Zml5WmVLcU5LVG9RR0RzTThoQkFEZ1VYb0dBaXFo U3ZwNVFBblFLR0lnVWh3RlVZTENWREZDcktVRTFsQmF2QVZpRklEbFRJbWJLQzVHbTJoQjBTbEJD Qk1RaUIwVWpJUUE3KTsiIGNhc2U9ImZpcnN0IiAvPgorICAgICAgICAgICAgPHN0cm9uZyBkaXNw bGF5PSJibG9jayIgY2VsbHBhZGRpbmc9Ijk5Ij48L3N0cm9uZz4KKyAgICAgICAgICAgIDxkZXRh aWxzIG9udG9nZ2xlPSJub25leGlzdGVudCgpIiBvcGVuPSJ0cnVlIj48L2RldGFpbHM+CisgICAg ICAgICAgICA8c3ZnIGZvbnQtc2l6ZT0iMnB4IiByZXBlYXREdXI9ImluZGVmaW5pdGUiIHdyaXRp bmctbW9kZT0idGIiPgorICAgICAgICAgICAgICAgIDxmb3JlaWduT2JqZWN0IGF1dG87IHhtbG5z PSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIj4KKyAgICAgICAgICAgICAgICAgICAgPG1l bnUgdGV4dD0iZ3JlZW4iPgorICAgICAgICAgICAgICAgICAgICA8bWVudSBhbGluaz0id2hpdGUi PgorICAgICAgICAgICAgICAgICAgICA8L21lbnU+CisgICAgICAgICAgICAgICAgICAgIDxhbmlt YXRlIHN0cm9rZS1saW5lam9pbj0iYmV2ZWwiIHN0eWxlPSJmb250LXNpemU6IGxhcmdlOyIgLz4K KyAgICAgICAgICAgICAgICA8L2ZvcmVpZ25PYmplY3Q+CisgICAgICAgICAgICA8L3N2Zz4KKyAg ICAgICAgPC9zdmc+CisgICAgICAgIDxzdmcgZm9udC1zaXplPSJpbmhlcml0IiBzdHlsZT0iLXdl YmtpdC1hbmltYXRpb24tdGltaW5nLWZ1bmN0aW9uOiAtd2Via2l0LWFuaW1hdGlvbi1pdGVyYXRp b24tY291bnQ6IGluZmluaXRlOyBvcnBoYW5zOiAzMjc2ODsiIHhsaW5rOnR5cGU9InNpbXBsZSIg eTI9IjAuNTM5ODgxMjg2OTYiIHN0cm9rZS1vcGFjaXR5PSI2NTUzNSIgeGxpbms6c2hvdz0icmVw bGFjZSIgaWRlb2dyYXBoaWM9IjEiPgorICAgICAgICAgICAgPGN1cnNvciAvPgorICAgICAgICAg ICAgPGZvcmVpZ25PYmplY3QgeD0iMTYiIGRvbWluYW50LWJhc2VsaW5lPSJhbHBoYWJldGljIiBk eT0iMzBleCI+CisgICAgICAgICAgICA8YnIgaWQ9ImEiIHN0eWxlPSItd2Via2l0LWZsb3ctaW50 bzogMHgzRDJDRTMxRjsiIG9wdGltdW09Ii0zMjc2OSI+PC9icj4KKyAgICAgICAgICAgIDwvZm9y ZWlnbk9iamVjdD4KKyAgICAgICAgICAgIDx0ZXh0UGF0aCBsZXR0ZXItc3BhY2luZz0iMTBweCIg bGVuZ3RoQWRqdXN0PSJzcGFjaW5nQW5kR2x5cGhzIiAvPgorICAgICAgICA8L3N2Zz4KKyAgICAg ICAgPG1hcnF1ZWUgaWQ9ImIiIGhlaWdodD0iMTIlIiByb3c9IjAiPjwvbWFycXVlZT4KKyAgICA8 L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo= 388565 2020-01-23 11:20:15 -0800 2020-01-23 11:20:15 -0800 Test reduction complex-without-root-box.html text/html 356 zalan PHN0eWxlPgpmb3JlaWduT2JqZWN0IHsgcGFkZGluZy1yaWdodDogMTAwcHg7IH0KZGl2IHsgd2lk dGg6IDE2bW07IG92ZXJmbG93OiAtd2Via2l0LXBhZ2VkLXg7IH0KPC9zdHlsZT4KPHN2ZyB3cml0 aW5nLW1vZGU9InRiIj48Zm9yZWlnbk9iamVjdD48ZGl2PjwvZm9yZWlnbk9iamVjdD48L3N2Zz4K PHN2ZyBzdHlsZT0ib3JwaGFuczogMTsiPjxmb3JlaWduT2JqZWN0IHg9IjEwIj48YnIgaWQ9YnI+ PGJyPjwvZm9yZWlnbk9iamVjdD48L3N2Zz4KPHNwYW4gaWQ9Y29udGFpbmVyPjwvc3Bhbj4KCjxz Y3JpcHQ+CmRvY3VtZW50LmJvZHkub2Zmc2V0V2lkdGg7CmNvbnRhaW5lci5hcHBlbmRDaGlsZChi cik7Cjwvc2NyaXB0Pgo= 388731 2020-01-24 15:24:10 -0800 2020-01-30 10:07:15 -0800 Patch bug-206610-20200124152409.patch text/plain 4068 dougk U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1MDkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2VhYmQyZjcxNTkyMDRl ZDQ0ZjkyODliYTFlMmFiNGRiYzZhMzJkYy4uNTg1NjQxODA2OGYwNjY1NWFjNjY3NWZjOTEzNWRl Y2I3ZjM2NGFkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIwLTAxLTI0ICBEb3Vn IEtlbGx5ICA8ZG91Z2tAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFJlbmRlckJsb2Nr Rmxvdzo6YWRqdXN0TGluZVBvc2l0aW9uRm9yUGFnaW5hdGlvbigpIHdpdGggY29tcGxleCBsaW5l IHdpdGhvdXQgcm9vdCBib3gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIwNjYxMAorCisgICAgICAgIFJldmlld2VkIGJ5IFphbGFuIEJ1anRhcy4KKwor ICAgICAgICBBZGQgYSBjaGVjayBmb3IgYSBudWxsIHBvaW50ZXIgd2hlbiBnZXR0aW5nIGZpcnN0 Um9vdEJveCgpIC0tIGlmIGl0IGlzIG51bGwsIHJldHVybiBlYXJseSBhZnRlciBjYWxsaW5nIHNl dFBhZ2luYXRpb25TdHJ1dCgpLgorCisgICAgICAgIFRlc3Q6IGZhc3QvdGV4dC9jb21wbGV4LXdp dGhvdXQtcm9vdC1ib3guaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxv dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmFkanVzdExpbmVQb3Np dGlvbkZvclBhZ2luYXRpb24pOgorCiAyMDIwLTAxLTI0ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRk YWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTUwODku CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2tGbG93LmNw cCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCmluZGV4IGI4 MjBhYTdlNjFmMzk2NmZjODM3NmFmZWJhMTI2YmFlMWI2Njc3NDEuLmQxY2EwMjdjNDQ1MWI0YTMy YjY2MTJjY2YwMWE0NmE0MTQ5MjhjNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0xODExLDYgKzE4MTEsMTAgQEAgdm9pZCBSZW5kZXJCbG9j a0Zsb3c6OmFkanVzdExpbmVQb3NpdGlvbkZvclBhZ2luYXRpb24oUm9vdElubGluZUJveCogbGlu ZUJveCwgTGEKICAgICAgICAgaWYgKCgobGluZUJveCA9PSBmaXJzdFJvb3RCb3goKSAmJiB0b3Rh bExvZ2ljYWxIZWlnaHQgPCBwYWdlTG9naWNhbEhlaWdodEF0TmV3T2Zmc2V0KSB8fCAoIXN0eWxl KCkuaGFzQXV0b09ycGhhbnMoKSAmJiBzdHlsZSgpLm9ycGhhbnMoKSA+PSBsaW5lSW5kZXgpKQog ICAgICAgICAgICAgJiYgIWlzT3V0T2ZGbG93UG9zaXRpb25lZCgpICYmICFpc1RhYmxlQ2VsbCgp KSB7CiAgICAgICAgICAgICBhdXRvIGZpcnN0Um9vdEJveCA9IHRoaXMtPmZpcnN0Um9vdEJveCgp OworICAgICAgICAgICAgaWYgKCFmaXJzdFJvb3RCb3gpIHsKKyAgICAgICAgICAgICAgICBzZXRQ YWdpbmF0aW9uU3RydXQocmVtYWluaW5nTG9naWNhbEhlaWdodCArIGxvZ2ljYWxPZmZzZXQpOwor ICAgICAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgICAgIH0KICAgICAgICAgICAgIGF1dG8g Zmlyc3RSb290Qm94T3ZlcmZsb3dSZWN0ID0gZmlyc3RSb290Qm94LT5sb2dpY2FsVmlzdWFsT3Zl cmZsb3dSZWN0KGZpcnN0Um9vdEJveC0+bGluZVRvcCgpLCBmaXJzdFJvb3RCb3gtPmxpbmVCb3R0 b20oKSk7CiAgICAgICAgICAgICBhdXRvIGZpcnN0TGluZVVwcGVyT3ZlcmhhbmcgPSBzdGQ6Om1h eCgtZmlyc3RSb290Qm94T3ZlcmZsb3dSZWN0LnkoKSwgMF9sdSk7CiAgICAgICAgICAgICBpZiAo bmVlZHNBcHBsZU1haWxQYWdpbmF0aW9uUXVpcmsoKmxpbmVCb3gpKQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDJkNWE4ODli OWM2MTBkYWM2NWE3YTRlODdmMjk2NTlkZjJlYjViMzguLjRlZjZjODA2NjNmMGYzNWQ5ZTA4YTI4 YjFhMTkxOWVhOTc5NzNkMzQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMC0wMS0yNCAgRG91 ZyBLZWxseSAgPGRvdWdrQGFwcGxlLmNvbT4KKworICAgICAgICBDcmFzaCBpbiBSZW5kZXJCbG9j a0Zsb3c6OmFkanVzdExpbmVQb3NpdGlvbkZvclBhZ2luYXRpb24oKSB3aXRoIGNvbXBsZXggbGlu ZSB3aXRob3V0IHJvb3QgYm94CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMDY2MTAKKworICAgICAgICBSZXZpZXdlZCBieSBaYWxhbiBCdWp0YXMuCisK KyAgICAgICAgKiBmYXN0L3RleHQvY29tcGxleC13aXRob3V0LXJvb3QtYm94LWV4cGVjdGVkLnR4 dDogQWRkZWQuCisgICAgICAgICogZmFzdC90ZXh0L2NvbXBsZXgtd2l0aG91dC1yb290LWJveC5o dG1sOiBBZGRlZC4KKwogMjAyMC0wMS0yNCAgeW91ZW5uIGZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIE1lZGlhUmVjb3JkZXIucmVxdWVzdERhdGEK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jb21wbGV4LXdpdGhvdXQtcm9vdC1i b3gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2NvbXBsZXgtd2l0aG91dC1y b290LWJveC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uYzM4YzgyMzc4ZjFkMzAzN2E3MGEwOTcy ZWYzNzhmOTE5MDJkNjRiOAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4 dC9jb21wbGV4LXdpdGhvdXQtcm9vdC1ib3gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNCBAQAor VGhpcyB0ZXN0IGNvbmZpcm1zIHRoYXQgYSBjb21wbGV4IGxpbmUgbGF5b3V0IHdpdGggbm8gcm9v dCBib3ggZG9lcyBub3QgZmFpbC4gVGVzdCBwYXNzZXMgaWYgV2ViS2l0IGRvZXMgbm90IGNyYXNo LiBQQVNTIAorCisKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2NvbXBsZXgt d2l0aG91dC1yb290LWJveC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2NvbXBsZXgtd2l0 aG91dC1yb290LWJveC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmZmNGFmYTk4MjFkODJjMWZiMDZjNzAzY2U1 YjBlZTg4NDQxNjAwNmQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3RleHQv Y29tcGxleC13aXRob3V0LXJvb3QtYm94Lmh0bWwKQEAgLTAsMCArMSwxNCBAQAorPHN0eWxlPgor Zm9yZWlnbk9iamVjdCB7IHBhZGRpbmctcmlnaHQ6IDEwMHB4OyB9CitkaXYgeyB3aWR0aDogMTZt bTsgb3ZlcmZsb3c6IC13ZWJraXQtcGFnZWQteDsgfQorPC9zdHlsZT4KK1RoaXMgdGVzdCBjb25m aXJtcyB0aGF0IGEgY29tcGxleCBsaW5lIGxheW91dCB3aXRoIG5vIHJvb3QgYm94IGRvZXMgbm90 IGZhaWwuICBUZXN0IHBhc3NlcyBpZiBXZWJLaXQgZG9lcyBub3QgY3Jhc2guICBQQVNTCis8c3Zn IHdyaXRpbmctbW9kZT0idGIiPjxmb3JlaWduT2JqZWN0PjxkaXY+PC9mb3JlaWduT2JqZWN0Pjwv c3ZnPgorPHN2ZyBzdHlsZT0ib3JwaGFuczogMTsiPjxmb3JlaWduT2JqZWN0IHg9IjEwIj48YnIg aWQ9YnI+PGJyPjwvZm9yZWlnbk9iamVjdD48L3N2Zz4KKzxzcGFuIGlkPWNvbnRhaW5lcj48L3Nw YW4+Cis8c2NyaXB0PgorZG9jdW1lbnQuYm9keS5vZmZzZXRXaWR0aDsKK2NvbnRhaW5lci5hcHBl bmRDaGlsZChicik7CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgdGVzdFJ1bm5lci5kdW1w QXNUZXh0KCk7Cis8L3NjcmlwdD4K