206608 2020-01-22 12:24:49 -0800 REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated 2020-01-22 15:48:36 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson achristensen commit-queue oldest_to_newest 1609679 0 beidson 2020-01-22 12:24:49 -0800 REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated <rdar://problem/58544942> 1609687 1 388459 beidson 2020-01-22 12:39:49 -0800 Created attachment 388459 Patch 1609702 2 388459 achristensen 2020-01-22 13:00:37 -0800 Comment on attachment 388459 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388459&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:235 > + TCPServer server([](int socket) { You could've used HTTPServer since this only adds headers fields and body, but this is fine too. 1609807 3 388459 commit-queue 2020-01-22 15:48:35 -0800 Comment on attachment 388459 Patch Clearing flags on attachment: 388459 Committed r254950: <https://trac.webkit.org/changeset/254950> 1609808 4 commit-queue 2020-01-22 15:48:36 -0800 All reviewed patches have been landed. Closing bug. 388459 2020-01-22 12:39:49 -0800 2020-01-22 15:48:35 -0800 Patch bug-206608-20200122123949.patch text/plain 4515 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0OTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDQ5ZDcxZDkzNTM5YzNm ZWU2NGY3NWEyZWM2MThkNzZiYmQ0ZmVkMS4uYmEzOGE2OTY2M2E2ZDMwNTBmMWM1YjMyNzA1MWY3 MzA1ZWM5YjVlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAxLTIyICBCcmFk eSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjUz NTE5KTogW1dLV2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6Y29tcGxldGlvbkhhbmRsZXI6XSBn aXZlcyBhIG5vbi1uaWwsIG5vbi1FcnJvciByZXN1bHQgZXZlbiB3aGVuIEphdmFTY3JpcHQgY2Fu bm90IGJlIGV2YWx1YXRlZAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg1NDQ5NDI+IGFuZCBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NjA4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ292ZXJlZCBieSBuZXcgQVBJ IHRlc3QuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNjcmlwdENvbnRyb2xsZXI6OmV4ZWN1dGVTY3JpcHRJbldvcmxkKTog QWRkcmVzcyBhIEZJWE1FIGFkZGVkIGluIDI1MzUxOSB3aGljaCBoYWQgcHJlZGljdGVkIHRoaXMg cHJvYmxlbS4KKwogMjAyMC0wMS0yMiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtMRkNdIERvIG5vdCBjcmVhdGUgYSBGb3JtYXR0aW5nQ29udGV4dCB1bmxlc3Mg dGhlcmUncyBjb250ZW50IHRvIGxheW91dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggMDBjNjBlZmZkODMyMDg2OTdmZmQ1ZDQ2MDA5 NTRhYmNkMDJkNzljZS4uYTg3MzA4MGYwMDVmZmZiMGRmNTBkMWM1NWZmOGMwMDE1ZTJlMGQ3MCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAK QEAgLTU3Niw5ICs1NzYsOCBAQCBWYWx1ZU9yRXhjZXB0aW9uIFNjcmlwdENvbnRyb2xsZXI6OmV4 ZWN1dGVTY3JpcHRJbldvcmxkKERPTVdyYXBwZXJXb3JsZCYgd29ybGQsCiB7CiAgICAgVXNlckdl c3R1cmVJbmRpY2F0b3IgZ2VzdHVyZUluZGljYXRvcihwYXJhbWV0ZXJzLmZvcmNlVXNlckdlc3R1 cmUgPT0gRm9yY2VVc2VyR2VzdHVyZTo6WWVzID8gT3B0aW9uYWw8UHJvY2Vzc2luZ1VzZXJHZXN0 dXJlU3RhdGU+KFByb2Nlc3NpbmdVc2VyR2VzdHVyZSkgOiBXVEY6Om51bGxvcHQpOwogCi0gICAg Ly8gRklYTUU6IEluc3RlYWQgb2YgcmV0dXJuaW5nIGFuIGVtcHR5IEpTVmFsdWUsIHNob3VsZCBy ZXR1cm4gYW4gRXhjZXB0aW9uRGV0YWlscy4KICAgICBpZiAoIWNhbkV4ZWN1dGVTY3JpcHRzKEFi b3V0VG9FeGVjdXRlU2NyaXB0KSB8fCBpc1BhdXNlZCgpKQotICAgICAgICByZXR1cm4geyB9Owor ICAgICAgICByZXR1cm4gbWFrZVVuZXhwZWN0ZWQoRXhjZXB0aW9uRGV0YWlscyB7ICJDYW5ub3Qg ZXhlY3V0ZSBKYXZhU2NyaXB0IGluIHRoaXMgZG9jdW1lbnQiX3MgfSk7CiAKICAgICBzd2l0Y2gg KHBhcmFtZXRlcnMucnVuQXNBc3luY0Z1bmN0aW9uKSB7CiAgICAgY2FzZSBSdW5Bc0FzeW5jRnVu Y3Rpb246Ok5vOiB7CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggYmU1ODIyZTZlM2ExMWM3Mzc4MDU5OGQ3Y2IzZDNjOWZmYmY3MWQxMC4uNDZkNjM5 MTJlZjUzMGY1MWUxNzlmMzc5NDkyMTYzYTAxMzhkZmFmOSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTIy ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9O IChyMjUzNTE5KTogW1dLV2ViVmlldyBldmFsdWF0ZUphdmFTY3JpcHQ6Y29tcGxldGlvbkhhbmRs ZXI6XSBnaXZlcyBhIG5vbi1uaWwsIG5vbi1FcnJvciByZXN1bHQgZXZlbiB3aGVuIEphdmFTY3Jp cHQgY2Fubm90IGJlIGV2YWx1YXRlZAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg1NDQ5NDI+ IGFuZCBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NjA4CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0 QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLV2ViVmlld0V2YWx1YXRlSmF2YVNjcmlwdC5tbToKKyAg ICAgICAgKFRFU1QpOgorCiAyMDIwLTAxLTIxICBNYXR0IExld2lzICA8amxld2lzM0BhcHBsZS5j b20+CiAKICAgICAgICAgVGVzdCBoaXN0b3J5IGxpbmtzIG9uIHRoZSBkYXNoYm9hcmQgc2hvdWxk IGdvIHRvIHRoZSBuZXcgcmVzdWx0cyBkYXRhYmFzZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdl YktpdEFQSS9UZXN0cy9XZWJLaXRDb2NvYS9XS1dlYlZpZXdFdmFsdWF0ZUphdmFTY3JpcHQubW0g Yi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLV2ViVmlld0V2YWx1YXRl SmF2YVNjcmlwdC5tbQppbmRleCA4YzcwYzI0Y2M3MGEwMGQ3YWU1YjJkYjE1MWU2Zjk5ZjRkMjYw ZWQ3Li4wYjBkM2Q0Y2VlYzFmNmEzYzg0NjgxMWMzMWM2MTFhNGRhMmU1Mjc1IDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29hL1dLV2ViVmlld0V2YWx1YXRl SmF2YVNjcmlwdC5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdENvY29h L1dLV2ViVmlld0V2YWx1YXRlSmF2YVNjcmlwdC5tbQpAQCAtMjcsNiArMjcsNyBAQAogI2ltcG9y dCA8V2ViS2l0L1dLRm91bmRhdGlvbi5oPgogCiAjaW1wb3J0ICJQbGF0Zm9ybVV0aWxpdGllcy5o IgorI2ltcG9ydCAiVENQU2VydmVyLmgiCiAjaW1wb3J0ICJUZXN0LmgiCiAjaW1wb3J0ICJUZXN0 TmF2aWdhdGlvbkRlbGVnYXRlLmgiCiAjaW1wb3J0ICJUZXN0V0tXZWJWaWV3LmgiCkBAIC0yMjQs MyArMjI1LDMyIEBAIFRFU1QoV0tXZWJWaWV3LCBFdmFsdWF0ZUphdmFTY3JpcHRJbldvcmxkcykK ICAgICB9XTsKICAgICBpc0RvbmUgPSBmYWxzZTsKIH0KKworVEVTVChXZWJLaXQsIEV2YWx1YXRl SmF2YVNjcmlwdEluQXR0YWNobWVudHMpCit7CisgICAgLy8gQXR0YWNobWVudHMgZGlzcGxheWVk IGlubGluZSBhcmUgaW4gc2FuZGJveGVkIGRvY3VtZW50cy4KKyAgICAvLyBFdmFsdWF0aW5nIEph dmFTY3JpcHQgaW4gc3VjaCBhIGRvY3VtZW50IHNob3VsZCBmYWlsIGFuZCByZXN1bHQgaW4gYW4g ZXJyb3IuCisKKyAgICB1c2luZyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSTsKKyAgICBUQ1BTZXJ2 ZXIgc2VydmVyKFtdKGludCBzb2NrZXQpIHsKKyAgICAgICAgTlNTdHJpbmcgKnJlc3BvbnNlID0g QCJIVFRQLzEuMSAyMDAgT0tcclxuIgorICAgICAgICAgICAgIkNvbnRlbnQtTGVuZ3RoOiAxMlxy XG4iCisgICAgICAgICAgICAiQ29udGVudC1EaXNwb3NpdGlvbjogYXR0YWNobWVudDsgZmlsZW5h bWU9ZnJvbUhlYWRlci50eHQ7XHJcblxyXG4iCisgICAgICAgICAgICAiSGVsbG8gd29ybGQhIjsK KworICAgICAgICBUQ1BTZXJ2ZXI6OnJlYWQoc29ja2V0KTsKKyAgICAgICAgVENQU2VydmVyOjp3 cml0ZShzb2NrZXQsIHJlc3BvbnNlLlVURjhTdHJpbmcsIHJlc3BvbnNlLmxlbmd0aCk7CisgICAg fSk7CisgICAgYXV0byB3ZWJWaWV3ID0gYWRvcHROUyhbVGVzdFdLV2ViVmlldyBuZXddKTsKKyAg ICBbd2ViVmlldyBzeW5jaHJvbm91c2x5TG9hZFJlcXVlc3Q6W05TVVJMUmVxdWVzdCByZXF1ZXN0 V2l0aFVSTDpbTlNVUkwgVVJMV2l0aFN0cmluZzpbTlNTdHJpbmcgc3RyaW5nV2l0aEZvcm1hdDpA Imh0dHA6Ly8xMjcuMC4wLjE6JWQvIiwgc2VydmVyLnBvcnQoKV1dXV07CisKKyAgICBfX2Jsb2Nr IGJvb2wgZG9uZSA9IGZhbHNlOworICAgIFt3ZWJWaWV3IGV2YWx1YXRlSmF2YVNjcmlwdDpAIkhl bGxvIiBjb21wbGV0aW9uSGFuZGxlcjpeKGlkIHJlc3VsdCwgTlNFcnJvciAqZXJyb3IpIHsKKyAg ICAgICAgRVhQRUNUX05VTEwocmVzdWx0KTsKKyAgICAgICAgRVhQRUNUX05PVF9OVUxMKGVycm9y KTsKKyAgICAgICAgRVhQRUNUX1RSVUUoW1tlcnJvciBkZXNjcmlwdGlvbl0gY29udGFpbnNTdHJp bmc6QCJDYW5ub3QgZXhlY3V0ZSBKYXZhU2NyaXB0IGluIHRoaXMgZG9jdW1lbnQiXSk7CisgICAg ICAgIGRvbmUgPSB0cnVlOworICAgIH1dOworICAgIFRlc3RXZWJLaXRBUEk6OlV0aWw6OnJ1bigm ZG9uZSk7Cit9CisK