<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>206565</bug_id>
          
          <creation_ts>2020-01-21 18:10:36 -0800</creation_ts>
          <short_desc>[AppleWin][Cygwin Perl][EWS] preprocessor.pm is occasionally failing to spawn a child process</short_desc>
          <delta_ts>2020-09-22 14:08:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Bindings</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WORKSFORME</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>achristensen</cc>
    
    <cc>ap</cc>
    
    <cc>bfulgham</cc>
    
    <cc>cdumez</cc>
    
    <cc>krollin</cc>
    
    <cc>pvollan</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1609420</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-01-21 18:10:36 -0800</bug_when>
    <thetext>[AppleWin][Cygwin Perl][EWS] preprocessor.pm is occasionally failing to spawn a child process

EWS are observing AppleWin binding generation errors like:

&gt; Processing document /home/buildbot/worker/Windows-EWS/build/Source/WebCore/svg/SVGAltGlyphDefElement.idl did not generate anything at /home/buildbot/worker/Windows-EWS/build/Source/WebCore/bindings/scripts/CodeGenerator.pm line 247.

&gt; Could NOT find interface definition for Node in ./dom/Node.idl at /home/buildbot/worker/Windows-EWS/build/Source/WebCore/bindings/scripts/CodeGenerator.pm line 502.

Bug 84274 is the past attempt to fix the issue.
AppleWin should use Win32 Perl as well as WinCairo does.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1610936</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-01-24 17:09:33 -0800</bug_when>
    <thetext>make_names.pl failed today.

https://ews-build.webkit.org/#/builders/10/builds/4744
https://bugs.webkit.org/attachment.cgi?id=388672&amp;action=prettypatch
https://bugs.webkit.org/show_bug.cgi?id=206416

&gt; xlinkattrs.in
&gt; Generating ../../DerivedSources/WebCore/XMLNSNames.cpp, ../../DerivedSources/WebCore/XMLNSNames.h
&gt;  Failed to read names from file: C:/cygwin/home/buildbot/worker/Windows-EWS/build/Source/WebCore/xml/xmlnsattrs.in at C:/cygwin/home/buildbot/worker/Windows-EWS/build/Source/WebCore/dom/make_names.pl line 331.

It also invoke cc to preprocess.
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/dom/make_names.pl

This seems a variant of this issue.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612830</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-01-29 19:31:25 -0800</bug_when>
    <thetext>I haven&apos;t observed the issue after the fix (, while observing issues of Bug 206565). Closed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612832</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-01-29 19:32:12 -0800</bug_when>
    <thetext>&lt;rdar://problem/59016784&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1612833</commentid>
    <comment_count>4</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-01-29 19:34:24 -0800</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #2)
Oops. My bad. This is a comment for Bug 206399. Reopened this ticket.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1619563</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-02-16 20:18:21 -0800</bug_when>
    <thetext>It&apos;s still failing today.

&gt; Could NOT find interface definition for SVGGradientElement in ./svg/SVGGradientElement.idl at /home/buildbot/worker/Windows-EWS/build/Source/WebCore/bindings/scripts/CodeGenerator.pm line 502.

https://ews-build.webkit.org/#/builders/10/builds/7486</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1668917</commentid>
    <comment_count>6</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-07-05 12:52:04 -0700</bug_when>
    <thetext>It&apos;s still failing today.

&gt;  Processing document /home/buildbot/worker/Windows-EWS/build/Source/WebCore/svg/SVGSwitchElement.idl did not generate anything at /home/buildbot/worker/Windows-EWS/build/Source/WebCore/bindings/scripts/CodeGenerator.pm line 247.

https://ews-build.webkit.org/#/builders/10/builds/29815/steps/22/logs/stdio</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1668926</commentid>
    <comment_count>7</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-07-05 14:41:10 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #0)
&gt; AppleWin should use Win32 Perl as well as WinCairo does.

Or, how about using 64bit Cygwin? It seems that EWS is using 32bit cygwin.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1669072</commentid>
    <comment_count>8</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-07-06 11:18:03 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #7)
&gt; (In reply to Fujii Hironori from comment #0)
&gt; &gt; AppleWin should use Win32 Perl as well as WinCairo does.
&gt; 
&gt; Or, how about using 64bit Cygwin? It seems that EWS is using 32bit cygwin.

I think we&apos;re using 64-bit Cygwin, if I am not mistaken?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1669109</commentid>
    <comment_count>9</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-07-06 12:54:35 -0700</bug_when>
    <thetext>I thought it&apos;s 32bit just because the log has C:\cygwin not C:\cygwin64, and CygwinDownloader downloads setup-x86.exe.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1669115</commentid>
    <comment_count>10</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2020-07-06 13:01:54 -0700</bug_when>
    <thetext>Seems like 64-bit.

buildbot@ews215 ~$ uname -m
x86_64

See: https://stackoverflow.com/a/22689191</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1669139</commentid>
    <comment_count>11</comment_count>
    <who name="Per Arne Vollan">pvollan</who>
    <bug_when>2020-07-06 13:28:13 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #9)
&gt; I thought it&apos;s 32bit just because the log has C:\cygwin not C:\cygwin64, and
&gt; CygwinDownloader downloads setup-x86.exe.

I think we just kept the Cygwin folder name when upgrading to 64-bit, since I believe Win EWS on Cygwin depends on this.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1688401</commentid>
    <comment_count>12</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-09-14 13:42:50 -0700</bug_when>
    <thetext>This issue is still happening.

https://ews-build.webkit.org/#/builders/10/builds/36343

&gt; Processing document /home/buildbot/worker/Windows-EWS/build/Source/WebCore/Modules/webaudio/PannerNode.idl did not generate anything. at /home/buildbot/worker/Windows-EWS/build/Source/WebCore/bindings/scripts/CodeGenerator.pm line 196.

I&apos;m going to try some ideas.

* Use cl.exe to preprocess even for Cygwin
* Sleep random seconds before retrying process spawning</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1688415</commentid>
    <comment_count>13</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-09-14 14:13:16 -0700</bug_when>
    <thetext>I realized GENERATE_DOM_NAMES is already using CMAKE_CXX_COMPILER to preprocess.
CMAKE_CXX_COMPILER is cl.exe in AppleWin Cygwin builds.
However, looking at Comment 1 failure, spawning cl.exe also failed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1688494</commentid>
    <comment_count>14</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-09-14 17:24:19 -0700</bug_when>
    <thetext>It seems that GENERATE_BINDINGS is also using cl.exe for preprocessing in AppleWin Cygwin builds.

Umm, is this a problem of spawning a win32 process in Cygwin?
Can using Cygwin gcc solve the issue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1688581</commentid>
    <comment_count>15</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-09-14 21:49:15 -0700</bug_when>
    <thetext>Another idea:

* No so many files are using preprocessor directives nowadays. Skip spawning a process for files which doesn&apos;t have &quot;#if&quot; by grepping &quot;#if&quot; in preprocessor.pm.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1688862</commentid>
    <comment_count>16</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-09-15 14:45:51 -0700</bug_when>
    <thetext>r267101 stops cygpath process spawning. I&apos;m going to watch AppleWin EWS for a week.

  Bug 216527 – preprocessor.pm: Use Cygwin::win_to_posix_path and Cygwin::posix_to_win_path instead of cygpath command</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1690852</commentid>
    <comment_count>17</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-09-22 14:08:34 -0700</bug_when>
    <thetext>I&apos;ve observed no failures since r267101. Closed.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>