206561 2020-01-21 16:20:19 -0800 Add missing NS_NOESCAPE to CFNetwork SPI 2020-01-21 17:30:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen joepeck webkit-bug-importer oldest_to_newest 1609360 0 achristensen 2020-01-21 16:20:19 -0800 Add missing NS_NOESCAPE to CFNetwork SPI 1609369 1 388369 achristensen 2020-01-21 16:27:29 -0800 Created attachment 388369 Patch 1609370 2 achristensen 2020-01-21 16:27:32 -0800 <rdar://problem/58774422> 1609403 3 388369 joepeck 2020-01-21 17:28:16 -0800 Comment on attachment 388369 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388369&action=review r=me > Source/WebCore/platform/network/cocoa/NetworkStorageSessionCocoa.mm:-49 > -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101400) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 120000) > -@interface NSHTTPCookieStorage (Staging) > -- (void)_getCookiesForURL:(NSURL *)url mainDocumentURL:(NSURL *)mainDocumentURL partition:(NSString *)partition policyProperties:(NSDictionary*)props completionHandler:(void (^)(NSArray *))completionHandler; > -- (void)_setCookies:(NSArray *)cookies forURL:(NSURL *)URL mainDocumentURL:(NSURL *)mainDocumentURL policyProperties:(NSDictionary*) props; > -@end > -#endif Nice! 1609405 4 achristensen 2020-01-21 17:30:30 -0800 https://trac.webkit.org/changeset/254895/webkit 388369 2020-01-21 16:27:29 -0800 2020-01-21 17:28:16 -0800 Patch bug-206561-20200121162729.patch text/plain 3492 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI1NDg4OSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTIxICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgQWRkIG1pc3Np bmcgTlNfTk9FU0NBUEUgdG8gQ0ZOZXR3b3JrIFNQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NTYxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81 ODc3NDQyMj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIHBsYXRmb3JtL25ldHdvcmsvY29jb2EvTmV0d29ya1N0b3JhZ2VTZXNzaW9uQ29jb2EubW06 CisKIDIwMjAtMDEtMjEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9y Zz4KIAogICAgICAgICBCdWlsZCBmaXguCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cJKHJldmlzaW9u IDI1NDg5MikKKysrIFNvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxMyBAQAorMjAyMC0wMS0yMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3Rl bnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBtaXNzaW5nIE5TX05PRVNDQVBFIHRvIENG TmV0d29yayBTUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIwNjU2MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg3NzQ0MjI+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwYWwvc3BpL2NmL0NGTmV0 d29ya1NQSS5oOgorCiAyMDIwLTAxLTIxICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CiAK ICAgICAgICAgQWRkIGJ1aWxkIGZsYWcgZm9yIHN0YWxlLXdoaWxlLXJldmFsaWRhdGUKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2NmL0NGTmV0d29ya1NQSS5oCShyZXZpc2lv biAyNTQ4ODkpCisrKyBTb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9jZi9DRk5ldHdvcmtTUEku aAkod29ya2luZyBjb3B5KQpAQCAtMTI3LDcgKzEyNyw3IEBAIHR5cGVkZWYgdm9pZCAoXkNGQ2Fj aGVkVVJMUmVzcG9uc2VDYWxsQmEKIEBpbnRlcmZhY2UgTlNIVFRQQ29va2llU3RvcmFnZSAoKQog LSAoaWQpX2luaXRXaXRoSWRlbnRpZmllcjooTlNTdHJpbmcgKilpZGVudGlmaWVyIHByaXZhdGU6 KGJvb2wpaXNQcml2YXRlOwogLSAodm9pZClfZ2V0Q29va2llc0ZvclVSTDooTlNVUkwgKil1cmwg bWFpbkRvY3VtZW50VVJMOihOU1VSTCAqKW1haW5Eb2N1bWVudFVSTCBwYXJ0aXRpb246KE5TU3Ry aW5nICopcGFydGl0aW9uIGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShOU0FycmF5ICopKWNv bXBsZXRpb25IYW5kbGVyOwotLSAodm9pZClfZ2V0Q29va2llc0ZvclVSTDooTlNVUkwgKil1cmwg bWFpbkRvY3VtZW50VVJMOihOU1VSTCAqKW1haW5Eb2N1bWVudFVSTCBwYXJ0aXRpb246KE5TU3Ry aW5nICopcGFydGl0aW9uIHBvbGljeVByb3BlcnRpZXM6KE5TRGljdGlvbmFyeSopcHJvcHMgY29t cGxldGlvbkhhbmRsZXI6KHZvaWQgKF4pKE5TQXJyYXkgKikpY29tcGxldGlvbkhhbmRsZXI7Cist ICh2b2lkKV9nZXRDb29raWVzRm9yVVJMOihOU1VSTCAqKXVybCBtYWluRG9jdW1lbnRVUkw6KE5T VVJMICopbWFpbkRvY3VtZW50VVJMIHBhcnRpdGlvbjooTlNTdHJpbmcgKilwYXJ0aXRpb24gcG9s aWN5UHJvcGVydGllczooTlNEaWN0aW9uYXJ5Kilwcm9wcyBjb21wbGV0aW9uSGFuZGxlcjoodm9p ZCAoTlNfTk9FU0NBUEUgXikoTlNBcnJheSAqKSljb21wbGV0aW9uSGFuZGxlcjsKIC0gKHZvaWQp X3NldENvb2tpZXM6KE5TQXJyYXkgKiljb29raWVzIGZvclVSTDooTlNVUkwgKilVUkwgbWFpbkRv Y3VtZW50VVJMOihOU1VSTCAqKW1haW5Eb2N1bWVudFVSTCBwb2xpY3lQcm9wZXJ0aWVzOihOU0Rp Y3Rpb25hcnkqKSBwcm9wczsKIC0gKHZvaWQpcmVtb3ZlQ29va2llc1NpbmNlRGF0ZTooTlNEYXRl ICopZGF0ZTsKIC0gKGlkKV9pbml0V2l0aENGSFRUUENvb2tpZVN0b3JhZ2U6KENGSFRUUENvb2tp ZVN0b3JhZ2VSZWYpY2ZTdG9yYWdlOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jb2NvYS9OZXR3b3JrU3RvcmFnZVNlc3Npb25Db2NvYS5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NvY29hL05ldHdvcmtTdG9yYWdlU2Vzc2lv bkNvY29hLm1tCShyZXZpc2lvbiAyNTQ4ODkpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL2NvY29hL05ldHdvcmtTdG9yYWdlU2Vzc2lvbkNvY29hLm1tCSh3b3JraW5nIGNvcHkp CkBAIC00MSwxMyArNDEsNiBAQCBAaW50ZXJmYWNlIE5TVVJMICgpCiAtIChDRlVSTFJlZilfY2Z1 cmw7CiBAZW5kCiAKLSNpZiAoUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlO X1JFUVVJUkVEID49IDEwMTQwMCkgfHwgKFBMQVRGT1JNKElPU19GQU1JTFkpICYmIF9fSVBIT05F X09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEyMDAwMCkKLUBpbnRlcmZhY2UgTlNIVFRQQ29v a2llU3RvcmFnZSAoU3RhZ2luZykKLS0gKHZvaWQpX2dldENvb2tpZXNGb3JVUkw6KE5TVVJMICop dXJsIG1haW5Eb2N1bWVudFVSTDooTlNVUkwgKiltYWluRG9jdW1lbnRVUkwgcGFydGl0aW9uOihO U1N0cmluZyAqKXBhcnRpdGlvbiBwb2xpY3lQcm9wZXJ0aWVzOihOU0RpY3Rpb25hcnkqKXByb3Bz IGNvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShOU0FycmF5ICopKWNvbXBsZXRpb25IYW5kbGVy OwotLSAodm9pZClfc2V0Q29va2llczooTlNBcnJheSAqKWNvb2tpZXMgZm9yVVJMOihOU1VSTCAq KVVSTCBtYWluRG9jdW1lbnRVUkw6KE5TVVJMICopbWFpbkRvY3VtZW50VVJMIHBvbGljeVByb3Bl cnRpZXM6KE5TRGljdGlvbmFyeSopIHByb3BzOwotQGVuZAotI2VuZGlmCi0KIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogdm9pZCBOZXR3b3JrU3RvcmFnZVNlc3Npb246OnNldENvb2tpZShjb25zdCBD b29raWUmIGNvb2tpZSkK