206552 2020-01-21 13:49:13 -0800 REGRESSION (r254856?): [Win] http/tests/security/same-origin-websql-blocked.html and 2 fast/dom/Window/window-function-* tests failing 2020-10-14 14:23:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=204907 InRadar P2 Normal --- 1 ryanhaddad sihui_liu commit-queue rniwa ryanhaddad sihui_liu webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1609256 0 ryanhaddad 2020-01-21 13:49:13 -0800 The following layout tests are failing on Windows: fast/dom/Window/window-function-frame-getter-precedence.html fast/dom/Window/window-function-name-getter-precedence.html http/tests/security/same-origin-websql-blocked.html https://build.webkit.org/results/Apple%20Win%2010%20Release%20(Tests)/r254862%20(4692)/results.html https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&test=fast%2Fdom%2FWindow%2Fwindow-function-frame-getter-precedence.html&test=fast%2Fdom%2FWindow%2Fwindow-function-name-getter-precedence.html&test=http%2Ftests%2Fsecurity%2Fsame-origin-websql-blocked.html The diffs for the fast/dom/Window tests looks like this: -PASS: typeof window.openDatabase should be function and is. +FAIL: typeof window.openDatabase should be function but instead is undefined The websql test is this: --- /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/same-origin-websql-blocked-expected.txt +++ /home/buildbot/worker/win10-release-tests/build/layout-test-results/http/tests/security/same-origin-websql-blocked-actual.txt @@ -1,4 +1,3 @@ -CONSOLE MESSAGE: line 5: Web SQL is deprecated. Please use IndexedDB instead. This iframe should return a security error: @@ -6,4 +5,4 @@ -------- Frame: '<!--frame1-->' -------- -SecurityError +UnknownError 1609257 1 ryanhaddad 2020-01-21 13:55:07 -0800 The tests passed as of r254853, failed as of r254862. This change looks like it could be related: Disable WebSQL everywhere by default except in tests https://bugs.webkit.org/show_bug.cgi?id=204907 https://trac.webkit.org/changeset/254856 1609277 2 388348 sihui_liu 2020-01-21 14:13:43 -0800 Created attachment 388348 Patch for landing 1609314 3 388348 commit-queue 2020-01-21 14:57:06 -0800 Comment on attachment 388348 Patch for landing Clearing flags on attachment: 388348 Committed r254885: <https://trac.webkit.org/changeset/254885> 1609315 4 commit-queue 2020-01-21 14:57:08 -0800 All reviewed patches have been landed. Closing bug. 1609317 5 webkit-bug-importer 2020-01-21 14:58:19 -0800 <rdar://problem/58775033> 388348 2020-01-21 14:13:43 -0800 2020-01-21 14:57:06 -0800 Patch for landing bug-206552-20200121141343.patch text/plain 1363 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODgxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDBiZDcyMjBhZThmNWJiNDJkZDljZTcwYjEyYTk2Zjdm NTk0MjNmNC4uY2U0YTBiYjZmNmY5NmIwYzMyMmI3OTcyYjQ0NjM1MjI1MTVmY2FkZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEy IEBACisyMDIwLTAxLTIxICBTaWh1aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIyNTQ4NTY/KTogW1dpbl0gaHR0cC90ZXN0cy9zZWN1cml0eS9zYW1l LW9yaWdpbi13ZWJzcWwtYmxvY2tlZC5odG1sIGFuZCAyIGZhc3QvZG9tL1dpbmRvdy93aW5kb3ct ZnVuY3Rpb24tKiB0ZXN0cyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMDY1NTIKKworICAgICAgICBVbnJldmlld2VkIGZpeCBhZnRlciBy MjU0ODU2LiByMjU0ODU2IHdhbnRlZCB0byBlbmFibGUgV2ViU1FMIG9uIGxheW91dCB0ZXN0cyBi dXQgZW5hYmxlV2ViU1FMIHdhcyBzZXQgdG8gZmFsc2UuCisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9UZXN0T3B0aW9ucy5oOgorCiAyMDIwLTAxLTIxICBZdXN1a2UgU3V6dWtpICA8eXN1enVr aUBhcHBsZS5jb20+CiAKICAgICAgICAgW1dURl0gQXRvbVN0cmluZ1RhYmxlIHNob3VsZCBiZSBz bWFsbApkaWZmIC0tZ2l0IGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE9wdGlvbnMuaCBiL1Rv b2xzL0R1bXBSZW5kZXJUcmVlL1Rlc3RPcHRpb25zLmgKaW5kZXggY2M0ZTdjMDk5NjE3ODJjZjcx OWMwMzljYTExY2NkZDlkM2RhMGY3Mi4uZjM3N2Q2OGNhOThmYjgxOGRhN2U3YjM1NjNmZGM1Yjhk YWE5YzI4MyAxMDA2NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvVGVzdE9wdGlvbnMuaAor KysgYi9Ub29scy9EdW1wUmVuZGVyVHJlZS9UZXN0T3B0aW9ucy5oCkBAIC01Niw3ICs1Niw3IEBA IHN0cnVjdCBUZXN0T3B0aW9ucyB7CiAgICAgYm9vbCBlbmFibGVBc3luY0NsaXBib2FyZEFQSSB7 IGZhbHNlIH07CiAgICAgYm9vbCBsYXlvdXRGb3JtYXR0aW5nQ29udGV4dEludGVncmF0aW9uRW5h YmxlZCB7IHRydWUgfTsKICAgICBib29sIGVuYWJsZUFzcGVjdFJhdGlvT2ZJbWdGcm9tV2lkdGhB bmRIZWlnaHQgeyBmYWxzZSB9OwotICAgIGJvb2wgZW5hYmxlV2ViU1FMIHsgZmFsc2UgfTsKKyAg ICBib29sIGVuYWJsZVdlYlNRTCB7IHRydWUgfTsKICAgICBzdGQ6OnN0cmluZyBqc2NPcHRpb25z OwogICAgIHN0ZDo6c3RyaW5nIGFkZGl0aW9uYWxTdXBwb3J0ZWRJbWFnZVR5cGVzOwogCg==