206547 2020-01-21 11:59:03 -0800 [WebAuthn] authenticatorGetAssertion should be sent without pinAuth if UV = "discouraged" 2020-02-06 18:57:37 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 181943 1 jiewen_tan jiewen_tan bfulgham commit-queue jiewen_tan loginllama webkit-bug-importer oldest_to_newest 1609183 0 jiewen_tan 2020-01-21 11:59:03 -0800 authenticatorGetAssertion should be sent without pinAuth if UV = "discouraged" even if the authenticator is protected by a PIN. 1609184 1 webkit-bug-importer 2020-01-21 11:59:33 -0800 <rdar://problem/58768032> 1609229 2 loginllama 2020-01-21 13:09:51 -0800 If getInfo options reports "clientPin"=1 (pin set on device) The platform should not negotiate or send pintoken if UserVerificationRequirement is discouraged. Until you have pintoken fully working UserVerificationRequirement being absent or prefered should probably be interprited as discouraged. That is what Google did until pintoken support was working. If getInfo options reports "clientPin"=0 (pin not set on device) Browsers should not do pintoken for absent, discouraged, or preferred. For required Chrome and Edge are taking the user through setting a pin inline and then negotiating pintoken. 1615281 3 389868 jiewen_tan 2020-02-05 14:17:24 -0800 Created attachment 389868 Patch 1615953 4 389868 bfulgham 2020-02-06 17:32:44 -0800 Comment on attachment 389868 Patch r=me 1615958 5 389868 jiewen_tan 2020-02-06 17:39:33 -0800 Comment on attachment 389868 Patch Thanks for r+ this patch. 1616001 6 commit-queue 2020-02-06 18:56:58 -0800 The commit-queue encountered the following flaky tests while processing attachment 389868: imported/w3c/web-platform-tests/web-animations/timing-model/timelines/update-and-send-events-replacement.html bug 207335 (author: graouts@apple.com) The commit-queue is continuing to process your patch. 1616002 7 389868 commit-queue 2020-02-06 18:57:35 -0800 Comment on attachment 389868 Patch Clearing flags on attachment: 389868 Committed r256001: <https://trac.webkit.org/changeset/256001> 1616003 8 commit-queue 2020-02-06 18:57:37 -0800 All reviewed patches have been landed. Closing bug. 389868 2020-02-05 14:17:24 -0800 2020-02-06 18:57:35 -0800 Patch bug-206547-20200205141724.patch text/plain 7193 jiewen_tan U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1Njg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGViY2U0MTQ1MDQ5ODI0MTcz ODYyNGZkMWJjN2IyNjg3MTg3ZjM3YTguLjY2ZjM2MDMzNjkzYjgyYzNlMGE3ZGI5ZmQ5NGZmNjdh MzM4ZWJlYzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDItMDUgIEppZXdlbiBU YW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2ViQXV0aG5dIGF1dGhlbnRp Y2F0b3JHZXRBc3NlcnRpb24gc2hvdWxkIGJlIHNlbnQgd2l0aG91dCBwaW5BdXRoIGlmIFVWID0g ImRpc2NvdXJhZ2VkIgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA2NTQ3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81ODc2ODAzMj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IG5ldyB0 ZXN0cyB3aXRoaW4gZXhpc3RpbmcgZmlsZXMuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViQXV0 aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHA6CisgICAgICAgIChXZWJLaXQ6 OkN0YXBBdXRoZW50aWNhdG9yOjptYWtlQ3JlZGVudGlhbCk6CisgICAgICAgIChXZWJLaXQ6OkN0 YXBBdXRoZW50aWNhdG9yOjpnZXRBc3NlcnRpb24pOgorCiAyMDIwLTAyLTA0ICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4ZWQgRGVwcmVjYXRl ZCBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYkF1dGhlbnRpY2F0 aW9uL2ZpZG8vQ3RhcEF1dGhlbnRpY2F0b3IuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHAKaW5kZXggOWEwYThk YjI3ZGE1YTJhMzBkMmZlMWZkNTQ5Yjc3MmQ2ZGYyYTFmZS4uYzhkOGUwZTRmZmZjZjFjYzE1NGJl OWJiYjAwYmRhNWQ2ZDI4MGM3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv V2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRvci5jcHAKKysrIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2ViQXV0aGVudGljYXRpb24vZmlkby9DdGFwQXV0aGVudGljYXRv ci5jcHAKQEAgLTU4LDEwICs1OCwxMSBAQCB2b2lkIEN0YXBBdXRoZW50aWNhdG9yOjptYWtlQ3Jl ZGVudGlhbCgpCiAgICAgaWYgKHByb2Nlc3NHb29nbGVMZWdhY3lBcHBJZFN1cHBvcnRFeHRlbnNp b24oKSkKICAgICAgICAgcmV0dXJuOwogICAgIFZlY3Rvcjx1aW50OF90PiBjYm9yQ21kOworICAg IGF1dG8mIG9wdGlvbnMgPSBXVEY6OmdldDxQdWJsaWNLZXlDcmVkZW50aWFsQ3JlYXRpb25PcHRp b25zPihyZXF1ZXN0RGF0YSgpLm9wdGlvbnMpOwogICAgIGlmIChtX2luZm8ub3B0aW9ucygpLmNs aWVudFBpbkF2YWlsYWJpbGl0eSgpID09IEF1dGhlbnRpY2F0b3JTdXBwb3J0ZWRPcHRpb25zOjpD bGllbnRQaW5BdmFpbGFiaWxpdHk6OmtTdXBwb3J0ZWRBbmRQaW5TZXQpCi0gICAgICAgIGNib3JD bWQgPSBlbmNvZGVNYWtlQ3JlZGVuaXRhbFJlcXVlc3RBc0NCT1IocmVxdWVzdERhdGEoKS5oYXNo LCBXVEY6OmdldDxQdWJsaWNLZXlDcmVkZW50aWFsQ3JlYXRpb25PcHRpb25zPihyZXF1ZXN0RGF0 YSgpLm9wdGlvbnMpLCBtX2luZm8ub3B0aW9ucygpLnVzZXJWZXJpZmljYXRpb25BdmFpbGFiaWxp dHkoKSwgUGluUGFyYW1ldGVycyB7IHBpbjo6a1Byb3RvY29sVmVyc2lvbiwgbV9waW5BdXRoIH0p OworICAgICAgICBjYm9yQ21kID0gZW5jb2RlTWFrZUNyZWRlbml0YWxSZXF1ZXN0QXNDQk9SKHJl cXVlc3REYXRhKCkuaGFzaCwgb3B0aW9ucywgbV9pbmZvLm9wdGlvbnMoKS51c2VyVmVyaWZpY2F0 aW9uQXZhaWxhYmlsaXR5KCksIFBpblBhcmFtZXRlcnMgeyBwaW46OmtQcm90b2NvbFZlcnNpb24s IG1fcGluQXV0aCB9KTsKICAgICBlbHNlCi0gICAgICAgIGNib3JDbWQgPSBlbmNvZGVNYWtlQ3Jl ZGVuaXRhbFJlcXVlc3RBc0NCT1IocmVxdWVzdERhdGEoKS5oYXNoLCBXVEY6OmdldDxQdWJsaWNL ZXlDcmVkZW50aWFsQ3JlYXRpb25PcHRpb25zPihyZXF1ZXN0RGF0YSgpLm9wdGlvbnMpLCBtX2lu Zm8ub3B0aW9ucygpLnVzZXJWZXJpZmljYXRpb25BdmFpbGFiaWxpdHkoKSk7CisgICAgICAgIGNi b3JDbWQgPSBlbmNvZGVNYWtlQ3JlZGVuaXRhbFJlcXVlc3RBc0NCT1IocmVxdWVzdERhdGEoKS5o YXNoLCBvcHRpb25zLCBtX2luZm8ub3B0aW9ucygpLnVzZXJWZXJpZmljYXRpb25BdmFpbGFiaWxp dHkoKSk7CiAgICAgZHJpdmVyKCkudHJhbnNhY3QoV1RGTW92ZShjYm9yQ21kKSwgW3dlYWtUaGlz ID0gbWFrZVdlYWtQdHIoKnRoaXMpXShWZWN0b3I8dWludDhfdD4mJiBkYXRhKSB7CiAgICAgICAg IEFTU0VSVChSdW5Mb29wOjppc01haW4oKSk7CiAgICAgICAgIGlmICghd2Vha1RoaXMpCkBAIC05 MSwxMCArOTIsMTEgQEAgdm9pZCBDdGFwQXV0aGVudGljYXRvcjo6Z2V0QXNzZXJ0aW9uKCkKIHsK ICAgICBBU1NFUlQoIW1faXNEb3duZ3JhZGVkKTsKICAgICBWZWN0b3I8dWludDhfdD4gY2JvckNt ZDsKLSAgICBpZiAobV9pbmZvLm9wdGlvbnMoKS5jbGllbnRQaW5BdmFpbGFiaWxpdHkoKSA9PSBB dXRoZW50aWNhdG9yU3VwcG9ydGVkT3B0aW9uczo6Q2xpZW50UGluQXZhaWxhYmlsaXR5OjprU3Vw cG9ydGVkQW5kUGluU2V0KQotICAgICAgICBjYm9yQ21kID0gZW5jb2RlR2V0QXNzZXJ0aW9uUmVx dWVzdEFzQ0JPUihyZXF1ZXN0RGF0YSgpLmhhc2gsIFdURjo6Z2V0PFB1YmxpY0tleUNyZWRlbnRp YWxSZXF1ZXN0T3B0aW9ucz4ocmVxdWVzdERhdGEoKS5vcHRpb25zKSwgbV9pbmZvLm9wdGlvbnMo KS51c2VyVmVyaWZpY2F0aW9uQXZhaWxhYmlsaXR5KCksIFBpblBhcmFtZXRlcnMgeyBwaW46OmtQ cm90b2NvbFZlcnNpb24sIG1fcGluQXV0aCB9KTsKKyAgICBhdXRvJiBvcHRpb25zID0gV1RGOjpn ZXQ8UHVibGljS2V5Q3JlZGVudGlhbFJlcXVlc3RPcHRpb25zPihyZXF1ZXN0RGF0YSgpLm9wdGlv bnMpOworICAgIGlmIChtX2luZm8ub3B0aW9ucygpLmNsaWVudFBpbkF2YWlsYWJpbGl0eSgpID09 IEF1dGhlbnRpY2F0b3JTdXBwb3J0ZWRPcHRpb25zOjpDbGllbnRQaW5BdmFpbGFiaWxpdHk6OmtT dXBwb3J0ZWRBbmRQaW5TZXQgJiYgb3B0aW9ucy51c2VyVmVyaWZpY2F0aW9uICE9IFVzZXJWZXJp ZmljYXRpb25SZXF1aXJlbWVudDo6RGlzY291cmFnZWQpCisgICAgICAgIGNib3JDbWQgPSBlbmNv ZGVHZXRBc3NlcnRpb25SZXF1ZXN0QXNDQk9SKHJlcXVlc3REYXRhKCkuaGFzaCwgb3B0aW9ucywg bV9pbmZvLm9wdGlvbnMoKS51c2VyVmVyaWZpY2F0aW9uQXZhaWxhYmlsaXR5KCksIFBpblBhcmFt ZXRlcnMgeyBwaW46OmtQcm90b2NvbFZlcnNpb24sIG1fcGluQXV0aCB9KTsKICAgICBlbHNlCi0g ICAgICAgIGNib3JDbWQgPSBlbmNvZGVHZXRBc3NlcnRpb25SZXF1ZXN0QXNDQk9SKHJlcXVlc3RE YXRhKCkuaGFzaCwgV1RGOjpnZXQ8UHVibGljS2V5Q3JlZGVudGlhbFJlcXVlc3RPcHRpb25zPihy ZXF1ZXN0RGF0YSgpLm9wdGlvbnMpLCBtX2luZm8ub3B0aW9ucygpLnVzZXJWZXJpZmljYXRpb25B dmFpbGFiaWxpdHkoKSk7CisgICAgICAgIGNib3JDbWQgPSBlbmNvZGVHZXRBc3NlcnRpb25SZXF1 ZXN0QXNDQk9SKHJlcXVlc3REYXRhKCkuaGFzaCwgb3B0aW9ucywgbV9pbmZvLm9wdGlvbnMoKS51 c2VyVmVyaWZpY2F0aW9uQXZhaWxhYmlsaXR5KCkpOwogICAgIGRyaXZlcigpLnRyYW5zYWN0KFdU Rk1vdmUoY2JvckNtZCksIFt3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKCp0aGlzKV0oVmVjdG9yPHVp bnQ4X3Q+JiYgZGF0YSkgewogICAgICAgICBBU1NFUlQoUnVuTG9vcDo6aXNNYWluKCkpOwogICAg ICAgICBpZiAoIXdlYWtUaGlzKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDExNzJjNTQ4Zjc1MGM5NzAwNWM1YWJlYWMxZjlm ZWU1NjRkOTYxOWQuLjE3MTA2NDBhNTRkOWQ3MzJmN2FiYjRkMWE4MDhiZTU3MjAxNWEwMjggMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMC0wMi0wNSAgSmlld2VuIFRhbiAgPGppZXdlbl90YW5A YXBwbGUuY29tPgorCisgICAgICAgIFtXZWJBdXRobl0gYXV0aGVudGljYXRvckdldEFzc2VydGlv biBzaG91bGQgYmUgc2VudCB3aXRob3V0IHBpbkF1dGggaWYgVVYgPSAiZGlzY291cmFnZWQiCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY1NDcKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzU4NzY4MDMyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHR0cC93cHQvd2ViYXV0aG4vcHVibGljLWtleS1j cmVkZW50aWFsLWdldC1zdWNjZXNzLWhpZC5odHRwcy1leHBlY3RlZC50eHQ6CisgICAgICAgICog aHR0cC93cHQvd2ViYXV0aG4vcHVibGljLWtleS1jcmVkZW50aWFsLWdldC1zdWNjZXNzLWhpZC5o dHRwcy5odG1sOgorCiAyMDIwLTAyLTA0ICBKYXNvbiBMYXdyZW5jZSAgPGxhd3JlbmNlLmpAYXBw bGUuY29tPgogCiAgICAgICAgIFsgbWFjT1Mgd2syIF0gaW5zcGVjdG9yL2NhbnZhcy9zaGFkZXJQ cm9ncmFtLWFkZC1yZW1vdmUtd2ViZ2wyLmh0bWwgaXMgZmxha3kgY3Jhc2hpbmcKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L3dlYmF1dGhuL3B1YmxpYy1rZXktY3JlZGVudGlhbC1n ZXQtc3VjY2Vzcy1oaWQuaHR0cHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC93cHQv d2ViYXV0aG4vcHVibGljLWtleS1jcmVkZW50aWFsLWdldC1zdWNjZXNzLWhpZC5odHRwcy1leHBl Y3RlZC50eHQKaW5kZXggNjczOTEwNzQ1YTdhYjQ2YTdkYzU0NWVjZmFmNzFjYmU1YWI4NWMyZC4u YjRkZmZiOTYzYTMyYWE2MzNhMDE0ZTNhMDFkNDUwNzM5MjU0MGZlNiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvaHR0cC93cHQvd2ViYXV0aG4vcHVibGljLWtleS1jcmVkZW50aWFsLWdldC1zdWNj ZXNzLWhpZC5odHRwcy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvd2Vi YXV0aG4vcHVibGljLWtleS1jcmVkZW50aWFsLWdldC1zdWNjZXNzLWhpZC5odHRwcy1leHBlY3Rl ZC50eHQKQEAgLTYsNCArNiw1IEBAIFBBU1MgUHVibGljS2V5Q3JlZGVudGlhbCdzIFtbZ2V0XV0g d2l0aCB1c2VyVmVyaWZpY2F0aW9uIHsgZGlzY291cmFnZWQgfSBpbiBhIG1vCiBQQVNTIFB1Ymxp Y0tleUNyZWRlbnRpYWwncyBbW2dldF1dIHdpdGggbWl4ZWQgb3B0aW9ucyBpbiBhIG1vY2sgaGlk IGF1dGhlbnRpY2F0b3IuIAogUEFTUyBQdWJsaWNLZXlDcmVkZW50aWFsJ3MgW1tnZXRdXSB3aXRo IHR3byBjb25zZWN1dGl2ZSByZXF1ZXN0cy4gCiBQQVNTIFB1YmxpY0tleUNyZWRlbnRpYWwncyBb W2dldF1dIHdpdGggbXVsdGlwbGUgYWNjb3VudHMgaW4gYSBtb2NrIGhpZCBhdXRoZW50aWNhdG9y LiAKK1BBU1MgUHVibGljS2V5Q3JlZGVudGlhbCdzIFtbZ2V0XV0gd2l0aCBQSU4gc3VwcG9ydGVk IGluIHRoZSBhdXRoZW50aWNhdG9yIGJ1dCB1c2VyVmVyaWZpY2F0aW9uID0gJ2Rpc2NvdXJhZ2Vk JyBpbiBhIG1vY2sgaGlkIGF1dGhlbnRpY2F0b3IuIAogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3dwdC93ZWJhdXRobi9wdWJsaWMta2V5LWNyZWRlbnRpYWwtZ2V0LXN1Y2Nlc3MtaGlk Lmh0dHBzLmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC93ZWJhdXRobi9wdWJsaWMta2V5LWNy ZWRlbnRpYWwtZ2V0LXN1Y2Nlc3MtaGlkLmh0dHBzLmh0bWwKaW5kZXggZWM5ZDZmYzI4ZjRmMTk5 Yjg3ODQyNTk1OWNiZjEyYmJkYjI1N2Y0Mi4uMjQ3OGRhZDQ2ZGViNzZkOWQzNmI5M2ViOWNjNWRh OWYzZTdjNTFmMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC93cHQvd2ViYXV0aG4vcHVi bGljLWtleS1jcmVkZW50aWFsLWdldC1zdWNjZXNzLWhpZC5odHRwcy5odG1sCisrKyBiL0xheW91 dFRlc3RzL2h0dHAvd3B0L3dlYmF1dGhuL3B1YmxpYy1rZXktY3JlZGVudGlhbC1nZXQtc3VjY2Vz cy1oaWQuaHR0cHMuaHRtbApAQCAtMTE2LDQgKzExNiwyMCBAQAogICAgICAgICAgICAgcmV0dXJu IGNoZWNrQ3RhcEdldEFzc2VydGlvblJlc3VsdChjcmVkZW50aWFsLCAiTUlJQmt6Q0NBVGlnQXdJ QkFqQ0NBWk13Z2dFNG9BTUNBUUl3Z2dHVE1JST0iKTsKICAgICAgICAgfSk7CiAgICAgfSwgIlB1 YmxpY0tleUNyZWRlbnRpYWwncyBbW2dldF1dIHdpdGggbXVsdGlwbGUgYWNjb3VudHMgaW4gYSBt b2NrIGhpZCBhdXRoZW50aWNhdG9yLiIpOworCisgICAgcHJvbWlzZV90ZXN0KHQgPT4geworICAg ICAgICBjb25zdCBvcHRpb25zID0geworICAgICAgICAgICAgcHVibGljS2V5OiB7CisgICAgICAg ICAgICAgICAgY2hhbGxlbmdlOiBCYXNlNjRVUkwucGFyc2UoIk1USXpORFUyIiksCisgICAgICAg ICAgICAgICAgdXNlclZlcmlmaWNhdGlvbjogImRpc2NvdXJhZ2VkIiwKKyAgICAgICAgICAgICAg ICB0aW1lb3V0OiAxMDAKKyAgICAgICAgICAgIH0KKyAgICAgICAgfTsKKworICAgICAgICBpZiAo d2luZG93LmludGVybmFscykKKyAgICAgICAgICAgIGludGVybmFscy5zZXRNb2NrV2ViQXV0aGVu dGljYXRpb25Db25maWd1cmF0aW9uKHsgaGlkOiB7IHN1cHBvcnRDbGllbnRQaW46IHRydWUsIHBh eWxvYWRCYXNlNjQ6IFt0ZXN0QXNzZXJ0aW9uTWVzc2FnZUJhc2U2NF0gfSB9KTsKKyAgICAgICAg cmV0dXJuIG5hdmlnYXRvci5jcmVkZW50aWFscy5nZXQob3B0aW9ucykudGhlbihjcmVkZW50aWFs ID0+IHsKKyAgICAgICAgICAgIHJldHVybiBjaGVja0N0YXBHZXRBc3NlcnRpb25SZXN1bHQoY3Jl ZGVudGlhbCk7CisgICAgICAgIH0pOworICAgIH0sICJQdWJsaWNLZXlDcmVkZW50aWFsJ3MgW1tn ZXRdXSB3aXRoIFBJTiBzdXBwb3J0ZWQgaW4gdGhlIGF1dGhlbnRpY2F0b3IgYnV0IHVzZXJWZXJp ZmljYXRpb24gPSAnZGlzY291cmFnZWQnIGluIGEgbW9jayBoaWQgYXV0aGVudGljYXRvci4iKTsK IDwvc2NyaXB0Pgo=