206544 2020-01-21 11:38:50 -0800 Performance tests fail if stderr logging is encountered 2020-01-21 12:34:50 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206545 InRadar P2 Normal --- 200543 1 bfulgham bfulgham ap bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1609164 0 bfulgham 2020-01-21 11:38:50 -0800 In Bug 200543 (and other updates) we changed our sandbox code to use vend extensions to processes by audit token. During this change, we used the WTFLogAlways() logging function when a sandbox extension could not be created. We now see that any output to stderr causes the test runner used by the micro-benchmark system in PerformanceTests to trigger a failure. Now that we have debugged this code, we should switch back to our standard logging behavior. 1609165 1 bfulgham 2020-01-21 11:39:54 -0800 <rdar://problem/58714766> 1609166 2 388328 bfulgham 2020-01-21 11:40:44 -0800 Created attachment 388328 Patch 1609173 3 388328 pvollan 2020-01-21 11:44:46 -0800 Comment on attachment 388328 Patch Great! R=me. 1609207 4 388328 commit-queue 2020-01-21 12:34:48 -0800 Comment on attachment 388328 Patch Clearing flags on attachment: 388328 Committed r254872: <https://trac.webkit.org/changeset/254872> 1609208 5 commit-queue 2020-01-21 12:34:50 -0800 All reviewed patches have been landed. Closing bug. 388328 2020-01-21 11:40:44 -0800 2020-01-21 12:34:48 -0800 Patch bug-206544-20200121114043.patch text/plain 1640 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJlMzg5M2IwYjQ2YmQ5Yzhj OGM0MTFmZjM3MDY3YjY5MmFjMjkxNTYuLmRiNGZjMjI2NzZhNWI2ODk3ZGYxZDQ2ODMxOTZmYzQ3 OWFmYWU3OTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjAtMDEtMjEgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgUGVyZm9ybWFuY2UgdGVzdHMg ZmFpbCBpZiBzdGRlcnIgbG9nZ2luZyBpcyBlbmNvdW50ZXJlZAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NTQ0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS81ODcxNDc2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTd2l0Y2ggdG8gTE9HX0VSUk9SLCByYXRoZXIgdGhhbiBXVEZMb2dBbHdheXMsIHRv IGF2b2lkIGNvbmZ1c2luZyB0aGUgUGVyZm9ybWFuY2VUZXN0cyBzeXN0ZW0uCisKKyAgICAgICAg KiBTaGFyZWQvQ29jb2EvU2FuZGJveEV4dGVuc2lvbkNvY29hLm1tOgorICAgICAgICAoV2ViS2l0 OjpTYW5kYm94RXh0ZW5zaW9uOjpjcmVhdGVIYW5kbGVGb3JSZWFkQnlBdWRpdFRva2VuKToKKwog MjAyMC0wMS0xNyAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBbaU9TXSBSZW1vdmUgdGhlIElPSElERXZlbnRTZXJ2aWNlRmFzdFBhdGhVc2VyQ2xpZW50IElP S2l0IGNsYXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9TYW5kYm94 RXh0ZW5zaW9uQ29jb2EubW0gYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9TYW5kYm94RXh0 ZW5zaW9uQ29jb2EubW0KaW5kZXggNTY3YzRiZWU5NjYxMWYyOGY5ZjExY2EyOWI3MjJmOTE5Y2Zl OTU4Yi4uMjE2NDA3MWVhNjFiOTFmODIwYTlkYzBlMGNhN2YyNzZlMTZiN2QwMCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9TaGFyZWQvQ29jb2EvU2FuZGJveEV4dGVuc2lvbkNvY29hLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL0NvY29hL1NhbmRib3hFeHRlbnNpb25Db2NvYS5tbQpA QCAtMzU1LDcgKzM1NSw3IEBAIGJvb2wgU2FuZGJveEV4dGVuc2lvbjo6Y3JlYXRlSGFuZGxlRm9y UmVhZEJ5QXVkaXRUb2tlbihjb25zdCBTdHJpbmcmIHBhdGgsIGF1ZGl0CiAKICAgICBoYW5kbGUu bV9zYW5kYm94RXh0ZW5zaW9uID0gU2FuZGJveEV4dGVuc2lvbkltcGw6OmNyZWF0ZShwYXRoLnV0 ZjgoKS5kYXRhKCksIFR5cGU6OlJlYWRCeVByb2Nlc3MsIGF1ZGl0VG9rZW4pOwogICAgIGlmICgh aGFuZGxlLm1fc2FuZGJveEV4dGVuc2lvbikgewotICAgICAgICBXVEZMb2dBbHdheXMoIkNvdWxk IG5vdCBjcmVhdGUgc2FuZGJveCBleHRlbnNpb24iKTsKKyAgICAgICAgTE9HX0VSUk9SKCJDb3Vs ZCBub3QgY3JlYXRlIGEgc2FuZGJveCBleHRlbnNpb24gZm9yICclcyciLCBwYXRoLnV0ZjgoKS5k YXRhKCkpOwogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgfQogICAgIAo=