206527 2020-01-21 06:03:34 -0800 [GTK][WPE] TestWebKitUserContentFilterStore is crashing 2020-01-21 07:39:58 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alex alex aperez berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo oldest_to_newest 1609005 0 alex 2020-01-21 06:03:34 -0800 There is a couple of assertions causing problems in the test: TEST: ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore... /webkit/WebKitUserContentFilterStore/empty-store: PASS /webkit/WebKitUserContentFilterStore/invalid-filter-source: PASS /webkit/WebKitUserContentFilterStore/filter-save-load: CRASH ASSERTION FAILED: error.category() == WebCore::ContentExtensions::contentExtensionErrorCategory() ../../Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp(73) : GError* toGError(WebKitUserContentFilterError, std::error_code) 1 0x7fb85a6fc739 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x9) [0x7fb85a6fc739] 2 0x561c9005611e ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(_Znwm10NotNullTagPv+0) [0x561c9005611e] 3 0x7fb86785bc87 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6d6c87) [0x7fb86785bc87] 4 0x7fb86785d330 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6d8330) [0x7fb86785d330] 5 0x7fb86785f77e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6da77e) [0x7fb86785f77e] 6 0x7fb8677af496 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK3WTF8FunctionIFvNS_6RefPtrIN3API15ContentRuleListENS_13DumbPtrTraitsIS3_EEEESt10error_codeEEclES6_S7_+0xb8) [0x7fb8677af496] 7 0x7fb8677ae1b2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3WTF17CompletionHandlerIFvNS_6RefPtrIN3API15ContentRuleListENS_13DumbPtrTraitsIS3_EEEESt10error_codeEEclES6_S7_+0x102) [0x7fb8677ae1b2] 8 0x7fb8677a2f79 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb61df79) [0x7fb8677a2f79] 9 0x7fb8677acd26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb627d26) [0x7fb8677acd26] 10 0x7fb866e092d9 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK3WTF8FunctionIFvvEEclEv+0x63) [0x7fb866e092d9] 11 0x7fb85a72bfaf /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF7RunLoop11performWorkEv+0xbb) [0x7fb85a72bfaf] 12 0x7fb85a7a2d74 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d74) [0x7fb85a7a2d74] 13 0x7fb85a7a2d98 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d98) [0x7fb85a7a2d98] 14 0x7fb85a7a2d26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d26) [0x7fb85a7a2d26] 15 0x7fb85a7a2d56 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d56) [0x7fb85a7a2d56] 16 0x7fb871e846b8 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_context_dispatch+0x138) [0x7fb871e846b8] 17 0x7fb871e84a78 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x4ca78) [0x7fb871e84a78] 18 0x7fb871e84d62 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_loop_run+0xb2) [0x7fb871e84d62] 19 0x561c90057316 ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0xa316) [0x561c90057316] 20 0x561c90055208 ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0x8208) [0x561c90055208] 21 0x7fb871eaab4a /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x72b4a) [0x7fb871eaab4a] 22 0x7fb871eaaa14 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x72a14) [0x7fb871eaaa14] 23 0x7fb871eaaa14 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x72a14) [0x7fb871eaaa14] 24 0x7fb871eaadf2 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_test_run_suite+0xc2) [0x7fb871eaadf2] 25 0x7fb871eaae11 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_test_run+0x11) [0x7fb871eaae11] 26 0x561c9005b4dc ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0xe4dc) [0x561c9005b4dc] 27 0x7fb852c4809b /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7fb852c4809b] 28 0x561c90054eda ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0x7eda) [0x561c90054eda] /webkit/WebKitUserContentFilterStore/saved-filter-identifier-match: PASS /webkit/WebKitUserContentFilterStore/remove-filter: CRASH ASSERTION FAILED: error.category() == WebCore::ContentExtensions::contentExtensionErrorCategory() ../../Source/WebKit/UIProcess/API/glib/WebKitUserContentFilterStore.cpp(73) : GError* toGError(WebKitUserContentFilterError, std::error_code) 1 0x7f17ec97e739 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(WTFCrash+0x9) [0x7f17ec97e739] 2 0x558185e2f11e ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(_Znwm10NotNullTagPv+0) [0x558185e2f11e] 3 0x7f17f9addc87 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6d6c87) [0x7f17f9addc87] 4 0x7f17f9adf330 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6d8330) [0x7f17f9adf330] 5 0x7f17f9ae177e /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb6da77e) [0x7f17f9ae177e] 6 0x7f17f9a31496 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK3WTF8FunctionIFvNS_6RefPtrIN3API15ContentRuleListENS_13DumbPtrTraitsIS3_EEEESt10error_codeEEclES6_S7_+0xb8) [0x7f17f9a31496] 7 0x7f17f9a301b2 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZN3WTF17CompletionHandlerIFvNS_6RefPtrIN3API15ContentRuleListENS_13DumbPtrTraitsIS3_EEEESt10error_codeEEclES6_S7_+0x102) [0x7f17f9a301b2] 8 0x7f17f9a24f79 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb61df79) [0x7f17f9a24f79] 9 0x7f17f9a2ed26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(+0xb627d26) [0x7f17f9a2ed26] 10 0x7f17f908b2d9 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libwebkit2gtk-4.0.so.37(_ZNK3WTF8FunctionIFvvEEclEv+0x63) [0x7f17f908b2d9] 11 0x7f17ec9adfaf /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(_ZN3WTF7RunLoop11performWorkEv+0xbb) [0x7f17ec9adfaf] 12 0x7f17eca24d74 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d74) [0x7f17eca24d74] 13 0x7f17eca24d98 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d98) [0x7f17eca24d98] 14 0x7f17eca24d26 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d26) [0x7f17eca24d26] 15 0x7f17eca24d56 /home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/lib/libjavascriptcoregtk-4.0.so.18(+0x36e1d56) [0x7f17eca24d56] 16 0x7f18041066b8 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_context_dispatch+0x138) [0x7f18041066b8] 17 0x7f1804106a78 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x4ca78) [0x7f1804106a78] 18 0x7f1804106d62 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_main_loop_run+0xb2) [0x7f1804106d62] 19 0x558185e30316 ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0xa316) [0x558185e30316] 20 0x558185e2e670 ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0x8670) [0x558185e2e670] 21 0x7f180412cb4a /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x72b4a) [0x7f180412cb4a] 22 0x7f180412ca14 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x72a14) [0x7f180412ca14] 23 0x7f180412ca14 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(+0x72a14) [0x7f180412ca14] 24 0x7f180412cdf2 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_test_run_suite+0xc2) [0x7f180412cdf2] 25 0x7f180412ce11 /home/slave/webkitgtk/gtk-linux-64-debug-tests/build/WebKitBuild/DependenciesGTK/Root/lib/libglib-2.0.so.0(g_test_run+0x11) [0x7f180412ce11] 26 0x558185e344dc ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0xe4dc) [0x558185e344dc] 27 0x7f17e4eca09b /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xeb) [0x7f17e4eca09b] 28 0x558185e2deda ./Tools/glib/../../WebKitBuild/Debug/bin/TestWebKitAPI/WebKit2Gtk/TestWebKitUserContentFilterStore(+0x7eda) [0x558185e2deda] 1609006 1 388293 alex 2020-01-21 06:09:08 -0800 Created attachment 388293 Patch 1609007 2 ews-watchlist 2020-01-21 06:10:12 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1609015 3 388293 aperez 2020-01-21 06:50:47 -0800 Comment on attachment 388293 Patch Nice catch! 1609032 4 388293 commit-queue 2020-01-21 07:39:56 -0800 Comment on attachment 388293 Patch Clearing flags on attachment: 388293 Committed r254852: <https://trac.webkit.org/changeset/254852> 1609033 5 commit-queue 2020-01-21 07:39:58 -0800 All reviewed patches have been landed. Closing bug. 388293 2020-01-21 06:09:08 -0800 2020-01-21 07:39:56 -0800 Patch bug-206527-20200121150907.patch text/plain 2463 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGFjYTFlOWMyYzBlYmY5Yjk3 ODI4MDQ2ZTYyNGMxN2YwY2ZiOTVlZjkuLmNjYjU5MDJiYmY1OTEzYTk0YmRjZDQ4MmQ4OWEwODM0 ZTFkMDJlODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjAtMDEtMjEgIEFsZWphbmRy byBHLiBDYXN0cm8gIDxhbGV4QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBUZXN0 V2ViS2l0VXNlckNvbnRlbnRGaWx0ZXJTdG9yZSBpcyBjcmFzaGluZworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NTI3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYXJlIGFzc2VydGluZyBsb29raW5n IGZvciBhIGNhdGVnb3J5IG9mIGVycm9yIHdoZW4gY29udmVydGluZworICAgICAgICBpbiB0aGUg dG9HRXJyb3IgZnVuY3Rpb24sIGJ1dCBkZXBlbmRpbmcgb24gdGhlIGZ1bmN0aW9uIGNhbGxlZCB0 aGUKKyAgICAgICAgY2F0ZWdvcnkgY2FuIGJlIGRpZmZlcmVudC4KKworICAgICAgICAqIFVJUHJv Y2Vzcy9BUEkvZ2xpYi9XZWJLaXRVc2VyQ29udGVudEZpbHRlclN0b3JlLmNwcDoKKyAgICAgICAg KHRvR0Vycm9yKToKKyAgICAgICAgKHdlYmtpdFVzZXJDb250ZW50RmlsdGVyU3RvcmVTYXZlQnl0 ZXMpOiBNb3ZlZCB0aGUgQVNTRVJUIHRvIHRoZQorICAgICAgICBmdW5jdGlvbiB0aGF0IHVzZXMg dGhpcyBjYXRlZ29yeSwgdGhlIG90aGVyIGZ1bmN0aW9ucyBjYWxsaW5nCisgICAgICAgIHRvR0Vy cm9yIHdlcmUgYWxyZWFkeSBBU1NFUlRpbmcgdGhlIGNvcnJlY3QgY2F0ZWdvcnkuCisKIDIwMjAt MDEtMjEgIHlvdWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIExvZyB0 aGUgZGVzdGluYXRpb24gb2YgYSBsb2FkIHdoZW4gaGl0dGluZyBuZXR3b3JrIHByb2Nlc3MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVzZXJDb250 ZW50RmlsdGVyU3RvcmUuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2Vi S2l0VXNlckNvbnRlbnRGaWx0ZXJTdG9yZS5jcHAKaW5kZXggNDJiZDk5N2M3ZGU5M2UzNGRlNWVi Y2JmYzAxOTlmYzlhMDA3NjViOC4uYzZlYmU5OTdmODBlNjA1Yzc0MTUxOWY1ZTc1ZmJlMDBmOGZh YjUwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvV2ViS2l0 VXNlckNvbnRlbnRGaWx0ZXJTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL2dsaWIvV2ViS2l0VXNlckNvbnRlbnRGaWx0ZXJTdG9yZS5jcHAKQEAgLTcwLDcgKzcwLDYg QEAgZW51bSB7CiBzdGF0aWMgaW5saW5lIEdFcnJvciogdG9HRXJyb3IoV2ViS2l0VXNlckNvbnRl bnRGaWx0ZXJFcnJvciBjb2RlLCBjb25zdCBzdGQ6OmVycm9yX2NvZGUgZXJyb3IpCiB7CiAgICAg QVNTRVJUKGVycm9yKTsKLSAgICBBU1NFUlQoZXJyb3IuY2F0ZWdvcnkoKSA9PSBXZWJDb3JlOjpD b250ZW50RXh0ZW5zaW9uczo6Y29udGVudEV4dGVuc2lvbkVycm9yQ2F0ZWdvcnkoKSk7CiAgICAg cmV0dXJuIGdfZXJyb3JfbmV3X2xpdGVyYWwoV0VCS0lUX1VTRVJfQ09OVEVOVF9GSUxURVJfRVJS T1IsIGNvZGUsIGVycm9yLm1lc3NhZ2UoKS5jX3N0cigpKTsKIH0KIApAQCAtMTg3LDkgKzE4Niwx MCBAQCBzdGF0aWMgdm9pZCB3ZWJraXRVc2VyQ29udGVudEZpbHRlclN0b3JlU2F2ZUJ5dGVzKEdS ZWZQdHI8R1Rhc2s+JiYgdGFzaywgU3RyaW5nJgogICAgICAgICBpZiAoZ190YXNrX3JldHVybl9l cnJvcl9pZl9jYW5jZWxsZWQodGFzay5nZXQoKSkpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAg ICAgICAgaWYgKGVycm9yKQorICAgICAgICBpZiAoZXJyb3IpIHsKKyAgICAgICAgICAgIEFTU0VS VChlcnJvci5jYXRlZ29yeSgpID09IFdlYkNvcmU6OkNvbnRlbnRFeHRlbnNpb25zOjpjb250ZW50 RXh0ZW5zaW9uRXJyb3JDYXRlZ29yeSgpKTsKICAgICAgICAgICAgIGdfdGFza19yZXR1cm5fZXJy b3IodGFzay5nZXQoKSwgdG9HRXJyb3IoV0VCS0lUX1VTRVJfQ09OVEVOVF9GSUxURVJfRVJST1Jf SU5WQUxJRF9TT1VSQ0UsIGVycm9yKSk7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgfSBlbHNlCiAg ICAgICAgICAgICBnX3Rhc2tfcmV0dXJuX3BvaW50ZXIodGFzay5nZXQoKSwgd2Via2l0VXNlckNv bnRlbnRGaWx0ZXJDcmVhdGUoV1RGTW92ZShjb250ZW50UnVsZUxpc3QpKSwgcmVpbnRlcnByZXRf Y2FzdDxHRGVzdHJveU5vdGlmeT4od2Via2l0X3VzZXJfY29udGVudF9maWx0ZXJfdW5yZWYpKTsK ICAgICB9KTsKIH0K