206517 2020-01-20 20:30:16 -0800 [WebKitTestRunner] setOpenPanelFiles support in non-local tests 2024-08-07 17:18:09 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=277772 InRadar P2 Normal --- 1 lmoura lmoura aestes clopez commit-queue thorton webkit-bug-importer oldest_to_newest 1608923 0 lmoura 2020-01-20 20:30:16 -0800 `TestRunner::setOpenPanelFiles` always uses `m_testURL' as base URL for the files it will provide to the given form. While this this works nice for tests using `file://`, this breaks tests using remote URLs, as a resulting URL like `http://127.0.0.1:8000/misc/foo.txt` would fail to be converted to a local file with the default implementation of `WTF::URL::fileSystemPath`. The mac port seems to work around this with CF's implementation of this method. Example of test failing in webkitgtk due to this: * http/tests/misc/form-submit-file-cross-site-redirect.html 1608924 1 388276 lmoura 2020-01-20 20:42:57 -0800 Created attachment 388276 Tentative patch Tentative patch by treating paths passed to setOpenPanelFiles with leading slash as absolute file:// paths. 1609002 2 lmoura 2020-01-21 06:01:29 -0800 EWS failures: * win: fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html * Flaky, failing from time to time with unrelated patches * https://ews-build.webkit.org/#/builders/10 * mac-wk2: inspector/heap/getRemoteObject.html * Ditto * https://ews-build.webkit.org/#/builders/31 * api-ios: KeyboardInputTests.SupportsImagePaste * Ditto * https://ews-build.webkit.org/#/builders/9 * api-mac: WebAuthenticationPanel.PanelHidCtapNoCredentialsFound * Ditto * https://ews-build.webkit.org/#/builders/3 1609008 3 lmoura 2020-01-21 06:10:46 -0800 cc'ing Andy and Tim (original author and reviewer) for review. 1612905 4 388276 clopez 2020-01-30 04:28:21 -0800 Comment on attachment 388276 Tentative patch Does this patch fixes any test? Then I think this patch should also unlist the failures it fixes from the TestExpectation 1613128 5 389284 lmoura 2020-01-30 14:02:35 -0800 Created attachment 389284 Patch 1613130 6 lmoura 2020-01-30 14:04:28 -0800 (In reply to Carlos Alberto Lopez Perez from comment #4) > Comment on attachment 388276 [details] > Tentative patch > > Does this patch fixes any test? Then I think this patch should also unlist > the failures it fixes from the TestExpectation Right, updated with the new expectations. The redirect test is still failing despite loading the correct data, so I opened a bug for it in bug207016. 1614109 7 commit-queue 2020-02-03 13:29:53 -0800 The commit-queue encountered the following flaky tests while processing attachment 389284: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1614112 8 commit-queue 2020-02-03 13:30:18 -0800 The commit-queue encountered the following flaky tests while processing attachment 389284: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1614136 9 389284 commit-queue 2020-02-03 13:54:58 -0800 Comment on attachment 389284 Patch Clearing flags on attachment: 389284 Committed r255590: <https://trac.webkit.org/changeset/255590> 1614137 10 commit-queue 2020-02-03 13:55:00 -0800 All reviewed patches have been landed. Closing bug. 1614138 11 webkit-bug-importer 2020-02-03 13:55:15 -0800 <rdar://problem/59124286> 388276 2020-01-20 20:42:57 -0800 2020-01-30 14:02:21 -0800 Tentative patch bug-206517-20200121014255.patch text/plain 1859 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODE2MmM2NjZjZGE5ZjQzZGYxOGJkNjdjMmIxNGY3MDI1 YTE1NTUwYy4uYWJjMTRkZTViODc0OTQxMDI1ZWM0NTkyNzdlMWEyMDUyZWVlYTYxNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAxLTIwICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtXZWJLaXRUZXN0UnVubmVyXSBzZXRPcGVuUGFuZWxGaWxlcyBzdXBwb3J0IGluIG5vbi1s b2NhbCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA2NTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwOgorICAg ICAgICAoV1RSOjpUZXN0UnVubmVyOjpzZXRPcGVuUGFuZWxGaWxlcyk6IFVzZSBmaWxlOi8vIGlm IHRoZSBwYXNzZWQgcGF0aAorICAgICAgICBzdGFydHMgd2l0aCBhIGxlYWRpbmcgc2xhc2ggaW5z dGVhZCBvZiB1c2luZyB0aGUgdGVzdCBVUkwsIHdoaWNoIGNvdWxkCisgICAgICAgIGNhdXNlIGlu cHV0IGZvcm1zIHdpdGggaW52YWxpZCBmaWxlIGRhdGEuCisKIDIwMjAtMDEtMjAgIFphbiBEb2Jl cnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEV4cG9zZSB0aGUg V2ViS2l0T3B0aW9uTWVudSBBUElzCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVy L0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcAppbmRleCAyZWEzY2JkNzJiNDJiMmEzMGNhMmE3 NmM4NjVjMWRhYjAyMjllYzVhLi41ZTc1OWFiNjcwZTE0MTViY2ZmMGIxMzg2ZTY1NDQwOGU5MWFi MzBjIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rl c3RSdW5uZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUv VGVzdFJ1bm5lci5jcHAKQEAgLTI1OTAsNyArMjU5MCwxMyBAQCB2b2lkIFRlc3RSdW5uZXI6OnNl dE9wZW5QYW5lbEZpbGVzKEpTVmFsdWVSZWYgZmlsZXNWYWx1ZSkKICAgICAgICAgYXV0byBmaWxl QnVmZmVyID0gbWFrZVVuaXF1ZUFycmF5PGNoYXI+KGZpbGVCdWZmZXJTaXplKTsKICAgICAgICAg SlNTdHJpbmdHZXRVVEY4Q1N0cmluZyhmaWxlLmdldCgpLCBmaWxlQnVmZmVyLmdldCgpLCBmaWxl QnVmZmVyU2l6ZSk7CiAKLSAgICAgICAgV0tBcnJheUFwcGVuZEl0ZW0oZmlsZVVSTHMuZ2V0KCks IGFkb3B0V0soV0tVUkxDcmVhdGVXaXRoQmFzZVVSTChtX3Rlc3RVUkwuZ2V0KCksIGZpbGVCdWZm ZXIuZ2V0KCkpKS5nZXQoKSk7CisgICAgICAgIGF1dG8gYmFzZVVSTCA9IG1fdGVzdFVSTC5nZXQo KTsKKworICAgICAgICBpZiAoZmlsZUJ1ZmZlclswXSA9PSAnLycpCisgICAgICAgICAgICBiYXNl VVJMID0gV0tVUkxDcmVhdGVXaXRoVVRGOENTdHJpbmcoImZpbGU6Ly8iKTsKKworICAgICAgICBX S0FycmF5QXBwZW5kSXRlbShmaWxlVVJMcy5nZXQoKSwgYWRvcHRXSyhXS1VSTENyZWF0ZVdpdGhC YXNlVVJMKGJhc2VVUkwsIGZpbGVCdWZmZXIuZ2V0KCkpKS5nZXQoKSk7CisKICAgICB9CiAKICAg ICBzdGF0aWMgYXV0byBtZXNzYWdlTmFtZSA9IGFkb3B0V0soV0tTdHJpbmdDcmVhdGVXaXRoVVRG OENTdHJpbmcoIlNldE9wZW5QYW5lbEZpbGVVUkxzIikpOwo= 389284 2020-01-30 14:02:35 -0800 2020-02-03 13:54:58 -0800 Patch bug-206517-20200130190233.patch text/plain 3974 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1NDE5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWRmYzg0MWZkZjI4YTUzMjZiOTc5MjkzMzlmMTRhNjUw NTBjMjE5Ni4uZDEzMDA4YzcwNjY0Y2RjYmZjYmRhZjRmYTVhYzNmYmVlNGM5ZDZjNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIwLTAxLTMwICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtXZWJLaXRUZXN0UnVubmVyXSBzZXRPcGVuUGFuZWxGaWxlcyBzdXBwb3J0IGluIG5vbi1s b2NhbCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjA2NTE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwOgorICAg ICAgICAoV1RSOjpUZXN0UnVubmVyOjpzZXRPcGVuUGFuZWxGaWxlcyk6IFVzZSBmaWxlOi8vIGlm IHRoZSBwYXNzZWQgcGF0aAorICAgICAgICBzdGFydHMgd2l0aCBhIGxlYWRpbmcgc2xhc2ggaW5z dGVhZCBvZiB1c2luZyB0aGUgdGVzdCBVUkwsIHdoaWNoIGNvdWxkCisgICAgICAgIGNhdXNlIGlu cHV0IGZvcm1zIHdpdGggaW52YWxpZCBmaWxlIGRhdGEuCisKIDIwMjAtMDEtMjkgIEpvbmF0aGFu IEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIHJ1bi1zYWZhcmkgLyBydW4t d2Via2l0LXRlc3RzIC0taW9zLXNpbXVsYXRvciBub3Qgd29ya2luZyB3aXRoIFhDb2RlIDEzLjMu MSAoMTFDNTA0KQpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1 bmRsZS9UZXN0UnVubmVyLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5k bGUvVGVzdFJ1bm5lci5jcHAKaW5kZXggMmVhM2NiZDcyYjQyYjJhMzBjYTJhNzZjODY1YzFkYWIw MjI5ZWM1YS4uNWU3NTlhYjY3MGUxNDE1YmNmZjBiMTM4NmU2NTQ0MDhlOTFhYjMwYyAxMDA2NDQK LS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNw cAorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIu Y3BwCkBAIC0yNTkwLDcgKzI1OTAsMTMgQEAgdm9pZCBUZXN0UnVubmVyOjpzZXRPcGVuUGFuZWxG aWxlcyhKU1ZhbHVlUmVmIGZpbGVzVmFsdWUpCiAgICAgICAgIGF1dG8gZmlsZUJ1ZmZlciA9IG1h a2VVbmlxdWVBcnJheTxjaGFyPihmaWxlQnVmZmVyU2l6ZSk7CiAgICAgICAgIEpTU3RyaW5nR2V0 VVRGOENTdHJpbmcoZmlsZS5nZXQoKSwgZmlsZUJ1ZmZlci5nZXQoKSwgZmlsZUJ1ZmZlclNpemUp OwogCi0gICAgICAgIFdLQXJyYXlBcHBlbmRJdGVtKGZpbGVVUkxzLmdldCgpLCBhZG9wdFdLKFdL VVJMQ3JlYXRlV2l0aEJhc2VVUkwobV90ZXN0VVJMLmdldCgpLCBmaWxlQnVmZmVyLmdldCgpKSku Z2V0KCkpOworICAgICAgICBhdXRvIGJhc2VVUkwgPSBtX3Rlc3RVUkwuZ2V0KCk7CisKKyAgICAg ICAgaWYgKGZpbGVCdWZmZXJbMF0gPT0gJy8nKQorICAgICAgICAgICAgYmFzZVVSTCA9IFdLVVJM Q3JlYXRlV2l0aFVURjhDU3RyaW5nKCJmaWxlOi8vIik7CisKKyAgICAgICAgV0tBcnJheUFwcGVu ZEl0ZW0oZmlsZVVSTHMuZ2V0KCksIGFkb3B0V0soV0tVUkxDcmVhdGVXaXRoQmFzZVVSTChiYXNl VVJMLCBmaWxlQnVmZmVyLmdldCgpKSkuZ2V0KCkpOworCiAgICAgfQogCiAgICAgc3RhdGljIGF1 dG8gbWVzc2FnZU5hbWUgPSBhZG9wdFdLKFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCJT ZXRPcGVuUGFuZWxGaWxlVVJMcyIpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAzODM1OWJhNGZiNzNjODczOTYxZWQzYWZm OGExZTNjM2E2MzI4ZTNkLi4yODQzYWY4Nzg0MTFhODJjMWNkMDhkYTMyZDhhN2ZkY2YyZjFjZmEx IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjAtMDEtMzAgIExhdXJvIE1vdXJhICA8bG1vdXJh QGlnYWxpYS5jb20+CisKKyAgICAgICAgW1dlYktpdFRlc3RSdW5uZXJdIHNldE9wZW5QYW5lbEZp bGVzIHN1cHBvcnQgaW4gbm9uLWxvY2FsIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDY1MTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOiBV cGRhdGUgZXhwZWN0YXRpb25zIGFmdGVyIGZpeC4KKwogMjAyMC0wMS0zMCAgUm9zc2FuYSBNb250 ZXJpc28gIDxybW9udGVyaXNvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW2Nzcy1ncmlkXSBNb3Zl IGdyaWQtaXRlbS1hbGlnbm1lbnQgdGVzdHMgdG8gV1BUIGZvbGRlcgpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwppbmRleCAyYjIxY2QyNWViYjgxYzgxM2ZmOGQ5MzJi OGY4ZDBiMDEwNTk5ODM5Li42NmRlZTU5NDhhY2ExYWNkNGNhYmU5NTBlNGFlYThmMGM1ZTFmMjZm IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwor KysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucwpAQCAtMzgzNSw4 ICszODM1LDYgQEAgd2Via2l0Lm9yZy9iLzE5MzQ5MyBmYXN0L3RleHQvaW50ZXJuYXRpb25hbC9z cGFjZXMtY29tYmluZWQtaW4tdmVydGljYWwtdGV4dC5odG0KIAogd2Via2l0Lm9yZy9iLzE5MzUx MSBodHRwL3Rlc3RzL2ltYWdlcy9tcDQtcGFydGlhbC1sb2FkLmh0bWwgWyBGYWlsdXJlIF0KIAot d2Via2l0Lm9yZy9iLzE5MzUxNiBodHRwL3Rlc3RzL21pc2MvZm9ybS1zdWJtaXQtZmlsZS1jcm9z cy1zaXRlLmh0bWwgWyBGYWlsdXJlIF0KLQogd2Via2l0Lm9yZy9iLzE5MzYyNyBlZGl0aW5nL3Nw ZWxsaW5nL3NwZWxsaW5nLWRvdHMtcG9zaXRpb24uaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQog CiB3ZWJraXQub3JnL2IvMTkzNjI4IGZhc3QvY3NzL2NvbnRlbnQtY291bnRlci0wMTAuaHRtIFsg SW1hZ2VPbmx5RmFpbHVyZSBdCkBAIC00MTAxLDggKzQwOTksNyBAQCB3ZWJraXQub3JnL2IvMjA0 Njc1IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvb2Zmc2NyZWVuLWNhbnZhcy9pbWFn ZS1zbW9vdAogd2Via2l0Lm9yZy9iLzIwNDY3NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL29mZnNjcmVlbi1jYW52YXMvdGhlLW9mZnNjcmVlbi1jYW52YXMvaW5pdGlhbC5yZXNldC5w YXR0ZXJuLmh0bWwgWyBGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8yMDQ2NzUgaW1wb3J0ZWQvdzNj L3dlYi1wbGF0Zm9ybS10ZXN0cy9vZmZzY3JlZW4tY2FudmFzL3RoZS1vZmZzY3JlZW4tY2FudmFz L2luaXRpYWwucmVzZXQucGF0dGVybi53b3JrZXIuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQu b3JnL2IvMjA2NTE3IGh0dHAvdGVzdHMvbWlzYy9mb3JtLXN1Ym1pdC1maWxlLWNyb3NzLXNpdGUt cmVkaXJlY3QuaHRtbCBbIEZhaWx1cmUgXQotd2Via2l0Lm9yZy9iLzIwNjUxNyBodHRwL3dwdC9z ZXJ2aWNlLXdvcmtlcnMvZmlsZS11cGxvYWQuaHRtbCBbIEZhaWx1cmUgXQord2Via2l0Lm9yZy9i LzIwNzAxNiBodHRwL3Rlc3RzL21pc2MvZm9ybS1zdWJtaXQtZmlsZS1jcm9zcy1zaXRlLXJlZGly ZWN0Lmh0bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzIwNjY5MiBmYXN0L2NhbnZhcy9j YW52YXMtZmlsbFBhdGgtc2hhZG93Lmh0bWwgWyBGYWlsdXJlIF0KIAo=