206502 2020-01-20 07:19:53 -0800 [GTK][WPE] InputMethodFilter: do not notify about focus in when only content type changed 2020-01-20 07:53:05 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned aperez berto bugs-noreply ews-watchlist gustavo oldest_to_newest 1608751 0 cgarcia 2020-01-20 07:19:53 -0800 That's unbalancing the focus in/out notifications. 1608758 1 388240 cgarcia 2020-01-20 07:22:43 -0800 Created attachment 388240 Patch 1608759 2 ews-watchlist 2020-01-20 07:23:38 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1608769 3 cgarcia 2020-01-20 07:53:05 -0800 Committed r254826: <https://trac.webkit.org/changeset/254826> 388240 2020-01-20 07:22:43 -0800 2020-01-20 07:24:15 -0800 Patch wk2-ime-focus.diff text/plain 3705 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggMzBhMWNjZGEzNjcuLjVmMWM1MGFlZDA4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDIwLTAxLTIwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIElucHV0TWV0aG9kRmlsdGVyOiBkbyBub3Qgbm90 aWZ5IGFib3V0IGZvY3VzIGluIHdoZW4gb25seSBjb250ZW50IHR5cGUgY2hhbmdlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NTAyCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhhdCdzIHVuYmFsYW5j aW5nIHRoZSBmb2N1cyBpbi9vdXQgbm90aWZpY2F0aW9ucy4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ2xpYi9JbnB1dE1ldGhvZEZpbHRlci5jcHA6CisgICAgICAgIChXZWJLaXQ6OklucHV0 TWV0aG9kRmlsdGVyOjpzZXRDb250ZXh0KTogQWx3YXlzIGNhbGwgbm90aWZ5Q29udGVudFR5cGUo KS4KKyAgICAgICAgKFdlYktpdDo6SW5wdXRNZXRob2RGaWx0ZXI6OnNldFN0YXRlKTogT25seSBj YWxsIG5vdGlmeUZvY3VzZWRJbigpIGFuZCBub3RpZnlGb2N1c2VkT3V0IHdoZW4gdGhlcmUncyBh IGZvY3VzIGNoYW5nZS4KKyAgICAgICAgKFdlYktpdDo6SW5wdXRNZXRob2RGaWx0ZXI6Om5vdGlm eUNvbnRlbnRUeXBlKTogTm90aWZ5IGNvbnRlbnQgdHlwZSBpZiBjaGFuZ2VkLgorICAgICAgICAo V2ViS2l0OjpJbnB1dE1ldGhvZEZpbHRlcjo6bm90aWZ5Rm9jdXNlZEluKTogTW92ZSB0aGUgY29u dGVudCB0eXBlIG5vdGlmaWNhdGlvbiB0byBpdHMgb3duIGZ1bmN0aW9uLgorICAgICAgICAqIFVJ UHJvY2Vzcy9BUEkvZ2xpYi9JbnB1dE1ldGhvZEZpbHRlci5oOgorCiAyMDIwLTAxLTIwICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXVtX UEVdIEFsc28gaW5jbHVkZSB0aGUgc2VsZWN0aW9uIGluZGV4IGluIHdlYmtpdF9pbnB1dF9tZXRo b2RfY29udGV4dF9ub3RpZnlfc3Vycm91bmRpbmcoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2dsaWIvSW5wdXRNZXRob2RGaWx0ZXIuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL2dsaWIvSW5wdXRNZXRob2RGaWx0ZXIuY3BwCmluZGV4IGIxNzczZjFk Mjk5Li5kZGI4MmEyNzlkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJ L2dsaWIvSW5wdXRNZXRob2RGaWx0ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9nbGliL0lucHV0TWV0aG9kRmlsdGVyLmNwcApAQCAtNzcsMTcgKzc3LDIyIEBAIHZvaWQg SW5wdXRNZXRob2RGaWx0ZXI6OnNldENvbnRleHQoV2ViS2l0SW5wdXRNZXRob2RDb250ZXh0KiBj b250ZXh0KQogICAgIGdfc2lnbmFsX2Nvbm5lY3Rfc3dhcHBlZChtX2NvbnRleHQuZ2V0KCksICJj b21taXR0ZWQiLCBHX0NBTExCQUNLKGNvbW1pdHRlZENhbGxiYWNrKSwgdGhpcyk7CiAgICAgZ19z aWduYWxfY29ubmVjdF9zd2FwcGVkKG1fY29udGV4dC5nZXQoKSwgImRlbGV0ZS1zdXJyb3VuZGlu ZyIsIEdfQ0FMTEJBQ0soZGVsZXRlU3Vycm91bmRpbmdDYWxsYmFjayksIHRoaXMpOwogCisgICAg bm90aWZ5Q29udGVudFR5cGUoKTsKKwogICAgIGlmIChpc0VuYWJsZWQoKSAmJiBpc1ZpZXdGb2N1 c2VkKCkpCiAgICAgICAgIG5vdGlmeUZvY3VzZWRJbigpOwogfQogCiB2b2lkIElucHV0TWV0aG9k RmlsdGVyOjpzZXRTdGF0ZShPcHRpb25hbDxJbnB1dE1ldGhvZFN0YXRlPiYmIHN0YXRlKQogewot ICAgIGlmICghc3RhdGUpCisgICAgYm9vbCBmb2N1c0NoYW5nZWQgPSBzdGF0ZS5oYXNWYWx1ZSgp ICE9IG1fc3RhdGUuaGFzVmFsdWUoKTsKKyAgICBpZiAoZm9jdXNDaGFuZ2VkICYmICFzdGF0ZSkK ICAgICAgICAgbm90aWZ5Rm9jdXNlZE91dCgpOwogCiAgICAgbV9zdGF0ZSA9IFdURk1vdmUoc3Rh dGUpOwotICAgIGlmIChpc0VuYWJsZWQoKSAmJiBpc1ZpZXdGb2N1c2VkKCkpCisgICAgbm90aWZ5 Q29udGVudFR5cGUoKTsKKworICAgIGlmIChmb2N1c0NoYW5nZWQgJiYgaXNFbmFibGVkKCkgJiYg aXNWaWV3Rm9jdXNlZCgpKQogICAgICAgICBub3RpZnlGb2N1c2VkSW4oKTsKIH0KIApAQCAtMTcy LDcgKzE3Nyw4IEBAIHN0YXRpYyBXZWJLaXRJbnB1dEhpbnRzIHRvV2ViS2l0SGludHMoY29uc3Qg T3B0aW9uU2V0PElucHV0TWV0aG9kU3RhdGU6OkhpbnQ+JiBoCiAgICAgICAgIHdrSGludHMgfD0g V0VCS0lUX0lOUFVUX0hJTlRfSU5ISUJJVF9PU0s7CiAgICAgcmV0dXJuIHN0YXRpY19jYXN0PFdl YktpdElucHV0SGludHM+KHdrSGludHMpOwogfQotdm9pZCBJbnB1dE1ldGhvZEZpbHRlcjo6bm90 aWZ5Rm9jdXNlZEluKCkKKwordm9pZCBJbnB1dE1ldGhvZEZpbHRlcjo6bm90aWZ5Q29udGVudFR5 cGUoKQogewogICAgIGlmICghaXNFbmFibGVkKCkgfHwgIW1fY29udGV4dCkKICAgICAgICAgcmV0 dXJuOwpAQCAtMTgxLDYgKzE4NywxMyBAQCB2b2lkIElucHV0TWV0aG9kRmlsdGVyOjpub3RpZnlG b2N1c2VkSW4oKQogICAgIHdlYmtpdF9pbnB1dF9tZXRob2RfY29udGV4dF9zZXRfaW5wdXRfcHVy cG9zZShtX2NvbnRleHQuZ2V0KCksIHRvV2ViS2l0UHVycG9zZShtX3N0YXRlLT5wdXJwb3NlKSk7 CiAgICAgd2Via2l0X2lucHV0X21ldGhvZF9jb250ZXh0X3NldF9pbnB1dF9oaW50cyhtX2NvbnRl eHQuZ2V0KCksIHRvV2ViS2l0SGludHMobV9zdGF0ZS0+aGludHMpKTsKICAgICBnX29iamVjdF90 aGF3X25vdGlmeShHX09CSkVDVChtX2NvbnRleHQuZ2V0KCkpKTsKK30KKwordm9pZCBJbnB1dE1l dGhvZEZpbHRlcjo6bm90aWZ5Rm9jdXNlZEluKCkKK3sKKyAgICBpZiAoIWlzRW5hYmxlZCgpIHx8 ICFtX2NvbnRleHQpCisgICAgICAgIHJldHVybjsKKwogICAgIHdlYmtpdF9pbnB1dF9tZXRob2Rf Y29udGV4dF9ub3RpZnlfZm9jdXNfaW4obV9jb250ZXh0LmdldCgpKTsKIH0KIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL2dsaWIvSW5wdXRNZXRob2RGaWx0ZXIuaCBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL0lucHV0TWV0aG9kRmlsdGVyLmgKaW5k ZXggYTQwYTgxZDE2M2YuLmExMTBkOTU3NTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvZ2xpYi9JbnB1dE1ldGhvZEZpbHRlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9nbGliL0lucHV0TWV0aG9kRmlsdGVyLmgKQEAgLTg3LDYgKzg3LDggQEAg cHJpdmF0ZToKICAgICBib29sIGlzRW5hYmxlZCgpIGNvbnN0IHsgcmV0dXJuICEhbV9zdGF0ZTsg fQogICAgIGJvb2wgaXNWaWV3Rm9jdXNlZCgpIGNvbnN0OwogCisgICAgdm9pZCBub3RpZnlDb250 ZW50VHlwZSgpOworCiAgICAgV2ViQ29yZTo6SW50UmVjdCBwbGF0Zm9ybVRyYW5zZm9ybUN1cnNv clJlY3RUb1ZpZXdDb29yZGluYXRlcyhjb25zdCBXZWJDb3JlOjpJbnRSZWN0Jik7CiAgICAgYm9v bCBwbGF0Zm9ybUV2ZW50S2V5SXNLZXlQcmVzcyhQbGF0Zm9ybUV2ZW50S2V5KikgY29uc3Q7CiAK