206500 2020-01-20 06:48:08 -0800 Invalid usage of ENABLE() before it's defined in WebCore/layout/integration/LayoutIntegrationBoxTree.cpp 2020-01-20 07:44:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez cgarcia clopez commit-queue webkit-bug-importer zan oldest_to_newest 1608741 0 aperez 2020-01-20 06:48:08 -0800 The ENABLE() macro is used before "config.h" gets a chance to be included, which makes the compilation trip. In the usual arches (at least for the ones tested by EWS bots) unified builds are masking the issue. 1608742 1 388236 aperez 2020-01-20 06:49:41 -0800 Created attachment 388236 Patch 1608743 2 388236 cgarcia 2020-01-20 06:54:24 -0800 Comment on attachment 388236 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388236&action=review > Source/WebCore/layout/integration/LayoutIntegrationBoxTree.cpp:30 > -#if ENABLE(LAYOUT_FORMATTING_CONTEXT) > - > #include "config.h" > + > +#if ENABLE(LAYOUT_FORMATTING_CONTEXT) > + > #include "LayoutIntegrationBoxTree.h" The header is already guarded, so this should be: #include "config.h" #include "LayoutIntegrationBoxTree.h" #if ENABLE(LAYOUT_FORMATTING_CONTEXT) 1608748 3 388237 aperez 2020-01-20 07:09:10 -0800 Created attachment 388237 Patch for landing 1608763 4 commit-queue 2020-01-20 07:42:39 -0800 The commit-queue encountered the following flaky tests while processing attachment 388237: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1608764 5 388237 commit-queue 2020-01-20 07:43:14 -0800 Comment on attachment 388237 Patch for landing Clearing flags on attachment: 388237 Committed r254825: <https://trac.webkit.org/changeset/254825> 1608765 6 commit-queue 2020-01-20 07:43:16 -0800 All reviewed patches have been landed. Closing bug. 1608766 7 webkit-bug-importer 2020-01-20 07:44:13 -0800 <rdar://problem/58738949> 388236 2020-01-20 06:49:41 -0800 2020-01-20 07:09:06 -0800 Patch bug-206500-20200120164940.patch text/plain 1437 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTlmNjQzOTY1ZmVmYTcy MjhiMDE3MjBjNjVlZGZlZGFkMDMxZTBiMS4uY2ZlOGMyNDhjZjBhYzI5NGRlMzVmZGM5MGViZmE4 ZjgzNThjYWRjMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAxLTIwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgSW52YWxp ZCB1c2FnZSBvZiBFTkFCTEUoKSBiZWZvcmUgaXQncyBkZWZpbmVkIGluIFdlYkNvcmUvbGF5b3V0 L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQm94VHJlZS5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjUwMAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisK KyAgICAgICAgKiBsYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25Cb3hUcmVlLmNw cDogSW5jbHVkZSAiY29uZmlnLmgiCisgICAgICAgIGJlZm9yZSB1c2luZyB0aGUgRU5BQkxFKCkg bWFjcm8sIHRvIG1ha2Ugc3VyZSB0aGF0IGl0IGdldHMgZGVmaW5lZC4KKwogMjAyMC0wMS0yMCAg Um9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIE1ha2UgaXNWYWxpZFVzZXJB Z2VudEhlYWRlclZhbHVlIEdMaWIgb25seQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQm94VHJlZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25Cb3hUcmVlLmNwcAppbmRl eCBkMjFhMjA3NDgwYzVmMmRmZWU4ZjRmMDdiMjBjZmE5OGJmMzQ2ZmY4Li4yZTVhZTBjZWRlNTNm ODEwZGEzYTk4Mzk4NjIxOGI2ODFjM2JjZTRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25Cb3hUcmVlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25Cb3hUcmVlLmNw cApAQCAtMjMsOSArMjMsMTAgQEAKICAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4K ICAqLwogCi0jaWYgRU5BQkxFKExBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQpCi0KICNpbmNsdWRl ICJjb25maWcuaCIKKworI2lmIEVOQUJMRShMQVlPVVRfRk9STUFUVElOR19DT05URVhUKQorCiAj aW5jbHVkZSAiTGF5b3V0SW50ZWdyYXRpb25Cb3hUcmVlLmgiCiAKICNpbmNsdWRlICJSZW5kZXJC bG9ja0Zsb3cuaCIK 388237 2020-01-20 07:09:10 -0800 2020-01-20 07:43:14 -0800 Patch for landing bug-206500-20200120170909.patch text/plain 1473 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0ODIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGFjZGZkMmRjYWM3YzAw MDlhYTlkOGUyNTI5NTdjN2U0Y2NhYTM0ZC4uNWE5YzI1ZTJlMDk4OTA2NmQ2MGYwYWFhNGNlM2Y4 NmMwOGY3OTgxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIwLTAxLTIwICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgSW52YWxp ZCB1c2FnZSBvZiBFTkFCTEUoKSBiZWZvcmUgaXQncyBkZWZpbmVkIGluIFdlYkNvcmUvbGF5b3V0 L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQm94VHJlZS5jcHAKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjUwMAorCisgICAgICAgIFJldmll d2VkIGJ5IMW9YW4gRG9iZXLFoWVrLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBuZWVkZWQuCisK KyAgICAgICAgKiBsYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRpb25Cb3hUcmVlLmNw cDogSW5jbHVkZSAiY29uZmlnLmgiCisgICAgICAgIGJlZm9yZSB1c2luZyB0aGUgRU5BQkxFKCkg bWFjcm8sIHRvIG1ha2Ugc3VyZSB0aGF0IGl0IGdldHMgZGVmaW5lZC4KKwogMjAyMC0wMS0yMCAg Um9iIEJ1aXMgIDxyYnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIEltcGxlbWVudCAiY3JlYXRl IGEgcG90ZW50aWFsLUNPUlMgcmVxdWVzdCIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkJveFRyZWUuY3BwIGIvU291cmNlL1dl YkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQm94VHJlZS5jcHAKaW5k ZXggZDIxYTIwNzQ4MGM1ZjJkZmVlOGY0ZjA3YjIwY2ZhOThiZjM0NmZmOC4uMGI3MTBiZGIzYWE3 NTljMjFiYTdkNmE1MzZiMDQxNzIwYjlmOTM3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv bGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQm94VHJlZS5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbGF5b3V0L2ludGVncmF0aW9uL0xheW91dEludGVncmF0aW9uQm94VHJlZS5j cHAKQEAgLTIzLDExICsyMywxMSBAQAogICogVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdF LgogICovCiAKLSNpZiBFTkFCTEUoTEFZT1VUX0ZPUk1BVFRJTkdfQ09OVEVYVCkKLQogI2luY2x1 ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIkxheW91dEludGVncmF0aW9uQm94VHJlZS5oIgogCisj aWYgRU5BQkxFKExBWU9VVF9GT1JNQVRUSU5HX0NPTlRFWFQpCisKICNpbmNsdWRlICJSZW5kZXJC bG9ja0Zsb3cuaCIKICNpbmNsdWRlICJSZW5kZXJDaGlsZEl0ZXJhdG9yLmgiCiAK