<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>206475</bug_id>
          
          <creation_ts>2020-01-18 11:30:09 -0800</creation_ts>
          <short_desc>Make isValidUserAgentHeaderValue GLib only</short_desc>
          <delta_ts>2020-01-20 03:00:30 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>Safari Technology Preview</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Rob Buis">rbuis</reporter>
          <assigned_to name="Rob Buis">rbuis</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1608464</commentid>
    <comment_count>0</comment_count>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-01-18 11:30:09 -0800</bug_when>
    <thetext>The function isValidUserAgentHeaderValue is only used by code that requires GLib, so move it behind USE(GLIB).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1608465</commentid>
    <comment_count>1</comment_count>
      <attachid>388158</attachid>
    <who name="Rob Buis">rbuis</who>
    <bug_when>2020-01-18 11:32:43 -0800</bug_when>
    <thetext>Created attachment 388158
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1608693</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-20 02:58:41 -0800</bug_when>
    <thetext>The commit-queue encountered the following flaky tests while processing attachment 388158:

editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org)
The commit-queue is continuing to process your patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1608694</commentid>
    <comment_count>3</comment_count>
      <attachid>388158</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-20 02:59:13 -0800</bug_when>
    <thetext>Comment on attachment 388158
Patch

Clearing flags on attachment: 388158

Committed r254818: &lt;https://trac.webkit.org/changeset/254818&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1608695</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-20 02:59:15 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1608696</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-01-20 03:00:30 -0800</bug_when>
    <thetext>&lt;rdar://problem/58734822&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>388158</attachid>
            <date>2020-01-18 11:32:43 -0800</date>
            <delta_ts>2020-01-20 02:59:13 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206475-20200118203242.patch</filename>
            <type>text/plain</type>
            <size>4046</size>
            <attacher name="Rob Buis">rbuis</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0Njc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDEzNjQ4MTY4ODU4NTYx
N2ZmNDc2NGU2NmEyYjVhNzQxYzI1YzA4OC4uNzQzYWE1NTA3YmE2NjYwY2UxZmEzOTljOTgyMDI1
Y2I0YTM1MmYwZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTE4ICBSb2Ig
QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgTWFrZSBpc1ZhbGlkVXNlckFnZW50
SGVhZGVyVmFsdWUgR0xpYiBvbmx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No
b3dfYnVnLmNnaT9pZD0yMDY0NzUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh
KS4KKworICAgICAgICBUaGUgZnVuY3Rpb24gaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVlIGlz
IG9ubHkgdXNlZAorICAgICAgICBieSBjb2RlIHRoYXQgcmVxdWlyZXMgR0xpYiwgc28gbW92ZSBp
dCBiZWhpbmQgVVNFKEdMSUIpLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9IVFRQUGFy
c2Vycy5jcHA6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5oOgorCiAy
MDIwLTAxLTE2ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBb
TEZDXVtJRkNdIFRleHRVdGlsOjp3aWR0aCBzaG91bGQgdXNlIFN0cmluZ1ZpZXcgZm9yIHN1YnN0
cmluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBh
cnNlcnMuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5j
cHAKaW5kZXggYjdhNTE2YzFiNGIxOWE0ZmQ1NzA3ZGMwNzhkZGEzNjBkZTlhOTQzOC4uNmEyZGVk
MGVhZDc0OTllNGZiMjE1NWIyYjQ4ZDYwOGMyMDkzZjNlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAKKysrIGIvU291cmNlL1dlYkNv
cmUvcGxhdGZvcm0vbmV0d29yay9IVFRQUGFyc2Vycy5jcHAKQEAgLTIwMCw2ICsyMDAsNyBAQCBi
b29sIGlzVmFsaWRIVFRQVG9rZW4oY29uc3QgU3RyaW5nJiB2YWx1ZSkKICAgICByZXR1cm4gdHJ1
ZTsKIH0KIAorI2lmIFVTRShHTElCKQogLy8gVHJ1ZSBpZiB0aGUgY2hhcmFjdGVyIGF0IHRoZSBn
aXZlbiBwb3NpdGlvbiBzYXRpc2lmaWVzIGEgcHJlZGljYXRlLCBpbmNyZW1lbnRpbmcgInBvcyIg
Ynkgb25lLgogLy8gTm90ZTogTWlnaHQgcmV0dXJuIHBvcyA9PSBzdHIubGVuZ3RoKCkKIHN0YXRp
YyBpbmxpbmUgYm9vbCBza2lwQ2hhcmFjdGVyKGNvbnN0IFN0cmluZyYgdmFsdWUsIHVuc2lnbmVk
JiBwb3MsIFdURjo6RnVuY3Rpb248Ym9vbChjb25zdCBVQ2hhcik+JiYgcHJlZGljYXRlKQpAQCAt
MzA2LDYgKzMwNyw3IEBAIGJvb2wgaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVlKGNvbnN0IFN0
cmluZyYgdmFsdWUpCiAKICAgICByZXR1cm4gcG9zID09IHZhbHVlLmxlbmd0aCgpOwogfQorI2Vu
ZGlmCiAKIHN0YXRpYyBjb25zdCBzaXplX3QgbWF4SW5wdXRTYW1wbGVTaXplID0gMTI4Owogc3Rh
dGljIFN0cmluZyB0cmltSW5wdXRTYW1wbGUoY29uc3QgY2hhciogcCwgc2l6ZV90IGxlbmd0aCkK
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMu
aCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvSFRUUFBhcnNlcnMuaAppbmRleCAw
NTIxOWE5YmViY2I0YmRhNTEyZGYxMzNhYmI2ZDNjZTU2NTdlOTlmLi42NmI5ODAyOTkwOWI5ZWM0
ZDAwNGE0YWQyODZjYTRlM2Y2YjNhMWUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0
Zm9ybS9uZXR3b3JrL0hUVFBQYXJzZXJzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v
bmV0d29yay9IVFRQUGFyc2Vycy5oCkBAIC03Miw3ICs3Miw5IEBAIGJvb2wgaXNWYWxpZFJlYXNv
blBocmFzZShjb25zdCBTdHJpbmcmKTsKIGJvb2wgaXNWYWxpZEhUVFBIZWFkZXJWYWx1ZShjb25z
dCBTdHJpbmcmKTsKIGJvb2wgaXNWYWxpZEFjY2VwdEhlYWRlclZhbHVlKGNvbnN0IFN0cmluZyYp
OwogYm9vbCBpc1ZhbGlkTGFuZ3VhZ2VIZWFkZXJWYWx1ZShjb25zdCBTdHJpbmcmKTsKKyNpZiBV
U0UoR0xJQikKIFdFQkNPUkVfRVhQT1JUIGJvb2wgaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVl
KGNvbnN0IFN0cmluZyYpOworI2VuZGlmCiBib29sIGlzVmFsaWRIVFRQVG9rZW4oY29uc3QgU3Ry
aW5nJik7CiBPcHRpb25hbDxXYWxsVGltZT4gcGFyc2VIVFRQRGF0ZShjb25zdCBTdHJpbmcmKTsK
IFN0cmluZyBmaWxlbmFtZUZyb21IVFRQQ29udGVudERpc3Bvc2l0aW9uKGNvbnN0IFN0cmluZyYp
OwpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDAw
NjMyOWQ1YmZjOGJiYzFjNmZjYjBlYWI5Yzk0ZjZjODlkNWM5OWEuLmZkZjk1YmMyMjk0OWQ0ZjVm
YzgxYjY1M2M3OTZiMDllMDI3YzVlYjYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg
Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMC0wMS0xOCAgUm9iIEJ1aXMg
IDxyYnVpc0BpZ2FsaWEuY29tPgorCisgICAgICAgIE1ha2UgaXNWYWxpZFVzZXJBZ2VudEhlYWRl
clZhbHVlIEdMaWIgb25seQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjA2NDc1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgTWFrZSB0aGUgdW5pdCB0ZXN0IHRoYXQgdGVzdHMgaXNWYWxpZFVzZXJBZ2VudEhl
YWRlclZhbHVlCisgICAgICAgIGRlcGVuZCBvbiBVU0UoR0xJQikgYXMgd2VsbC4KKworICAgICAg
ICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9IVFRQUGFyc2Vycy5jcHA6CisKIDIwMjAt
MDEtMTYgIFRha2FzaGkgS29tb3JpICA8VGFrYXNoaS5Lb21vcmlAc29ueS5jb20+CiAKICAgICAg
ICAgS2V5ZWREZWNvZGVyR2VuZXJpYyBjcmFzaGVzIHdoZW4gaXQgYWNjZXNzZXMgZGF0YSB3aXRo
IG5vbi1leGlzdGluZyBrZXkKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv
V2ViQ29yZS9IVFRQUGFyc2Vycy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNv
cmUvSFRUUFBhcnNlcnMuY3BwCmluZGV4IGVlNDM5MWYyZGE1MDdhM2YyN2U0YjQ5NDczNDQ0MjVh
ZGNkYmZlZDcuLmZmYmEwMGI4MDIxYTVhNDZiODMxYTNiOTdjNDVkYjRiZjNiNDU4ZWIgMTAwNjQ0
Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9IVFRQUGFyc2Vycy5jcHAK
KysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJDb3JlL0hUVFBQYXJzZXJzLmNwcApA
QCAtNTYsNiArNTYsNyBAQCBURVNUKEhUVFBQYXJzZXJzLCBQYXJzZUNyb3NzT3JpZ2luUmVzb3Vy
Y2VQb2xpY3lIZWFkZXIpCiAgICAgRVhQRUNUX1RSVUUocGFyc2VDcm9zc09yaWdpblJlc291cmNl
UG9saWN5SGVhZGVyKCLvo78iKSA9PSBDcm9zc09yaWdpblJlc291cmNlUG9saWN5OjpJbnZhbGlk
KTsKIH0KIAorI2lmIFVTRShHTElCKQogVEVTVChIVFRQUGFyc2VycywgVmFsaWRhdGVVc2VyQWdl
bnRWYWx1ZXMpCiB7CiAgICAgRVhQRUNUX1RSVUUoaXNWYWxpZFVzZXJBZ2VudEhlYWRlclZhbHVl
KCJTYWZhcmkiKSk7CkBAIC04NSw1ICs4Niw2IEBAIFRFU1QoSFRUUFBhcnNlcnMsIFZhbGlkYXRl
VXNlckFnZW50VmFsdWVzKQogICAgIEVYUEVDVF9GQUxTRShpc1ZhbGlkVXNlckFnZW50SGVhZGVy
VmFsdWUoIldQRVxcIFdlYktpdCAocXVvdGVkIHBhaXIgaW4gdG9rZW4pIikpOwogICAgIEVYUEVD
VF9GQUxTRShpc1ZhbGlkVXNlckFnZW50SGVhZGVyVmFsdWUoIi8xMjMgKG1pc3NpbmcgcHJvZHVj
dCB0b2tlbikiKSk7CiB9CisjZW5kaWYKIAogfSAvLyBuYW1lc3BhY2UgVGVzdFdlYktpdEFQSQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>