206474 2020-01-18 07:25:51 -0800 Regression r254652: fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html fails on windows 2020-01-21 10:36:34 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206315 InRadar P2 Normal --- 1 aakash_jain cdumez ap cdumez ddkilzer pvollan ryanhaddad tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1608436 0 aakash_jain 2020-01-18 07:25:51 -0800 r254652 added test fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload.html which is consistently failing on windows. Results database: https://results.webkit.org/?suite=layout-tests&test=fast%2Fxmlhttprequest%2Fxmlhttprequest-multiple-sync-xhr-during-unload.html 1608437 1 aakash_jain 2020-01-18 07:27:18 -0800 e.g.: https://build.webkit.org/results/Apple%20Win%2010%20Debug%20(Tests)/r254663%20(3323)/results.html --- /home/buildbot/worker/win10-debug-tests/build/layout-test-results/fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-expected.txt +++ /home/buildbot/worker/win10-debug-tests/build/layout-test-results/fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-actual.txt @@ -1,9 +1,9 @@ frame "<!--frame1-->" - has 1 onunload handler(s) -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?0. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?1. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?2. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?3. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?4. +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json 1608438 2 aakash_jain 2020-01-18 07:31:52 -0800 r254652 might have also caused http/tests/websocket/tests/hybi/simple-wss.html to fail, not 100% sure at the moment. 1608909 3 ddkilzer 2020-01-20 19:03:37 -0800 *** Bug 206515 has been marked as a duplicate of this bug. *** 1609063 4 cdumez 2020-01-21 08:31:58 -0800 Looks to me that we need a windows-specific baseline. 1609090 5 ryanhaddad 2020-01-21 09:43:51 -0800 The test was marked as failing in https://trac.webkit.org/changeset/254851/webkit 1609091 6 cdumez 2020-01-21 09:45:27 -0800 (In reply to Ryan Haddad from comment #5) > The test was marked as failing in > https://trac.webkit.org/changeset/254851/webkit This is not a failure, it just needs a windows baseline: --- /home/buildbot/worker/win10-debug-tests/build/layout-test-results/fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-expected.txt +++ /home/buildbot/worker/win10-debug-tests/build/layout-test-results/fast/xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-actual.txt @@ -1,9 +1,9 @@ frame "<!--frame1-->" - has 1 onunload handler(s) -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?0. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?1. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?2. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?3. -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json?4. +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load xmlhttprequest-responsetype-json.json Makes sure that we throw when doing sync XHRs during unload. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". 1609094 7 ryanhaddad 2020-01-21 09:47:06 -0800 (In reply to Chris Dumez from comment #6) > (In reply to Ryan Haddad from comment #5) > > The test was marked as failing in > > https://trac.webkit.org/changeset/254851/webkit > > This is not a failure, it just needs a windows baseline: > --- > /home/buildbot/worker/win10-debug-tests/build/layout-test-results/fast/ > xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-expected.txt > +++ > /home/buildbot/worker/win10-debug-tests/build/layout-test-results/fast/ > xmlhttprequest/xmlhttprequest-multiple-sync-xhr-during-unload-actual.txt > @@ -1,9 +1,9 @@ > frame "<!--frame1-->" - has 1 onunload handler(s) > -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json?0. > -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json?1. > -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json?2. > -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json?3. > -CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json?4. > +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json > +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json > +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json > +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json > +CONSOLE MESSAGE: line 9: XMLHttpRequest cannot load > xmlhttprequest-responsetype-json.json > Makes sure that we throw when doing sync XHRs during unload. > > On success, you will see a series of "PASS" messages, followed by "TEST > COMPLETE". Understood, just wanted to call out the fact that it was marked as failing via the dupe. 1609110 8 ap 2020-01-21 09:59:54 -0800 Out of curiosity, why is it OK for Windows to have this difference? The diff makes it look like the test is not doing the expected work. 1609112 9 cdumez 2020-01-21 10:03:05 -0800 (In reply to Alexey Proskuryakov from comment #8) > Out of curiosity, why is it OK for Windows to have this difference? The diff > makes it look like the test is not doing the expected work. It looks to me that the search query is getting stripped on windows before the URL gets printed. The test still says: PASS xhrExceptionCount is 5 So to me it does look like the test is passing. The only difference is in console logging. 1609113 10 cdumez 2020-01-21 10:04:10 -0800 (In reply to Chris Dumez from comment #9) > (In reply to Alexey Proskuryakov from comment #8) > > Out of curiosity, why is it OK for Windows to have this difference? The diff > > makes it look like the test is not doing the expected work. > > It looks to me that the search query is getting stripped on windows before > the URL gets printed. > > The test still says: > PASS xhrExceptionCount is 5 > > So to me it does look like the test is passing. The only difference is in > console logging. Code looks like: String messageEnd = error.isAccessControl() ? " due to access control checks."_s : "."_s; context.addConsoleMessage(MessageSource::JS, MessageLevel::Error, makeString(messageStart, error.failingURL().string(), messageEnd)); For some reason, it seems error.failingURL() is missing the query parameter. 1609114 11 cdumez 2020-01-21 10:07:27 -0800 Committed r254860: <https://trac.webkit.org/changeset/254860> 1609115 12 webkit-bug-importer 2020-01-21 10:08:15 -0800 <rdar://problem/58763098> 1609131 13 ap 2020-01-21 10:36:34 -0800 That seems like something to fix (at least eventually), so that we don't have to maintain separate expectations.