206472 2020-01-18 05:57:23 -0800 REGRESSION(r254780): fast/css/content/content-none.html asserts in LineBuilder::CollapsibleContent::collapse() (Requested by zalan on #webkit). 2020-01-18 06:02:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 206428 1 commit-queue commit-queue koivisto webkit-bug-importer zalan oldest_to_newest 1608427 0 commit-queue 2020-01-18 05:57:23 -0800 https://trac.webkit.org/changeset/254780 broke the build: fast/css/content/content-none.html asserts in LineBuilder::CollapsibleContent::collapse() (Requested by zalan on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail. 1608429 1 388150 commit-queue 2020-01-18 05:57:28 -0800 Created attachment 388150 ROLLOUT of r254780 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 1608430 2 388150 commit-queue 2020-01-18 06:01:14 -0800 Comment on attachment 388150 ROLLOUT of r254780 Clearing flags on attachment: 388150 Committed r254794: <https://trac.webkit.org/changeset/254794> 1608431 3 commit-queue 2020-01-18 06:01:15 -0800 All reviewed patches have been landed. Closing bug. 1608432 4 webkit-bug-importer 2020-01-18 06:02:16 -0800 <rdar://problem/58710059> 388150 2020-01-18 05:57:28 -0800 2020-01-18 06:01:14 -0800 ROLLOUT of r254780 bug-206472-20200118055727.patch text/plain 7241 commit-queue U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ1YTcxNDBjNTY3YWQ3 ZThmYTRiMmYzYzdlN2VjYzE5ODkyNzBlMS4uZDNlODRkZjVlNWUyOTA2YzFiMjlhYjRhMzQyMWRh Yzc5MjdkM2JiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIwLTAxLTE4ICBDb21t aXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KKworICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMjU0NzgwLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjA2NDcyCisKKyAgICAgICAgZmFzdC9jc3MvY29udGVudC9jb250ZW50 LW5vbmUuaHRtbCBhc3NlcnRzIGluCisgICAgICAgIExpbmVCdWlsZGVyOjpDb2xsYXBzaWJsZUNv bnRlbnQ6OmNvbGxhcHNlKCkgKFJlcXVlc3RlZCBieQorICAgICAgICB6YWxhbiBvbiAjd2Via2l0 KS4KKworICAgICAgICBSZXZlcnRlZCBjaGFuZ2VzZXQ6CisKKyAgICAgICAgIltMRkNdW0lGQ10g RG8gbm90IGNvbnN0cnVjdCBhIGRlZGljYXRlZCBydW4gZm9yIHRoZSB0cmFpbGluZworICAgICAg ICAoZnVsbHkpIGNvbGxhcHNlZCB3aGl0ZXNwYWNlLiIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQyOAorICAgICAgICBodHRwczovL3RyYWMud2Vi a2l0Lm9yZy9jaGFuZ2VzZXQvMjU0NzgwCisKIDIwMjAtMDEtMTcgIENhdGhpZSBDaGVuICA8Y2F0 aGllY2hlbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBzY3JvbGwgYmVo YXZpb3IgcGFyc2luZwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZv cm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRRdWlya3MuY3BwIGIvU291cmNlL1dlYkNv cmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRRdWlya3Mu Y3BwCmluZGV4IDA1NGI1ZGM0ZGVmMjIwM2YxZWY5YzBiMmEwMzZjOTMzMjJmYWViZWQuLjA4OTY5 NzI1OTg4ZTg4Yjk3NDZkNjhiNjZmM2Y5MGRkYmE4OWU0MjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0UXVp cmtzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9Jbmxp bmVGb3JtYXR0aW5nQ29udGV4dFF1aXJrcy5jcHAKQEAgLTQ3LDE1ICs0NywxMyBAQCBib29sIElu bGluZUZvcm1hdHRpbmdDb250ZXh0OjpRdWlya3M6OmxpbmVEZXNjZW50TmVlZHNDb2xsYXBzaW5n KGNvbnN0IExpbmVCdWlsZAogICAgICAgICBpZiAocnVuLmlzQ29udGFpbmVyRW5kKCkgfHwgbGF5 b3V0Qm94LnN0eWxlKCkudmVydGljYWxBbGlnbigpICE9IFZlcnRpY2FsQWxpZ246OkJhc2VsaW5l KQogICAgICAgICAgICAgY29udGludWU7CiAKKyAgICAgICAgaWYgKHJ1bi5pc0xpbmVCcmVhaygp KQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICBpZiAocnVuLmlzVGV4dCgpKSB7 CiAgICAgICAgICAgICBpZiAoIXJ1bi5pc0NvbGxhcHNlZFRvVmlzdWFsbHlFbXB0eSgpKQogICAg ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAg ICB9Ci0KLSAgICAgICAgaWYgKHJ1bi5pc0xpbmVCcmVhaygpKQotICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwotCiAgICAgICAgIGlmIChydW4uaXNDb250YWluZXJTdGFydCgpKSB7CiAgICAgICAg ICAgICBhdXRvJiBib3hHZW9tZXRyeSA9IGZvcm1hdHRpbmdDb250ZXh0KCkuZ2VvbWV0cnlGb3JC b3gobGF5b3V0Qm94KTsKICAgICAgICAgICAgIGlmIChib3hHZW9tZXRyeS5ob3Jpem9udGFsQm9y ZGVyKCkgfHwgKGJveEdlb21ldHJ5Lmhvcml6b250YWxQYWRkaW5nKCkgJiYgYm94R2VvbWV0cnku aG9yaXpvbnRhbFBhZGRpbmcoKS52YWx1ZSgpKSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCdWlsZGVyLmNwcAppbmRl eCA0NzhmNDg0ZTEyMjg3NmEwZmM5NGE5MWVlZTllYmZiNjExOWIwZTlmLi43YWJmNDI2MDg0Yzc2 OGMzNzAwMzk3MTA3YTA4NjY4YjQxZGI4OGI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s YXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQnVpbGRlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJ1aWxkZXIuY3BwCkBA IC02OSw3ICs2OSw3IEBAIHB1YmxpYzoKICAgICBDb250aW51b3VzQ29udGVudChjb25zdCBJbmxp bmVJdGVtUnVuJiwgYm9vbCB0ZXh0SXNBbGlnbkp1c3RpZnkpOwogCiAgICAgYm9vbCBpc0VsaWdp YmxlKGNvbnN0IElubGluZUl0ZW1SdW4mKSBjb25zdDsKLSAgICB2b2lkIGV4cGFuZChjb25zdCBJ bmxpbmVJdGVtUnVuJik7CisgICAgdm9pZCBhcHBlbmQoY29uc3QgSW5saW5lSXRlbVJ1biYpOwog ICAgIExpbmVCdWlsZGVyOjpSdW4gY2xvc2UoKTsKIAogICAgIHN0YXRpYyBib29sIGNhbklubGlu ZUl0ZW1SdW5CZUV4cGFuZGVkKGNvbnN0IElubGluZUl0ZW1SdW4mIHJ1bikgeyByZXR1cm4gcnVu LmlzVGV4dCgpICYmICFydW4uaXNDb2xsYXBzZWQoKSAmJiAhcnVuLmlzQ29sbGFwc2VkVG9aZXJv QWR2YW5jZVdpZHRoKCk7IH0KQEAgLTk2LDE4ICs5NiwxOCBAQCBib29sIExpbmVCdWlsZGVyOjpD b250aW51b3VzQ29udGVudDo6aXNFbGlnaWJsZShjb25zdCBJbmxpbmVJdGVtUnVuJiBpbmxpbmVJ dGVtUgogewogICAgIGlmICghbV90cmFpbGluZ1J1bkNhbkJlRXhwYW5kZWQpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKLSAgICByZXR1cm4gaW5saW5lSXRlbVJ1bi5pc1RleHQoKSAmJiAmbV9pbml0 aWFsSW5saW5lUnVuLmxheW91dEJveCgpID09ICZpbmxpbmVJdGVtUnVuLmxheW91dEJveCgpOwor ICAgIC8vIE9ubHkgbm9uLWNvbGxhcHNlZCB0ZXh0IHJ1bnMgd2l0aCB0aGUgc2FtZSBsYXlvdXQg Ym94IGNhbiBiZSBhZGRlZCBhcyBjb250aW51b3VzIGNvbnRlbnQuCisgICAgcmV0dXJuIGlubGlu ZUl0ZW1SdW4uaXNUZXh0KCkgJiYgIWlubGluZUl0ZW1SdW4uaXNDb2xsYXBzZWRUb1plcm9BZHZh bmNlV2lkdGgoKSAmJiAmbV9pbml0aWFsSW5saW5lUnVuLmxheW91dEJveCgpID09ICZpbmxpbmVJ dGVtUnVuLmxheW91dEJveCgpOwogfQogCi12b2lkIExpbmVCdWlsZGVyOjpDb250aW51b3VzQ29u dGVudDo6ZXhwYW5kKGNvbnN0IElubGluZUl0ZW1SdW4mIGlubGluZUl0ZW1SdW4pCit2b2lkIExp bmVCdWlsZGVyOjpDb250aW51b3VzQ29udGVudDo6YXBwZW5kKGNvbnN0IElubGluZUl0ZW1SdW4m IGlubGluZUl0ZW1SdW4pCiB7CiAgICAgLy8gTWVyZ2VkIGNvbnRlbnQgbmVlZHMgdG8gYmUgY29u dGludW91cy4KICAgICBBU1NFUlQoaXNFbGlnaWJsZShpbmxpbmVJdGVtUnVuKSk7CiAgICAgbV90 cmFpbGluZ1J1bkNhbkJlRXhwYW5kZWQgPSBjYW5JbmxpbmVJdGVtUnVuQmVFeHBhbmRlZChpbmxp bmVJdGVtUnVuKTsKIAogICAgIEFTU0VSVChpbmxpbmVJdGVtUnVuLmlzVGV4dCgpKTsKLSAgICBp ZiAoIWlubGluZUl0ZW1SdW4uaXNDb2xsYXBzZWRUb1plcm9BZHZhbmNlV2lkdGgoKSkKLSAgICAg ICAgbV9leHBhbmRlZExlbmd0aCArPSBpbmxpbmVJdGVtUnVuLnRleHRDb250ZXh0KCktPmxlbmd0 aCgpOworICAgIG1fZXhwYW5kZWRMZW5ndGggKz0gaW5saW5lSXRlbVJ1bi50ZXh0Q29udGV4dCgp LT5sZW5ndGgoKTsKICAgICBtX2V4cGFuZGVkV2lkdGggKz0gaW5saW5lSXRlbVJ1bi5sb2dpY2Fs V2lkdGgoKTsKIAogICAgIGlmIChtX2NvbGxlY3RFeHBhbnNpb25PcHBvcnR1bml0aWVzKSB7CkBA IC0yMzgsNyArMjM4LDggQEAgTGluZUJ1aWxkZXI6OlJ1bkxpc3QgTGluZUJ1aWxkZXI6OmNsb3Nl KElzTGFzdExpbmVXaXRoSW5saW5lQ29udGVudCBpc0xhc3RMaW5lV2kKICAgICB2aXN1YWxseUNv bGxhcHNlUHJlV3JhcE92ZXJmbG93Q29udGVudCgpOwogICAgIGF1dG8gaGFuZ2luZ0NvbnRlbnQg PSBjb2xsZWN0SGFuZ2luZ0NvbnRlbnQoaXNMYXN0TGluZVdpdGhJbmxpbmVDb250ZW50KTsKIAot ICAgIGF1dG8gbWVyZ2VkSW5saW5lSXRlbVJ1bnMgPSBbJl0gKGF1dG8mIHJ1bkxpc3QpIHsKKyAg ICBhdXRvIG1lcmdlZElubGluZUl0ZW1SdW5zID0gWyZdIHsKKyAgICAgICAgUnVuTGlzdCBydW5M aXN0OwogICAgICAgICB1bnNpZ25lZCBydW5JbmRleCA9IDA7CiAgICAgICAgIHdoaWxlIChydW5J bmRleCA8IG1faW5saW5lSXRlbVJ1bnMuc2l6ZSgpKSB7CiAgICAgICAgICAgICAvLyBNZXJnZSBl bGlnaWJsZSBydW5zLgpAQCAtMjUwLDEzICsyNTEsMTMgQEAgTGluZUJ1aWxkZXI6OlJ1bkxpc3Qg TGluZUJ1aWxkZXI6OmNsb3NlKElzTGFzdExpbmVXaXRoSW5saW5lQ29udGVudCBpc0xhc3RMaW5l V2kKICAgICAgICAgICAgIH0KICAgICAgICAgICAgIGF1dG8gbWVyZ2VkUnVucyA9IENvbnRpbnVv dXNDb250ZW50IHsgaW5saW5lSXRlbVJ1biwgaXNUZXh0QWxpZ25KdXN0aWZ5KCkgfTsKICAgICAg ICAgICAgIGZvciAocnVuSW5kZXggPSBydW5JbmRleCArIDE7IHJ1bkluZGV4IDwgbV9pbmxpbmVJ dGVtUnVucy5zaXplKCkgJiYgbWVyZ2VkUnVucy5pc0VsaWdpYmxlKG1faW5saW5lSXRlbVJ1bnNb cnVuSW5kZXhdKTsgKytydW5JbmRleCkKLSAgICAgICAgICAgICAgICBtZXJnZWRSdW5zLmV4cGFu ZChtX2lubGluZUl0ZW1SdW5zW3J1bkluZGV4XSk7CisgICAgICAgICAgICAgICAgbWVyZ2VkUnVu cy5hcHBlbmQobV9pbmxpbmVJdGVtUnVuc1tydW5JbmRleF0pOwogICAgICAgICAgICAgcnVuTGlz dC5hcHBlbmQobWVyZ2VkUnVucy5jbG9zZSgpKTsKICAgICAgICAgfQorICAgICAgICByZXR1cm4g cnVuTGlzdDsKICAgICB9OwogCi0gICAgUnVuTGlzdCBydW5MaXN0OwotICAgIG1lcmdlZElubGlu ZUl0ZW1SdW5zKHJ1bkxpc3QpOworICAgIGF1dG8gcnVuTGlzdCA9IG1lcmdlZElubGluZUl0ZW1S dW5zKCk7CiAgICAgaWYgKCFtX2lzSW50cmluc2ljU2l6aW5nKSB7CiAgICAgICAgIGZvciAoYXV0 byYgcnVuIDogcnVuTGlzdCkgewogICAgICAgICAgICAgYWRqdXN0QmFzZWxpbmVBbmRMaW5lSGVp Z2h0KHJ1bik7CkBAIC0zNDUsNyArMzQ2LDcgQEAgdm9pZCBMaW5lQnVpbGRlcjo6YWxpZ25Db250 ZW50VmVydGljYWxseShSdW5MaXN0JiBydW5MaXN0KQogCiAgICAgICAgIHN3aXRjaCAodmVydGlj YWxBbGlnbikgewogICAgICAgICBjYXNlIFZlcnRpY2FsQWxpZ246OkJhc2VsaW5lOgotICAgICAg ICAgICAgaWYgKHJ1bi5pc1RleHQoKSB8fCBydW4uaXNMaW5lQnJlYWsoKSkKKyAgICAgICAgICAg IGlmIChydW4uaXNMaW5lQnJlYWsoKSB8fCBydW4uaXNUZXh0KCkpCiAgICAgICAgICAgICAgICAg bG9naWNhbFRvcCA9IGJhc2VsaW5lT2Zmc2V0KCkgLSBhc2NlbnQ7CiAgICAgICAgICAgICBlbHNl IGlmIChydW4uaXNDb250YWluZXJTdGFydCgpKSB7CiAgICAgICAgICAgICAgICAgYXV0byYgYm94 R2VvbWV0cnkgPSBmb3JtYXR0aW5nQ29udGV4dCgpLmdlb21ldHJ5Rm9yQm94KGxheW91dEJveCk7 CkBAIC03OTAsNyArNzkxLDcgQEAgdm9pZCBMaW5lQnVpbGRlcjo6YWRqdXN0QmFzZWxpbmVBbmRM aW5lSGVpZ2h0KGNvbnN0IFJ1biYgcnVuKQogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQog Ci1pbmxpbmUgSW5saW5lTGF5b3V0VW5pdCBMaW5lQnVpbGRlcjo6cnVuQ29udGVudEhlaWdodChj b25zdCBSdW4mIHJ1bikgY29uc3QKK0lubGluZUxheW91dFVuaXQgTGluZUJ1aWxkZXI6OnJ1bkNv bnRlbnRIZWlnaHQoY29uc3QgUnVuJiBydW4pIGNvbnN0CiB7CiAgICAgQVNTRVJUKCFtX2lzSW50 cmluc2ljU2l6aW5nKTsKICAgICBhdXRvJiBmb250TWV0cmljcyA9IHJ1bi5zdHlsZSgpLmZvbnRN ZXRyaWNzKCk7CkBAIC05MDAsMTAgKzkwMSwxNCBAQCBJbmxpbmVMYXlvdXRVbml0IExpbmVCdWls ZGVyOjpDb2xsYXBzaWJsZUNvbnRlbnQ6OmNvbGxhcHNlKCkKICAgICBmb3IgKGF1dG8gaW5kZXgg PSAqbV9maXJzdFJ1bkluZGV4OyBpbmRleCA8IG1faW5saW5laXRlbVJ1bkxpc3Quc2l6ZSgpOyAr K2luZGV4KSB7CiAgICAgICAgIGF1dG8mIHJ1biA9IG1faW5saW5laXRlbVJ1bkxpc3RbaW5kZXhd OwogICAgICAgICBydW4ubW92ZUhvcml6b250YWxseSgtYWNjdW11bGF0ZWRDb2xsYXBzZWRXaWR0 aCk7CisgICAgICAgIGlmICghcnVuLmlzVGV4dCgpKSB7CisgICAgICAgICAgICBBU1NFUlQocnVu LmlzQ29udGFpbmVyU3RhcnQoKSB8fCBydW4uaXNDb250YWluZXJFbmQoKSB8fCBydW4uaXNMaW5l QnJlYWsoKSk7CisgICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgfQogICAgICAgICBpZiAo cnVuLmlzV2hpdGVzcGFjZSgpKSB7CiAgICAgICAgICAgICBhY2N1bXVsYXRlZENvbGxhcHNlZFdp ZHRoICs9IHJ1bi5sb2dpY2FsV2lkdGgoKTsKICAgICAgICAgICAgIHJ1bi5zZXRDb2xsYXBzZXNU b1plcm9BZHZhbmNlV2lkdGgoKTsKLSAgICAgICAgfSBlbHNlIGlmIChydW4uaXNUZXh0KCkpIHsK KyAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgIEFTU0VSVCghaGFzU2Vlbk5vbldoaXRlc3Bh Y2VUZXh0Q29udGVudCk7CiAjaWYgQVNTRVJUX0VOQUJMRUQKICAgICAgICAgICAgIGhhc1NlZW5O b25XaGl0ZXNwYWNlVGV4dENvbnRlbnQgPSB0cnVlOwpAQCAtOTEzLDcgKzkxOCw2IEBAIElubGlu ZUxheW91dFVuaXQgTGluZUJ1aWxkZXI6OkNvbGxhcHNpYmxlQ29udGVudDo6Y29sbGFwc2UoKQog ICAgICAgICAgICAgYWNjdW11bGF0ZWRDb2xsYXBzZWRXaWR0aCArPSBydW4udHJhaWxpbmdMZXR0 ZXJTcGFjaW5nKCk7CiAgICAgICAgICAgICBydW4ucmVtb3ZlVHJhaWxpbmdMZXR0ZXJTcGFjaW5n KCk7CiAgICAgICAgIH0KLSAgICAgICAgQVNTRVJUKHJ1bi5pc0NvbnRhaW5lclN0YXJ0KCkgfHwg cnVuLmlzQ29udGFpbmVyRW5kKCkgfHwgcnVuLmlzTGluZUJyZWFrKCkpOwogICAgIH0KICAgICBB U1NFUlQoYWNjdW11bGF0ZWRDb2xsYXBzZWRXaWR0aCA9PSB3aWR0aCgpKTsKICAgICByZXNldCgp Owo=