206461 2020-01-17 16:49:00 -0800 JSModuleLoader's printableModuleKey() should never throw. 2020-01-20 02:09:35 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam ews-watchlist keith_miller msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1608311 0 mark.lam 2020-01-17 16:49:00 -0800 Hence, it should be using a CatchScope instead of a ThrowScope. <rdar://problem/58696678> 1608314 1 388117 mark.lam 2020-01-17 16:55:14 -0800 Created attachment 388117 proposed patch. 1608317 2 388117 msaboff 2020-01-17 16:58:56 -0800 Comment on attachment 388117 proposed patch. r=me 1608319 3 mark.lam 2020-01-17 17:03:05 -0800 Thanks for the review. Landed in r254783: <http://trac.webkit.org/r254783>. 1608679 4 ticaiolima 2020-01-20 02:09:35 -0800 *** Bug 206414 has been marked as a duplicate of this bug. *** 388117 2020-01-17 16:55:14 -0800 2020-01-17 16:58:56 -0800 proposed patch. bug-206461.patch text/plain 2444 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNTQ3ODEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDIwLTAxLTE3ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBKU01vZHVsZUxvYWRlcidzIHByaW50YWJsZU1vZHVsZUtleSgpIHNob3Vs ZCBuZXZlciB0aHJvdy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNjQ2MQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTg2OTY2Nzg+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvcHJpbnRh YmxlTW9kdWxlS2V5LXNob3VsZC1uZXZlci10aHJvdy5qczogQWRkZWQuCisKIDIwMjAtMDEtMTcg IEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIEpTT04u cGFyc2Ugc2hvdWxkIGxvb2t1cCBwcm90b3R5cGUgY2hhaW5zIGR1cmluZyByZXZpdmFsCkluZGV4 OiBKU1Rlc3RzL3N0cmVzcy9wcmludGFibGVNb2R1bGVLZXktc2hvdWxkLW5ldmVyLXRocm93Lmpz Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEpTVGVzdHMvc3RyZXNzL3ByaW50YWJsZU1vZHVsZUtleS1zaG91bGQt bmV2ZXItdGhyb3cuanMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvcHJpbnRhYmxl TW9kdWxlS2V5LXNob3VsZC1uZXZlci10aHJvdy5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsx LDMgQEAKKy8vQCBydW5EZWZhdWx0CisKK2ltcG9ydCgwKTsKSW5kZXg6IFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwkocmV2aXNpb24gMjU0Nzc3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTE3ICBNYXJrIExh bSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBKU01vZHVsZUxvYWRlcidzIHByaW50 YWJsZU1vZHVsZUtleSgpIHNob3VsZCBuZXZlciB0aHJvdy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQ2MQorICAgICAgICA8cmRhcjovL3Byb2Js ZW0vNTg2OTY2Nzg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSGVuY2UsIGl0IHNob3VsZCBiZSB1c2luZyBhIENhdGNoU2NvcGUgaW5zdGVhZCBvZiBh IFRocm93U2NvcGUuCisKKyAgICAgICAgKiBydW50aW1lL0pTTW9kdWxlTG9hZGVyLmNwcDoKKyAg ICAgICAgKEpTQzo6cHJpbnRhYmxlTW9kdWxlS2V5KToKKwogMjAyMC0wMS0xNyAgSnVzdGluIE1p Y2hhdWQgIDxqdXN0aW5fbWljaGF1ZEBhcHBsZS5jb20+CiAKICAgICAgICAgU2VwYXJhdGUgc3Rv cmFnZSBvZiBTdHJ1Y3R1cmU6Om1fb2Zmc2V0IGludG8gdHJhbnNpdGlvbiBhbmQgbWF4IG9mZnNl dApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNNb2R1bGVMb2FkZXIuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTTW9kdWxlTG9h ZGVyLmNwcAkocmV2aXNpb24gMjU0Nzc3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvSlNNb2R1bGVMb2FkZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTYsNyArMTE2LDcgQEAg dm9pZCBKU01vZHVsZUxvYWRlcjo6ZmluaXNoQ3JlYXRpb24oSlNHbAogc3RhdGljIFN0cmluZyBw cmludGFibGVNb2R1bGVLZXkoSlNHbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgSlNWYWx1ZSBr ZXkpCiB7CiAgICAgVk0mIHZtID0gZ2xvYmFsT2JqZWN0LT52bSgpOwotICAgIGF1dG8gc2NvcGUg PSBERUNMQVJFX1RIUk9XX1NDT1BFKHZtKTsKKyAgICBhdXRvIHNjb3BlID0gREVDTEFSRV9DQVRD SF9TQ09QRSh2bSk7CiAgICAgaWYgKGtleS5pc1N0cmluZygpIHx8IGtleS5pc1N5bWJvbCgpKSB7 CiAgICAgICAgIGF1dG8gcHJvcGVydHlOYW1lID0ga2V5LnRvUHJvcGVydHlLZXkoZ2xvYmFsT2Jq ZWN0KTsKICAgICAgICAgc2NvcGUuYXNzZXJ0Tm9FeGNlcHRpb24oKTsgLy8gVGhpcyBpcyBPSyBz aW5jZSB0aGlzIGZ1bmN0aW9uIGlzIGp1c3QgZm9yIGRlYnVnZ2luZyBwdXJwb3NlLgo=