206452 2020-01-17 15:34:36 -0800 Remove WebsiteDataStore::setSourceApplicationSecondaryIdentifier 2020-02-26 17:19:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez webkit-bug-importer oldest_to_newest 1608240 0 achristensen 2020-01-17 15:34:36 -0800 Remove WebsiteDataStore::setSourceApplicationSecondaryIdentifier 1608241 1 388098 achristensen 2020-01-17 15:35:23 -0800 Created attachment 388098 Patch 1608248 2 388098 cdumez 2020-01-17 15:37:02 -0800 Comment on attachment 388098 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388098&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:358 > - (NSString *)_sourceApplicationSecondaryIdentifier Is this already marked as deprecated in the header? 1623296 3 achristensen 2020-02-26 17:18:56 -0800 Yes. http://trac.webkit.org/r257539 1623297 4 webkit-bug-importer 2020-02-26 17:19:13 -0800 <rdar://problem/59828835> 388098 2020-01-17 15:35:23 -0800 2020-01-17 15:37:02 -0800 Patch bug-206452-20200117153522.patch text/plain 3362 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNTQ3NjgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIwLTAxLTE3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmVtb3ZlIFdlYnNp dGVEYXRhU3RvcmU6OnNldFNvdXJjZUFwcGxpY2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllcgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NDUyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXRzIHJlcGxhY2Vt ZW50IG9uIFdlYnNpdGVEYXRhU3RvcmVDb25maWd1cmF0aW9uIHdhcyBhZG9wdGVkIGluIHJkYXI6 Ly9wcm9ibGVtLzU4NjcxNzA0CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vi c2l0ZURhdGFTdG9yZS5tbToKKyAgICAgICAgKC1bV0tXZWJzaXRlRGF0YVN0b3JlIF9zb3VyY2VB cHBsaWNhdGlvblNlY29uZGFyeUlkZW50aWZpZXJdKToKKyAgICAgICAgKC1bV0tXZWJzaXRlRGF0 YVN0b3JlIF9zZXRTb3VyY2VBcHBsaWNhdGlvblNlY29uZGFyeUlkZW50aWZpZXI6XSk6CisgICAg ICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpzZXRTb3VyY2VBcHBsaWNhdGlvblNlY29uZGFy eUlkZW50aWZpZXIpOiBEZWxldGVkLgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJzaXRlRGF0YS9X ZWJzaXRlRGF0YVN0b3JlLmg6CisgICAgICAgIChXZWJLaXQ6OldlYnNpdGVEYXRhU3RvcmU6OnNv dXJjZUFwcGxpY2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllciBjb25zdCk6CisKIDIwMjAtMDEtMTcg IEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUmVt b3ZlIHRoZSBJT0hJREV2ZW50U2VydmljZUZhc3RQYXRoVXNlckNsaWVudCBJT0tpdCBjbGFzcwpJ bmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2Vic2l0ZURhdGFTdG9y ZS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tX ZWJzaXRlRGF0YVN0b3JlLm1tCShyZXZpc2lvbiAyNTQ0MzEpCisrKyBTb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJzaXRlRGF0YVN0b3JlLm1tCSh3b3JraW5nIGNvcHkpCkBA IC0zNTcsMTMgKzM1NywxMSBAQCAtICh2b2lkKV9zZXRTb3VyY2VBcHBsaWNhdGlvbkJ1bmRsZUlk ZW50CiAKIC0gKE5TU3RyaW5nICopX3NvdXJjZUFwcGxpY2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmll cgogewotICAgIHJldHVybiBfd2Vic2l0ZURhdGFTdG9yZS0+c291cmNlQXBwbGljYXRpb25TZWNv bmRhcnlJZGVudGlmaWVyKCk7CisgICAgcmV0dXJuIG5pbDsKIH0KIAogLSAodm9pZClfc2V0U291 cmNlQXBwbGljYXRpb25TZWNvbmRhcnlJZGVudGlmaWVyOihOU1N0cmluZyAqKWlkZW50aWZpZXIK IHsKLSAgICBpZiAoIV93ZWJzaXRlRGF0YVN0b3JlLT5zZXRTb3VyY2VBcHBsaWNhdGlvblNlY29u ZGFyeUlkZW50aWZpZXIoaWRlbnRpZmllcikpCi0gICAgICAgIFtOU0V4Y2VwdGlvbiByYWlzZTpO U0dlbmVyaWNFeGNlcHRpb24gZm9ybWF0OkAiX3NldFNvdXJjZUFwcGxpY2F0aW9uU2Vjb25kYXJ5 SWRlbnRpZmllciBjYW5ub3QgYmUgY2FsbGVkIGFmdGVyIG5ldHdvcmtpbmcgaGFzIGJlZ3VuIl07 CiB9CiAKIC0gKHZvaWQpX3NldEFsbG93c1RMU0ZhbGxiYWNrOihCT09MKWFsbG93cwpJbmRleDog U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0 ZURhdGFTdG9yZS5jcHAJKHJldmlzaW9uIDI1NDQzMSkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0y MTcxLDE0ICsyMTcxLDYgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpkaWRDcmVhdGVOZXR3b3Jr UAogewogfQogCi1ib29sIFdlYnNpdGVEYXRhU3RvcmU6OnNldFNvdXJjZUFwcGxpY2F0aW9uU2Vj b25kYXJ5SWRlbnRpZmllcihTdHJpbmcmJiBpZGVudGlmaWVyKQotewotICAgIGlmIChtX25ldHdv cmtpbmdIYXNCZWd1bikKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotICAgIG1fcmVzb2x2ZWRDb25m aWd1cmF0aW9uLT5zZXRTb3VyY2VBcHBsaWNhdGlvblNlY29uZGFyeUlkZW50aWZpZXIoV1RGTW92 ZShpZGVudGlmaWVyKSk7Ci0gICAgcmV0dXJuIHRydWU7Ci19Ci0KIGJvb2wgV2Vic2l0ZURhdGFT dG9yZTo6c2V0U291cmNlQXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKFN0cmluZyYmIGlkZW50 aWZpZXIpCiB7CiAgICAgaWYgKG1fbmV0d29ya2luZ0hhc0JlZ3VuKQpJbmRleDogU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUu aAkocmV2aXNpb24gMjU0NDMxKQorKysgU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURh dGEvV2Vic2l0ZURhdGFTdG9yZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMzAsNyArMjMwLDYgQEAg cHVibGljOgogICAgIGJvb2wgc2V0U291cmNlQXBwbGljYXRpb25CdW5kbGVJZGVudGlmaWVyKFN0 cmluZyYmKTsKIAogICAgIGNvbnN0IFN0cmluZyYgc291cmNlQXBwbGljYXRpb25TZWNvbmRhcnlJ ZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4gbV9yZXNvbHZlZENvbmZpZ3VyYXRpb24tPnNvdXJj ZUFwcGxpY2F0aW9uU2Vjb25kYXJ5SWRlbnRpZmllcigpOyB9Ci0gICAgYm9vbCBzZXRTb3VyY2VB cHBsaWNhdGlvblNlY29uZGFyeUlkZW50aWZpZXIoU3RyaW5nJiYpOwogCiAgICAgdm9pZCBuZXR3 b3JraW5nSGFzQmVndW4oKSB7IG1fbmV0d29ya2luZ0hhc0JlZ3VuID0gdHJ1ZTsgfQogICAgIAo=