206448 2020-01-17 15:18:21 -0800 [JSC] Add missing header guards 2020-01-18 23:06:26 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206480 https://bugs.webkit.org/show_bug.cgi?id=206481 InRadar P2 Normal --- 1 ddkilzer ddkilzer commit-queue ews-watchlist fpizlo jfbastien keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1608231 0 ddkilzer 2020-01-17 15:18:21 -0800 Add missing header guards to JavaScriptCore headers as found by lgtm.com: Source/JavaScriptCore/heap/IsoHeapCellType.h Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h 1608232 1 388095 ddkilzer 2020-01-17 15:21:12 -0800 Created attachment 388095 Patch v1 1608340 2 keith_miller 2020-01-17 18:20:46 -0800 Lol, we should really have a style warning for this... 1608346 3 388095 commit-queue 2020-01-17 18:49:39 -0800 Comment on attachment 388095 Patch v1 Clearing flags on attachment: 388095 Committed r254787: <https://trac.webkit.org/changeset/254787> 1608347 4 commit-queue 2020-01-17 18:49:40 -0800 All reviewed patches have been landed. Closing bug. 1608348 5 webkit-bug-importer 2020-01-17 18:50:18 -0800 <rdar://problem/58703846> 1608522 6 ddkilzer 2020-01-18 22:39:44 -0800 (In reply to Keith Miller from comment #2) > Lol, we should really have a style warning for this... We do have a check, but it wasn't very good because it assumed any header that didn't already have #ifndef/#define/#endif or #pragma once was an Objective-C header that didn't need a header guard. Improving this in Bug 206480. 388095 2020-01-17 15:21:12 -0800 2020-01-17 18:49:39 -0800 Patch v1 bug-206448-20200117152111.patch text/plain 2218 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi YmVlOWNmMjg0ODI0M2M5Zjc0N2Y4YTgzMDYxOGZlOTZjOWY0MTc1Li40OGRhOWU0MDQwZmUyZjcw NDA1NTAxZjkyMjNiOWFjMWI3MjRlNzE3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAyMC0wMS0xNyAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBtaXNzaW5nIGhlYWRlciBndWFyZHMKKyAgICAgICAgPGh0 dHBzOi8vd2Via2l0Lm9yZy9iLzIwNjQ0OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIGhlYXAvSXNvSGVhcENlbGxUeXBlLmg6CisgICAgICAgICog d2FzbS9XYXNtRmF1bHRTaWduYWxIYW5kbGVyLmg6CisgICAgICAgIC0gQWRkICNwcmFnbWEgb25j ZSBoZWFkZXIgZ3VhcmQuCisKIDIwMjAtMDEtMTUgIENhaXRsaW4gUG90dGVyIDxjYWl0cEBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtKU0NdIEFkZCBzdXBwb3J0IGZvciBwdWJsaWMgY2xhc3MgZmll bGRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9Jc29IZWFwQ2VsbFR5 cGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL0lzb0hlYXBDZWxsVHlwZS5oCmluZGV4 IDA5MWE5MWM3ZDY3ODQ2ODVlYzg5Mzc5NTg4NzA2NDU1ZDBiYjAxYTIuLjY2MWI2ZmNmYThmMWY1 MjNmNWQzZTI5MDg5ZTA5ZGNmNWY3MjlkODUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9oZWFwL0lzb0hlYXBDZWxsVHlwZS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9o ZWFwL0lzb0hlYXBDZWxsVHlwZS5oCkBAIC0xLDUgKzEsNSBAQAogLyoKLSAqIENvcHlyaWdodCAo QykgMjAxOSBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMp IDIwMTktMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKgogICogUmVkaXN0 cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRo b3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9s bG93aW5nIGNvbmRpdGlvbnMKQEAgLTIzLDYgKzIzLDggQEAKICAqIE9GIFRISVMgU09GVFdBUkUs IEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAgKi8K IAorI3ByYWdtYSBvbmNlCisKICNpbmNsdWRlICJIZWFwQ2VsbFR5cGUuaCIKICNpbmNsdWRlICJN YXJrZWRCbG9ja0lubGluZXMuaCIKIApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3dhc20vV2FzbUZhdWx0U2lnbmFsSGFuZGxlci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dh c20vV2FzbUZhdWx0U2lnbmFsSGFuZGxlci5oCmluZGV4IDRmMjQwNzA4M2ZmMzQ3ODlmYjRlOGNm OWQ3NmU4NDg1M2U0MDU0ZGUuLjc4M2I2YTZhNTJiMTExZWIwYTZkZWEyNTE3MzA4ZTZhYTMyZTlk OGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21GYXVsdFNpZ25h bEhhbmRsZXIuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtRmF1bHRTaWdu YWxIYW5kbGVyLmgKQEAgLTEsNSArMSw1IEBACiAvKgotICogQ29weXJpZ2h0IChDKSAyMDE3IEFw cGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqIENvcHlyaWdodCAoQykgMjAxNy0yMDIw IEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBh bmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKICAqIG1v ZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29u ZGl0aW9ucwpAQCAtMjMsNiArMjMsOCBAQAogICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAqLwogCisjcHJhZ21h IG9uY2UKKwogI2lmIEVOQUJMRShXRUJBU1NFTUJMWSkKIAogbmFtZXNwYWNlIEpTQyB7Cg==