206441 2020-01-17 13:39:21 -0800 Some iOS tests using UIHelper.dragFromPointToPoint() are flakey 2020-01-17 18:23:58 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser megan_gardner simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1608181 0 simon.fraser 2020-01-17 13:39:21 -0800 Some iOS tests using UIHelper.dragFromPointToPoint() are flakey 1608183 1 388085 simon.fraser 2020-01-17 13:43:00 -0800 Created attachment 388085 Patch 1608184 2 simon.fraser 2020-01-17 13:43:03 -0800 <rdar://problem/56714139> 1608188 3 388085 wenson_hsieh 2020-01-17 13:47:26 -0800 Comment on attachment 388085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review r=mews > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:434 > +static NSDictionary *dictionaryForFingerEventWithContentPoint(CGPoint point, NSString* phase, Seconds timeOffset) Nit - * on other side. > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:459 > + NSDictionary* touchDownInfo = dictionaryForFingerEventWithContentPoint(startPoint, HIDEventPhaseBegan, 0_s); Nit - * on other side. > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:467 > + NSDictionary* liftUpInfo = dictionaryForFingerEventWithContentPoint(endPoint, HIDEventPhaseEnded, Seconds(durationSeconds)); Ditto. 1608189 4 388085 wenson_hsieh 2020-01-17 13:48:41 -0800 Comment on attachment 388085 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review > Tools/ChangeLog:14 > + and dispatching via -[HIDEventGenerator HIDEventGenerator:]. This spawns a thread to Nit - I think you meant to write "sendEventStream:completionBlock:". 1608341 5 simon.fraser 2020-01-17 18:23:58 -0800 https://trac.webkit.org/changeset/254786/webkit 388085 2020-01-17 13:43:00 -0800 2020-01-17 13:47:26 -0800 Patch bug-206441-20200117134300.patch text/plain 7245 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjQwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYWNmMGI2ZWM1ZjAyYzlhNmQ0MTNjY2NjZjViOWMwMTk5 OGNjZTU5Ny4uZDJiMTM4NjcwOTQwNGQ1OGI4NGE0OTZmYTNjZjg3OGJjMjRkMGU4MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDIwLTAxLTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFNvbWUgaU9TIHRlc3RzIHVzaW5nIFVJSGVscGVyLmRyYWdGcm9tUG9pbnRUb1Bv aW50KCkgYXJlIGZsYWtleQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjA2NDQxCisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzU2NzE0MTM5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHdheSB0aGF0IEhJ REV2ZW50R2VuZXJhdG9yIHNlbmRzIGFsbCB0aGUgZ2VuZXJhdGVkIGV2ZW50cyBpbiBhIGJsb2Nr aW5nIGxvb3Agc2VlbXMgdG8KKyAgICAgICAgdHJpZ2dlciBhbiBpc3N1ZSB3aGVyZSB0aGUgZXZl bnRzLCB3aGVuIHJlY2VpdmVkIGJ5IHRoZSBzY3JvbGwgdmlldyBnZXN0dXJlIHJlY29nbml6ZXJz LAorICAgICAgICBkb24ndCBhY3R1YWxseSB0cmlnZ2VyIGEgc2Nyb2xsLgorCisgICAgICAgIEF0 dGVtcHQgdG8gZml4IGJ5IGNyZWF0aW5nIGFuIGV2ZW50IHN0cmVhbSBpbiBVSVNjcmlwdENvbnRy b2xsZXJJT1M6OmRyYWdGcm9tUG9pbnRUb1BvaW50LAorICAgICAgICBhbmQgZGlzcGF0Y2hpbmcg dmlhIC1bSElERXZlbnRHZW5lcmF0b3IgSElERXZlbnRHZW5lcmF0b3I6XS4gVGhpcyBzcGF3bnMg YSB0aHJlYWQgdG8KKyAgICAgICAgZGlzcGF0Y2ggdGhlIGV2ZW50cywgd2hpY2ggd2lsbCBob3Bl ZnVsbHkgYmUgY2xvc2VyIHRvIHVzZXIgYmVoYXZpb3IgYW5kIG1vcmUgcmVsaWFibHkKKyAgICAg ICAgdHJpZ2dlciB0aGUgZ2VzdHVyZSByZWNvZ25pemVyLgorCisgICAgICAgICogV2ViS2l0VGVz dFJ1bm5lci9pb3MvVUlTY3JpcHRDb250cm9sbGVySU9TLm1tOgorICAgICAgICAoV1RSOjpkaWN0 aW9uYXJ5Rm9yRmluZ2VyRXZlbnRXaXRoQ29udGVudFBvaW50KToKKyAgICAgICAgKFdUUjo6VUlT Y3JpcHRDb250cm9sbGVySU9TOjpkcmFnRnJvbVBvaW50VG9Qb2ludCk6CisKIDIwMjAtMDEtMTUg IERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgLVdj b25kaXRpb25hbC11bmluaXRpYWxpemVkIGluIER1bXBSZW5kZXJUcmVlLCBXZWJLaXRUZXN0UnVu bmVyCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENvbnRy b2xsZXJJT1MubW0gYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9VSVNjcmlwdENvbnRyb2xs ZXJJT1MubW0KaW5kZXggOWJhMzMwMzA3MWZiMjg4ZGIyOTZmODUzMWFhYjZlNGYyMzcyOTIxNS4u Yzk3OWI2NGQ0YWE0N2EwNjgyMDIzZTgyMzBkMzY2NjNiZjU4ZDA0MCAxMDA2NDQKLS0tIGEvVG9v bHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVUlTY3JpcHRDb250cm9sbGVySU9TLm1tCisrKyBiL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvaW9zL1VJU2NyaXB0Q29udHJvbGxlcklPUy5tbQpAQCAtNDMx LDE4ICs0MzEsNTYgQEAgdm9pZCBVSVNjcmlwdENvbnRyb2xsZXJJT1M6OnNlbmRFdmVudFN0cmVh bShKU1N0cmluZ1JlZiBldmVudHNKU09OLCBKU1ZhbHVlUmVmIGMKICAgICBbW0hJREV2ZW50R2Vu ZXJhdG9yIHNoYXJlZEhJREV2ZW50R2VuZXJhdG9yXSBzZW5kRXZlbnRTdHJlYW06ZXZlbnRJbmZv IGNvbXBsZXRpb25CbG9jazpjb21wbGV0aW9uLmdldCgpXTsKIH0KIAorc3RhdGljIE5TRGljdGlv bmFyeSAqZGljdGlvbmFyeUZvckZpbmdlckV2ZW50V2l0aENvbnRlbnRQb2ludChDR1BvaW50IHBv aW50LCBOU1N0cmluZyogcGhhc2UsIFNlY29uZHMgdGltZU9mZnNldCkKK3sKKyAgICByZXR1cm4g QHsKKyAgICAgICAgSElERXZlbnRDb29yZGluYXRlU3BhY2VLZXkgOiBISURFdmVudENvb3JkaW5h dGVTcGFjZVR5cGVDb250ZW50LAorICAgICAgICBISURFdmVudFRpbWVPZmZzZXRLZXkgOiBAKHRp bWVPZmZzZXQuc2Vjb25kcygpKSwKKyAgICAgICAgSElERXZlbnRJbnB1dFR5cGUgOiBISURFdmVu dElucHV0VHlwZUhhbmQsCisgICAgICAgIEhJREV2ZW50VG91Y2hlc0tleSA6IEBbCisgICAgICAg ICAgICBAeworICAgICAgICAgICAgICAgIEhJREV2ZW50VG91Y2hJREtleSA6IEAxLAorICAgICAg ICAgICAgICAgIEhJREV2ZW50SW5wdXRUeXBlIDogSElERXZlbnRJbnB1dFR5cGVGaW5nZXIsCisg ICAgICAgICAgICAgICAgSElERXZlbnRQaGFzZUtleSA6IHBoYXNlLAorICAgICAgICAgICAgICAg IEhJREV2ZW50WEtleSA6IEAocG9pbnQueCksCisgICAgICAgICAgICAgICAgSElERXZlbnRZS2V5 IDogQChwb2ludC55KSwKKyAgICAgICAgICAgIH0sCisgICAgICAgIF0sCisgICAgfTsKK30KKwog dm9pZCBVSVNjcmlwdENvbnRyb2xsZXJJT1M6OmRyYWdGcm9tUG9pbnRUb1BvaW50KGxvbmcgc3Rh cnRYLCBsb25nIHN0YXJ0WSwgbG9uZyBlbmRYLCBsb25nIGVuZFksIGRvdWJsZSBkdXJhdGlvblNl Y29uZHMsIEpTVmFsdWVSZWYgY2FsbGJhY2spCiB7CiAgICAgdW5zaWduZWQgY2FsbGJhY2tJRCA9 IG1fY29udGV4dC0+cHJlcGFyZUZvckFzeW5jVGFzayhjYWxsYmFjaywgQ2FsbGJhY2tUeXBlTm9u UGVyc2lzdGVudCk7Ci0KKyAgICAKICAgICBDR1BvaW50IHN0YXJ0UG9pbnQgPSBnbG9iYWxUb0Nv bnRlbnRDb29yZGluYXRlcyh3ZWJWaWV3KCksIHN0YXJ0WCwgc3RhcnRZKTsKICAgICBDR1BvaW50 IGVuZFBvaW50ID0gZ2xvYmFsVG9Db250ZW50Q29vcmRpbmF0ZXMod2ViVmlldygpLCBlbmRYLCBl bmRZKTsKLSAgICAKLSAgICBbW0hJREV2ZW50R2VuZXJhdG9yIHNoYXJlZEhJREV2ZW50R2VuZXJh dG9yXSBkcmFnV2l0aFN0YXJ0UG9pbnQ6c3RhcnRQb2ludCBlbmRQb2ludDplbmRQb2ludCBkdXJh dGlvbjpkdXJhdGlvblNlY29uZHMgY29tcGxldGlvbkJsb2NrOm1ha2VCbG9ja1B0cihbdGhpcywg c3Ryb25nVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBjYWxsYmFja0lEXSB7CisKKyAgICBOU0RpY3Rp b25hcnkqIHRvdWNoRG93bkluZm8gPSBkaWN0aW9uYXJ5Rm9yRmluZ2VyRXZlbnRXaXRoQ29udGVu dFBvaW50KHN0YXJ0UG9pbnQsIEhJREV2ZW50UGhhc2VCZWdhbiwgMF9zKTsKKyAgICBOU0RpY3Rp b25hcnkgKmludGVycG9sYXRlZEV2ZW50cyA9IEB7CisgICAgICAgIEhJREV2ZW50SW50ZXJwb2xh dGVLZXkgOiBISURFdmVudEludGVycG9sYXRpb25UeXBlTGluZWFyLAorICAgICAgICBISURFdmVu dENvb3JkaW5hdGVTcGFjZUtleSA6IEhJREV2ZW50Q29vcmRpbmF0ZVNwYWNlVHlwZUNvbnRlbnQs CisgICAgICAgIEhJREV2ZW50VGltZXN0ZXBLZXkgOiBAKDAuMDE2KSwKKyAgICAgICAgSElERXZl bnRTdGFydEV2ZW50S2V5IDogZGljdGlvbmFyeUZvckZpbmdlckV2ZW50V2l0aENvbnRlbnRQb2lu dChzdGFydFBvaW50LCBISURFdmVudFBoYXNlTW92ZWQsIDBfcyksCisgICAgICAgIEhJREV2ZW50 RW5kRXZlbnRLZXkgOiBkaWN0aW9uYXJ5Rm9yRmluZ2VyRXZlbnRXaXRoQ29udGVudFBvaW50KGVu ZFBvaW50LCBISURFdmVudFBoYXNlTW92ZWQsIFNlY29uZHMoZHVyYXRpb25TZWNvbmRzKSksCisg ICAgfTsKKyAgICBOU0RpY3Rpb25hcnkqIGxpZnRVcEluZm8gPSBkaWN0aW9uYXJ5Rm9yRmluZ2Vy RXZlbnRXaXRoQ29udGVudFBvaW50KGVuZFBvaW50LCBISURFdmVudFBoYXNlRW5kZWQsIFNlY29u ZHMoZHVyYXRpb25TZWNvbmRzKSk7CisKKyAgICBOU0RpY3Rpb25hcnkgKmV2ZW50U3RyZWFtID0g QHsKKyAgICAgICAgVG9wTGV2ZWxFdmVudEluZm9LZXkgOiBAWworICAgICAgICAgICAgdG91Y2hE b3duSW5mbywKKyAgICAgICAgICAgIGludGVycG9sYXRlZEV2ZW50cywKKyAgICAgICAgICAgIGxp ZnRVcEluZm8sCisgICAgICAgIF0sCisgICAgfTsKKworICAgIGF1dG8gY29tcGxldGlvbiA9IG1h a2VCbG9ja1B0cihbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWZQdHIoKnRoaXMpLCBjYWxs YmFja0lEXSB7CiAgICAgICAgIGlmICghbV9jb250ZXh0KQogICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICBtX2NvbnRleHQtPmFzeW5jVGFza0NvbXBsZXRlKGNhbGxiYWNrSUQpOwotICAgIH0p LmdldCgpXTsKKyAgICB9KTsKKworICAgIFtbSElERXZlbnRHZW5lcmF0b3Igc2hhcmVkSElERXZl bnRHZW5lcmF0b3JdIHNlbmRFdmVudFN0cmVhbTpldmVudFN0cmVhbSBjb21wbGV0aW9uQmxvY2s6 Y29tcGxldGlvbi5nZXQoKV07CiB9CiAgICAgCiB2b2lkIFVJU2NyaXB0Q29udHJvbGxlcklPUzo6 bG9uZ1ByZXNzQXRQb2ludChsb25nIHgsIGxvbmcgeSwgSlNWYWx1ZVJlZiBjYWxsYmFjaykKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpp bmRleCA1ZjExODkyOGZlZWY4MmZkOWZkOWIyY2IxOWQ4OWUxNDc0OTVjMTNkLi4wMmEyZjRkOGMx NDFhMWNhMTlmNTQ4ODUzZDk2NjYwM2RjY2NiZDEzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIw MjAtMDEtMTcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAg ICAgU29tZSBpT1MgdGVzdHMgdXNpbmcgVUlIZWxwZXIuZHJhZ0Zyb21Qb2ludFRvUG9pbnQoKSBh cmUgZmxha2V5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMDY0NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVbnNraXAgdGVzdHMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3Rh dGlvbnM6CisgICAgICAgICogcGxhdGZvcm0vaW9zL1Rlc3RFeHBlY3RhdGlvbnM6CisKIDIwMjAt MDEtMTUgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyNTQ1NzYuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9pb3Mtd2syL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNWQzMWQ4NjdmNTFjNzExZDRmMGUzMTE2 ZDZkMTJjODgxNzIyMTY4My4uMjkwYzYyMjJiMmY0YmI0YWYxNjNmN2IyOTNiMWQ4MzEzMTBhMTRk OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vaW9zLXdrMi9UZXN0RXhwZWN0YXRp b25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy13azIvVGVzdEV4cGVjdGF0aW9ucwpA QCAtMTMzOSw5ICsxMzM5LDYgQEAgd2Via2l0Lm9yZy9iLzIwMzI2NCBbIFJlbGVhc2UgXSBlZGl0 aW5nL3Bhc3RlYm9hcmQvc21hcnQtcGFzdGUtcGFyYWdyYXBoLTAwMi5odG0KIHdlYmtpdC5vcmcv Yi8yMDMyNjQgWyBSZWxlYXNlIF0gZWRpdGluZy9wYXN0ZWJvYXJkL3NtYXJ0LXBhc3RlLXBhcmFn cmFwaC0wMDMuaHRtbCBbIFBhc3MgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMjAzMjY0IFsgUmVs ZWFzZSBdIGVkaXRpbmcvcGFzdGVib2FyZC9zbWFydC1wYXN0ZS1wYXJhZ3JhcGgtMDA0Lmh0bWwg WyBQYXNzIEZhaWx1cmUgXQogCi0jIDxyZGFyOi8vcHJvYmxlbS81NjcxNDEzOT4gKHIyNTEyNDIp IFsgaU9TIF06IGZhc3Qvc2Nyb2xsaW5nL2lvcy90b3VjaC1zY3JvbGwtdmlzaWJpbGl0eS1oaWRk ZW4uaHRtbCBpcyBhIEZsYWt5IFRpbWVvdXQgKDIwMzU3NykKLXdlYmtpdC5vcmcvYi8yMDM1Nzcg ZmFzdC9zY3JvbGxpbmcvaW9zL3RvdWNoLXNjcm9sbC12aXNpYmlsaXR5LWhpZGRlbi5odG1sIFsg UGFzcyBUaW1lb3V0IF0KLQogIyBUaW1lb3V0IHJ1bm5pbmcgcHJvbXB0KCkgYmVjYXVzZSBtb2Nr IGltcGxlbWVudGF0aW9uIGlzIGFic2VudC4KIHdlYmtpdC5vcmcvYi8yMDM1NzIgbWVkaWEvcmVt b3RlcGxheWJhY2stcHJvbXB0Lmh0bWwgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8yMDM1NzIgbWVk aWEvcmVtb3RlcGxheWJhY2stdGFyZ2V0LWF2YWlsYWJpbGl0eS5odG1sIFsgU2tpcCBdCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3MvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGU3YTQzNTllNzI0YTAz OTg1YTM1YTUzNzYwNjRjNmY5YWM2NTMxNmQuLmYxMDU4YmVlMjFhNzM1MWVhMjYzNTM0ZmJmOGYy ODdlMjhhYTIzNmMgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhw ZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25z CkBAIC0zMzQ1LDEwICszMzQ1LDYgQEAgbGVnYWN5LWFuaW1hdGlvbi1lbmdpbmUvZmFzdC90ZXh0 L2NyYXNoLWNvbXBsZXgtdGV4dC1zdXJyb2dhdGUuaHRtbCBbIEZhaWx1cmUgXQogZmFzdC90ZXh0 L2NyYXNoLWNvbXBsZXgtdGV4dC1zdXJyb2dhdGUuaHRtbCBbIEZhaWx1cmUgXQogZmFzdC90ZXh0 L2ludGVybmF0aW9uYWwvc3lzdGVtLWxhbmd1YWdlL3N5c3RlbS1mb250LXB1bmN0dWF0aW9uLmh0 bWwgWyBGYWlsdXJlIF0KIAotIyA8cmRhcjovL3Byb2JsZW0vNTE3NTYyNTQ+UkVHUkVTU0lPTiAo cjI0NDU4Mi1yMjQ0NTk2KSBMYXlvdXQgdGVzdHMgZmFzdC9zY3JvbGxpbmcvaW9zL3RvdWNoLXNj cm9sbC12aXNpYmlsaXR5LWhpZGRlbi5odG1sIGZhc3Qvc2Nyb2xsaW5nL2lvcy90b3VjaC1zY3Jv bGwtcG9pbnRlci1ldmVudHMtbm9uZS5odG1sIGFyZSBmYWlsaW5nCi1mYXN0L3Njcm9sbGluZy9p b3MvdG91Y2gtc2Nyb2xsLXBvaW50ZXItZXZlbnRzLW5vbmUuaHRtbCBbIEZhaWx1cmUgXQotZmFz dC9zY3JvbGxpbmcvaW9zL3RvdWNoLXNjcm9sbC12aXNpYmlsaXR5LWhpZGRlbi5odG1sIFsgRmFp bHVyZSBdCi0KICMgPHJkYXI6Ly9wcm9ibGVtLzUyOTYyMjcyPiBmYXN0L3Njcm9sbGluZy9pb3Mv Ym9keS1vdmVyZmxvdy1oaWRkZW4uaHRtbCBpcyBhbiBJbWFnZSBmYWlsdXJlCiBmYXN0L3Njcm9s bGluZy9pb3MvYm9keS1vdmVyZmxvdy1oaWRkZW4uaHRtbCBbIFBhc3MgSW1hZ2VPbmx5RmFpbHVy ZSBdCiAK