206427 2020-01-17 10:28:57 -0800 [iOS] ASSERTION FAILED: ASSERT_NOT_REACHED() in selectionChangedWithTouch(WKContentView*, WebCore::IntPoint const&, unsigned int, unsigned int, WebKit::CallbackBase::Error) 2020-01-17 15:36:15 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Local Build iPhone / iPad iOS 13 RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1608061 0 dbates 2020-01-17 10:28:57 -0800 While trying to drag selected text in a text field on iOS the web process crashed then I hit the assertion ASSERT_NOT_REACHED in selectionChangedWithTouch(): [[ #2 0x00000001093e8b74 in selectionChangedWithTouch(WKContentView*, WebCore::IntPoint const&, unsigned int, unsigned int, WebKit::CallbackBase::Error) at /Volumes/.../Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3855 #3 0x00000001093e8ac0 in -[WKContentView(WKInteraction) changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]::$_12::operator()(WebCore::IntPoint const&, unsigned int, unsigned int, WebKit::CallbackBase::Error) const at /Volumes/.../Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:3885 #4 0x00000001093e8a0c in WTF::Detail::CallableWrapper<-[WKContentView(WKInteraction) changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]::$_12, void, WebCore::IntPoint const&, unsigned int, unsigned int, WebKit::CallbackBase::Error>::call(WebCore::IntPoint const&, unsigned int, unsigned int, WebKit::CallbackBase::Error) at /Volumes/.../Source/WTF/wtf/Function.h:52 #5 0x000000010881a688 in WTF::Function<void (WebCore::IntPoint const&, unsigned int, unsigned int, WebKit::CallbackBase::Error)>::operator()(WebCore::IntPoint const&, unsigned int, unsigned int, WebKit::CallbackBase::Error) const at /Volumes/.../Source/WTF/wtf/Function.h:84 #6 0x000000010883c0f4 in WebKit::GenericCallback<WebCore::IntPoint const&, unsigned int, unsigned int>::invalidate(WebKit::CallbackBase::Error) at /Volumes/.../Source/WebKit/UIProcess/GenericCallback.h:125 #7 0x00000001085a7380 in void WebKit::invalidateCallbackMap<WTF::RefPtr<WebKit::CallbackBase, WTF::DumbPtrTraits<WebKit::CallbackBase> > >(WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::CallbackBase, WTF::DumbPtrTraits<WebKit::CallbackBase> >, WTF::IntHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::CallbackBase, WTF::DumbPtrTraits<WebKit::CallbackBase> > > >&, WebKit::CallbackBase::Error) at /Volumes/.../Source/WebKit/UIProcess/GenericCallback.h:167 #8 0x000000010859bec4 in WebKit::CallbackMap::invalidate(WebKit::CallbackBase::Error) at /Volumes/.../Source/WebKit/UIProcess/GenericCallback.h:214 #9 0x00000001085cf43c in WebKit::WebPageProxy::resetState(WebKit::WebPageProxy::ResetStateReason) at /Volumes/.../Source/WebKit/UIProcess/WebPageProxy.cpp:7387 #10 0x00000001085fb6f8 in WebKit::WebPageProxy::resetStateAfterProcessExited(WebKit::ProcessTerminationReason) at /Volumes/.../Source/WebKit/UIProcess/WebPageProxy.cpp:7451 #11 0x00000001085de1d4 in WebKit::WebPageProxy::processDidTerminate(WebKit::ProcessTerminationReason) at /Volumes/.../Source/WebKit/UIProcess/WebPageProxy.cpp:7160 #12 0x00000001086fed50 in WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch() at /Volumes/.../Source/WebKit/UIProcess/WebProcessProxy.cpp:794 #13 0x00000001086fe970 in WebKit::WebProcessProxy::didClose(IPC::Connection&) at /Volumes/.../Source/WebKit/UIProcess/WebProcessProxy.cpp:751 #14 0x0000000107a40e94 in IPC::Connection::connectionDidClose()::$_6::operator()() at /Volumes/.../Source/WebKit/Platform/IPC/Connection.cpp:873 #15 0x0000000107a40d70 in WTF::Detail::CallableWrapper<IPC::Connection::connectionDidClose()::$_6, void>::call() at /Volumes/.../Source/WTF/wtf/Function.h:52 #16 0x0000000101336778 in WTF::Function<void ()>::operator()() const at /Volumes/.../Source/WTF/wtf/Function.h:84 #17 0x000000010139c5bc in WTF::RunLoop::performWork() at /Volumes/.../Source/WTF/wtf/RunLoop.cpp:107 #18 0x000000010139d0bc in WTF::RunLoop::performWork(void*) at /Volumes/.../Source/WTF/wtf/cf/RunLoopCF.cpp:38 ]] 1608062 1 dbates 2020-01-17 10:29:38 -0800 (lldb) p error (WebKit::CallbackBase::Error) $0 = ProcessExited 1608065 2 dbates 2020-01-17 10:32:42 -0800 The assertion looks invalid. We are being called back to tell us that the process exited. 1608084 3 388060 dbates 2020-01-17 10:52:58 -0800 Created attachment 388060 Patch 1608194 4 dbates 2020-01-17 13:59:43 -0800 Thanks for the review! 1608245 5 388060 dbates 2020-01-17 15:35:49 -0800 Comment on attachment 388060 Patch Clearing flags on attachment: 388060 Committed r254769: <https://trac.webkit.org/changeset/254769> 1608246 6 dbates 2020-01-17 15:35:50 -0800 All reviewed patches have been landed. Closing bug. 1608247 7 webkit-bug-importer 2020-01-17 15:36:15 -0800 <rdar://problem/58698357> 388060 2020-01-17 10:52:58 -0800 2020-01-17 15:35:49 -0800 Patch bug-206427-20200117105257.patch text/plain 3079 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE0MmJiOGNkNzk1YTEzMDIy NDI1ODA5NjkxNzk1ZjVlMzkxMGM4MDcuLjAxYzFkMGJiNTJjZmJlYjgxOGM0ODBhNTE2MjJhZTY3 ZGU3ZWFmYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDEtMTcgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEFTU0VSVElPTiBGQUlM RUQ6IEFTU0VSVF9OT1RfUkVBQ0hFRCgpIGluIHNlbGVjdGlvbkNoYW5nZWRXaXRoVG91Y2goV0tD b250ZW50VmlldyosIFdlYkNvcmU6OkludFBvaW50IGNvbnN0JiwgdW5zaWduZWQgaW50LCB1bnNp Z25lZCBpbnQsIFdlYktpdDo6Q2FsbGJhY2tCYXNlOjpFcnJvcikKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQyNworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBBU1NFUlRfTk9UX1JFQUNIRUQo KSB1c2FnZSBpbiBjYWxsYmFja3Mgc2VsZWN0aW9uQ2hhbmdlZFdpdGhUb3VjaCgpIGFuZCBzZWxl Y3Rpb25DaGFuZ2VkV2l0aEdlc3R1cmUoKS4KKyAgICAgICAgVGhlc2UgY2FsbGJhY2tzIGNhbiBo YW5kbGUgYmVpbmctIGFuZCBzaG91bGQgZXhwZWN0IHRvIHNvbWV0aW1lcyBiZS0gaW52b2tlZCB3 aXRoIGEgbm9uLU5vbmUgZXJyb3IgdmFsdWUuCisgICAgICAgIEluIHBhcnRpY3VsYXIsIGlmIHRo ZSBXZWJQcm9jZXNzIGNyYXNoZXMgdGhlbiB0aGVzZSBjYWxsYmFja3Mgd2lsbCBiZSBpbnZva2Vk IHdpdGggZXJyb3IgQ2FsbGJhY2tCYXNlOjpFcnJvcjo6UHJvY2Vzc0V4aXRlZC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAo c2VsZWN0aW9uQ2hhbmdlZFdpdGhHZXN0dXJlKTogUmVtb3ZlIEFTU0VSVF9OT1RfUkVBQ0hFRCgp IHdoZW4gYW4gZXJyb3Igb2NjdXJzLiBUaGlzCisgICAgICAgIGZ1bmN0aW9uIGlzIGNhcGFibGUg b2YgaGFuZGxpbmcgdGhpcyBlcnJvci4KKyAgICAgICAgKHNlbGVjdGlvbkNoYW5nZWRXaXRoVG91 Y2gpOiBEaXR0by4KKwogMjAyMC0wMS0xNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5j b20+CiAKICAgICAgICAgW2lPU10gRm9jdXNpbmcgZWRpdGFibGUgZWxlbWVudCB3aXRoIFdlYlBh Z2U6OnNlbGVjdFBvc2l0aW9uQXRQb2ludCgpIGRvZXMgbm90IGJyaW5nIHVwIGtleWJvYXJkCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVy YWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRl cmFjdGlvbi5tbQppbmRleCA4Nzk0N2NiM2FjMTY0YTgyNWY0NDlmZTk3MGVlZDFjNTU1NTViMjgy Li44NWU3ODYyNDZlYWQ5Y2RjYjU3OTEzMWVhYWRmYjdmOTI1NzRhYjJlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisr KyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KQEAgLTM4NDIsMTkgKzM4NDIsMTUgQEAgc3RhdGljIGlubGluZSBXZWJDb3JlOjpTZWxlY3Rp b25EaXJlY3Rpb24gdG9XS1NlbGVjdGlvbkRpcmVjdGlvbihVSVRleHREaXJlY3Rpb24KIAogc3Rh dGljIHZvaWQgc2VsZWN0aW9uQ2hhbmdlZFdpdGhHZXN0dXJlKFdLQ29udGVudFZpZXcgKnZpZXcs IGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBwb2ludCwgdWludDMyX3QgZ2VzdHVyZVR5cGUsIHVp bnQzMl90IGdlc3R1cmVTdGF0ZSwgdWludDMyX3QgZmxhZ3MsIFdlYktpdDo6Q2FsbGJhY2tCYXNl OjpFcnJvciBlcnJvcikKIHsKLSAgICBpZiAoZXJyb3IgIT0gV2ViS2l0OjpDYWxsYmFja0Jhc2U6 OkVycm9yOjpOb25lKSB7Ci0gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIGlmIChl cnJvciAhPSBXZWJLaXQ6OkNhbGxiYWNrQmFzZTo6RXJyb3I6Ok5vbmUpCiAgICAgICAgIHJldHVy bjsKLSAgICB9CiAgICAgWyhVSVdLVGV4dEludGVyYWN0aW9uQXNzaXN0YW50ICopW3ZpZXcgaW50 ZXJhY3Rpb25Bc3Npc3RhbnRdIHNlbGVjdGlvbkNoYW5nZWRXaXRoR2VzdHVyZUF0OihDR1BvaW50 KXBvaW50IHdpdGhHZXN0dXJlOnRvVUlXS0dlc3R1cmVUeXBlKChXZWJLaXQ6Okdlc3R1cmVUeXBl KWdlc3R1cmVUeXBlKSB3aXRoU3RhdGU6dG9VSUdlc3R1cmVSZWNvZ25pemVyU3RhdGUoc3RhdGlj X2Nhc3Q8V2ViS2l0OjpHZXN0dXJlUmVjb2duaXplclN0YXRlPihnZXN0dXJlU3RhdGUpKSB3aXRo RmxhZ3M6KHRvVUlXS1NlbGVjdGlvbkZsYWdzKChXZWJLaXQ6OlNlbGVjdGlvbkZsYWdzKWZsYWdz KSldOwogfQogCiBzdGF0aWMgdm9pZCBzZWxlY3Rpb25DaGFuZ2VkV2l0aFRvdWNoKFdLQ29udGVu dFZpZXcgKnZpZXcsIGNvbnN0IFdlYkNvcmU6OkludFBvaW50JiBwb2ludCwgdWludDMyX3QgdG91 Y2gsIHVpbnQzMl90IGZsYWdzLCBXZWJLaXQ6OkNhbGxiYWNrQmFzZTo6RXJyb3IgZXJyb3IpCiB7 Ci0gICAgaWYgKGVycm9yICE9IFdlYktpdDo6Q2FsbGJhY2tCYXNlOjpFcnJvcjo6Tm9uZSkgewot ICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICBpZiAoZXJyb3IgIT0gV2ViS2l0OjpD YWxsYmFja0Jhc2U6OkVycm9yOjpOb25lKQogICAgICAgICByZXR1cm47Ci0gICAgfQogICAgIFso VUlXS1RleHRJbnRlcmFjdGlvbkFzc2lzdGFudCAqKVt2aWV3IGludGVyYWN0aW9uQXNzaXN0YW50 XSBzZWxlY3Rpb25DaGFuZ2VkV2l0aFRvdWNoQXQ6KENHUG9pbnQpcG9pbnQgd2l0aFNlbGVjdGlv blRvdWNoOnRvVUlXS1NlbGVjdGlvblRvdWNoKChXZWJLaXQ6OlNlbGVjdGlvblRvdWNoKXRvdWNo KSB3aXRoRmxhZ3M6c3RhdGljX2Nhc3Q8VUlXS1NlbGVjdGlvbkZsYWdzPihmbGFncyldOwogfQog Cg==