206423 2020-01-17 09:30:57 -0800 [LFC][IFC] Use Optional for partialLeading/TrailingTextItem 2020-01-17 10:54:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1608036 0 koivisto 2020-01-17 09:30:57 -0800 Remove the remaining heap allocated InlineItem 1608040 1 388050 koivisto 2020-01-17 09:37:32 -0800 Created attachment 388050 patch 1608085 2 388050 commit-queue 2020-01-17 10:53:04 -0800 Comment on attachment 388050 patch Clearing flags on attachment: 388050 Committed r254754: <https://trac.webkit.org/changeset/254754> 1608086 3 commit-queue 2020-01-17 10:53:06 -0800 All reviewed patches have been landed. Closing bug. 1608087 4 webkit-bug-importer 2020-01-17 10:54:16 -0800 <rdar://problem/58687959> 388050 2020-01-17 09:37:32 -0800 2020-01-17 10:53:04 -0800 patch lfc-InlineItem-no-heap.patch text/plain 6164 koivisto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNDBmNTQzNTdjZi4uNDM5MzIyOTA0YTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNCBAQAorMjAyMC0wMS0xNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CisKKyAgICAgICAgW0xGQ11bSUZDXSBVc2UgT3B0aW9uYWwgZm9yIHBhcnRpYWxMZWFkaW5nL1Ry YWlsaW5nVGV4dEl0ZW0KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIwNjQyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFJlbW92ZSB0aGUgcmVtYWluaW5nIElubGluZUl0ZW0gaGVhcCBhbGxvY2F0aW9uLgor CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lSXRlbS5oOgorICAgICAg ICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6SW5saW5lVGV4dEl0ZW06OmxlZnQgY29uc3QpOiBEZWxldGVkLgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpJbmxpbmVUZXh0SXRlbTo6cmlnaHQgY29uc3QpOiBE ZWxldGVkLgorICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVt Lmg6CisKKyAgICAgICAgQ29uc3RydWN0b3IgY2FuIG5vdyBiZSBwcml2YXRlLgorCisgICAgICAg IChXZWJDb3JlOjpMYXlvdXQ6OklubGluZVRleHRJdGVtOjpsZWZ0IGNvbnN0KToKKyAgICAgICAg KFdlYkNvcmU6OkxheW91dDo6SW5saW5lVGV4dEl0ZW06OnJpZ2h0IGNvbnN0KToKKyAgICAgICAg KiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9MaW5lTGF5b3V0Q29udGV4dC5oOgorCiAyMDIwLTAx LTE3ICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZD XSBPcHRpbWl6ZSBMaW5lQnVpbGRlcjo6YXBwZW5kVGV4dENvbnRlbnQgZm9yIHRoZSBtb3N0IGNv bW1vbiBpbmxpbmUgY29udGVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvSW5saW5lSXRlbS5oIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lSXRlbS5oCmluZGV4IDI2ZGRlZmM2OGI0Li40MjBjN2NiNmVlMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5l SXRlbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGlu ZUl0ZW0uaApAQCAtMzMsNyArMzMsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBuYW1lc3BhY2Ug TGF5b3V0IHsKIAogY2xhc3MgSW5saW5lSXRlbSB7Ci0gICAgV1RGX01BS0VfRkFTVF9BTExPQ0FU RUQ7CiBwdWJsaWM6CiAgICAgZW51bSBjbGFzcyBUeXBlIDogdWludDhfdCB7IFRleHQsIEhhcmRM aW5lQnJlYWssIFNvZnRMaW5lQnJlYWssIEJveCwgRmxvYXQsIENvbnRhaW5lclN0YXJ0LCBDb250 YWluZXJFbmQgfTsKICAgICBJbmxpbmVJdGVtKGNvbnN0IEJveCYgbGF5b3V0Qm94LCBUeXBlKTsK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGlu ZVRleHRJdGVtLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZVRleHRJdGVtLmNwcAppbmRleCAyZjc4OWEzNzc2NC4uMWNkMzNiYWQzODMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVt LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVU ZXh0SXRlbS5jcHAKQEAgLTEyNywyMiArMTI3LDYgQEAgYm9vbCBJbmxpbmVUZXh0SXRlbTo6aXNF bXB0eUNvbnRlbnQoKSBjb25zdAogICAgIHJldHVybiAhbV9sZW5ndGggfHwgKG1fbGVuZ3RoID09 IDEgJiYgbGF5b3V0Qm94KCkudGV4dENvbnRleHQoKS0+Y29udGVudFtzdGFydCgpXSA9PSB6ZXJv V2lkdGhTcGFjZSk7IAogfQogCi1zdGQ6OnVuaXF1ZV9wdHI8SW5saW5lVGV4dEl0ZW0+IElubGlu ZVRleHRJdGVtOjpsZWZ0KHVuc2lnbmVkIGxlbmd0aCkgY29uc3QKLXsKLSAgICBSRUxFQVNFX0FT U0VSVChsZW5ndGggPD0gdGhpcy0+bGVuZ3RoKCkpOwotICAgIEFTU0VSVChtX3RleHRJdGVtVHlw ZSAhPSBUZXh0SXRlbVR5cGU6OlVuZGVmaW5lZCk7Ci0gICAgQVNTRVJUKGxlbmd0aCk7Ci0gICAg cmV0dXJuIG1ha2VVbmlxdWU8SW5saW5lVGV4dEl0ZW0+KGxheW91dEJveCgpLCBzdGFydCgpLCBs ZW5ndGgsIFdURjo6bnVsbG9wdCwgbV90ZXh0SXRlbVR5cGUpOwotfQotCi1zdGQ6OnVuaXF1ZV9w dHI8SW5saW5lVGV4dEl0ZW0+IElubGluZVRleHRJdGVtOjpyaWdodCh1bnNpZ25lZCBsZW5ndGgp IGNvbnN0Ci17Ci0gICAgUkVMRUFTRV9BU1NFUlQobGVuZ3RoIDw9IHRoaXMtPmxlbmd0aCgpKTsK LSAgICBBU1NFUlQobV90ZXh0SXRlbVR5cGUgIT0gVGV4dEl0ZW1UeXBlOjpVbmRlZmluZWQpOwot ICAgIEFTU0VSVChsZW5ndGgpOwotICAgIHJldHVybiBtYWtlVW5pcXVlPElubGluZVRleHRJdGVt PihsYXlvdXRCb3goKSwgZW5kKCkgLSBsZW5ndGgsIGxlbmd0aCwgV1RGOjpudWxsb3B0LCBtX3Rl eHRJdGVtVHlwZSk7Ci19Ci0KIH0KIH0KICNlbmRpZgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lVGV4dEl0ZW0uaCBiL1NvdXJjZS9XZWJD b3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVtLmgKaW5kZXggZWMyNDEx NDdkODguLjJmMTc4NzdhYmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5s aW5lZm9ybWF0dGluZy9JbmxpbmVUZXh0SXRlbS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZVRleHRJdGVtLmgKQEAgLTM3LDEwICszNyw2IEBAIGNs YXNzIElubGluZVRleHRJdGVtIDogcHVibGljIElubGluZUl0ZW0gewogcHVibGljOgogICAgIHN0 YXRpYyB2b2lkIGNyZWF0ZUFuZEFwcGVuZFRleHRJdGVtcyhJbmxpbmVJdGVtcyYsIGNvbnN0IEJv eCYpOwogCi0gICAgc3RhdGljIElubGluZVRleHRJdGVtIGNyZWF0ZVdoaXRlc3BhY2VJdGVtKGNv bnN0IEJveCYsIHVuc2lnbmVkIHN0YXJ0LCB1bnNpZ25lZCBsZW5ndGgsIE9wdGlvbmFsPElubGlu ZUxheW91dFVuaXQ+IHdpZHRoKTsKLSAgICBzdGF0aWMgSW5saW5lVGV4dEl0ZW0gY3JlYXRlTm9u V2hpdGVzcGFjZUl0ZW0oY29uc3QgQm94JiwgdW5zaWduZWQgc3RhcnQsIHVuc2lnbmVkIGxlbmd0 aCwgT3B0aW9uYWw8SW5saW5lTGF5b3V0VW5pdD4gd2lkdGgpOwotICAgIHN0YXRpYyBJbmxpbmVU ZXh0SXRlbSBjcmVhdGVFbXB0eUl0ZW0oY29uc3QgQm94Jik7Ci0KICAgICB1bnNpZ25lZCBzdGFy dCgpIGNvbnN0IHsgcmV0dXJuIG1fc3RhcnRPclBvc2l0aW9uOyB9CiAgICAgdW5zaWduZWQgZW5k KCkgY29uc3QgeyByZXR1cm4gc3RhcnQoKSArIGxlbmd0aCgpOyB9CiAgICAgdW5zaWduZWQgbGVu Z3RoKCkgY29uc3QgeyByZXR1cm4gbV9sZW5ndGg7IH0KQEAgLTUwLDEzICs0NiwxOCBAQCBwdWJs aWM6CiAgICAgT3B0aW9uYWw8SW5saW5lTGF5b3V0VW5pdD4gd2lkdGgoKSBjb25zdCB7IHJldHVy biBtX2hhc1dpZHRoID8gbWFrZU9wdGlvbmFsKG1fd2lkdGgpIDogT3B0aW9uYWw8SW5saW5lTGF5 b3V0VW5pdD4geyB9OyB9CiAgICAgYm9vbCBpc0VtcHR5Q29udGVudCgpIGNvbnN0OwogCi0gICAg c3RkOjp1bmlxdWVfcHRyPElubGluZVRleHRJdGVtPiBsZWZ0KHVuc2lnbmVkIGxlbmd0aCkgY29u c3Q7Ci0gICAgc3RkOjp1bmlxdWVfcHRyPElubGluZVRleHRJdGVtPiByaWdodCh1bnNpZ25lZCBs ZW5ndGgpIGNvbnN0OworICAgIElubGluZVRleHRJdGVtIGxlZnQodW5zaWduZWQgbGVuZ3RoKSBj b25zdDsKKyAgICBJbmxpbmVUZXh0SXRlbSByaWdodCh1bnNpZ25lZCBsZW5ndGgpIGNvbnN0Owog Citwcml2YXRlOgogICAgIHVzaW5nIElubGluZUl0ZW06OlRleHRJdGVtVHlwZTsKIAogICAgIElu bGluZVRleHRJdGVtKGNvbnN0IEJveCYsIHVuc2lnbmVkIHN0YXJ0LCB1bnNpZ25lZCBsZW5ndGgs IE9wdGlvbmFsPElubGluZUxheW91dFVuaXQ+IHdpZHRoLCBUZXh0SXRlbVR5cGUpOwogICAgIElu bGluZVRleHRJdGVtKGNvbnN0IEJveCYpOworCisgICAgc3RhdGljIElubGluZVRleHRJdGVtIGNy ZWF0ZVdoaXRlc3BhY2VJdGVtKGNvbnN0IEJveCYsIHVuc2lnbmVkIHN0YXJ0LCB1bnNpZ25lZCBs ZW5ndGgsIE9wdGlvbmFsPElubGluZUxheW91dFVuaXQ+IHdpZHRoKTsKKyAgICBzdGF0aWMgSW5s aW5lVGV4dEl0ZW0gY3JlYXRlTm9uV2hpdGVzcGFjZUl0ZW0oY29uc3QgQm94JiwgdW5zaWduZWQg c3RhcnQsIHVuc2lnbmVkIGxlbmd0aCwgT3B0aW9uYWw8SW5saW5lTGF5b3V0VW5pdD4gd2lkdGgp OworICAgIHN0YXRpYyBJbmxpbmVUZXh0SXRlbSBjcmVhdGVFbXB0eUl0ZW0oY29uc3QgQm94Jik7 CiB9OwogCiBpbmxpbmUgSW5saW5lVGV4dEl0ZW0gSW5saW5lVGV4dEl0ZW06OmNyZWF0ZVdoaXRl c3BhY2VJdGVtKGNvbnN0IEJveCYgaW5saW5lQm94LCB1bnNpZ25lZCBzdGFydCwgdW5zaWduZWQg bGVuZ3RoLCBPcHRpb25hbDxJbmxpbmVMYXlvdXRVbml0PiB3aWR0aCkKQEAgLTkwLDYgKzkxLDIy IEBAIGlubGluZSBJbmxpbmVUZXh0SXRlbTo6SW5saW5lVGV4dEl0ZW0oY29uc3QgQm94JiBpbmxp bmVCb3gpCiB7CiB9CiAKK2lubGluZSBJbmxpbmVUZXh0SXRlbSBJbmxpbmVUZXh0SXRlbTo6bGVm dCh1bnNpZ25lZCBsZW5ndGgpIGNvbnN0Cit7CisgICAgUkVMRUFTRV9BU1NFUlQobGVuZ3RoIDw9 IHRoaXMtPmxlbmd0aCgpKTsKKyAgICBBU1NFUlQobV90ZXh0SXRlbVR5cGUgIT0gVGV4dEl0ZW1U eXBlOjpVbmRlZmluZWQpOworICAgIEFTU0VSVChsZW5ndGgpOworICAgIHJldHVybiB7IGxheW91 dEJveCgpLCBzdGFydCgpLCBsZW5ndGgsIFdURjo6bnVsbG9wdCwgbV90ZXh0SXRlbVR5cGUgfTsK K30KKworaW5saW5lIElubGluZVRleHRJdGVtIElubGluZVRleHRJdGVtOjpyaWdodCh1bnNpZ25l ZCBsZW5ndGgpIGNvbnN0Cit7CisgICAgUkVMRUFTRV9BU1NFUlQobGVuZ3RoIDw9IHRoaXMtPmxl bmd0aCgpKTsKKyAgICBBU1NFUlQobV90ZXh0SXRlbVR5cGUgIT0gVGV4dEl0ZW1UeXBlOjpVbmRl ZmluZWQpOworICAgIEFTU0VSVChsZW5ndGgpOworICAgIHJldHVybiB7IGxheW91dEJveCgpLCBl bmQoKSAtIGxlbmd0aCwgbGVuZ3RoLCBXVEY6Om51bGxvcHQsIG1fdGV4dEl0ZW1UeXBlIH07Cit9 CisKIH0KIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvTGluZUxheW91dENvbnRleHQuaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVm b3JtYXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmgKaW5kZXggZWZkMjYxNDA1ZGYuLjUzOGU5OTM3 ZjRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9M aW5lTGF5b3V0Q29udGV4dC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3Jt YXR0aW5nL0xpbmVMYXlvdXRDb250ZXh0LmgKQEAgLTc1LDggKzc1LDggQEAgcHJpdmF0ZToKICAg ICBjb25zdCBDb250YWluZXImIG1fZm9ybWF0dGluZ0NvbnRleHRSb290OwogICAgIGNvbnN0IElu bGluZUl0ZW1zJiBtX2lubGluZUl0ZW1zOwogICAgIEZsb2F0TGlzdCBtX2Zsb2F0czsKLSAgICBz dGQ6OnVuaXF1ZV9wdHI8SW5saW5lVGV4dEl0ZW0+IG1fcGFydGlhbExlYWRpbmdUZXh0SXRlbTsK LSAgICBzdGQ6OnVuaXF1ZV9wdHI8SW5saW5lVGV4dEl0ZW0+IG1fcGFydGlhbFRyYWlsaW5nVGV4 dEl0ZW07CisgICAgT3B0aW9uYWw8SW5saW5lVGV4dEl0ZW0+IG1fcGFydGlhbExlYWRpbmdUZXh0 SXRlbTsKKyAgICBPcHRpb25hbDxJbmxpbmVUZXh0SXRlbT4gbV9wYXJ0aWFsVHJhaWxpbmdUZXh0 SXRlbTsKICAgICB1bnNpZ25lZCBtX3N1Y2Nlc3NpdmVIeXBoZW5hdGVkTGluZUNvdW50IHsgMCB9 OwogfTsKIAo=