206421 2020-01-17 09:19:43 -0800 [EWS] Print disk space usage for windows bots 2020-01-18 07:19:38 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jbedard tsavell webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1608027 0 aakash_jain 2020-01-17 09:19:43 -0800 We added build-step to print bot configuration in EWS in https://trac.webkit.org/changeset/240680/webkit On windows, we should also print disk space usage. It would help in debugging disk space issues. 1608028 1 388046 aakash_jain 2020-01-17 09:24:47 -0800 Created attachment 388046 Patch 1608035 2 aakash_jain 2020-01-17 09:30:19 -0800 Test run: https://ews-build.webkit-uat.org/#/builders/13/builds/2343/steps/2/logs/stdio 1608037 3 388048 aakash_jain 2020-01-17 09:34:12 -0800 Created attachment 388048 Patch 1608039 4 388048 jbedard 2020-01-17 09:37:28 -0800 Comment on attachment 388048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1888 > + command_list_win = [['df', '-hl']] Shouldn't this go into command_list_generic? Do we have a 4th class of machines? 1608042 5 388048 aakash_jain 2020-01-17 09:40:45 -0800 Comment on attachment 388048 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:1888 >> + command_list_win = [['df', '-hl']] > > Shouldn't this go into command_list_generic? Do we have a 4th class of machines? Yeah, the 4th category is wincairo. We don't want to run this command on wincairo since I believe wincairo doesn't use cygwin and windows doesn't have df command. 1608286 6 commit-queue 2020-01-17 16:32:18 -0800 The commit-queue encountered the following flaky tests while processing attachment 388048: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1608288 7 388048 commit-queue 2020-01-17 16:32:54 -0800 Comment on attachment 388048 Patch Clearing flags on attachment: 388048 Committed r254777: <https://trac.webkit.org/changeset/254777> 1608289 8 commit-queue 2020-01-17 16:32:56 -0800 All reviewed patches have been landed. Closing bug. 1608290 9 webkit-bug-importer 2020-01-17 16:33:15 -0800 <rdar://problem/58700332> 1608435 10 aakash_jain 2020-01-18 07:19:38 -0800 Deployed on the production server. Working fine, e.g.: https://ews-build.webkit.org/#/builders/10/builds/4263/steps/2/logs/stdio 388046 2020-01-17 09:24:47 -0800 2020-01-17 09:34:08 -0800 Patch bug-206421-20200117122446.patch text/plain 1808 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NDc1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBQcmludCBkaXNrIHNwYWNlIHVzYWdlIGZvciB3aW5kb3dzIGJv dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQy MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoUHJpbnRDb25maWd1 cmF0aW9uKTogV2luZG93cyBib3QgdXNlIGN5Z3dpbiwgc28gZGYgY29tbWFuZCB3b3Jrcy4KKwog MjAyMC0wMS0xNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZWxhbmQgYnl0ZWNvZGUgY2hlY2twb2ludHMgc2luY2UgYnVncyBoYXZlIGJlZW4gZml4 ZWQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJl dmlzaW9uIDI1NDc1MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw cy5weQkod29ya2luZyBjb3B5KQpAQCAtMTg4NSw3ICsxODg1LDcgQEAgY2xhc3MgUHJpbnRDb25m aWd1cmF0aW9uKHN0ZXBzLlNoZWxsU2VxdQogICAgIGNvbW1hbmRfbGlzdF9nZW5lcmljID0gW1sn aG9zdG5hbWUnXV0KICAgICBjb21tYW5kX2xpc3RfYXBwbGUgPSBbWydkZicsICctaGwnXSwgWydk YXRlJ10sIFsnc3dfdmVycyddLCBbJ3hjb2RlYnVpbGQnLCAnLXNkaycsICctdmVyc2lvbiddLCBb J3VwdGltZSddXQogICAgIGNvbW1hbmRfbGlzdF9saW51eCA9IFtbJ2RmJywgJy1obCddLCBbJ2Rh dGUnXSwgWyd1bmFtZScsICctYSddLCBbJ3VwdGltZSddXQotICAgIGNvbW1hbmRfbGlzdF93aW4g PSBbW11dICAjIFRPRE86IGFkZCB3aW5kb3dzIHNwZWNpZmljIGNvbW1hbmRzIGhlcmUKKyAgICBj b21tYW5kX2xpc3Rfd2luID0gW1snZGYnLCAnLWhsJ11dCiAKICAgICBkZWYgX19pbml0X18oc2Vs ZiwgKiprd2FyZ3MpOgogICAgICAgICBzdXBlcihQcmludENvbmZpZ3VyYXRpb24sIHNlbGYpLl9f aW5pdF9fKHRpbWVvdXQ9NjAsICoqa3dhcmdzKQpAQCAtMTkwMiw3ICsxOTAyLDcgQEAgY2xhc3Mg UHJpbnRDb25maWd1cmF0aW9uKHN0ZXBzLlNoZWxsU2VxdQogICAgICAgICAgICAgY29tbWFuZF9s aXN0LmV4dGVuZChzZWxmLmNvbW1hbmRfbGlzdF9hcHBsZSkKICAgICAgICAgZWxpZiBwbGF0Zm9y bSBpbiAoJ2d0aycsICd3cGUnLCAnanNjLW9ubHknKToKICAgICAgICAgICAgIGNvbW1hbmRfbGlz dC5leHRlbmQoc2VsZi5jb21tYW5kX2xpc3RfbGludXgpCi0gICAgICAgIGVsaWYgcGxhdGZvcm0g aW4gKCd3aW4nLCAnd2luY2Fpcm8nKToKKyAgICAgICAgZWxpZiBwbGF0Zm9ybSBpbiAoJ3dpbicp OgogICAgICAgICAgICAgY29tbWFuZF9saXN0LmV4dGVuZChzZWxmLmNvbW1hbmRfbGlzdF93aW4p CiAKICAgICAgICAgZm9yIGNvbW1hbmQgaW4gY29tbWFuZF9saXN0Ogo= 388048 2020-01-17 09:34:12 -0800 2020-01-17 16:32:54 -0800 Patch bug-206421-20200117123411.patch text/plain 2490 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI1NDc1MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIwLTAxLTE3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbRVdTXSBQcmludCBkaXNrIHNwYWNlIHVzYWdlIGZvciB3aW5kb3dzIGJv dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQy MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoUHJpbnRDb25maWd1 cmF0aW9uKTogV2luZG93cyBib3QgdXNlIGN5Z3dpbiwgc28gZGYgY29tbWFuZCB3b3Jrcy4KKwog MjAyMC0wMS0xNiAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZWxhbmQgYnl0ZWNvZGUgY2hlY2twb2ludHMgc2luY2UgYnVncyBoYXZlIGJlZW4gZml4 ZWQKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkJKHJl dmlzaW9uIDI1NDc1MCkKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVw cy5weQkod29ya2luZyBjb3B5KQpAQCAtMTg4NSw3ICsxODg1LDcgQEAgY2xhc3MgUHJpbnRDb25m aWd1cmF0aW9uKHN0ZXBzLlNoZWxsU2VxdQogICAgIGNvbW1hbmRfbGlzdF9nZW5lcmljID0gW1sn aG9zdG5hbWUnXV0KICAgICBjb21tYW5kX2xpc3RfYXBwbGUgPSBbWydkZicsICctaGwnXSwgWydk YXRlJ10sIFsnc3dfdmVycyddLCBbJ3hjb2RlYnVpbGQnLCAnLXNkaycsICctdmVyc2lvbiddLCBb J3VwdGltZSddXQogICAgIGNvbW1hbmRfbGlzdF9saW51eCA9IFtbJ2RmJywgJy1obCddLCBbJ2Rh dGUnXSwgWyd1bmFtZScsICctYSddLCBbJ3VwdGltZSddXQotICAgIGNvbW1hbmRfbGlzdF93aW4g PSBbW11dICAjIFRPRE86IGFkZCB3aW5kb3dzIHNwZWNpZmljIGNvbW1hbmRzIGhlcmUKKyAgICBj b21tYW5kX2xpc3Rfd2luID0gW1snZGYnLCAnLWhsJ11dCiAKICAgICBkZWYgX19pbml0X18oc2Vs ZiwgKiprd2FyZ3MpOgogICAgICAgICBzdXBlcihQcmludENvbmZpZ3VyYXRpb24sIHNlbGYpLl9f aW5pdF9fKHRpbWVvdXQ9NjAsICoqa3dhcmdzKQpAQCAtMTkwMiw3ICsxOTAyLDcgQEAgY2xhc3Mg UHJpbnRDb25maWd1cmF0aW9uKHN0ZXBzLlNoZWxsU2VxdQogICAgICAgICAgICAgY29tbWFuZF9s aXN0LmV4dGVuZChzZWxmLmNvbW1hbmRfbGlzdF9hcHBsZSkKICAgICAgICAgZWxpZiBwbGF0Zm9y bSBpbiAoJ2d0aycsICd3cGUnLCAnanNjLW9ubHknKToKICAgICAgICAgICAgIGNvbW1hbmRfbGlz dC5leHRlbmQoc2VsZi5jb21tYW5kX2xpc3RfbGludXgpCi0gICAgICAgIGVsaWYgcGxhdGZvcm0g aW4gKCd3aW4nLCAnd2luY2Fpcm8nKToKKyAgICAgICAgZWxpZiBwbGF0Zm9ybSBpbiAoJ3dpbicp OgogICAgICAgICAgICAgY29tbWFuZF9saXN0LmV4dGVuZChzZWxmLmNvbW1hbmRfbGlzdF93aW4p CiAKICAgICAgICAgZm9yIGNvbW1hbmQgaW4gY29tbWFuZF9saXN0OgpJbmRleDogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2 aXNpb24gMjU0NzUwKQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz X3VuaXR0ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNzc1LDYgKzI3NzUsNyBAQCBCdWlsZFZl cnNpb246CTE3RzcwMjQnJycpLAogCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMo CiAgICAgICAgICAgICBFeHBlY3RTaGVsbChjb21tYW5kPVsnaG9zdG5hbWUnXSwgd29ya2Rpcj0n d2tkaXInLCB0aW1lb3V0PTYwLCBsb2dFbnZpcm9uPUZhbHNlKSArIDAsCisgICAgICAgICAgICBF eHBlY3RTaGVsbChjb21tYW5kPVsnZGYnLCAnLWhsJ10sIHdvcmtkaXI9J3drZGlyJywgdGltZW91 dD02MCwgbG9nRW52aXJvbj1GYWxzZSkgKyAwLAogICAgICAgICApCiAgICAgICAgIHNlbGYuZXhw ZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQcmludGVkIGNvbmZpZ3Vy YXRpb24nKQogICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkK