206418 2020-01-17 08:52:17 -0800 Drop dead code related to local storage prewarming 2020-01-21 09:56:24 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=200373 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson commit-queue dbates ews-watchlist ggaren japhet sam sihui_liu webkit-bug-importer oldest_to_newest 1608014 0 cdumez 2020-01-17 08:52:17 -0800 Drop dead code related to local storage prewarming. Sihui neutered it in <https://trac.webkit.org/changeset/248734> but did not remove the code. 1608016 1 388044 cdumez 2020-01-17 08:55:08 -0800 Created attachment 388044 Patch 1608073 2 commit-queue 2020-01-17 10:45:03 -0800 The commit-queue encountered the following flaky tests while processing attachment 388044: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch. 1608075 3 388044 commit-queue 2020-01-17 10:45:39 -0800 Comment on attachment 388044 Patch Clearing flags on attachment: 388044 Committed r254753: <https://trac.webkit.org/changeset/254753> 1608076 4 commit-queue 2020-01-17 10:45:40 -0800 All reviewed patches have been landed. Closing bug. 1608078 5 webkit-bug-importer 2020-01-17 10:46:14 -0800 <rdar://problem/58687658> 1609085 6 sihui_liu 2020-01-21 09:36:02 -0800 It's not dead... My change was about the prewarm message. By creating localStorage ahead, web process connects to the storage area in network process, and network process does the prewarm there. 1609097 7 cdumez 2020-01-21 09:50:34 -0800 (In reply to Sihui Liu from comment #6) > It's not dead... My change was about the prewarm message. By creating > localStorage ahead, web process connects to the storage area in network > process, and network process does the prewarm there. Ok, I will revert but add a comment then. It is too subtle otherwise. 1609102 8 cdumez 2020-01-21 09:53:01 -0800 Reverted r254753 for reason: It turns out this is not dead code Committed r254857: <https://trac.webkit.org/changeset/254857> 1609104 9 cdumez 2020-01-21 09:56:24 -0800 <https://trac.webkit.org/changeset/254858> 388044 2020-01-17 08:55:08 -0800 2020-01-17 10:45:39 -0800 Patch bug-206418-20200117085507.patch text/plain 5417 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGJmNDk0NTY5ZmQzMzdk OGFjYjlhNGNmY2NkOTMxZTA3NWI5YWQxZi4uZTUwNDc0MGFmNmJhZmIyNmMzZWY3YzNkOTkzOGY3 ZDNjMWIxNjlhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIwLTAxLTE3ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgRHJvcCBkZWFkIGNvZGUgcmVs YXRlZCB0byBsb2NhbCBzdG9yYWdlIHByZXdhcm1pbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQxOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIERyb3AgZGVhZCBjb2RlIHJlbGF0ZWQgdG8gbG9jYWwg c3RvcmFnZSBwcmV3YXJtaW5nLiBTaWh1aSBuZXV0ZXJlZCBpdCBpbiA8aHR0cHM6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzI0ODczND4KKyAgICAgICAgYnV0IGRpZCBub3QgcmVtb3ZlIHRo ZSBjb2RlLgorCisgICAgICAgICogbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkRvY3VtZW50TG9hZGVyOjpjb21taXREYXRhKToKKyAgICAgICAgKiBwYWdlL0RP TVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OnByZXdhcm1Mb2NhbFN0 b3JhZ2VJZk5lY2Vzc2FyeSk6IERlbGV0ZWQuCisgICAgICAgICogcGFnZS9ET01XaW5kb3cuaDoK KyAgICAgICAgKiBwYWdlL0ZyYW1lLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpkaWRQ cmV3YXJtTG9jYWxTdG9yYWdlKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lOjpt YXlQcmV3YXJtTG9jYWxTdG9yYWdlIGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBwYWdlL0Zy YW1lLmg6CisKIDIwMjAtMDEtMTcgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAog ICAgICAgICBbTEZDXVtJRkNdIE9wdGltaXplIG5leHRXcmFwT3Bwb3J0dW5pdHkvaXNBdFNvZnRX cmFwT3Bwb3J0dW5pdHkgZm9yIHRoZSBtb3N0IGNvbW1vbiBpbmxpbmUgY29udGVudApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAKaW5kZXggMmFiMmVmNWRjYzk0MzQyNTBm ZmQwZGI1ZWIzNDA0NDlkZjdjODViMS4uNzhlMDhjN2E5ZjczZjIzNDg3NmE3NDliMGMxMTYzZjMy NjhlZjYxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCkBAIC0x MDkyLDkgKzEwOTIsNiBAQCB2b2lkIERvY3VtZW50TG9hZGVyOjpjb21taXREYXRhKGNvbnN0IGNo YXIqIGJ5dGVzLCBzaXplX3QgbGVuZ3RoKQogICAgICAgICBpZiAoIWlzTG9hZGluZygpKQogICAg ICAgICAgICAgcmV0dXJuOwogCi0gICAgICAgIGlmIChhdXRvKiB3aW5kb3cgPSBtX2ZyYW1lLT5k b2N1bWVudCgpLT5kb21XaW5kb3coKSkKLSAgICAgICAgICAgIHdpbmRvdy0+cHJld2FybUxvY2Fs U3RvcmFnZUlmTmVjZXNzYXJ5KCk7Ci0KICAgICAgICAgYm9vbCB1c2VyQ2hvc2VuOwogICAgICAg ICBTdHJpbmcgZW5jb2Rpbmc7CiAgICAgICAgIGlmIChvdmVycmlkZUVuY29kaW5nKCkuaXNOdWxs KCkpIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAppbmRleCA0MDBkZWQ0MTUxOTVmYzA5ZDFh MmIxZjQ3YjdkMjk0NmE2OWRhODI3Li43NDNiNmU4YWUzMjE2NzZkMGY2MjljYTY1MzRmZTUxMzI0 NmFiMDQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCkBAIC00MzksMjggKzQzOSw2IEBA IHZvaWQgRE9NV2luZG93OjpkaWRTZWN1cmVUcmFuc2l0aW9uVG8oRG9jdW1lbnQmIGRvY3VtZW50 KQogICAgIG1fcGVyZm9ybWFuY2UgPSBudWxscHRyOwogfQogCi12b2lkIERPTVdpbmRvdzo6cHJl d2FybUxvY2FsU3RvcmFnZUlmTmVjZXNzYXJ5KCkKLXsKLSAgICBhdXRvKiBwYWdlID0gdGhpcy0+ cGFnZSgpOwotCi0gICAgLy8gTm8gbmVlZCB0byBwcmV3YXJtIGZvciBlcGhlbWVyYWwgc2Vzc2lv bnMgc2luY2UgdGhlIGRhdGEgaXMgaW4gbWVtb3J5IG9ubHkuCi0gICAgaWYgKCFwYWdlIHx8IHBh Z2UtPnVzZXNFcGhlbWVyYWxTZXNzaW9uKCkpCi0gICAgICAgIHJldHVybjsKLQotICAgIGlmICgh cGFnZS0+bWFpbkZyYW1lKCkubWF5UHJld2FybUxvY2FsU3RvcmFnZSgpKQotICAgICAgICByZXR1 cm47Ci0KLSAgICBhdXRvIGxvY2FsU3RvcmFnZVJlc3VsdCA9IHRoaXMtPmxvY2FsU3RvcmFnZSgp OwotICAgIGlmIChsb2NhbFN0b3JhZ2VSZXN1bHQuaGFzRXhjZXB0aW9uKCkpCi0gICAgICAgIHJl dHVybjsKLQotICAgIGF1dG8qIGxvY2FsU3RvcmFnZSA9IGxvY2FsU3RvcmFnZVJlc3VsdC5yZXR1 cm5WYWx1ZSgpOwotICAgIGlmICghbG9jYWxTdG9yYWdlKQotICAgICAgICByZXR1cm47Ci0KLSAg ICBwYWdlLT5tYWluRnJhbWUoKS5kaWRQcmV3YXJtTG9jYWxTdG9yYWdlKCk7Ci19Ci0KIERPTVdp bmRvdzo6fkRPTVdpbmRvdygpCiB7CiAgICAgaWYgKG1fc3VzcGVuZGVkRm9yRG9jdW1lbnRTdXNw ZW5zaW9uKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmgKaW5kZXggZjdlMDcyODZkMDA4NTc2MjNhY2M4 OTMwZmRlZTZmMGQyYWI1MjBkMy4uMDI0YjI2M2U4MWE3OTg2YzgyMmExZjc3OWY2NGMzODY1MzZk Njc2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5oCkBAIC0yMDMsOCArMjAzLDYgQEAgcHVibGlj OgogCiAgICAgdm9pZCBzaG93TW9kYWxEaWFsb2coY29uc3QgU3RyaW5nJiB1cmxTdHJpbmcsIGNv bnN0IFN0cmluZyYgZGlhbG9nRmVhdHVyZXNTdHJpbmcsIERPTVdpbmRvdyYgYWN0aXZlV2luZG93 LCBET01XaW5kb3cmIGZpcnN0V2luZG93LCBjb25zdCBXVEY6OkZ1bmN0aW9uPHZvaWQoRE9NV2lu ZG93Jik+JiBwcmVwYXJlRGlhbG9nRnVuY3Rpb24pOwogCi0gICAgdm9pZCBwcmV3YXJtTG9jYWxT dG9yYWdlSWZOZWNlc3NhcnkoKTsKLQogICAgIHZvaWQgYWxlcnQoY29uc3QgU3RyaW5nJiBtZXNz YWdlID0gZW1wdHlTdHJpbmcoKSk7CiAgICAgYm9vbCBjb25maXJtRm9yQmluZGluZ3MoY29uc3Qg U3RyaW5nJiBtZXNzYWdlKTsKICAgICBTdHJpbmcgcHJvbXB0KGNvbnN0IFN0cmluZyYgbWVzc2Fn ZSwgY29uc3QgU3RyaW5nJiBkZWZhdWx0VmFsdWUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGFnZS9GcmFtZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcAppbmRleCA2 ZjQzNGQ5NTgzMmUyNTI3YWEyMDU5ZTU5MDcxNTRiZGY2NGJlZjYzLi5kYzAyNjZkODgxYmE5NGYz NWMyYWIxNTYxMjk4NjM5MmJiNDVmOTFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdl L0ZyYW1lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmNwcApAQCAtMTE3LDkg KzExNyw2IEBAIHN0YXRpYyBjb25zdCBTZWNvbmRzIHNjcm9sbEZyZXF1ZW5jeSB7IDEwMDBfcyAv IDYwLiB9OwogCiBERUZJTkVfREVCVUdfT05MWV9HTE9CQUwoV1RGOjpSZWZDb3VudGVkTGVha0Nv dW50ZXIsIGZyYW1lQ291bnRlciwgKCJGcmFtZSIpKTsKIAotLy8gV2UgcHJld2FybSBsb2NhbCBz dG9yYWdlIGZvciBhdCBtb3N0IDUgb3JpZ2lucyBpbiBhIGdpdmVuIHBhZ2UuCi1zdGF0aWMgY29u c3QgdW5zaWduZWQgbWF4bG9jYWxTdG9yYWdlUHJld2FybWluZ0NvdW50IHsgNSB9OwotCiBzdGF0 aWMgaW5saW5lIEZyYW1lKiBwYXJlbnRGcm9tT3duZXJFbGVtZW50KEhUTUxGcmFtZU93bmVyRWxl bWVudCogb3duZXJFbGVtZW50KQogewogICAgIGlmICghb3duZXJFbGVtZW50KQpAQCAtOTg4LDE5 ICs5ODUsNiBAQCB2b2lkIEZyYW1lOjpkcm9wQ2hpbGRyZW4oKQogICAgICAgICB0cmVlKCkucmVt b3ZlQ2hpbGQoKmNoaWxkKTsKIH0KIAotdm9pZCBGcmFtZTo6ZGlkUHJld2FybUxvY2FsU3RvcmFn ZSgpCi17Ci0gICAgQVNTRVJUKGlzTWFpbkZyYW1lKCkpOwotICAgIEFTU0VSVChtX2xvY2FsU3Rv cmFnZVByZXdhcm1pbmdDb3VudCA8IG1heGxvY2FsU3RvcmFnZVByZXdhcm1pbmdDb3VudCk7Ci0g ICAgKyttX2xvY2FsU3RvcmFnZVByZXdhcm1pbmdDb3VudDsKLX0KLQotYm9vbCBGcmFtZTo6bWF5 UHJld2FybUxvY2FsU3RvcmFnZSgpIGNvbnN0Ci17Ci0gICAgQVNTRVJUKGlzTWFpbkZyYW1lKCkp OwotICAgIHJldHVybiBtX2xvY2FsU3RvcmFnZVByZXdhcm1pbmdDb3VudCA8IG1heGxvY2FsU3Rv cmFnZVByZXdhcm1pbmdDb3VudDsKLX0KLQogdm9pZCBGcmFtZTo6c2VsZk9ubHlSZWYoKQogewog ICAgIEFTU0VSVChpc01haW5GcmFtZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWUuaCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWUuaAppbmRleCBkZDk4MDJjMDFj YmJlMmY5NGM5ZTY3ZTlkNjRlYWVlNDAwOTg5MjcyLi4yZDhkMDA3ODAyZjY0M2ViMjVmYzMzZjc2 ZGJmZGY3MDczNWQzZDEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZS5oCkBAIC0yOTEsOSArMjkxLDYgQEAgcHVi bGljOgogCiAgICAgV0VCQ09SRV9FWFBPUlQgYm9vbCBpc0Fsd2F5c09uTG9nZ2luZ0FsbG93ZWQo KSBjb25zdDsKIAotICAgIHZvaWQgZGlkUHJld2FybUxvY2FsU3RvcmFnZSgpOwotICAgIGJvb2wg bWF5UHJld2FybUxvY2FsU3RvcmFnZSgpIGNvbnN0OwotCiAvLyA9PT09PT09PQogCiAgICAgdm9p ZCBzZWxmT25seVJlZigpOwpAQCAtMzU2LDcgKzM1Myw2IEBAIHByaXZhdGU6CiAgICAgdW5zaWdu ZWQgbV9uYXZpZ2F0aW9uRGlzYWJsZUNvdW50IHsgMCB9OwogICAgIHVuc2lnbmVkIG1fc2VsZk9u bHlSZWZDb3VudCB7IDAgfTsKICAgICBib29sIG1faGFzSGFkVXNlckludGVyYWN0aW9uIHsgZmFs c2UgfTsKLSAgICB1bnNpZ25lZCBtX2xvY2FsU3RvcmFnZVByZXdhcm1pbmdDb3VudCB7IDAgfTsK IAogcHJvdGVjdGVkOgogICAgIFVuaXF1ZVJlZjxFdmVudEhhbmRsZXI+IG1fZXZlbnRIYW5kbGVy Owo=