206413 2020-01-17 07:29:41 -0800 ASSERT in case a service worker cannot be terminated in a timely manner 2020-01-22 14:19:44 -0800 1 1 1 Unclassified WebKit Service Workers WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=206396 InRadar P2 Normal --- 1 youennf youennf achristensen cdumez cgarcia commit-queue webkit-bug-importer oldest_to_newest 1607978 0 youennf 2020-01-17 07:29:41 -0800 ASSERT in case a service worker cannot be terminated in a timely manner. This might help debugging test flakiness. 1607982 1 388038 youennf 2020-01-17 07:36:09 -0800 Created attachment 388038 Patch 1608401 2 388038 ap 2020-01-17 23:24:55 -0800 Comment on attachment 388038 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388038&action=review > Source/WebCore/workers/service/context/SWContextManager.cpp:168 > + ASSERT_NOT_REACHED(); > _exit(EXIT_FAILURE); Builds passed on EWS, but I recall some ports failing to build because of unreachable code warnings in the past. Maybe they disabled the warning. 1608642 3 youennf 2020-01-20 00:18:29 -0800 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 388038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388038&action=review > > > Source/WebCore/workers/service/context/SWContextManager.cpp:168 > > + ASSERT_NOT_REACHED(); > > _exit(EXIT_FAILURE); > > Builds passed on EWS, but I recall some ports failing to build because of > unreachable code warnings in the past. Maybe they disabled the warning. I remember hitting that issue on EWS. Either it has changed or the call to exit changes things? 1608643 4 youennf 2020-01-20 00:18:56 -0800 Will land it as is and will check webkit console. 1608653 5 388038 commit-queue 2020-01-20 01:02:44 -0800 Comment on attachment 388038 Patch Clearing flags on attachment: 388038 Committed r254812: <https://trac.webkit.org/changeset/254812> 1608654 6 commit-queue 2020-01-20 01:02:45 -0800 All reviewed patches have been landed. Closing bug. 1608655 7 webkit-bug-importer 2020-01-20 01:03:15 -0800 <rdar://problem/58732681> 1609747 8 ap 2020-01-22 14:19:44 -0800 We are not hitting this assertion on tests where ServiceWorker process terminates unexpectedly. 388038 2020-01-17 07:36:09 -0800 2020-01-20 01:02:44 -0800 Patch bug-206413-20200117163606.patch text/plain 1704 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDhlMmMwN2I2NjE5MTQ3 NWI0MmRiNTFlZDc3MjM1OTZlNjcwMTdkZC4uMjAyOWRlMjc4MjMxNjQ3YmVlNDgzYTZjOGI4YjQ0 ZmVlN2I1MjA1YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIwLTAxLTE3ICB5b3Vl bm4gZmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBU1NFUlQgaW4gY2FzZSBh IHNlcnZpY2Ugd29ya2VyIGNhbm5vdCBiZSB0ZXJtaW5hdGVkIGluIGEgdGltZWx5IG1hbm5lcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2NDEzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdl IG9mIGJlaGF2aW9yLCB0aGUgcHJvY2VzcyB3aWxsIHN0aWxsIGV4aXQgaWYgaXQgZG9lcyBub3Qg c3VjY2VlZCBpbiBzdG9wcGluZyBhIHNlcnZpY2Ugd29ya2VyLgorICAgICAgICBJbiBEZWJ1Zywg YSBjcmFzaCBsb2cgd2lsbCBiZSBjb2xsZWN0ZWQgd2hpY2ggd2lsbCBhbGxvdyB0byBoZWxwIGlk ZW50aWZ5aW5nIG90aGVyIGNyYXNoZXMuCisKKyAgICAgICAgKiB3b3JrZXJzL3NlcnZpY2UvY29u dGV4dC9TV0NvbnRleHRNYW5hZ2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNXQ29udGV4dE1h bmFnZXI6OnNlcnZpY2VXb3JrZXJGYWlsZWRUb1Rlcm1pbmF0ZSk6CisKIDIwMjAtMDEtMTcgIHlv dWVubiBmYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFZpZGVvIHNvdW5kIHNv bWV0aW1lcyBrZWVwcyBwbGF5aW5nIGluIHBhZ2UgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3dvcmtlcnMvc2VydmljZS9jb250ZXh0L1NXQ29udGV4dE1hbmFnZXIuY3BwIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU1dDb250ZXh0TWFuYWdlci5jcHAK aW5kZXggZGQ1ZjM3OGFhNzNkNDdmNTc4NTg5ZjE0NWI3NmZiODEyOGE4OGZlOS4uYjk4ZDY2NDdh ZGJhNmU1ZjYwZjQzZDhhZGNhMWY2MjllZTI4MmQ2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU1dDb250ZXh0TWFuYWdlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvd29ya2Vycy9zZXJ2aWNlL2NvbnRleHQvU1dDb250ZXh0TWFuYWdlci5jcHAK QEAgLTE2NCw2ICsxNjQsNyBAQCB2b2lkIFNXQ29udGV4dE1hbmFnZXI6OnNlcnZpY2VXb3JrZXJG YWlsZWRUb1Rlcm1pbmF0ZShTZXJ2aWNlV29ya2VySWRlbnRpZmllciBzZQogewogICAgIFVOVVNF RF9QQVJBTShzZXJ2aWNlV29ya2VySWRlbnRpZmllcik7CiAgICAgUkVMRUFTRV9MT0dfRVJST1Io U2VydmljZVdvcmtlciwgIkZhaWxlZCB0byB0ZXJtaW5hdGUgc2VydmljZSB3b3JrZXIgd2l0aCBp ZGVudGlmaWVyICVzLCBraWxsaW5nIHRoZSBzZXJ2aWNlIHdvcmtlciBwcm9jZXNzIiwgc2Vydmlj ZVdvcmtlcklkZW50aWZpZXIubG9nZ2luZ1N0cmluZygpLnV0ZjgoKS5kYXRhKCkpOworICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOwogICAgIF9leGl0KEVYSVRfRkFJTFVSRSk7CiB9CiAK