206404 2020-01-17 00:44:46 -0800 Bytecode checkpoints break 32bit tests 2020-01-17 08:36:16 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pmatos ticaiolima commit-queue ews-watchlist keith_miller mark.lam msaboff saam ticaiolima tzagallo webkit-bug-importer oldest_to_newest 1607915 0 pmatos 2020-01-17 00:44:46 -0800 The reland of the bytecode checkpoints (https://bugs.webkit.org/show_bug.cgi?id=206361) break 32bit tests: https://build.webkit.org/builders/JSCOnly%20Linux%20ARMv7%20Thumb2%20Release/builds/10571 1607916 1 pmatos 2020-01-17 00:51:18 -0800 Failure in debug mode looks like: stress/plus-boolean-or-int.js.mini-mode: ASSERTION FAILED: returnAddress >= instructionsBegin && returnAddress < instructionsEnd stress/plus-boolean-or-int.js.mini-mode: ../../Source/JavaScriptCore/bytecode/CodeBlock.h(394) : unsigned int JSC::CodeBlock::bytecodeOffset(const JSC::Instruction*) stress/plus-boolean-or-int.js.mini-mode: Aborted stress/plus-boolean-or-int.js.mini-mode: ERROR: Unexpected exit code: 134 1607945 2 388027 ticaiolima 2020-01-17 04:10:25 -0800 Created attachment 388027 Patch 1607977 3 388036 ticaiolima 2020-01-17 07:26:54 -0800 Created attachment 388036 Patch 1607999 4 388036 commit-queue 2020-01-17 08:14:27 -0800 Comment on attachment 388036 Patch Clearing flags on attachment: 388036 Committed r254748: <https://trac.webkit.org/changeset/254748> 1608000 5 commit-queue 2020-01-17 08:14:29 -0800 All reviewed patches have been landed. Closing bug. 1608002 6 webkit-bug-importer 2020-01-17 08:15:17 -0800 <rdar://problem/58682741> 1608009 7 388036 keith_miller 2020-01-17 08:36:16 -0800 Comment on attachment 388036 Patch Whoops, thanks. 388027 2020-01-17 04:10:25 -0800 2020-01-17 07:26:49 -0800 Patch bug-206404-20200117091024.patch text/plain 1221 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MDdhYzI0NDkyYTM3MmExZTk0MDdkYjYwYzZlNDk2NmQ4ODNlNGQzLi4wZWNlMTA1ODMzNTBkYWI5 MDQ5MTkzMjg2MDY4ZGQ1Y2Q2NjM3MjY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMC0wMS0xNyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgQnl0ZWNvZGUgY2hlY2twb2ludHMgYnJlYWsgMzJiaXQgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQwNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogbGxpbnQvTG93TGV2 ZWxJbnRlcnByZXRlcjMyXzY0LmFzbToKKwogMjAyMC0wMS0xNiAgUm9iaW4gTW9yaXNzZXQgIDxy bW9yaXNzZXRAYXBwbGUuY29tPgogCiAgICAgICAgIFtFU05leHRdIEVuYWJsZXMgYSB3YXkgdG8g dGhyb3cgYW4gZXJyb3Igb24gQnl0ZUNvZGVHZW5lcmF0b3Igc3RlcApkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20gYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQpp bmRleCAwN2MyZWU5ZDJkZjBkZWFjOTNlM2I2MmY2YzYwZTNhNWRiNzI3ZDFjLi45M2MyOTAyNWIw ZDkzMDVkOTk1NzEwM2UxNjViN2FhODkxNGNiYjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQorKysgYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQpAQCAtMTQy LDcgKzE0Miw3IEBAIGVuZAogbWFjcm8gY2FsbFNsb3dQYXRoKHNsb3dQYXRoKQogICAgIHByZXBh cmVTdGF0ZUZvckNDYWxsKCkKICAgICBtb3ZlIGNmciwgYTAKLSAgICBwcmVwYXJlU3RhdGVGb3JD Q2FsbCgpCisgICAgbW92ZSBQQywgYTEKICAgICBjQ2FsbDIoc2xvd1BhdGgpCiAgICAgcmVzdG9y ZVN0YXRlQWZ0ZXJDQ2FsbCgpCiBlbmQK 388036 2020-01-17 07:26:54 -0800 2020-01-17 08:14:27 -0800 Patch bug-206404-20200117122652.patch text/plain 1329 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk MDdhYzI0NDkyYTM3MmExZTk0MDdkYjYwYzZlNDk2NmQ4ODNlNGQzLi4zNjIwYzE5YjMzZjBkZGE4 YWIwNDNjMjdlYzYxZGU0MTQwYzVhNTExIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMC0wMS0xNyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgQnl0ZWNvZGUgY2hlY2twb2ludHMgYnJlYWsgMzJiaXQgdGVzdHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjQwNAorCisgICAg ICAgIFVucmV2aWV3ZWQuCisKKyAgICAgICAgKiBsbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJf NjQuYXNtOgorCisgICAgICAgIFJldmVydGluZyBjaGFuZ2UgaW50cm9kdWNlZCBieSByMjU0NzM1 IHRoYXQgbWFrZXMgMzItYml0IGNvZGVzIGNyYXNoCisgICAgICAgIHdoZW4gY2FsbGluZyBpbnRv IExMSW50IHNsb3cgcGF0aC4KKwogMjAyMC0wMS0xNiAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNz ZXRAYXBwbGUuY29tPgogCiAgICAgICAgIFtFU05leHRdIEVuYWJsZXMgYSB3YXkgdG8gdGhyb3cg YW4gZXJyb3Igb24gQnl0ZUNvZGVHZW5lcmF0b3Igc3RlcApkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20gYi9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQppbmRleCAw N2MyZWU5ZDJkZjBkZWFjOTNlM2I2MmY2YzYwZTNhNWRiNzI3ZDFjLi45M2MyOTAyNWIwZDkzMDVk OTk1NzEwM2UxNjViN2FhODkxNGNiYjFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQorKysgYi9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbQpAQCAtMTQyLDcgKzE0 Miw3IEBAIGVuZAogbWFjcm8gY2FsbFNsb3dQYXRoKHNsb3dQYXRoKQogICAgIHByZXBhcmVTdGF0 ZUZvckNDYWxsKCkKICAgICBtb3ZlIGNmciwgYTAKLSAgICBwcmVwYXJlU3RhdGVGb3JDQ2FsbCgp CisgICAgbW92ZSBQQywgYTEKICAgICBjQ2FsbDIoc2xvd1BhdGgpCiAgICAgcmVzdG9yZVN0YXRl QWZ0ZXJDQ2FsbCgpCiBlbmQK