<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>206394</bug_id>
          
          <creation_ts>2020-01-16 20:39:24 -0800</creation_ts>
          <short_desc>[WinCairo][WK2] ASSERT(isUIThread()) is failing since r254723</short_desc>
          <delta_ts>2020-01-17 08:01:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fujii Hironori">fujii</reporter>
          <assigned_to name="Fujii Hironori">fujii</assigned_to>
          <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>ross.kirsling</cc>
    
    <cc>thedanielchen</cc>
    
    <cc>timothy</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1607850</commentid>
    <comment_count>0</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-01-16 20:39:24 -0800</bug_when>
    <thetext>[WinCairo][WK2] ASSERT(isUIThread()) is failing since r254723

WinCairo port, Debug builds
Since r254723 (Bug 206375)

1. Start MiniBrowser --wk2
2. The assertion fails

Callstack:

&gt; WTF.dll!WTFCrash() Line 305	C++
&gt; WTF.dll!WTFCrashWithInfo(int __formal=147, const char * __formal=0x00007ffe22880c20, const char * __formal=0x00007ffe22880bd0, int __formal=214) Line 619	C++
&gt; WTF.dll!WTF::AtomString::init::__l2::&lt;lambda&gt;() Line 147	C++
&gt; [External Code]	
&gt; WTF.dll!WTF::AtomString::init() Line 155	C++
&gt; WebKit2.dll!WebKit::InitializeWebKit2() Line 43	C++
&gt; WebKit2.dll!API::Object::Object() Line 41	C++
&gt; WebKit2.dll!API::ObjectImpl&lt;85&gt;::ObjectImpl&lt;85&gt;() Line 275	C++
&gt; WebKit2.dll!API::PageConfiguration::PageConfiguration() Line 50	C++
&gt; WebKit2.dll!API::PageConfiguration::create() Line 47	C++
&gt; WebKit2.dll!WKPageConfigurationCreate() Line 45	C++
&gt; MiniBrowserLib.dll!WebKitBrowserWindow::create(BrowserWindowClient &amp; client={...}, HWND__ * mainWnd=0x00000000002f0300, bool __formal=false) Line 112	C++
&gt; [External Code]	
&gt; MiniBrowserLib.dll!MainWindow::init(std::function&lt;WTF::Ref&lt;BrowserWindow,WTF::DumbPtrTraits&lt;BrowserWindow&gt;&gt; __cdecl(BrowserWindowClient &amp;,HWND__ *,bool)&gt; factory={...}, HINSTANCE__ * hInstance=0x00007ffe5f1a0000, bool usesLayeredWebView=false) Line 137	C++
&gt; MiniBrowserLib.dll!wWinMain(HINSTANCE__ * hInstance=0x00007ff763870000, HINSTANCE__ * hPrevInstance=0x0000000000000000, wchar_t * lpstrCmdLine=0x0000023771556920, int nCmdShow=10) Line 90	C++
&gt; MiniBrowserLib.dll!dllLauncherEntryPoint(HINSTANCE__ * hInstance=0x00007ff763870000, HINSTANCE__ * hPrevInstance=0x0000000000000000, wchar_t * lpstrCmdLine=0x0000023771556920, int nCmdShow=10) Line 145	C++
&gt; MiniBrowser.exe!wWinMain(HINSTANCE__ * hInstance=0x00007ff763870000, HINSTANCE__ * hPrevInstance=0x0000000000000000, wchar_t * lpstrCmdLine=0x0000023771556920, int nCmdShow=10) Line 232	C++
&gt; [External Code]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607861</commentid>
    <comment_count>1</comment_count>
      <attachid>388008</attachid>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2020-01-16 21:02:06 -0800</bug_when>
    <thetext>Created attachment 388008
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607960</commentid>
    <comment_count>2</comment_count>
      <attachid>388008</attachid>
    <who name="Carlos Alberto Lopez Perez">clopez</who>
    <bug_when>2020-01-17 05:59:50 -0800</bug_when>
    <thetext>Comment on attachment 388008
Patch

This issue is also affecting WPE and GTK</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607986</commentid>
    <comment_count>3</comment_count>
      <attachid>388008</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-17 08:00:27 -0800</bug_when>
    <thetext>Comment on attachment 388008
Patch

Clearing flags on attachment: 388008

Committed r254746: &lt;https://trac.webkit.org/changeset/254746&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607987</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2020-01-17 08:00:28 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1607988</commentid>
    <comment_count>5</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2020-01-17 08:01:29 -0800</bug_when>
    <thetext>&lt;rdar://problem/58682385&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>388008</attachid>
            <date>2020-01-16 21:02:06 -0800</date>
            <delta_ts>2020-01-17 08:00:27 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-206394-20200117140204.patch</filename>
            <type>text/plain</type>
            <size>1539</size>
            <attacher name="Fujii Hironori">fujii</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No
YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkwMjllZTFlZWJjZDkwMmJi
MjAwZTEzMTRkOTJkMjk0MWU2MjhiZDAuLmE1ODU1Yjc2ZjVmNjgzYWFkM2RlZDZlM2MwZmNkYzhk
ZDMzODlhODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj
ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjAtMDEtMTYgIEZ1amlpIEhp
cm9ub3JpICA8SGlyb25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW1dpbkNhaXJvXVtX
SzJdIEFTU0VSVChpc1VJVGhyZWFkKCkpIGlzIGZhaWxpbmcgc2luY2UgcjI1NDcyMworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2Mzk0CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXRvbVN0cmluZzo6aW5p
dCgpIHNob3VsZCBiZSBjYWxsZWQgYWZ0ZXIKKyAgICAgICAgV1RGOjppbml0aWFsaXplVGhyZWFk
aW5nKCkgaXMgY2FsbGVkIG9uIFdpbmRvd3MgYmVjYXVzZSBpdCBoYXMKKyAgICAgICAgQVNTRVJU
KGlzVUlUaHJlYWQoKSkgYW5kIFdpbmRvd3MgZG9lc24ndCBoYXZlIGEgQVBJIHRvIGdldCBtYWlu
CisgICAgICAgIHRocmVhZCBoYW5kbGUgbGlrZSBwdGhyZWFkX21haW5fbnAuCisKKyAgICAgICAg
KiBTaGFyZWQvV2ViS2l0MkluaXRpYWxpemUuY3BwOgorICAgICAgICAoV2ViS2l0OjpJbml0aWFs
aXplV2ViS2l0Mik6IENhbGwgQXRvbVN0cmluZzo6aW5pdCgpIGFmdGVyIEpTQzo6aW5pdGlhbGl6
ZVRocmVhZGluZygpLgorCiAyMDIwLTAxLTE2ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1AYXBw
bGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFkZCB0ZWxlbWV0cnkgZm9yIElPS0l0IGNsYXNzZXMg
bm90IHNlZW4gaW4gdGVzdCBydW5zCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9X
ZWJLaXQySW5pdGlhbGl6ZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJLaXQySW5pdGlh
bGl6ZS5jcHAKaW5kZXggNTQ1NmEyNWIzYmQ5MjBjN2YxM2RkYmVkMTBiNzQzNjVjNGFjYjA4YS4u
ZmJiNzM4NGNhMDc4YmQzN2UzOWFlZmE0M2Y3ZGJmYTg0MmZmYjhiMyAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYktpdC9TaGFyZWQvV2ViS2l0MkluaXRpYWxpemUuY3BwCisrKyBiL1NvdXJjZS9XZWJL
aXQvU2hhcmVkL1dlYktpdDJJbml0aWFsaXplLmNwcApAQCAtMzksOSArMzksOSBAQCBuYW1lc3Bh
Y2UgV2ViS2l0IHsKIAogdm9pZCBJbml0aWFsaXplV2ViS2l0MigpCiB7Ci0gICAgQXRvbVN0cmlu
Zzo6aW5pdCgpOwogICAgIEpTQzo6aW5pdGlhbGl6ZVRocmVhZGluZygpOwogICAgIFJ1bkxvb3A6
OmluaXRpYWxpemVNYWluUnVuTG9vcCgpOworICAgIEF0b21TdHJpbmc6OmluaXQoKTsKIAogICAg
IFdURjo6UmVmQ291bnRlZEJhc2U6OmVuYWJsZVRocmVhZGluZ0NoZWNrc0dsb2JhbGx5KCk7CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>