20639 2008-09-03 22:33:24 -0700 ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE 2008-09-04 14:44:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric eric oldest_to_newest 90113 0 eric 2008-09-03 22:33:24 -0700 ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE I made i one as part of various Platform.h cleanup in: http://trac.webkit.org/changeset/36074 Mark fixed it to actually work in: http://trac.webkit.org/changeset/36076 http://trac.webkit.org/changeset/36078 It doesn't need to be a FEATURE_DEFINE, since it only works for Mac. it can still be a separate ifdef though, but Platform.h can just turn it on for Apple-Mac only (once we have a way to distinguish Apple's Mac port from any other Mac port). 90115 1 mrowe 2008-09-03 23:15:04 -0700 After r36074 we have ENABLE_DASHBOARD_SUPPORT sprinkled over many files. It's not a "feature" like the other items listed in FEATURE_DEFINES, so it should be removed from there ASAP. 90198 2 mrowe 2008-09-04 14:44:40 -0700 Fixed in r36102.