206387 2020-01-16 16:45:54 -0800 [iOS] Remove the IOHIDEventServiceFastPathUserClient IOKit class 2020-01-17 12:37:48 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 204770 1 bfulgham bfulgham achristensen bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1607774 0 bfulgham 2020-01-16 16:45:54 -0800 After Bug 204770, we no longer interact with the device motion or geolocation systems inside the WebContent process. Testing and telemetry shows that we no longer access the IOHIDEventServiceFastPathUserClient, and so should remove access to it. 1607775 1 webkit-bug-importer 2020-01-16 16:46:39 -0800 <rdar://problem/58663859> 1607776 2 webkit-bug-importer 2020-01-16 16:46:43 -0800 <rdar://problem/58663849> 1607789 3 387991 bfulgham 2020-01-16 17:00:09 -0800 Created attachment 387991 Patch 1607791 4 387991 pvollan 2020-01-16 17:04:24 -0800 Comment on attachment 387991 Patch R=me. 1608125 5 bfulgham 2020-01-17 11:55:58 -0800 iOS-wk2 layout test failures are unrelated to this patch. These run on the simulator, which do not use the iOS sandbox at all. 1608144 6 387991 commit-queue 2020-01-17 12:37:46 -0800 Comment on attachment 387991 Patch Clearing flags on attachment: 387991 Committed r254759: <https://trac.webkit.org/changeset/254759> 1608145 7 commit-queue 2020-01-17 12:37:48 -0800 All reviewed patches have been landed. Closing bug. 387991 2020-01-16 17:00:09 -0800 2020-01-17 12:37:46 -0800 Patch bug-206387-20200116170008.patch text/plain 4387 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDQzOTNmOTQ1YWMzNGVjOTk3 YWJiZGU0NWMwYWYwYjBjZDNhNTdhMzQuLjMwYWFmYWM2NTFkMTRmNTZiZmIwMGU4ZTcxYmJhNTk5 MTIzYmI0YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjAtMDEtMTYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVtb3ZlIHRoZSBJ T0hJREV2ZW50U2VydmljZUZhc3RQYXRoVXNlckNsaWVudCBJT0tpdCBjbGFzcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA2Mzg3CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81ODY2Mzg0OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZnRlciBCdWcgMjA0NzcwLCB3ZSBubyBsb25nZXIgaW50ZXJhY3Qg d2l0aCB0aGUgZGV2aWNlIG1vdGlvbiBvciBnZW9sb2NhdGlvbiBzeXN0ZW1zIGluc2lkZQorICAg ICAgICB0aGUgV2ViQ29udGVudCBwcm9jZXNzLiBUZXN0aW5nIGFuZCB0ZWxlbWV0cnkgc2hvd3Mg dGhhdCB3ZSBubyBsb25nZXIgYWNjZXNzIHRoZQorICAgICAgICBJT0hJREV2ZW50U2VydmljZUZh c3RQYXRoVXNlckNsaWVudCwgYW5kIHNvIHNob3VsZCByZW1vdmUgYWNjZXNzIHRvIGl0LgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGNoYW5nZSBpbiBiZWhhdmlv ci4KKworICAgICAgICAqIFJlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5X ZWJLaXQuV2ViQ29udGVudC5zYjoKKwogMjAyMC0wMS0xNiAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIElQQyBoYXJkZW5pbmcgZm9yIFdlYlBhZ2VQcm94eTo6c2F2 ZVBERlRvVGVtcG9yYXJ5Rm9sZGVyKiAvIFdlYlBhZ2VQcm94eTo6b3BlblBERkZyb21UZW1wb3Jh cnlGb2xkZXIqIG1lc3NhZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9T YW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiIGIvU291cmNlL1dlYktp dC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LkdQVS5zYgpp bmRleCBjYWI5NDYzNzRkNzMzYTkyNGY1Y2E3OTRhMTdhY2FhYjM4ZGNmNDc0Li43ZDYxNDI1M2Uz Zjk2NWUzMDk3NzAyOGVhNjdhOWEzNWM0YzEzNDIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L1Jlc291cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuR1BVLnNiCisr KyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxl LldlYktpdC5HUFUuc2IKQEAgLTM5NywyOSArMzk3LDYgQEAKICAgICAgICAgKGhvbWUtc3VicGF0 aCAiL0xpYnJhcnkvQXNzZXRzL2NvbV9hcHBsZV9Nb2JpbGVBc3NldF9Wb2ljZVNlcnZpY2VzVm9j YWxpemVyVm9pY2UiKSkKICkKIAotKGRlZmluZS1vbmNlIChjb3JlLW1vdGlvbikKLSAgICA7OyBD b3JlTW90aW9uCi0gICAgKG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFkICJjb20uYXBwbGUuQ29yZU1v dGlvbiIpCi0KLSAgICA7OyBDb3JlTW90aW9u4oCZcyBkZXZpY2VNb3Rpb24gQVBJCi0gICAgKHdp dGgtZmlsdGVyCi0gICAgICAgIChyZXF1aXJlLWFueQotICAgICAgICAgICAgKGlva2l0LXJlZ2lz dHJ5LWVudHJ5LWNsYXNzICJBcHBsZU9zY2FyTnViIikKLSAgICAgICAgICAgIChpb2tpdC1yZWdp c3RyeS1lbnRyeS1jbGFzcyAiQXBwbGVTUFVISURJbnRlcmZhY2UiKSkKLSAgICAgICAgKGFsbG93 IGlva2l0LWdldC1wcm9wZXJ0aWVzCi0gICAgICAgICAgICAoaW9raXQtcHJvcGVydHkgImd5cm8t aW50ZXJydXB0LWNhbGlicmF0aW9uIikpKQotICAgICh3aXRoLWZpbHRlcgotICAgICAgICAoaW9r aXQtcmVnaXN0cnktZW50cnktY2xhc3MgIklPSElERXZlbnRTZXJ2aWNlRmFzdFBhdGhVc2VyQ2xp ZW50IikKLSAgICAgICAgKGFsbG93IGlva2l0LW9wZW4pCi0gICAgICAgIChhbGxvdyBpb2tpdC1n ZXQtcHJvcGVydGllcyBpb2tpdC1zZXQtcHJvcGVydGllcwotICAgICAgICAgICAgKGlva2l0LXBy b3BlcnR5ICJpbnRlcnZhbCIKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAibW9kZSIKLSAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiUXVldWVTaXplIgotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJ1c2VNYWciKSkKLSAgICAgICAgKGFsbG93IGlva2l0LWdldC1wcm9wZXJ0aWVz Ci0gICAgICAgICAgICAoaW9raXQtcHJvcGVydHkgImNsaWVudCIpKSkKLSkKLQogOzsgVGhpbmdz IHJlcXVpcmVkIGJ5IFVJS2l0CiAoZGVmaW5lLW9uY2UgKHVpa2l0LXJlcXVpcmVtZW50cykKICAg ICAobW9iaWxlLXByZWZlcmVuY2VzLXJlYWQKQEAgLTc3NCw4ICs3NTEsNiBAQAogCiAoYWxsb3ct cHJlZmVyZW5jZXMtY29tbW9uKQogCi0oY29yZS1tb3Rpb24pCi0KIDs7IEhvbWUgQnV0dG9uCiAo d2l0aC1maWx0ZXIgKGlva2l0LXJlZ2lzdHJ5LWVudHJ5LWNsYXNzICJJT1BsYXRmb3JtRGV2aWNl IikKICAgICAoYWxsb3cgaW9raXQtZ2V0LXByb3BlcnRpZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJD b250ZW50LnNiIGIvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9j b20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKaW5kZXggZjA5Yjc0MTVmYTkzZWZjOGM0NDNi MDRhZGZiYmY1NDc3OWVhN2ZiYi4uZDdkNDRiNGFmNGM5MjBmNWZiNjI0OGNjNjUxOTJlOTkyMjU0 YTgyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVz L2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKKysrIGIvU291cmNlL1dlYktpdC9S ZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQu c2IKQEAgLTQwMiwyOSArNDAyLDYgQEAKICAgICAgICAgKGhvbWUtc3VicGF0aCAiL0xpYnJhcnkv QXNzZXRzL2NvbV9hcHBsZV9Nb2JpbGVBc3NldF9Wb2ljZVNlcnZpY2VzVm9jYWxpemVyVm9pY2Ui KSkKICkKIAotKGRlZmluZS1vbmNlIChjb3JlLW1vdGlvbikKLSAgICA7OyBDb3JlTW90aW9uCi0g ICAgKG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFkICJjb20uYXBwbGUuQ29yZU1vdGlvbiIpCi0KLSAg ICA7OyBDb3JlTW90aW9u4oCZcyBkZXZpY2VNb3Rpb24gQVBJCi0gICAgKHdpdGgtZmlsdGVyCi0g ICAgICAgIChyZXF1aXJlLWFueQotICAgICAgICAgICAgKGlva2l0LXJlZ2lzdHJ5LWVudHJ5LWNs YXNzICJBcHBsZU9zY2FyTnViIikKLSAgICAgICAgICAgIChpb2tpdC1yZWdpc3RyeS1lbnRyeS1j bGFzcyAiQXBwbGVTUFVISURJbnRlcmZhY2UiKSkKLSAgICAgICAgKGFsbG93IGlva2l0LWdldC1w cm9wZXJ0aWVzCi0gICAgICAgICAgICAoaW9raXQtcHJvcGVydHkgImd5cm8taW50ZXJydXB0LWNh bGlicmF0aW9uIikpKQotICAgICh3aXRoLWZpbHRlcgotICAgICAgICAoaW9raXQtcmVnaXN0cnkt ZW50cnktY2xhc3MgIklPSElERXZlbnRTZXJ2aWNlRmFzdFBhdGhVc2VyQ2xpZW50IikKLSAgICAg ICAgKGFsbG93IGlva2l0LW9wZW4gKHdpdGggcmVwb3J0KSAod2l0aCB0ZWxlbWV0cnkpKQotICAg ICAgICAoYWxsb3cgaW9raXQtZ2V0LXByb3BlcnRpZXMgaW9raXQtc2V0LXByb3BlcnRpZXMKLSAg ICAgICAgICAgIChpb2tpdC1wcm9wZXJ0eSAiaW50ZXJ2YWwiCi0gICAgICAgICAgICAgICAgICAg ICAgICAgICAgIm1vZGUiCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgIlF1ZXVlU2l6ZSIK LSAgICAgICAgICAgICAgICAgICAgICAgICAgICAidXNlTWFnIikpCi0gICAgICAgIChhbGxvdyBp b2tpdC1nZXQtcHJvcGVydGllcwotICAgICAgICAgICAgKGlva2l0LXByb3BlcnR5ICJjbGllbnQi KSkpCi0pCi0KIDs7IFRoaW5ncyByZXF1aXJlZCBieSBVSUtpdAogKGRlZmluZS1vbmNlICh1aWtp dC1yZXF1aXJlbWVudHMpCiAgICAgKG1vYmlsZS1wcmVmZXJlbmNlcy1yZWFkCkBAIC03NjQsOCAr NzQxLDYgQEAKIAogKGFsbG93LXByZWZlcmVuY2VzLWNvbW1vbikKIAotKGNvcmUtbW90aW9uKQot CiA7OyBIb21lIEJ1dHRvbgogKHdpdGgtZmlsdGVyIChpb2tpdC1yZWdpc3RyeS1lbnRyeS1jbGFz cyAiSU9QbGF0Zm9ybURldmljZSIpCiAgICAgKGFsbG93IGlva2l0LWdldC1wcm9wZXJ0aWVzCg==