206386 2020-01-16 16:37:10 -0800 [iOS] Add telemetry for IOKIt classes not seen in test runs 2020-01-16 19:55:11 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 bfulgham bfulgham achristensen bfulgham commit-queue pvollan webkit-bug-importer oldest_to_newest 1607757 0 bfulgham 2020-01-16 16:37:10 -0800 Add telemetry to our uses of 'iokit-open' so we can see which classes are actively used by WebKit. Local test runs indicate many of these are not needed, but we need to capture wider data before changing our allow list. 1607758 1 webkit-bug-importer 2020-01-16 16:37:30 -0800 <rdar://problem/58663519> 1607761 2 387984 bfulgham 2020-01-16 16:39:16 -0800 Created attachment 387984 Patch 1607772 3 387984 pvollan 2020-01-16 16:43:55 -0800 Comment on attachment 387984 Patch Looks good! R=me. 1607832 4 bfulgham 2020-01-16 19:12:10 -0800 The Windows build failure is due to out-of-disk-space. 1607842 5 387984 commit-queue 2020-01-16 19:55:09 -0800 Comment on attachment 387984 Patch Clearing flags on attachment: 387984 Committed r254734: <https://trac.webkit.org/changeset/254734> 1607843 6 commit-queue 2020-01-16 19:55:11 -0800 All reviewed patches have been landed. Closing bug. 387984 2020-01-16 16:39:16 -0800 2020-01-16 19:55:09 -0800 Patch bug-206386-20200116163916.patch text/plain 2830 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDEyYzE3NDExZGI1MzMwYTJh Zjc3ZTRkZDhhMzRlNDg4NjUzOWI0MDguLmUyOTA5NGJhMDU4Yzg5ZDM4OWE3MTg4ZDJiZGM1Y2Jh YzQ1OGQ3MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjAtMDEtMTYgIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWRkIHRlbGVtZXRy eSBmb3IgSU9LSXQgY2xhc3NlcyBub3Qgc2VlbiBpbiB0ZXN0IHJ1bnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwNjM4NgorICAgICAgICA8cmRhcjov L3Byb2JsZW0vNTg2NjM1MTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2FwdHVyZSB0ZWxlbWV0cnkgdG8gc2hvdyB3aGljaCBJT0tpdCBjbGFzc2Vz IGFyZSBhY2l0dmVseSB1c2VkIGluIFdlYktpdC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYmVj YXVzZSB0aGlzIGRvZXMgbm90IGNoYW5nZSBiZWhhdmlvci4KKworICAgICAgICAqIFJlc291cmNl cy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYjoKKwog MjAyMC0wMS0xNSAgRG9uIE9sbXN0ZWFkICA8ZG9uLm9sbXN0ZWFkQHNvbnkuY29tPgogCiAgICAg ICAgIFNoYXJlIFdlYkluc3BlY3RvciBzdHVicyBmb3IgcG9ydHMgd2l0aG91dCBsb2NhbCBpbnNw ZWN0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1Jlc291cmNlcy9TYW5kYm94UHJvZmls ZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYiBiL1NvdXJjZS9XZWJLaXQvUmVz b3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNi CmluZGV4IGYwOWI3NDE1ZmE5M2VmYzhjNDQzYjA0YWRmYmJmNTQ3NzllYTdmYmIuLmVkZmM3N2E4 M2YyYmQ4OGU2ODUxMWQwZjUwMGM5NjljNzIwYzZjNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250 ZW50LnNiCisrKyBiL1NvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1NhbmRib3hQcm9maWxlcy9pb3Mv Y29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCkBAIC0yNjUsMTIgKzI2NSwxMiBAQAogOzs7 IERlY2xhcmUgdGhhdCB0aGUgYXBwbGljYXRpb24gdXNlcyB0aGUgT3BlbkdMLCBNZXRhbCwgYW5k IENvcmVNTCBoYXJkd2FyZSAmIGZyYW1ld29ya3MuCiA7OzsKIChkZWZpbmUtb25jZSAob3Blbmds KQotICAgIChhbGxvdyBpb2tpdC1vcGVuCisgICAgOzsgSXRlbXMgbm90IHNlZW4gaW4gdGVzdGlu ZworICAgIChhbGxvdyBpb2tpdC1vcGVuICh3aXRoIHJlcG9ydCkgKHdpdGggdGVsZW1ldHJ5KQog ICAgICAgICAgICAoaW9raXQtY29ubmVjdGlvbiAiSU9HUFUiKQogICAgICAgICAgICAoaW9raXQt dXNlci1jbGllbnQtY2xhc3MKICAgICAgICAgICAgICAgICAiQUdYQ29tbWFuZFF1ZXVlIgogICAg ICAgICAgICAgICAgICJBR1hEZXZpY2UiCi0gICAgICAgICAgICAgICAgIkFHWERldmljZVVzZXJD bGllbnQiCiAgICAgICAgICAgICAgICAgIkFHWFNoYXJlZFVzZXJDbGllbnQiCiAgICAgICAgICAg ICAgICAgIklPQWNjZWxDb250ZXh0IgogICAgICAgICAgICAgICAgICJJT0FjY2VsRGV2aWNlIgpA QCAtMjgwLDYgKzI4MCwxMyBAQAogICAgICAgICAgICAgICAgICJJT0FjY2VsRGV2aWNlMiIKICAg ICAgICAgICAgICAgICAiSU9BY2NlbFNoYXJlZFVzZXJDbGllbnQyIikpCiAKKyAgICA7OyBJdGVt cyB3aXRoIGtub3duIHVzZXMKKyAgICAoYWxsb3cgaW9raXQtb3BlbgorICAgICAgICAoaW9raXQt Y29ubmVjdGlvbiAiSU9HUFUiKQorICAgICAgICAoaW9raXQtdXNlci1jbGllbnQtY2xhc3MKKyAg ICAgICAgICAgICJBR1hEZXZpY2VVc2VyQ2xpZW50IiA7OyBVc2VkIGJ5IFdlYkdMCisgICAgKSkK KwogICAgIChhbGxvdyBpb2tpdC1nZXQtcHJvcGVydGllcwogICAgICAgICAoaW9raXQtcHJvcGVy dHkgIklPR0xCdW5kbGVOYW1lIikKICAgICAgICAgKGlva2l0LXByb3BlcnR5ICJJT0dMRVNCdW5k bGVOYW1lIikKQEAgLTQ0OCwxMCArNDU1LDE0IEBACiAgICAgKQogCiAgICAgOyBVSUtpdC1yZXF1 aXJlZCBJT0tpdCBub2Rlcy4KLSAgICAoYWxsb3cgaW9raXQtb3BlbgorICAgIChhbGxvdyBpb2tp dC1vcGVuICAod2l0aCByZXBvcnQpICh3aXRoIHRlbGVtZXRyeSkKICAgICAgICAgKGlva2l0LXVz ZXItY2xpZW50LWNsYXNzICJBcHBsZUpQRUdEcml2ZXJVc2VyQ2xpZW50IikKLSAgICAgICAgKGlv a2l0LXVzZXItY2xpZW50LWNsYXNzICJJT1N1cmZhY2VBY2NlbGVyYXRvckNsaWVudCIpCiAgICAg ICAgIChpb2tpdC11c2VyLWNsaWVudC1jbGFzcyAiSU9TdXJmYWNlU2VuZFJpZ2h0IikKKyAgICAp CisKKyAgICA7IFdlYktpdC1yZXF1aXJlZCBJT0tpdCBjbGFzc2VzCisgICAgKGFsbG93IGlva2l0 LW9wZW4KKyAgICAgICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJJT1N1cmZhY2VBY2NlbGVy YXRvckNsaWVudCIpIDs7IE1lZGlhIHJlbmRlcmluZyBpbnRvIHBpeGVsIGJ1ZmZlcnMKICAgICAg ICAgKGlva2l0LXVzZXItY2xpZW50LWNsYXNzICJJT1N1cmZhY2VSb290VXNlckNsaWVudCIpIDs7 IE5lZWRlZCBieSBUaWxlZCBHcmlkIGNvZGUuCiAgICAgKQogCg==