206385 2020-01-16 16:30:06 -0800 [iOS] Focusing editable element with WebPage::selectPositionAtPoint() does not bring up keyboard 2020-01-17 11:00:04 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates webkit-bug-importer wenson_hsieh oldest_to_newest 1607747 0 dbates 2020-01-16 16:30:06 -0800 When a hardware keyboard is not attached calling WebPage::selectPositionAtPoint() to focus an editable element does not bring up the keyboard. 1607748 1 dbates 2020-01-16 16:30:11 -0800 <rdar://problem/57414380> 1607752 2 387981 dbates 2020-01-16 16:31:57 -0800 Created attachment 387981 For bots 1608070 3 388057 dbates 2020-01-17 10:42:38 -0800 Created attachment 388057 Patch 1608074 4 388057 wenson_hsieh 2020-01-17 10:45:12 -0800 Comment on attachment 388057 Patch This would preferably have a test. I think you could write an API test for this that verifies -[_WKFocusedElementInfo userInitiated] is YES when using selectPositionAtPoint in a text field. 1608083 5 388057 wenson_hsieh 2020-01-17 10:50:52 -0800 Comment on attachment 388057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388057&action=review > Source/WebKit/ChangeLog:14 > + tagged selection change though the callers should be auditted to ensure they weren't accidentally Nit - auditted 1608088 6 388057 dbates 2020-01-17 10:54:44 -0800 Comment on attachment 388057 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388057&action=review Thanks for the review! >> Source/WebKit/ChangeLog:14 >> + tagged selection change though the callers should be auditted to ensure they weren't accidentally > > Nit - auditted I'll audit it! 1608092 7 388063 dbates 2020-01-17 10:57:02 -0800 Created attachment 388063 To Land 1608095 8 388063 dbates 2020-01-17 11:00:02 -0800 Comment on attachment 388063 To Land Clearing flags on attachment: 388063 Committed r254755: <https://trac.webkit.org/changeset/254755> 1608096 9 dbates 2020-01-17 11:00:04 -0800 All reviewed patches have been landed. Closing bug. 387981 2020-01-16 16:31:57 -0800 2020-01-17 10:42:37 -0800 For bots bug-206385-20200116163157.patch text/plain 1598 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyYWU5MmUwNjI1NDEzNzRi OTg2YzAyMzkxY2Y2YjdlMDQ5MmYxZGYuLjVlMGZkMjcyYmVmNDRiN2Y0MmMzNzA0ZTcxYjgyNWI3 MjUyMGE2M2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjAtMDEtMTYgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEZvY3VzaW5nIGVkaXRh YmxlIGVsZW1lbnQgd2l0aCBXZWJQYWdlOjpzZWxlY3RQb3NpdGlvbkF0UG9pbnQoKSBkb2VzIG5v dCBicmluZyB1cCBrZXlib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA2Mzg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NzQxNDM4MD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6 c2VsZWN0UG9zaXRpb25BdFBvaW50KToKKwogMjAxOS0wOS0xMyAgRGFuaWVsIEJhdGVzICA8ZGFi YXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBidWlsZGluZyBXZWJLaXQgZm9yIE1h YyBDYXRhbHlzdCBmcm9tIFhjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IGU3MWM3Mzg5NGMzZTRhZDAyMmIzOTJjNzBl MTBkZTA1ZTgzNzg3ZDAuLjAxZDYzYzFjNGE2M2M3MzIxODNmNDdiZmFkZWY0MTc5ZWQ0ZTQ2Zjgg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tCkBAIC0yMDA5LDYgKzIwMDksOCBAQCBWaXNpYmxlUG9zaXRpb24gV2ViUGFnZTo6dmlz aWJsZVBvc2l0aW9uSW5Gb2N1c2VkTm9kZUZvclBvaW50KGNvbnN0IEZyYW1lJiBmcmFtZQogCiB2 b2lkIFdlYlBhZ2U6OnNlbGVjdFBvc2l0aW9uQXRQb2ludChjb25zdCBXZWJDb3JlOjpJbnRQb2lu dCYgcG9pbnQsIGJvb2wgaXNJbnRlcmFjdGluZ1dpdGhGb2N1c2VkRWxlbWVudCwgQ2FsbGJhY2tJ RCBjYWxsYmFja0lEKQogeworICAgIFNldEZvclNjb3BlPGJvb2w+IHVzZXJJc0ludGVyYWN0aW5n Q2hhbmdlIHsgbV91c2VySXNJbnRlcmFjdGluZywgdHJ1ZSB9OworCiAgICAgYXV0byYgZnJhbWUg PSBtX3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOwogICAgIFZp c2libGVQb3NpdGlvbiBwb3NpdGlvbiA9IHZpc2libGVQb3NpdGlvbkluRm9jdXNlZE5vZGVGb3JQ b2ludChmcmFtZSwgcG9pbnQsIGlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVsZW1lbnQpOwogICAg IAo= 388057 2020-01-17 10:42:38 -0800 2020-01-17 10:57:01 -0800 Patch bug-206385-20200117104238.patch text/plain 2393 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyYWU5MmUwNjI1NDEzNzRi OTg2YzAyMzkxY2Y2YjdlMDQ5MmYxZGYuLmE0MmJiOGNkNzk1YTEzMDIyNDI1ODA5NjkxNzk1ZjVl MzkxMGM4MDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDEtMTYgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEZvY3VzaW5nIGVkaXRh YmxlIGVsZW1lbnQgd2l0aCBXZWJQYWdlOjpzZWxlY3RQb3NpdGlvbkF0UG9pbnQoKSBkb2VzIG5v dCBicmluZyB1cCBrZXlib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA2Mzg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NzQxNDM4MD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgdGhl IHZpZXcncyBzdGF0ZSB0byBpbmRpY2F0ZSB0aGF0IHRoZSB1c2VyIGlzIHBlcmZvcm1pbmcgYW4g aW50ZXJhY3Rpb24gZm9yIHRoZSBzY29wZSBvZgorICAgICAgICBXZWJQYWdlOjpzZWxlY3RQb3Np dGlvbkF0UG9pbnQoKS4gVGhpcyBwZXJtaXRzIFdlYktpdCB0byBzaG93IHRoZSBrZXlib2FyZCBp ZiBzZWxlY3RpbmcgdGhlCisgICAgICAgIHBvc2l0aW9uIGNhdXNlcyBhIGNoYW5nZSBpbiBmb2N1 cyAoc2F5LCB0aGUgcG9pbnQgaXMgaW5zaWRlIGFuIHVuZm9jdXNlZCB0ZXh0IGZpZWxkKS4KKwor ICAgICAgICBXZSBsaWtlbHkgc2hvdWxkIGRvIGEgc2ltaWxhciBjaGFuZ2UgZm9yIGFsbCBvdGhl ciBXZWJLaXQgSVBJcyB0aGF0IHBlcmZvcm0gYSBXZWJDb3JlOjpFVXNlclRyaWdnZXJlZDo6VXNl clRyaWdnZXJlZAorICAgICAgICB0YWdnZWQgc2VsZWN0aW9uIGNoYW5nZSB0aG91Z2ggdGhlIGNh bGxlcnMgc2hvdWxkIGJlIGF1ZGl0dGVkIHRvIGVuc3VyZSB0aGV5IHdlcmVuJ3QgYWNjaWRlbnRh bGx5CisgICAgICAgIGRlcGVuZGluZyBvbiB0aGUgZXhpc3RpbmcgYmVoYXZpb3IgdGhhdCBwcmV2 ZW50cyBzdWNoIHNlbGVjdGlvbnMgZnJvbSBicmluZ2luZyB1cCB0aGUga2V5Ym9hcmQuCisgICAg ICAgIEZvciBub3csIEkgb25seSBmaXggV2ViUGFnZTo6c2VsZWN0UG9zaXRpb25BdFBvaW50KCkg YXMgSSd2ZSBhdWRpdGVkIHRoYXQgYWxsIGNhbGxlcnMgZXhwZWN0IGl0CisgICAgICAgIHRvIGJy aW5nIHVwIHRoZSBrZXlib2FyZCwgaWYgbmVlZGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZWxl Y3RQb3NpdGlvbkF0UG9pbnQpOiAKKwogMjAxOS0wOS0xMyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRl c0BhcHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBidWlsZGluZyBXZWJLaXQgZm9yIE1hYyBD YXRhbHlzdCBmcm9tIFhjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IGU3MWM3Mzg5NGMzZTRhZDAyMmIzOTJjNzBlMTBk ZTA1ZTgzNzg3ZDAuLjAxZDYzYzFjNGE2M2M3MzIxODNmNDdiZmFkZWY0MTc5ZWQ0ZTQ2ZjggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9T Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9T Lm1tCkBAIC0yMDA5LDYgKzIwMDksOCBAQCBWaXNpYmxlUG9zaXRpb24gV2ViUGFnZTo6dmlzaWJs ZVBvc2l0aW9uSW5Gb2N1c2VkTm9kZUZvclBvaW50KGNvbnN0IEZyYW1lJiBmcmFtZQogCiB2b2lk IFdlYlBhZ2U6OnNlbGVjdFBvc2l0aW9uQXRQb2ludChjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYg cG9pbnQsIGJvb2wgaXNJbnRlcmFjdGluZ1dpdGhGb2N1c2VkRWxlbWVudCwgQ2FsbGJhY2tJRCBj YWxsYmFja0lEKQogeworICAgIFNldEZvclNjb3BlPGJvb2w+IHVzZXJJc0ludGVyYWN0aW5nQ2hh bmdlIHsgbV91c2VySXNJbnRlcmFjdGluZywgdHJ1ZSB9OworCiAgICAgYXV0byYgZnJhbWUgPSBt X3BhZ2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOwogICAgIFZpc2li bGVQb3NpdGlvbiBwb3NpdGlvbiA9IHZpc2libGVQb3NpdGlvbkluRm9jdXNlZE5vZGVGb3JQb2lu dChmcmFtZSwgcG9pbnQsIGlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVsZW1lbnQpOwogICAgIAo= 388063 2020-01-17 10:57:02 -0800 2020-01-17 10:57:02 -0800 To Land bug-206385-20200117105702.patch text/plain 2390 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGYyYWU5MmUwNjI1NDEzNzRi OTg2YzAyMzkxY2Y2YjdlMDQ5MmYxZGYuLjE0NmY5MGNiYmE4OTI1ZjQzOTY1OGYwNWE1YzNkZjAx ZmVlOTMyNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMjAtMDEtMTcgIERhbmllbCBC YXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIEZvY3VzaW5nIGVkaXRh YmxlIGVsZW1lbnQgd2l0aCBXZWJQYWdlOjpzZWxlY3RQb3NpdGlvbkF0UG9pbnQoKSBkb2VzIG5v dCBicmluZyB1cCBrZXlib2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjA2Mzg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81NzQxNDM4MD4KKwor ICAgICAgICBSZXZpZXdlZCBieSBXZW5zb24gSHNpZWguCisKKyAgICAgICAgVXBkYXRlIHRoZSB2 aWV3J3Mgc3RhdGUgdG8gaW5kaWNhdGUgdGhhdCB0aGUgdXNlciBpcyBwZXJmb3JtaW5nIGFuIGlu dGVyYWN0aW9uIGZvciB0aGUgc2NvcGUgb2YKKyAgICAgICAgV2ViUGFnZTo6c2VsZWN0UG9zaXRp b25BdFBvaW50KCkuIFRoaXMgcGVybWl0cyBXZWJLaXQgdG8gc2hvdyB0aGUga2V5Ym9hcmQgaWYg c2VsZWN0aW5nIHRoZQorICAgICAgICBwb3NpdGlvbiBjYXVzZXMgYSBjaGFuZ2UgaW4gZm9jdXMg KHNheSwgdGhlIHBvaW50IGlzIGluc2lkZSBhbiB1bmZvY3VzZWQgdGV4dCBmaWVsZCkuCisKKyAg ICAgICAgV2UgbGlrZWx5IHNob3VsZCBkbyBhIHNpbWlsYXIgY2hhbmdlIGZvciBhbGwgb3RoZXIg V2ViS2l0IElQSXMgdGhhdCBwZXJmb3JtIGEgV2ViQ29yZTo6RVVzZXJUcmlnZ2VyZWQ6OlVzZXJU cmlnZ2VyZWQKKyAgICAgICAgdGFnZ2VkIHNlbGVjdGlvbiBjaGFuZ2UgdGhvdWdoIHRoZSBjYWxs ZXJzIHNob3VsZCBiZSBhdWRpdGVkIHRvIGVuc3VyZSB0aGV5IHdlcmVuJ3QgYWNjaWRlbnRhbGx5 CisgICAgICAgIGRlcGVuZGluZyBvbiB0aGUgZXhpc3RpbmcgYmVoYXZpb3IgdGhhdCBwcmV2ZW50 cyBzdWNoIHNlbGVjdGlvbnMgZnJvbSBicmluZ2luZyB1cCB0aGUga2V5Ym9hcmQuCisgICAgICAg IEZvciBub3csIEkgb25seSBmaXggV2ViUGFnZTo6c2VsZWN0UG9zaXRpb25BdFBvaW50KCkgYXMg SSd2ZSBhdWRpdGVkIHRoYXQgYWxsIGNhbGxlcnMgZXhwZWN0IGl0CisgICAgICAgIHRvIGJyaW5n IHVwIHRoZSBrZXlib2FyZCwgaWYgbmVlZGVkLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQ YWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpzZWxlY3RQ b3NpdGlvbkF0UG9pbnQpOiAKKwogMjAxOS0wOS0xMyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0Bh cHBsZS5jb20+CiAKICAgICAgICAgU3VwcG9ydCBidWlsZGluZyBXZWJLaXQgZm9yIE1hYyBDYXRh bHlzdCBmcm9tIFhjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2Vi UGFnZS9pb3MvV2ViUGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdl L2lvcy9XZWJQYWdlSU9TLm1tCmluZGV4IGU3MWM3Mzg5NGMzZTRhZDAyMmIzOTJjNzBlMTBkZTA1 ZTgzNzg3ZDAuLjAxZDYzYzFjNGE2M2M3MzIxODNmNDdiZmFkZWY0MTc5ZWQ0ZTQ2ZjggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1t CkBAIC0yMDA5LDYgKzIwMDksOCBAQCBWaXNpYmxlUG9zaXRpb24gV2ViUGFnZTo6dmlzaWJsZVBv c2l0aW9uSW5Gb2N1c2VkTm9kZUZvclBvaW50KGNvbnN0IEZyYW1lJiBmcmFtZQogCiB2b2lkIFdl YlBhZ2U6OnNlbGVjdFBvc2l0aW9uQXRQb2ludChjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgcG9p bnQsIGJvb2wgaXNJbnRlcmFjdGluZ1dpdGhGb2N1c2VkRWxlbWVudCwgQ2FsbGJhY2tJRCBjYWxs YmFja0lEKQogeworICAgIFNldEZvclNjb3BlPGJvb2w+IHVzZXJJc0ludGVyYWN0aW5nQ2hhbmdl IHsgbV91c2VySXNJbnRlcmFjdGluZywgdHJ1ZSB9OworCiAgICAgYXV0byYgZnJhbWUgPSBtX3Bh Z2UtPmZvY3VzQ29udHJvbGxlcigpLmZvY3VzZWRPck1haW5GcmFtZSgpOwogICAgIFZpc2libGVQ b3NpdGlvbiBwb3NpdGlvbiA9IHZpc2libGVQb3NpdGlvbkluRm9jdXNlZE5vZGVGb3JQb2ludChm cmFtZSwgcG9pbnQsIGlzSW50ZXJhY3RpbmdXaXRoRm9jdXNlZEVsZW1lbnQpOwogICAgIAo=