206382 2020-01-16 15:57:38 -0800 Ensure full URLs for relative path images for social meta data 2020-01-16 17:31:28 -0800 1 1 1 Unclassified WebKit WebKit Website WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jond jond commit-queue hi jond webkit-bug-importer oldest_to_newest 1607726 0 jond 2020-01-16 15:57:38 -0800 Posts and pages that specify relative paths for images will not be properly propagated in open graph meta data. 1607729 1 387976 jond 2020-01-16 16:02:18 -0800 Created attachment 387976 Patch 1607753 2 387976 hi 2020-01-16 16:33:04 -0800 Comment on attachment 387976 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387976&action=review r=me, with a few comments > Websites/webkit.org/wp-content/plugins/social-meta.php:84 > + if ($image_url[0] === '/') Should we move this logic to the end of the initial `<?php` block at the top of this file? That way, if HTML tags are added for other social platforms above this, they won't "miss" this logic. > Websites/webkit.org/wp-content/plugins/social-meta.php:85 > + $image_url = get_home_url(null,$image_url); Style: should have space between `null, $image_url`. 1607770 3 387986 jond 2020-01-16 16:42:38 -0800 Created attachment 387986 Patch 1607812 4 387986 commit-queue 2020-01-16 17:30:10 -0800 Comment on attachment 387986 Patch Clearing flags on attachment: 387986 Committed r254731: <https://trac.webkit.org/changeset/254731> 1607813 5 commit-queue 2020-01-16 17:30:11 -0800 All reviewed patches have been landed. Closing bug. 1607815 6 webkit-bug-importer 2020-01-16 17:31:28 -0800 <rdar://problem/58665624> 387976 2020-01-16 16:02:18 -0800 2020-01-16 16:42:36 -0800 Patch bug-206382-20200116160217.patch text/plain 1443 jond U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzAzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGMwOWJj MWU1NWY2OTM5YmM5ZDUyMDJhNjQ2Y2I2MjlhYWY1OTEzOWYuLjkwMzBjYjM4YWRiNTRhNDVhNTJk ZTc0ZWNjN2I5NTU0NTVhODJmNTggMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMjAtMDEtMTYgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgorCisgICAgICAgIEVu c3VyZSBmdWxsIFVSTHMgZm9yIHJlbGF0aXZlIHBhdGggaW1hZ2VzIGZvciBzb2NpYWwgbWV0YSBk YXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYz ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHdw LWNvbnRlbnQvcGx1Z2lucy9zb2NpYWwtbWV0YS5waHA6CisKIDIwMjAtMDEtMTUgIEpvbiBEYXZp cyAgPGpvbmRAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBjYXRlZ29yaWVz IGFuZCBjdXN0b20gcG9zdCB0eXBlcyB0byB0aGUgc29jaWFsIG1ldGEgcGx1Z2luCmRpZmYgLS1n aXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL3dwLWNvbnRlbnQvcGx1Z2lucy9zb2NpYWwtbWV0YS5w aHAgYi9XZWJzaXRlcy93ZWJraXQub3JnL3dwLWNvbnRlbnQvcGx1Z2lucy9zb2NpYWwtbWV0YS5w aHAKaW5kZXggMWRkNzI4YzM2ZDA3NjRiZDRhZjJhMGQyODk0OTYyYjM3OGQyMTNlMi4uNTUzNTk5 NzEzNTIwMjM5MTJlYjVlMDY3YWQ3OWNjNGFiZTU5NjZlMCAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMv d2Via2l0Lm9yZy93cC1jb250ZW50L3BsdWdpbnMvc29jaWFsLW1ldGEucGhwCisrKyBiL1dlYnNp dGVzL3dlYmtpdC5vcmcvd3AtY29udGVudC9wbHVnaW5zL3NvY2lhbC1tZXRhLnBocApAQCAtODAs NyArODAsMTAgQEAgYWRkX2FjdGlvbignd3BfaGVhZCcsIGZ1bmN0aW9uKCkgewogPD9waHAgaWYg KCRkZXNjcmlwdGlvbik6ID8+CiAgICAgPG1ldGEgaXRlbXByb3A9ImRlc2NyaXB0aW9uIiBjb250 ZW50PSI8P3BocCBlY2hvIGVzY19hdHRyKCRkZXNjcmlwdGlvbik7ID8+Ij4KIDw/cGhwIGVuZGlm OyA/PgotPD9waHAgaWYgKCRpbWFnZV91cmwpOiA/PgorPD9waHAgaWYgKCRpbWFnZV91cmwpOgor ICAgICAgICBpZiAoJGltYWdlX3VybFswXSA9PT0gJy8nKQorICAgICAgICAgICAgJGltYWdlX3Vy bCA9IGdldF9ob21lX3VybChudWxsLCRpbWFnZV91cmwpOworPz4KICAgICA8bWV0YSBpdGVtcHJv cD0iaW1hZ2UiIGNvbnRlbnQ9Ijw/cGhwIGVjaG8gZXNjX3VybCgkaW1hZ2VfdXJsKTsgPz4iPgog PD9waHAgZW5kaWY7ID8+CiAK 387986 2020-01-16 16:42:38 -0800 2020-01-16 17:30:10 -0800 Patch bug-206382-20200116164237.patch text/plain 1303 jond U3VidmVyc2lvbiBSZXZpc2lvbjogMjU0NzAzCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGMwOWJj MWU1NWY2OTM5YmM5ZDUyMDJhNjQ2Y2I2MjlhYWY1OTEzOWYuLjdjYTBiY2EzYWU4ZWEwNGNmMWNk YzBkNDcyZjE5YjdkNjA2NmM3YzMgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIg QEAKKzIwMjAtMDEtMTYgIEpvbiBEYXZpcyAgPGpvbmRAYXBwbGUuY29tPgorCisgICAgICAgIEVu c3VyZSBmdWxsIFVSTHMgZm9yIHJlbGF0aXZlIHBhdGggaW1hZ2VzIGZvciBzb2NpYWwgbWV0YSBk YXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDYz ODIKKworICAgICAgICBSZXZpZXdlZCBieSBEZXZpbiBSb3Vzc28uCisKKyAgICAgICAgKiB3cC1j b250ZW50L3BsdWdpbnMvc29jaWFsLW1ldGEucGhwOgorCiAyMDIwLTAxLTE1ICBKb24gRGF2aXMg IDxqb25kQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3IgY2F0ZWdvcmllcyBh bmQgY3VzdG9tIHBvc3QgdHlwZXMgdG8gdGhlIHNvY2lhbCBtZXRhIHBsdWdpbgpkaWZmIC0tZ2l0 IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1jb250ZW50L3BsdWdpbnMvc29jaWFsLW1ldGEucGhw IGIvV2Vic2l0ZXMvd2Via2l0Lm9yZy93cC1jb250ZW50L3BsdWdpbnMvc29jaWFsLW1ldGEucGhw CmluZGV4IDFkZDcyOGMzNmQwNzY0YmQ0YWYyYTBkMjg5NDk2MmIzNzhkMjEzZTIuLmQzZjVlYTcz NTIwYzMwZDY0ZGRiZjE5YWYwMTQwNGI1N2FhNWEyNjIgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dl YmtpdC5vcmcvd3AtY29udGVudC9wbHVnaW5zL3NvY2lhbC1tZXRhLnBocAorKysgYi9XZWJzaXRl cy93ZWJraXQub3JnL3dwLWNvbnRlbnQvcGx1Z2lucy9zb2NpYWwtbWV0YS5waHAKQEAgLTczLDYg KzczLDkgQEAgYWRkX2FjdGlvbignd3BfaGVhZCcsIGZ1bmN0aW9uKCkgewogICAgICAgICAkcHVi bGlzaGVkX3RpbWUgPSBnZXRfdGhlX3RpbWUoJ2MnKTsKICAgICAgICAgJG1vZGlmaWVkX3RpbWUg PSBnZXRfdGhlX21vZGlmaWVkX2RhdGUoJ2MnKTsKICAgICB9CisKKyAgICBpZiAoJGltYWdlX3Vy bFswXSA9PT0gJy8nKQorICAgICAgICAkaW1hZ2VfdXJsID0gZ2V0X2hvbWVfdXJsKG51bGwsICRp bWFnZV91cmwpOwogPz4KIAogICAgIDwhLS0gU2NoZW1hLm9yZyBtYXJrdXAgLS0+Cg==