206353 2020-01-16 06:40:49 -0800 [GTK][WPE] Composition underline color is not applied 2020-01-17 06:00:49 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply svillar oldest_to_newest 1607444 0 cgarcia 2020-01-16 06:40:49 -0800 The right color is received by InlineTextBox::paintCompositionUnderline(), but for some reason colorByApplyingColorFilter() always returns a null color for any given color. 1607924 1 cgarcia 2020-01-17 01:38:14 -0800 The problem was not colorByApplyingColorFilter(), I assumed that was called with the given color, but that's not the case because underline.compositionUnderlineColor is always CompositionUnderlineColor::TextColor. This is because compositionUnderlineColor is not encoded/decoded in the IPC messages. 1607925 2 388023 cgarcia 2020-01-17 01:40:22 -0800 Created attachment 388023 Patch 1607930 3 388023 svillar 2020-01-17 02:22:03 -0800 Comment on attachment 388023 Patch Don't we have tests for this? 1607936 4 cgarcia 2020-01-17 02:55:07 -0800 Unit tests, but it's not easy to test that the color passed from the API is the actual color of the underline when composing. 1607961 5 cgarcia 2020-01-17 06:00:49 -0800 Committed r254742: <https://trac.webkit.org/changeset/254742> 388023 2020-01-17 01:40:22 -0800 2020-01-17 02:22:03 -0800 Patch wk2-composition-underline.diff text/plain 1908 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNjJhZTlkZGQ2MDUuLjcyMmIyNmRiZDM4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE3IEBACisyMDIwLTAxLTE3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIENvbXBvc2l0aW9uIHVuZGVybGluZSBjb2xvciBp cyBub3QgYXBwbGllZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjA2MzUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ29tcG9zaXRpb25VbmRlcmxpbmU6OmNvbXBvc2l0aW9uVW5kZXJsaW5lQ29sb3IgaXMg bm90IGVuY29kZWQvZGVjb2RlZCBpbiBJUEMgbWVzc2FnZXMsIHNvIHRoZSB3ZWIgcHJvY2Vzcwor ICAgICAgICBhbHdheXMgdXNlcyBDb21wb3NpdGlvblVuZGVybGluZUNvbG9yOjpUZXh0Q29sb3Ig aWdub3JpbmcgdGhlIGdpdmVuIGNvbG9yLgorCisgICAgICAgICogU2hhcmVkL1dlYkNvcmVBcmd1 bWVudENvZGVycy5jcHA6CisgICAgICAgIChJUEM6OkFyZ3VtZW50Q29kZXI8Q29tcG9zaXRpb25V bmRlcmxpbmU+OjplbmNvZGUpOiBFbmNvZGUgY29tcG9zaXRpb25VbmRlcmxpbmVDb2xvci4KKyAg ICAgICAgKElQQzo6QXJndW1lbnRDb2RlcjxDb21wb3NpdGlvblVuZGVybGluZT46OmRlY29kZSk6 IERlY29kZSBjb21wb3NpdGlvblVuZGVybGluZUNvbG9yLgorCiAyMDIwLTAxLTE2ICBaYW4gRG9i ZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBNb3Zl IHRoZSBjb21tb24gV2ViS2l0T3B0aW9uTWVudSBHTGliIEFQSSBpbXBsZW1lbnRhdGlvbgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvV2ViQ29yZUFyZ3VtZW50Q29kZXJzLmNwcCBi L1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkNvcmVBcmd1bWVudENvZGVycy5jcHAKaW5kZXggN2Mx ZWY3Nzg3YTcuLjg4MGQxOGNjMmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9X ZWJDb3JlQXJndW1lbnRDb2RlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1dlYkNv cmVBcmd1bWVudENvZGVycy5jcHAKQEAgLTE2MDMsNiArMTYwMyw3IEBAIHZvaWQgQXJndW1lbnRD b2RlcjxDb21wb3NpdGlvblVuZGVybGluZT46OmVuY29kZShFbmNvZGVyJiBlbmNvZGVyLCBjb25z dCBDb21wb3NpCiAgICAgZW5jb2RlciA8PCB1bmRlcmxpbmUuc3RhcnRPZmZzZXQ7CiAgICAgZW5j b2RlciA8PCB1bmRlcmxpbmUuZW5kT2Zmc2V0OwogICAgIGVuY29kZXIgPDwgdW5kZXJsaW5lLnRo aWNrOworICAgIGVuY29kZXIuZW5jb2RlRW51bSh1bmRlcmxpbmUuY29tcG9zaXRpb25VbmRlcmxp bmVDb2xvcik7CiAgICAgZW5jb2RlciA8PCB1bmRlcmxpbmUuY29sb3I7CiB9CiAKQEAgLTE2MTYs NiArMTYxNyw4IEBAIE9wdGlvbmFsPENvbXBvc2l0aW9uVW5kZXJsaW5lPiBBcmd1bWVudENvZGVy PENvbXBvc2l0aW9uVW5kZXJsaW5lPjo6ZGVjb2RlKERlY29kCiAgICAgICAgIHJldHVybiBXVEY6 Om51bGxvcHQ7CiAgICAgaWYgKCFkZWNvZGVyLmRlY29kZSh1bmRlcmxpbmUudGhpY2spKQogICAg ICAgICByZXR1cm4gV1RGOjpudWxsb3B0OworICAgIGlmICghZGVjb2Rlci5kZWNvZGVFbnVtKHVu ZGVybGluZS5jb21wb3NpdGlvblVuZGVybGluZUNvbG9yKSkKKyAgICAgICAgcmV0dXJuIFdURjo6 bnVsbG9wdDsKICAgICBpZiAoIWRlY29kZXIuZGVjb2RlKHVuZGVybGluZS5jb2xvcikpCiAgICAg ICAgIHJldHVybiBXVEY6Om51bGxvcHQ7CiAK